Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
f5dec0ebc1bd...
f5dec0ebc1bd06b176f7cafa6c1a33f4274506f8
Alexey Yurchenko
MDEV-40179 Found N prepared transactions after mariabackup SST

With log_bin=ON a transaction is committed via two-phase commit (the
binary log is the second participant), so it passes through the InnoDB
XA-prepare state. While a donor is held in BLOCK_COMMIT for a mariabackup
backup, its parallel appliers (wsrep_slave_threads > 1) leave one or more
such writesets prepared-but-not-yet-committed, and the snapshot captures
them. On a freshly SST'd joiner nothing resolves these prepared
transactions: binlog crash recovery does not run (the joiner has no in-use
binlog to recover from), and the wsrep continuity-based commit is inactive
because wsrep_emulate_bin_log is FALSE when log_bin is ON. The leftover
prepared transactions then abort startup with "Found <N> prepared
transactions!". Note this does not depend on the prepared set being
non-contiguous - even a contiguous run aborts, because nothing commits
or rolls it back.

Rollback these transactions in xarecover_handlerton().

Co-Authored-By: Claude Opus 4.8 <[email protected]>
ef4e5f3f3963...
ef4e5f3f396326f59d7c8f5738687b2486357f15
rusher
[misc] Add matrix entry that builds against latest C/C 3.3 branch
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
e76be95dd135...
e76be95dd135a9ed8244e52dddc3c045f55218c0
Lawrin Novitsky
Made prepearedstatement testsuite not to force CSPS for defautl connection

This way it can be controlled via params/env which typ of PS is tested.
Tests requiring CSPS should take care of that
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
e2205c99edc4...
e2205c99edc4c646edb6cdd0f9ac0c0f9b80c21b
Lawrin Novitsky
Removed polymorphysm from the row classes

Polymorfism is done my their respective resultset host class - text RS
always use text row class, binary RS - binary row. Thus no need to
access their features via virtual methods.
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
d7eb10106c1a...
d7eb10106c1af99e645fb0eb5c7eee3eed136cbc
Lawrin Novitsky
CONCPP-157, CONCPP-158 setBytes() parameter is sent as binary type in

binary protocol. It is sent as MYSQL_TYPE_BLOB. As counterpart, binary
types received from the server via binary protocol are now converted
to int types - berfore the exception would be thrown right away w/out
any attempt to convert.
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
d56f207dccbb...
d56f207dccbbc0be877682ab4c2c3916055348ad
drrtuy
chore(privs): restrict access to run_in_duckdb() to SUPER users only.
d2ed3cc58b20...
d2ed3cc58b200cc8cbcb08ca54583da440ee96a2
rusher
[misc] use DOCKER_LOGIN as user if secret available
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
ce566951c1b6...
ce566951c1b67d03e0810baae6cceb4802d90fb8
drrtuy
chore: enable run_in_duckdb by default()
c73e3ce80fba...
c73e3ce80fba09df17fb48001cc1a2b652eae7f0
Alexey Yurchenko
MDEV-38147 error 1950 after mariabackup SST with gtid_strict_mode=ON

After a mariabackup SST the joiner could fail with

  ER_GTID_STRICT_OUT_OF_ORDER (error 1950)

while re-binlogging transactions received over IST.

The cause is that the binary log copied from the donor carries a
Gtid_list whose position can be ahead of the storage-engine snapshot:
BACKUP STAGE BLOCK_COMMIT blocks the engine commit (2PC step 3) but not
the binary log write (step 2), so transactions can be present in the
copied binlog that are not committed in the copied engine snapshot.
After the SST the joiner reports the (committed) engine position to the
cluster, IST resends those transactions, and re-binlogging them under
gtid_strict_mode=ON collides with the ahead Gtid_list -> error 1950.
(MDEV-34483 made the engine snapshot stop short of the binlog, which is
what exposed this.)

The copied binary log carries no transactions the joiner needs - only a
Gtid_list - so instead of shipping and then having to truncate/reconcile
it, the joiner now starts a fresh binary log and seeds its GTID position
from the storage-engine checkpoint during recovery. That checkpoint is
the committed cluster position, i.e. exactly where IST resumes, so the
joiner's binary log stays in lockstep with the rest of the cluster and
no out-of-order GTID can occur.

This works for both wsrep_gtid_mode settings; only the binlog domain of
the cluster stream differs:

  - wsrep_gtid_mode=ON : wsrep_gtid_domain_id (cluster writes are
    re-tagged to it), which is the domain stored in the checkpoint;
  - wsrep_gtid_mode=OFF: gtid_domain_id (cluster writes keep the node's
    configured domain).

Async-replica positions (mysql.gtid_slave_pos) are part of the engine
snapshot and survive the SST unchanged, so a Galera node can still serve
as an async master or replica across the SST.

This commit:
- sql/log.cc: adds wsrep_seed_binlog_gtid_state(), called from
  do_binlog_recovery() when the joiner has no binary log, seeding the
  binlog GTID state for the cluster domain to the SE checkpoint position.
- scripts/wsrep_sst_mariabackup.sh: no longer moves the donor's binary
  log into place on the joiner.
- extra/mariabackup: backward compatibility: keep shipping binlog file
  in SST but
  - on donor fix the race between rotation and shipping so that the file
    shipped is the one that had been rotated;
  - on joiner discard shipped binlog in favour of one generated by
    wsrep_seed_binlog_gtid_state().
- sql/wsrep_sst.cc: logs the position actually adopted from storage
  (the authoritative post-SST position) rather than the script-reported
  one.
- sql/handler.cc: downgrades the "Discovered discontinuity in recovered
  wsrep transaction XIDs" message in wsrep_order_and_check_continuity()
  from warning to debug level. With parallel appliers a snapshot
  routinely captures prepared XIDs that are not contiguous with the
  engine checkpoint, so this is normal during SST recovery and of no
  value in regular operation; the transactions past the checkpoint are
  re-delivered by the cluster (IST/SST) regardless.
- Adds an MDEV-38147 MTR test reproducing the issue.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
b4905a78fcec...
b4905a78fcec6dc4575c8c2fd70624efded541e0
Lawrin Novitsky
Moved underlying libmariadb to 3.4 series - v3.4.9 atm

We have to support parsec auth plugin as minimum. zero config TLS is
also a big plus, but we don't change related options defaults - the
certificate is not yet validated by default.
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
b1627d4317cb...
b1627d4317cb1575c209bd8ebc1efa89beea3b4b
Lawrin Novitsky
CONCPP-153 Parameter value escaping did not consider the charset

In case of client side statement prepare, if the data is encoded in multibyte
charsets, escaping of string and binary parameter could lead to incorrect data
that in its turn could let sql injection with charsets like big5, gbk, sjis, cp932.

The fix considers the charset now. The testcase has been added.
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
a7a9df248d22...
a7a9df248d224a418cab01e45e15f63918f1e3a1
Lawrin Novitsky
Merge branch 'cpp-1.0' into cpp-1.1
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
a3a458edf763...
a3a458edf763f63429b1663fc7e01325d311085f
drrtuy
chore(tests): add data reclaim test.
8cd8e945a67c...
8cd8e945a67c362a6c2f0b044d46aca6e516eb2c
Lawrin Novitsky
Introduced UBSAN.supp to supress UBSAN issues beyond our control

(on C/C side). They are quite the same as in C/ODBC
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
8581099fb85f...
8581099fb85f90d61df7fb8e822f528d709d39ca
Lawrin Novitsky
Minor formatting changes
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
7fb1939c77ac...
7fb1939c77acb69e22ffa491640eadde06e34ef7
Lawrin Novitsky
Removed polymorphysm from the row classes

Polymorfism is done my their respective resultset host class - text RS
always use text row class, binary RS - binary row. Thus no need to
access their features via virtual methods.
7a8776a92e5f...
7a8776a92e5f88cad4fb8a7c8ff8caa4def3e107
drrtuy
chore(tests,docs): renew documentation and fixed a number of test inconsistences.
7a289771f92f...
7a289771f92f2f625a26d6d69da9b586dcd815bf
rusher
[misc] add maxscale testing to CI
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
72a6c5abbf21...
72a6c5abbf214b2c57a39437a14d0383d5a1d489
Lawrin Novitsky
Fix of UBSAN errors.

In one place copying from nullptr was possible. It could happen if the
streamed text resultset had to be cached(if the connection is requested
for other operation), and NULL value was present.
In couple of places int64_t could be overflown - had to be changed to
uint64 as it is defined plus othe implied changes.
In particular fetching MIN_INT64 value in text protocol could cause
that. Looks like all compilers work fine in this case as there is the
test for this.
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
71d7543651dd...
71d7543651dd058a0054d520dad90c5e7e041c42
Lawrin Novitsky
One more UBSAN silencing.

Same nature "function called using wrong pointer type" for C/C parameters
callback call. In this case besides inclusion in the namespace the
function had accidentally wrong return type.
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
64d385ced998...
64d385ced99885bd289b8854027aca9328f53ce2
Lawrin Novitsky
CONCPP-152 fix of effect of C/C resetting length of fixed size types

The driver was using that length directly. Now it tests the length and
use either it or buffer length.
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
4b2deba35b13...
4b2deba35b13329a3838370e4bc1ad683f13b190
Razvan Liviu Varzaru
Support fedora for static_test linking
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
48037682e027...
48037682e02797148ce8e321bc80cec6d0c38445
rusher
[misc] add maxscale testing to CI
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
472898c75c8d...
472898c75c8df1dd672cda395e14357747470a4e
drrtuy
chore: default memory limits are now 80% * (physical RAM - innodb_buffer_pool_size_max)
46488f191396...
46488f191396c1396e593e62250de49700f5ddef
Lawrin Novitsky
Merge branch 'cpp-1.0' into cpp-1.1
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
415a37038551...
415a37038551b3fd704e3aff49be01c7ba2662f8
Lawrin Novitsky
BinRow class as value in binary resultSet class
3948339afb7f...
3948339afb7fb0ebc28a6a59021383b495ffc293
Lawrin Novitsky
CONCPP-153 Parameter value escaping did not consider the charset

In case of client side statement prepare, if the data is encoded in multibyte
charsets, escaping of string and binary parameter could lead to incorrect data
that in its turn could let sql injection with charsets like big5, gbk, sjis, cp932.

The fix considers the charset now. The testcase has been added.
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
38c74af6ab05...
38c74af6ab054ad7d17595997aa9d7d1855a3ebd
rusher
[misc] use DOCKER_LOGIN as user if secret available
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
3363fc891293...
3363fc891293b01f621f9c9c07ca0958d42ac19e
Alexey Yurchenko
MDEV-40179 Found N prepared transactions after mariabackup SST

With log_bin=ON a transaction is committed via two-phase commit (the
binary log is the second participant), so it passes through the InnoDB
XA-prepare state. While a donor is held in BLOCK_COMMIT for a mariabackup
backup, its parallel appliers (wsrep_slave_threads > 1) leave one or more
such writesets prepared-but-not-yet-committed, and the snapshot captures
them. On a freshly SST'd joiner nothing resolves these prepared
transactions: binlog crash recovery does not run (the joiner has no in-use
binlog to recover from), and the wsrep continuity-based commit is inactive
because wsrep_emulate_bin_log is FALSE when log_bin is ON. The leftover
prepared transactions then abort startup with "Found <N> prepared
transactions!". Note this does not depend on the prepared set being
non-contiguous - even a contiguous run aborts, because nothing commits
or rolls it back.

Rollback these transactions in xarecover_handlerton().

Co-Authored-By: Claude Opus 4.8 <[email protected]>
2e56bf4ecd0f...
2e56bf4ecd0f9040738f67846c9c2504242ffd7a
Lawrin Novitsky
Merge branch 'cpp-1.1'
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
2e25fa829fde...
2e25fa829fde36d4e5abc326c02c6e1f109a953a
drrtuy
chore: bump DuckDB version to 1.5.4.
25013481bd38...
25013481bd38cd49014758eaa55f0cfac65a6f6b
Alexey Yurchenko
MDEV-38147 error 1950 after mariabackup SST with gtid_strict_mode=ON

After a mariabackup SST the joiner could fail with

  ER_GTID_STRICT_OUT_OF_ORDER (error 1950)

while re-binlogging transactions received over IST.

The cause is that the binary log copied from the donor carries a
Gtid_list whose position can be ahead of the storage-engine snapshot:
BACKUP STAGE BLOCK_COMMIT blocks the engine commit (2PC step 3) but not
the binary log write (step 2), so transactions can be present in the
copied binlog that are not committed in the copied engine snapshot.
After the SST the joiner reports the (committed) engine position to the
cluster, IST resends those transactions, and re-binlogging them under
gtid_strict_mode=ON collides with the ahead Gtid_list -> error 1950.
(MDEV-34483 made the engine snapshot stop short of the binlog, which is
what exposed this.)

The copied binary log carries no transactions the joiner needs - only a
Gtid_list - so instead of shipping and then having to truncate/reconcile
it, the joiner now starts a fresh binary log and seeds its GTID position
from the storage-engine checkpoint during recovery. That checkpoint is
the committed cluster position, i.e. exactly where IST resumes, so the
joiner's binary log stays in lockstep with the rest of the cluster and
no out-of-order GTID can occur.

This works for both wsrep_gtid_mode settings; only the binlog domain of
the cluster stream differs:

  - wsrep_gtid_mode=ON : wsrep_gtid_domain_id (cluster writes are
    re-tagged to it), which is the domain stored in the checkpoint;
  - wsrep_gtid_mode=OFF: gtid_domain_id (cluster writes keep the node's
    configured domain).

Async-replica positions (mysql.gtid_slave_pos) are part of the engine
snapshot and survive the SST unchanged, so a Galera node can still serve
as an async master or replica across the SST.

This commit:
- sql/log.cc: adds wsrep_seed_binlog_gtid_state(), called from
  do_binlog_recovery() when the joiner has no binary log, seeding the
  binlog GTID state for the cluster domain to the SE checkpoint position.
- scripts/wsrep_sst_mariabackup.sh: no longer moves the donor's binary
  log into place on the joiner.
- extra/mariabackup: backward compatibility: keep shipping binlog file
  in SST but
  - on donor fix the race between rotation and shipping so that the file
    shipped is the one that had been rotated;
  - on joiner discard shipped binlog in favour of one generated by
    wsrep_seed_binlog_gtid_state().
- sql/wsrep_sst.cc: logs the position actually adopted from storage
  (the authoritative post-SST position) rather than the script-reported
  one.
- sql/handler.cc: downgrades the "Discovered discontinuity in recovered
  wsrep transaction XIDs" message in wsrep_order_and_check_continuity()
  from warning to debug level. With parallel appliers a snapshot
  routinely captures prepared XIDs that are not contiguous with the
  engine checkpoint, so this is normal during SST recovery and of no
  value in regular operation; the transactions past the checkpoint are
  re-delivered by the cluster (IST/SST) regardless.
- Adds an MDEV-38147 MTR test reproducing the issue.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
2022c5548ad4...
2022c5548ad44741d842ed9b3862c1ee7d70e917
Lawrin Novitsky
Increased cmake min required version to enable build with newest cmake's

Also, fixed UBSAN issue caused by including mysql header inside the
namespace and using pointer to destroyer functions in the smart
pointers. Tha was in ConnectProtocol and TextRowProtocol classes with
MYSQL and MYSQL_RES handles, respectively. Removed unique_ptr use
completely as it's pretty safe and easy to destroy them in the the
respective class destructor.
Added check and exception throw if MYSQL handle could not be allocated -
taht was missing.
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
176589bf19ea...
176589bf19ea6e2261bb3ef57886c13b9c0b6759
drrtuy
MDEV-40265 fix: UUID type support in DuckDB and mixed SELECT statements.
1130940ab691...
1130940ab69105b2770b4c243aa85e5408188ab6
Lawrin Novitsky
Merge branch 'cpp-1.0' into cpp-1.1
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
0d773c011a10...
0d773c011a10f23d45f9e3990820a9956501404f
Lawrin Novitsky
CONCPP-156 Move to C/C 3.4 to support Parsec plugin

The submodule has been moved to 3.4.9 already in one of previous
commits. This one makes it it installed by MSI and taraballs
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
0c3ed7dad05c...
0c3ed7dad05cfaab03c3c21992ed0e8999e74a03
drrtuy
chore(build): suppress sfinae-incomplete warnings building DuckDB code to reduce noise for >=] GCC-16 compiler.
03cb6bc4f221...
03cb6bc4f221ca89e6445d236587856e40d05cdc
drrtuy
fix(func): time functions fixes and tests.
01701aa3c3d6...
01701aa3c3d631d5ec15e508267396bb2603a98a
Lawrin Novitsky
More fixes to please UBSAN and MSAN.

For UBSAN it's the similar problem as in prvious commit, for MSAN - it
suddenly had issues afte move of min required cmake version to 3.5.
Seemingly it is connected to policy 0056 and it's new behavior.
  • ccpp-sles12-amd64: build linux-connector_cpp failed -  stdio
000c3382cdc4...
000c3382cdc42c5accfeddf56e1bd480e6011eed
Sergei Golubchik
github copilot review instructions

Co-Authored-By: Claude Opus 4.8 <[email protected]>
BuildBot (0.8.9) working for the MariaDB project.
Page built: Mon 06 Jul 2026 00:07:16 (UTC)