Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
f8deec9d6fe5...
f8deec9d6fe5024bcfc72f4f6698c278ef84b6ed
Oleg Smirnov
MDEV-33281 Make BNL() hint work for join_cache_levels from 0 to 3

BNL() hint effectively increases join_cache_level up to 4 if it is
set to value less than 4.
This commit also makes the BKA() hint override not only
`join_cache_bka` optimizer switch but `join_cache_level` as well.
I.e., BKA() hint enables BKA and BKAH join buffers both flat and
incremental despite `join_cache_level` and `join_cache_bka` setting.
e0cc2884287a...
e0cc2884287a8ccbb2032a91be09f07e7701bb7a
Oleg Smirnov
MDEV-34870: implement join order hints

This commit implements optimizer hints allowing to affect the order
of joining tables:

- JOIN_FIXED_ORDER similar to existing STRAIGHT_JOIN hint;
- JOIN_ORDER to apply the specified table order;
- JOIN_PREFIX to hint what tables should be first in the join;
- JOIN_SUFFIX to hint what tables should be last in the join.
dae0ec7ca03f...
dae0ec7ca03ff98eb1edf85476d24836821dd865
Sergei Golubchik
compilation embedded
d8ee6b68fd0e...
d8ee6b68fd0e125bfd70e896083c0e61ca3af547
Oleg Smirnov
MDEV-34860 Implement MAX_EXECUTION_TIME hint

It places a limit N (a timeout value in milliseconds) on how long
a statement is permitted to execute before the server terminates it.

Syntax:
SELECT /*+ MAX_EXECUTION_TIME(milliseconds) */ ...

Only top-level SELECT statements support the hint.
cba2f91daa4a...
cba2f91daa4a94eeb71ceea389dde80625e43a1c
Sergei Golubchik
MDEV-20299 SET SESSION AUTHORIZATION

a.k.a. "sudo"
bf4325fc5289...
bf4325fc5289a546fd7ba66cd8c33a96001f462a
Sergei Golubchik
MDEV-36589 Garbage written into slow log for SET SESSION AUTHORIZATION command, assertion fails

don't reset query start time on change user.
do reset bytes_sent_old on change user
be155df8502f...
be155df8502f064eb654f41920d13bc4cc72625d
Alexander Barkov
MDEV-33281 Implement optimizer hints

- Using Lex_ident_sys to scan identifiers, like the SQL parser does.

  This fixes handling of double-quote-delimited and backtick-delimited identifiers,
  as well as handling of non-ASCII identifiers.

  Unescaping and converting from the client character set to the system
  character set is now done using Lex_ident_cli_st and Lex_ident_sys,
  like it's done in the SQL tokenizer/parser.
  Adding helper methods to_ident_cli() and to_ident_sys()
  in Optimizer_hint_parser::Token.

- Fixing the hint parser to report a syntax error when an empty identifiers:
    SELECT /*+ BKA(``) */ * FROM t1;

- Moving a part of the code from opt_hints_parser.h to opt_hints_parser.cc

  Moving these method definitions:
  - Optimizer_hint_tokenizer::find_keyword()
  - Optimizer_hint_tokenizer::get_token()

  to avoid huge pieces of the code in the header file.

- A Lex_ident_cli_st cleanup
  Fixing a few Lex_ident_cli_st methods to return Lex_ident_cli_st &
  instead of void, to use them easier in the caller code.

- Fixing the hint parser to display the correct line number

  Adding a new data type Lex_comment_st
  (a combination of LEX_CSTRING and a line number)
  Using it in sql_yacc.yy

- Getting rid of redundant dependencies on sql_hints_parser.h

  Moving void LEX::resolve_optimizer_hints() from sql_lex.h to sql_lex.cc

  Adding a class Optimizer_hint_parser_output, deriving from
  Optimizer_hint_parser::Hint_list. Fixing the hint parser to
  return a pointer to an allocated instance of Optimizer_hint_parser_output
  rather than an instance of Optimizer_hint_parser::Hint_list.
  This allows to use a forward declaration of Optimizer_hint_parser_output
  in sql_lex.h and thus avoid dependencies on sql_hints_parser.h.
bcb628d4c4de...
bcb628d4c4de4e32c048af91773e7ddfa1157e44
Alexander Barkov
MDEV-33281 Implement optimizer hints

Implementing a recursive descent parser for optimizer hints.
b97a299f6f12...
b97a299f6f122028fc71f76d063609fdfab452b6
Sergei Petrunia
MDEV-33281 Optimizer hints cleanup:
- add a comment that opt_hints_global->check_unresolved() is never called
- improve comments
- rename everything with "resolved_children" to "fully_resolved_children"
- Opt_hints_table::adjust_key_hints() now returns value
- less "reach-back-to-parent" logic
- rename Hint "adjustment" and "resolution" (yes, both terms were used)
    to "fixing". "Resolution" is already used for parse-tree objects
aba426fa3e6c...
aba426fa3e6cf1f6c9aec47656258b5e21896255
Oleg Smirnov
MDEV-33281 Make BNL() hint work for join_cache_level=0

join_cache_level=0 disables join cache buffers, but the hint
BNL() now allows to employ BNL(H) buffers for particular tables
or query blocks.

This commit also adds a number of test cases including
OUTER JOINs to make sure hints do not break the rules of
join buffers application
a8d46423753d...
a8d46423753df7b0c020d828b827a8792fcf8784
Oleksandr Byelkin
Merge branch '10.11' into 11.4
a389fcc62de0...
a389fcc62de02f268d6e8827b04f9f170e3c3f89
Sergei Petrunia
MDEV-33281 Optimizer hints code cleanup:
- remove get_args_printer() from hints printing
- add append_hint_arguments(THD *thd, opt_hints_enum hint, String *str)
- add more comments
- rename st_opt_hint_info::hint_name to hint_type
- add pptimizer trace support for hints
- add dbug_print_hints()
- make print_warn() not be a template
- introduce Printable_parser_rule interface, make grammar rules that
    emit warnings implement it  and print_warn invokes its function)
- remove Parser::Hint::append_args() as it is not used anywhere
    (it used to be necessary call print_warn(... (Parser::Hint*)NULL);
a0b77eb806df...
a0b77eb806df51f15ef1f8d798f8d99187f9478a
Andrei Elkin
MDEV-36685 CREATE-SELECT may lose in binlog side-effects of stored-routine

When the SELECT sub-statement executes a stored function that is defined
to modify a non-transactional table, like

  delimiter |;
  create function f_ia(arg int)
  returns integer
  begin
    insert into ti_pk set a=1;
    insert into ta set a=1;
    insert into ti_pk set a=arg;
    return 1;
  end |
  delimiter ;|

any modified records that the function has succeeded
on must be binlogged as a "side effect" of CREATE-SELECT.

It is expected that a failing CREATE-SELECT like

  --error ER_DUP_ENTRY
  set statement binlog_format = ROW for create table t_y (a int) engine=aria select f_ia(1 /* err in Innodb after Aria stmt is done */) as a;

leaves upon itself the following state:

  include/show_binlog_events.inc
  Log_name Pos Event_type Server_id End_log_pos Info
  master-bin.000001 # Gtid # # BEGIN GTID #-#-#
  master-bin.000001 # Table_map # #
  table_id: # (test.  ta)
  master-bin.000001 # Write_rows_v1 # #
  table_id: # flags:  STMT_END_F
  master-bin.000001 # Query # # COMMIT
  select * from ta;
  a
  1
  select count(*) = 0 from ti_pk;
  true

However it's not so for the binlog part.
The reason is that prior to MDEV-34150 fixes the CREATE-SELECT's
errored phase leaves the binlog caches intact (the file:pos from 10.11 c06c36218a5)

to defer their reset to the rollback phase of the top-level

/* the statement cache gets binlogged */

where the side-effect changes gets binlogged.

MDEV-34150 fixes harmed (+#4 line) the statement cache in particular
in the error phase (file:pos are from 395db6f1d53 the current 11.8 )

/* The caches incl the statement cache are gone */
/* 'cos of MDEV-34150 */
+#4  0x00005d75f9b6a92e in THD::binlog_remove_rows_events (this=0x52c000240288) at log.cc:579

Apparently it should not have been there, as proper emptying (either
with reset for the transactional cache or flush and then reset for the
statement cache) is (must be) always done via binlog_rollback of the
top-level statement.
To observe the above requirement the case is fixed with the removal of
thd->binlog_remove_rows_events() and its definition.

Tested with rpl.rpl_create_select_row.

Reviewed-by Brandon Nesterenko.
98fb8337f1eb...
98fb8337f1eb4fb8436b1790f53b440f25e9facf
Oleg Smirnov
MDEV-33281 Implement optimizer hints

Forbid adding optimizer hints to view definitions.
In the case when optimizer hints are added to the view definition
at a `CREATE (OR REPLACE) VIEW`/`ALTER VIEW` statement, a warning is
generated and the hints are ignored.

This commit also disables ps-protocol for test cases where
`Unresolved table/index name` warnings are generated. The reason
for this is such warnings are generated during both PREPARE
and EXECUTE stages. Since opt_hints.test has `--enable_prepare_warnings`,
running it with `--ps-protocol` causes duplication of warning messages
8ee1f7b6de9d...
8ee1f7b6de9ddc5975e63234f326d6d6346bd6f1
Lawrin Novitsky
The checkbox for EDSERVER option was missing in the DSN dialog
  • codbc-focal-amd64: build linux-connector_odbc failed -  stdio
81aca24ab6f3...
81aca24ab6f3193bff85de45798b55c7d3d0c205
Sergei Petrunia
MDEV-33281 Optimizer hints cleanup: add `const` specifiers, comments
7f618bf24beb...
7f618bf24beb32b914b6f04351654c5de19d3152
Oleg Smirnov
MDEV-33281 Make BNL() hint enable hashed join buffers

Since BNL() hint does not specify which whether hashed or non-hashed
join cache should be employed, allow usage of hashed ones
where possible
7db5df121db6...
7db5df121db6ef7e5dc5ad9b60a07db49dd0242b
Oleg Smirnov
MDEV-34888 Implement SEMIJOIN() and SUBQUERY() hints
7b8e6b8799f7...
7b8e6b8799f7817f965479a1ed0bea8f6dbd38d9
Oleg Smirnov
MDEV-34860 Fix opt_hint_timeout.test for embedded; fix mariadb client

1. Disable opt_hint_timeout.test for embedded server. Make sure
the test does not crash even when started for embedded server.
Disable view-protocol since hints are not supported inside views.

2. Hints are designed to behave like regular /* ... */ comments:
  `SELECT /*+ " */ 1;` -- a valid SQL query
However, the mysql client program waits for the closing doublequote
character.
Another problem is observed when there is no space character between
closing `*/` of the hint and the following `*`:
  `SELECT /*+ some_hints(...) */* FROM t1;`
In this case the client treats `/*` as a comment section opening and
waits for the closing `*/` sequence.

This commit fixes all of these issues
7aeda1b0f74f...
7aeda1b0f74f03b9f00cf3696dfc5b8dab6a5e7e
Sergei Golubchik
compilation embedded
68b878d84726...
68b878d84726fc582687d560ae0934d61c83b6a6
Oleg Smirnov
MDEV-34860 Make the hint override global/session/statement setting of max_statement_time
66a063e48ef0...
66a063e48ef0bc568dbaebfc315a123036b0c29c
Lawrin Novitsky
ODBC-460 Crash in SQLExecDirect on UPDATE statement with paramset

SQLExecDirect uses text protocol by default.
If case of INSERT driver asseble INSERT ... VALUES(...),(...), ... query
on the paramset, and the function doing this was not affected. For
update the batch of statements was assembled, and that would crash.
  • codbc-bullseye-amd64: build linux-connector_odbc failed -  stdio
651e531323e7...
651e531323e7842750605f412e2237bfa31b8f40
Sergei Golubchik
MDEV-36405 Session tracking does not report changes from COM_CHANGE_USER

report all sysvar tracker changes, as for the new login.
also report db and other session state changes.

this also fixes

MDEV-36384 Command-line client keeps showing database in prompt after changing user
5c99fc70ffc7...
5c99fc70ffc7a76a0fb4849c608bd7681b4f9270
Sergei Golubchik
MDEV-36405 Session tracking does not report changes from COM_CHANGE_USER

report all sysvar tracker changes, as for the new login.
also report db and other session state changes.

this also fixes

MDEV-36384 Command-line client keeps showing database in prompt after changing user
502f38a9f08b...
502f38a9f08b92c3fb64aabf9d52f0839756e0f3
Sergei Golubchik
increase tolerance in socket_summary_check.inc

for approx. stat P_S calculations.

fixes perfschema.socket_summary_by_instance_func
4d41ec081e34...
4d41ec081e34671a1997ce797dcb9f7b7997437e
Oleksandr Byelkin
Merge branch '10.6' into 10.11
47208f3dff19...
47208f3dff193742177794fa61e338bd2eafbb03
Oleg Smirnov
MDEV-33281 Fix after-rebase commits
41d27fd2a40d...
41d27fd2a40d77c9d0aee0a8c32c77ca831a66e1
Sergei Golubchik
mtr: 10x longer timeouts if --big

unless they were specified explicitly on the command line.

note that specifying test names on the command line enables big
tests too, but without explicit --big it won't affect timeouts
3aa9d016bc8f...
3aa9d016bc8fee67813772e0793556db5c7f2e40
Sergei Golubchik
cleanup: extract reusable code chunks

move user_name parser rule out of user_maybe_role

extract setting privileges on login from acl_authenticate() into a
  separate function
34bdfa9b92d0...
34bdfa9b92d0e262fd8303f070eed94c11d318e4
Sergei Golubchik
increase tolerance in socket_summary_check.inc

for approx. stat P_S calculations.

fixes perfschema.socket_summary_by_instance_func
3250686a5a03...
3250686a5a03bae0468e09a360285c18d13d93dc
Oleg Smirnov
MDEV-33281 Fix mysql-test-run to correctly handle hints

After commit 408a637b87cba62506a4fbf363424ccc8530df12 for MDEV-29344
the mysql-test framework started to misinterpret slash/star sequences for
statements looking like this:
  SELECT /* BNL(t1) */* FROM t1, t2
where there is no space after closing `*/` and the following `*`.
This commit fixes that misinterpretation
30eb6b7b0076...
30eb6b7b00764446bc49dca3d04154a021bb42e6
Oleg Smirnov
MDEV-33281 Implement optimizer hints

    This commit introduces:
    - the infrastructure for optimizer hints;
    - hints for join buffering: BNL(), NO_BNL(), BKA(), NO_BKA();
    - NO_ICP() hint for disabling index condition pushdown;
    - MRR(), MO_MRR() hint for multi-range reads control;
    - NO_RANGE_OPTIMIZATION() for disabling range optimization;
    - QB_NAME() for assigning names for query blocks.
2ea910daac48...
2ea910daac48e2f1460f6c6c701a81f9bd606657
Oleg Smirnov
MDEV-36675 Optimizer hints parser catches irrelevant `thd->is_error()` set by multi-RENAME TABLE

Optimizer hints parser analyzes `thd->is_error()` flag to detect a fatal
error occured during hints processing. However, this criteria is not
reliable and considered a bad practice.
This commit replaces the criteria with the parser's own `is_fatal_error()`
flag which is related strictly to hints parsing and not something else
2e97fa9db229...
2e97fa9db229c26b6c9c0f8239a7e2f207f1dae3
Sergei Golubchik
fix error messages

when a definer for SP/view is wrong - it shold be ER_MALFORMED_DEFINER,
not ER_NO_SUCH_USER

when one uses current_role as a definer or grantee but there's no
current role - it should be ER_INVALID_ROLE not ER_MALFORMED_DEFINER

when a non-existent user is specified - it should be ER_NO_SUCH_USER,
which should say "The user does not exist", not "Definer does not exist"

clarify ER_CANT_CHANGE_TX_CHARACTERISTICS to say what cannot be changed
27ec961432d8...
27ec961432d87df8c303a530955aa4c41522d0f4
Sergei Golubchik
MDEV-36399 SET SESSION AUTHORIZATION allows an unrpivileged user to bypass resource limits
20d283717990...
20d2837179906953e9371bffb7ce0584726b81cf
Sergei Golubchik
MDEV-36401 Access denied errors produced by SET SESSION AUTHORIZATION not reflected in status values
19644f6821d5...
19644f6821d59ecca0f9b1f44fadb3b887061965
Oleksandr Byelkin
Merge branch '10.5' into 10.6
167468a74523...
167468a74523e92bbd04c8ecb68c21557324e83b
Lawrin Novitsky
Updated C/C to the v3.4.5
  • codbc-bullseye-amd64: build linux-connector_odbc failed -  stdio
10aadde583e2...
10aadde583e2ec3583bb12f6a74b0b065380d32d
Oleg Smirnov
MDEV-33281 Optimizer hints Cleanup: fix formatting, rename objects
04f70d8e0d50...
04f70d8e0d507c69876a0c760595a3c67904eef4
Sergei Golubchik
MDEV-36589 Garbage written into slow log for SET SESSION AUTHORIZATION command, assertion fails

don't reset query start time on change user.
do reset bytes_sent_old on change user
BuildBot (0.8.9) working for the MariaDB project.
Page built: Sat 26 Apr 2025 09:22:10 (UTC)