Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
fe1a2f91af16...
fe1a2f91af16f7160dbc94bbe5a76a98ae09d4c1
Vladislav Vaintroub
update libmariadb
fdf12149fcf4...
fdf12149fcf445974f7c42bd043a0e01b908f235
Vladislav Vaintroub
Use the server's MariaDB::zlib target when built as a submodule

When Connector/C is built inside the MariaDB server tree, pick up the server's
zlib via the MariaDB::zlib target instead of running FIND_PACKAGE(ZLIB), so the
connector uses exactly the same zlib (bundled or system) as the server and no
longer depends on the FindZLIB result-variable signature. Standalone builds are
unchanged - they still fall back to FIND_PACKAGE(ZLIB).

Also stop adding zlib to CMAKE_REQUIRED_LIBRARIES: ZLIB_LIBRARY may now be an
(ALIAS) target which cannot be used inside try_compile() checks, and none of
those checks need zlib.

Server: MDEV-37996
e70185772d01...
e70185772d0161f9bda1e8eca9572735c9347270
Fariha Shaikh
MDEV-33660 Add note when setting AUTO_INCREMENT lower than next value

Currently, ALTER TABLE ... AUTO_INCREMENT = N silently fails when using
values lower than the next AUTO_INCREMENT value in the column.

Add a note when attempting to set AUTO_INCREMENT to a lower value than
the next AUTO_INCREMENT value, and maintain the higher value.

Update existing test suites and add a new test to the maria suite for
the newly added note.

All new code of the whole pull request, including one or several files
that are either new files or modified ones, are contributed under the
BSD-new license. I am contributing on behalf of my employer Amazon Web
Services, Inc.
e3546ca2b3b7...
e3546ca2b3b784069f8cb1eb2e59db2f190a49ae
Vladislav Vaintroub
Fix wide-decimal fetch in prepared statements

Regression from dcd0a343 (CONC-820): fetching a decimal via a prepared
statement could return MYSQL_DATA_MALFORMED (error 102) for valid rows.

- MAX_DECIMAL_LEN was 67 (max storable precision 65 + 2), but the server's
  maximum decimal string length is 83 (DECIMAL_MAX_STR_LENGTH = max possible
  precision 81 + 2). Corrected to 83.
- The check also rejected on field->length (display width), which can
  legitimately exceed the max string length for computed expressions such as
  TRUNCATE(<81 digits>, 28). Only the actual data length matters for buffer
  safety, so field->length is no longer checked.

Server: MDEV-37996 (found by --ps-protocol tests)
e0aee9ef4722...
e0aee9ef47225c1215f91ec05effe046814e50cd
Yuchen Pei
MDEV-39451 Cleanup Item_sum_ntile::val_int

Reduce function calls that just returns partition_row_count_

Add some assertions and explanations
d58e182cb9e1...
d58e182cb9e1d78722ae95bc14fd9303545aedf9
Vladislav Vaintroub
update libmariadb
cf4215c4625e...
cf4215c4625edfc13c0d97b97c36e4ef15c91dbd
Brandon Nesterenko
MDEV-39302: main.xa wrong errno ER_XAER_NOTA instead of ER_XA_RBROLLBACK

Revert some changes of bead24b7f3dff5a1fe8bcd283eccb7b654495b3e
which incorrectly removed wait_until_count_sessions.inc from xa.test.
This test relies on having fully disconnected sessions with prepared XA
transactions before progressing with the test. I.e., the prepared
transaction must be made fully recoverable before the test progresses to
try and XA COMMIT/ROLLBACK the transaction.

Signed-off-by: Brandon Nesterenko <[email protected]>
c91176cf2f81...
c91176cf2f81aead464d14140f1dcdc3937dab7c
Yuchen Pei
MDEV-39451 Accounting for truncation to value_max_length in the ntile comparison

When truncation to value_max_length in ntile function happens, the
cached string value is the truncated string. For the purpose of
comparison to determine the size of the current partition, it should
not compare the original string with the truncated string.
be8094fa48b5...
be8094fa48b57a93f3a57d1a64a8a0cff081d82e
sjaakola
MDEV-39681 delayed BF aborting with multi master load

Reason for the hanging, and occasional crashes turned out
to be orphaned innodb lock wait request of a BF aborted
local transaction, which had arrived in commit stage.

Reason is that wsrep BF-abort marks a transaction a deadlock
victim out-of-band, so (unlike native deadlock resolution)
the victim can still own a live LOCK_WAIT request;
if that orphaned waiter survives into commit/rollback,
another transaction granting it calls lock_wait_end() cross-thread
and corrupts the victim's state — surfacing as the lock_wait_end,
que_thr_step, and rollback_finish assertions.

This commit has fixes for claering lock wait status of BF aborted
transactions.

Commit has also a new mtr test: galera.galera_bf_abort_orphan_lock
to work as regression test for the fix.
bdb4f38c9d41...
bdb4f38c9d4143d6df248c4bf6126c807f49d7aa
Sergei Golubchik
MDEV-39841 handlersocket plugin default secret is empty

if handlersocket_plain_secret is not specified, generate a random one.
one can still set an empty secret in my.cnf if needed.
bd366d81b80a...
bd366d81b80aa65fc76ec570fa0bf218a996853b
bsrikanth-mariadb
MDEV-39942: use actual_rec_per_key in loose scan sj optimization

While performing loose scan semi-join optimization in
Loose_scan_opt::check_ref_access_part1() [opt_subselect.h],
the filtered value in the explain plan was in-consistent for a table
with index when same data was inserted using "insert into t1 values()...",
and "insert into t1 select * from t2". This is noticed when
rec_per_key[] was used to get the number of records during optimization.

However, when actual_rec_per_key() is used to get the number of records,
we don't notice this discrepancy.

This PR changes the rec_per_key[] usage to actual_rec_per_key() in the
method Loose_scan_opt::check_ref_access_part1() [opt_subselect.h]
b70008ab5ebf...
b70008ab5ebf721c9fa16a4ce06a4c0cc1b23a9c
PranavKTiwari
Added logic for global temp table.
b63519654614...
b63519654614d9cbbba20567b4983a4a34a067e0
Sergei Golubchik
github copilot review instructions
b2d913a88f03...
b2d913a88f03c8207f2b855b958654292c0cec8c
Sergei Golubchik
MDEV-39776 SHOW CREATE TABLE corrupts `-quoted table options

Two problems:

1. option value specified as `foo bar` was not quoted,
  printed as foo bar, breaking CREATE TABLE.
2. Option value that included */ was printed as is, in unknown
  options when the whole option was commented out, this broke the
  comment: /* opt='val*/ue' */

Fix: simplify value printing, ignore the original quoting,
always print the value quoted as a string. Break comment markers
with an escape (as *\/) if inside a comment.

Note, cannot use `-quoting, because \-escapes don't work inside,
backticks, so */ cannot be broken.
b0e5936a3ad8...
b0e5936a3ad8a8d78afd8fcb00a72b3954730477
Vladislav Vaintroub
Remove bogus length check in mthd_stmt_fetch_to_bind

The CONC-820 check flagged a row as malformed whenever the server's
declared field/data length exceeded a fixed maximum. That maximum is
unrelated to the caller's output buffer and is legitimately exceeded by
computed expressions (e.g. TRUNCATE(<81-digit value>, 28)), so valid
results failed with CR_MALFORMED_PACKET under --ps-protocol (server
MDEV-37996). The sentinel check (data_len > remaining packet space) is
the real malformed-packet guard and is kept.
a8c7e6b83014...
a8c7e6b83014066ef53eac27342c09811772e015
Vladislav Vaintroub
MDEV-37781 ASAN build crashes on deep query with low thread stack

check_stack_overrun() was compiled out under ASAN, so a deeply nested
expression recursed in Item_func::fix_fields() until the stack was
exhausted and the server crashed instead of reporting
ER_STACK_OVERRUN_NEED_MORE.

Since MDEV-34533 (Monty) the stack usage seems to be accounted correctly
under ASAN via my_get_stack_pointer(), so the check seems to works there
too.

Fix:
Remove the #ifndef __SANITIZE_ADDRESS__  guard from check_stack_overrun()

Add a test for ER_STACK_OVERRUN_NEED_MORE
a6a7fbf131e2...
a6a7fbf131e2549b73cdb7c048a0cbf62a41edf6
Vladislav Vaintroub
MDEV-37781 ASAN build crashes on deep query with low thread stack

check_stack_overrun() was compiled out under ASAN, so a deeply nested
expression recursed in Item_func::fix_fields() until the stack was
exhausted and the server crashed instead of reporting
ER_STACK_OVERRUN_NEED_MORE.

Since MDEV-34533 (Monty) the stack usage seems to be accounted correctly
under ASAN via my_get_stack_pointer(), so the check seems to works there
too.

Fix:
Remove the #ifndef __SANITIZE_ADDRESS__  guard from check_stack_overrun()

Add a test for ER_STACK_OVERRUN_NEED_MORE
a4b6ee9b2432...
a4b6ee9b2432bf8f53dff30abbb6b1daef3023a6
Vladislav Vaintroub
Use the server's MariaDB::zlib target when built as a submodule (#316)

When Connector/C is built inside the MariaDB server tree, pick up the server's
zlib via the MariaDB::zlib target instead of running FIND_PACKAGE(ZLIB), so the
connector uses exactly the same zlib (bundled or system) as the server and no
longer depends on the FindZLIB result-variable signature. Standalone builds are
unchanged - they still fall back to FIND_PACKAGE(ZLIB).

Also stop adding zlib to CMAKE_REQUIRED_LIBRARIES: ZLIB_LIBRARY may now be an
(ALIAS) target which cannot be used inside try_compile() checks, and none of
those checks need zlib.

Server: MDEV-37996
a461ea5adf8c...
a461ea5adf8cfda5d6372e3acd7579f1222f2198
sjaakola
MDEV-38243 Write binlog row events for changes done by cascading FK operations

This commit implements a feature which changes the handling of cascading foreign
key operations to write the changes of cascading operations into binlog.
The applying of such transaction, in the slave node, will apply just the binlog
events, and does not execute the actual foreign key cascade operation.
This will simplify the slave side replication applying and make it more predictable
in terms of potential interference with other parallel applying happning
in the node.

This feature can be turned ON/OFF by new variable:
rpl_use_binlog_events_for_fk_cascade, with default value OFF

The actual implementation is largely by windsurf.

The commit has also mtr tests for testing rpl_use_binlog_events_for_fk_cascade
feature:  rpl.rpl_fk_cascade_binlog_row, rpl.rpl_fk_set_null_binlog_row and
rpl.fk_cascade_binlog_row_rollback
9fa1780d92f2...
9fa1780d92f22cc7ec88cf6699883b401c2ff3cb
Dave Gosselin
MDEV-33524:  marked_for_read assertion with virtual column

A couple of things interact in this scenario.

1. A virtual column whose value depends on session state, such as a
VCOL calling DATE_FORMAT, has fix_fields (via fix_expr) run on it
again before each INSERT.  For a table reused from the cache this runs in
Vcol_expr_context before setup_tables sets the table map.  The test
first opens t1 with a SELECT that fails before setup_tables, leaving
it cached with map zero.

2. When the connection character set needs conversion, CONCAT (more
generally, any charset aggregation) wraps that column in a charset
converter.  The converter evaluates any argument reported as
constant, so it calls val_str() on the column as part of
fix_fields, before a row exists and without the column in the read
set.  On DEBUG builds this fails the marked_for_read assertion;
otherwise it reads an unread column.

Consequently:
When a table instance is opened, fix_fields runs with table->map
already nonzero, but the fix_fields (via fix_expr) call from vcol_fix_expr
did not have it nonzero; so set table->map=1 during Vcol_expr_context::init.
The original Vcol_expr_context::init() (MDEV-24176) called
init_lex_with_single_table, which set table->map= 1 as a side effect.
A later merge of 10.2 into 10.3 (6f6c74b0d18) replaced that call with
a backup of table->expr_arena, dropping the side effect.
The destructor of the Vcol_expr_context will reset the map back to its
original value.
9e12726e998c...
9e12726e998c9566c6fe46a19093ea53ee08d70d
PranavKTiwari
Added logic for global temp table.
91fe17e020d5...
91fe17e020d5c12feb818fde4066a65596cf254d
Dave Gosselin
MDEV-24658:  Optimizer trace reads a column not marked for read

When the optimizer trace is enabled, it's safe to read from a
constant table because the value in record[0] was materialized
during optimization and remains available, even after constants
propagation has removed the table from the read set.
91634c8ba6f4...
91634c8ba6f41ce4c08b3ffd0739da19f88d2376
Brandon Nesterenko
MDEV-39302: main.xa wrong errno ER_XAER_NOTA instead of ER_XA_RBROLLBACK

When a session has a prepared an XA transaction (via XA PREPARE), if it
is not yet finalized (via XA COMMIT / ROLLBACK) when the session
disconnects, there is cleanup logic by the disconnecting session to put
this hanging transaction into a recoverable state. The main.xa test
follows a pattern where it disconnects these transactions, but doesn't
wait for the session to finalize before it tries to finalize these
transactions. If the transaction hasn't yet been put into a recoverable
state, when the test tries to XA COMMIT or XA ROLLBACK the transaction,
it results in the error:

mysqltest: At line 831: query 'xa commit 'c:foo'' failed: ER_XAER_NOTA (1397): XAER_NOTA: Unknown XID

The test is fixed by waiting for the XA PREPARE'ing session
to finalize and be disconnected before trying to recover/commit/rollback
it.

Signed-off-by: Brandon Nesterenko <[email protected]>
80cc8d397686...
80cc8d397686f068a29493997fe74a862a2af5b5
Dave Gosselin
MDEV-24658:  Optimizer trace reads a column not marked for read

When the optimizer trace is enabled, it's safe to read from a
constant table because the value in record[0] was materialized
during optimization and remains available, even after constants
propagation has removed the table from the read set.
7eb0987fec06...
7eb0987fec069ff1f348756497cbb5d260ac1b82
Brandon Nesterenko
MDEV-39302: main.xa wrong errno ER_XAER_NOTA instead of ER_XA_RBROLLBACK

Revert some changes of bead24b7f3dff5a1fe8bcd283eccb7b654495b3e
which incorrectly removed wait_until_count_sessions.inc from xa.test.
This test relies on having fully disconnected sessions with prepared XA
transactions before progressing with the test. I.e., the prepared
transaction must be made fully recoverable before the test progresses to
try and XA COMMIT/ROLLBACK the transaction.

Signed-off-by: Brandon Nesterenko <[email protected]>
769eef2e983f...
769eef2e983fa4a138585849169573e21cc9e1d5
Vladislav Vaintroub
MDEV-37781 ASAN build crashes on deep query with low thread stack

check_stack_overrun() was compiled out under ASAN, so a deeply nested
expression recursed in Item_func::fix_fields() until the stack was
exhausted and the server crashed instead of reporting
ER_STACK_OVERRUN_NEED_MORE.

Since MDEV-34533 (Monty) the stack usage seems to be accounted correctly
under ASAN via my_get_stack_pointer(), so the check seems to works there
too.

Fix:
Remove the #ifndef __SANITIZE_ADDRESS__  guard from check_stack_overrun()

Add a test for ER_STACK_OVERRUN_NEED_MORE
672252a5b048...
672252a5b0485bbc5c6d4e24c25a155f0c5460db
PranavKTiwari
Added logic for global temp table.
60825b5dfc4c...
60825b5dfc4c030f7bb7b335f1a6c1630d1ec84f
Yuchen Pei
MDEV-39451 Cleanup Item_sum_ntile::val_int

Reduce function calls that just returns partition_row_count_

Add some assertions and explanations
5a7f9a984a18...
5a7f9a984a1845dfbdac6d3079928edbdd45ec76
Vladislav Vaintroub
Remove bogus length checks in mthd_stmt_fetch_to_bind

Commit dcd0a343 ("Length and type checking for stmt_fetch_to_bind") added
checks that reject valid rows; under --ps-protocol the server test suite
hits them and buildbot fails (server MDEV-37996). Both checks are wrong.

Display length (field->length > MAX_ZEROFILL_LEN / MAX_DECIMAL_LEN):
field->length is result-set metadata -- the column's maximum display
width from the column-definition packet -- not the size of any row value.
It is routinely larger than the data and can be arbitrarily large for
computed expressions (zerofill, wide DECIMAL such as
TRUNCATE(<81-digit value>, 28)), so this rejected perfectly valid rows.

Decimal data length (data_len > MAX_DECIMAL_LEN, capped at 67 vs the
server maximum DECIMAL_MAX_STR_LENGTH = 83): redundant. A DECIMAL is
fetched by ps_fetch_string, which ignores the field and passes the raw
bytes to convert_froma_string; numbers are parsed with explicit
begin/end pointers and strings are copied with MIN(len, buffer_length).
Nothing is sized by data_len, so the value is handled safely at any
length and the check guards nothing.

The sentinel (data_len > remaining packet space) already prevents reading
past the packet and is the only check the row data needs. Remove both
checks, the now-unused MAX_ZEROFILL_LEN / MAX_DECIMAL_LEN, and the test
case that asserted the removed display-length behaviour.
523617dec03a...
523617dec03ad6fe02d69c23923290c4f46f2702
Vladislav Vaintroub
MDEV-37781 ASAN build crashes on deep query with low thread stack

check_stack_overrun() was compiled out under ASAN, so a deeply nested
expression recursed in Item_func::fix_fields() until the stack was
exhausted and the server crashed instead of reporting
ER_STACK_OVERRUN_NEED_MORE.

Since MDEV-34533 (Monty) the stack usage seems to be accounted correctly
under ASAN via my_get_stack_pointer(), so the check seems to works there
too.

Fix:
Remove the #ifndef __SANITIZE_ADDRESS__  guard from check_stack_overrun()

Add a test for ER_STACK_OVERRUN_NEED_MORE
4bd757b61cca...
4bd757b61ccaf6a58116755193bcf69b6ba1b329
Vladislav Vaintroub
MDEV-37996 update libmariadb to use server's MariaDB::zlib

Remove hack in cmake/mariadb_connector_c.cmake that sets variables
to make connectors FIND_PACKAGE(ZLIB) use server's zlib.
it is not necessary anymore, and is expressed more directly.
4ba2ebdd86f8...
4ba2ebdd86f8f90752e3c67d89af579b7b22f796
forkfun
MDEV-39380 Assertion `arg2_int >= 0' failed in Item_func_additive_op::result_precision

A 0xHHHH / b'..' literal keeps its hex_hybrid type through
COALESCE/IF/IFNULL/NVL/NVL2/NULLIF/CASE/LEAST/GREATEST, but was evaluated,
sized and stored as a string, so a wrapped literal behaved differently from a
bare one (10+COALESCE(0x31) gave 11 instead of 59;).

After the patch the numeric side of Type_handler_hex_hybrid so it matches the bare
literal:
- val_int/val_real/val_decimal read the bytes as a hex hybrid, not a number string
- Item_decimal_precision returns the integer precision (correct DECIMAL sizing
  for AVG/SUM, views, CREATE ... SELECT)
- Item_save_in_field stores it like the bare literal into any column type
- keep the hybrid type when aggregated with NULL (COALESCE(NULL, 0x31))
- restore decimals=0/unsigned after string attribute aggregation
4a42b823f4c3...
4a42b823f4c3ee0796c83b80d6003bbeca6e9523
Yuchen Pei
MDEV-39451 Accounting for truncation to value_max_length in the ntile comparison

When truncation to value_max_length in ntile function happens, the
cached string value is the truncated string. For the purpose of
comparison to determine the size of the current partition, it should
not compare the original string with the truncated string.
473f573b552b...
473f573b552b0158a1685c714e39112e12af72d4
Sergei Golubchik
MDEV-39841 handlersocket plugin default secret is empty

if handlersocket_plain_secret is not specified, generate a random one.
one can still set an empty secret in my.cnf if needed.
354a54527dde...
354a54527dde860b1e272498e989b72a34839488
Brandon Nesterenko
MDEV-39302: main.xa wrong errno ER_XAER_NOTA instead of ER_XA_RBROLLBACK

When a session has a prepared an XA transaction (via XA PREPARE), if it
is not yet finalized (via XA COMMIT / ROLLBACK) when the session
disconnects, there is cleanup logic by the disconnecting session to put
this hanging transaction into a recoverable state. The main.xa test
follows a pattern where it disconnects these transactions, but doesn't
wait for the session to finalize before it tries to finalize these
transactions. If the transaction hasn't yet been put into a recoverable
state, when the test tries to XA COMMIT or XA ROLLBACK the transaction,
it results in the error:

mysqltest: At line 831: query 'xa commit 'c:foo'' failed: ER_XAER_NOTA (1397): XAER_NOTA: Unknown XID

The test is fixed by waiting for the XA PREPARE'ing session
to finalize and be disconnected before trying to recover/commit/rollback
it.

Signed-off-by: Brandon Nesterenko <[email protected]>
318a5b3c8788...
318a5b3c87883126eacd4f590be7d2902d70c60c
Sergei Golubchik
MDEV-39776 SHOW CREATE TABLE corrupts `-quoted table options

Two problems:

1. option value specified as `foo bar` was not quoted,
  printed as foo bar, breaking CREATE TABLE.
2. Option value that included */ was printed as is, in unknown
  options when the whole option was commented out, this broke the
  comment: /* opt='val*/ue' */

Fix: simplify value printing, ignore the original quoting,
always print the value quoted as a string. Break comment markers
with an escape (as *\/) if inside a comment.

Note, cannot use `-quoting, because \-escapes don't work inside,
backticks, so */ cannot be broken.
2bd5b1252811...
2bd5b1252811e09c5d44eaf12a4d6a35db46b630
Dave Gosselin
MDEV-33524:  marked_for_read assertion with virtual column

vcol.vcol_misc deadlocks under --view-protocol at the
FLUSH TABLES WITH READ LOCK block.  The main connection holds
the global read lock.  The SELECT COUNT(*) FROM t1 query becomes
CREATE OR REPLACE VIEW on a separate connection, and that DDL
blocks on the read lock and never returns.  So the same mysqltest
client never reaches unlock tables.  The fix is to wrap only that
one SELECT in the view_protocol guards.
284559c6bcf4...
284559c6bcf420cef26ec6e351b7857c7345e713
Brandon Nesterenko
MDEV-39302: main.xa wrong errno ER_XAER_NOTA instead of ER_XA_RBROLLBACK

When a session has a prepared an XA transaction (via XA PREPARE), if it
is not yet finalized (via XA COMMIT / ROLLBACK) when the session
disconnects, there is cleanup logic by the disconnecting session to put
this hanging transaction into a recoverable state. The main.xa test
follows a pattern where it disconnects these transactions, but doesn't
wait for the session to finalize before it tries to finalize these
transactions. If the transaction hasn't yet been put into a recoverable
state, when the test tries to XA COMMIT or XA ROLLBACK the transaction,
it results in the error:

mysqltest: At line 831: query 'xa commit 'c:foo'' failed: ER_XAER_NOTA (1397): XAER_NOTA: Unknown XID

The test is fixed by waiting for the XA PREPARE'ing session
to finalize and be disconnected before trying to recover/commit/rollback
it.

Signed-off-by: Brandon Nesterenko <[email protected]>
17ae0fe8b30b...
17ae0fe8b30b7d0f9a77c68fa8d7c3d241738026
Aleksey Midenkov
MDEV-39306 Index corruption on UPDATE when using versioned InnoDB table (on UPDATE)

VCOL_UPDATE_FOR_READ does not update virtual fields for the following
cases:

1. It is not in read_set;
2. It is not in the index, but can be calculated from index columns;
3. It is stored virtual column.

VCOL_UPDATE_FOR_WRITE does not have conditions 2. and 3.

Test case fails condition 3., stored vcol was not updated by
VCOL_UPDATE_FOR_READ. Since vers_update_fields() is only for write
operations it is safe to change it to VCOL_UPDATE_FOR_WRITE.
BuildBot (0.8.9) working for the MariaDB project.
Page built: Thu 02 Jul 2026 01:47:29 (UTC)