Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
f12634f5a451...
f12634f5a4513d73de828d8d04010c2f17d3a69d
Sergei Golubchik
MDEV-34530 dead code in the thr_rwlock.c

remove it
e7c2e25ba82c...
e7c2e25ba82cafcacecac8c2927ab5d1f7d3c305
Oleksandr Byelkin
new CC version
e644e130b0f8...
e644e130b0f8236826b372d81f7fb214ba0a3e5f
Sergei Petrunia
MDEV-30623: Fix the testcase

- Fix view-protocol: long expressions in SELECT
  list should have "expr AS column_name".

- Also, moved the test from subselect*test to
  suite/json/t/json_table.test.
dea5746de2e6...
dea5746de2e604bb1c15892d7f77593e6d7145a2
Sergei Golubchik
MDEV-32155 MariaDB Server crashes with ill-formed partitions

for ALTER_PARTITION_ADMIN (CHECK/REPAIR/LOAD INDEX/CACHE INDEX/etc)
partitioning marks affected partitions with PART_ADMIN state.

The assumption is that the server will call a corresponding
method of ha_partition which will reset the state back to PART_NORMAL.

This assumption is invalid, the server is not required to do so,
indeed, in CHECK ... FOR UPGRADE the server might decide early that
the table is fine and won't call ha_partition::check(), leaving
partitions in the wrong state. It will thus leak into the next
statement confusing the engine about what it is doing (see
ha_partition::create_handler_file()), causing a crash later.

Let's force all partitions into PART_NORMAL state after the admin
operation succeeded, in case it did so without consulting the engine.
d60f5c11ea90...
d60f5c11ea9008fa57444327526e3d2c8633ba06
Sergei Golubchik
MDEV-34318 mariadb-dump SQL syntax error with MAX_STATEMENT_TIME against Percona MySQL server

protect MariaDB conditional comments from a bug
in Percona MySQL comment parser
d20518168aff...
d20518168aff435a4843eebb108e5b9df24c19fb
Sergei Golubchik
also protect the /*!999999 sandbox comment
b8f92ade5769...
b8f92ade57691a78cc97c5d79eae0a27a10cb8f2
Andrei
MDEV-15393 gtid_slave_pos duplicate key errors after mysqldump restore

When mysqldump is run to dump the `mysql` system database, it generates
INSERT statements into the table `mysql.gtid_slave_pos`.
After running the backup script
those inserts did not produce the expected gtid state on slave. In
particular the maximum of mysql.gtid_slave_pos.sub_id did not make
into
  rpl_global_gtid_slave_state.last_sub_id

an in-memory object that is supposed to match the current state of the
table. And that was regardless of whether --gtid option was specified
or not. Later when the backup recipient server starts as slave
in *non-gtid* mode this desychronization may lead to a duplicate key
error.

This effect is corrected for --gtid mode mysqldump/mariadb-dump only
as the following.  The fixes ensure the insert block of the dump
script is followed with a "summing-up" SET @global.gtid_slave_pos
assignment.

For the implemenation part, note a deferred print-out of
SET-gtid_slave_pos and associated comments is prefered over relocating
of the entire blocks if (opt_master,slave_data &&
do_show_master,slave_status) ...  because of compatiblity
concern. Namely an error inside do_show_*() is handled in the new code
the same way, as early as, as before.

A regression test can be run in how-to-reproduce mode as well.
One affected mtr test observed.
rpl_mysqldump_slave.result "mismatch" shows now the new deferring print
of SET-gtid_slave_pos policy in action.
b8b6cab2d767...
b8b6cab2d7679c9ac4b7f720c9de9c7d521ecca2
Oleksandr Byelkin
Fix view protocol
b777b749ad57...
b777b749ad57b11f3e0f0adc96ce06e50e704d23
Alexander Barkov
MDEV-28345 ASAN: use-after-poison or unknown-crash in my_strtod_int from charset_info_st::strntod or test_if_number

This patch fixes two problems:

- The code inside my_strtod_int() in strings/dtoa.c could test the byte
  behind the end of the string when processing the mantissa.
  Rewriting the code to avoid this.

- The code in test_if_number() in sql/sql_analyse.cc called my_atof()
  which is unsafe and makes the called my_strtod_int() look behind
  the end of the string if the input string is not 0-terminated.
  Fixing test_if_number() to use my_strtod() instead, passing the correct
  end pointer.
a94fd8742094...
a94fd8742094de9d97e8db410a61e7e34f6898b8
Oleksandr Byelkin
New CC 3.3
a938503cfb7b...
a938503cfb7b6c271ba6ea83e52a0f52d2fafc5a
Oleksandr Byelkin
Merge branch '10.5' into 10.6
a061ae107931...
a061ae1079312357fb42c4d82fc2188201179122
Brandon Nesterenko
MDEV-33921: Fix rpl_xa_empty_transaction.test

The test was missing a save_master_gtid.inc on the master,
leading to the slave thinking it was in sync after executing
sync_with_master_gtid.inc, despite not having executed the
latest transaction. This skipped transaction, XA COMMIT,
was supposed to error-to-be-ignored because its XID could not
be found, but be thrown out because the replication filters
would filter out the target database. However, if the slave
was able to stop before executing the transaction, then
the replication filer is reset (to empty), and when the
slave is later restarted, that transactions error would
no longer be ignored.

Additionally, as the test cases added in MDEV-33921 rely
on GTID synchronization, the test cases now force
master_use_gtid=slave_pos for consistency
9dafde575f0f...
9dafde575f0f91a25d0357c060c311a098c1a737
Alexander Barkov
Additional tests for MDEV-28345 ASAN: use-after-poison or unknown-crash in my_strtod_int from charset_info_st::strntod or test_if_number
9af2caca33aa...
9af2caca33aaaaeeb0b7e9958895af5e29fb9bfd
Oleksandr Byelkin
Merge branch '10.5' into 10.6
972879f413a1...
972879f413a1aa8aa2d52b731fe65315f9be208b
Oleg Smirnov
MDEV-33010 Crash when pushing condition with CHARSET()/COERCIBILITY() into derived table

Based on the current logic, objects of classes Item_func_charset and
Item_func_coercibility (responsible for CHARSET() and COERCIBILITY()
functions) are always considered constant.
However, SQL syntax allows their use in a non-constant manner, such as
CHARSET(t1.a), COERCIBILITY(t1.a).

In these cases, the `used_tables()` parameter corresponds to table names
in the function parameters, creating an inconsistency: the item is marked
as constant but accesses tables. This leads to crashes when
conditions with CHARSET()/COERCIBILITY() are pushed into derived tables.

This commit addresses the issue by setting `used_tables()` to 0 for
`Item_func_charset` and `Item_func_coercibility`. Additionally, the items
now store the return values during the preparation phase and return
them during the execution phase. This ensures that the items do not call
its arguments methods during the execution and are truly constant.

Reviewer: Alexander Barkov <[email protected]>
8d813f080b51...
8d813f080b510572ee0c056748b0055ae83ef23c
Sergei Golubchik
MDEV-34539 Invalid "use" and "Schema" in slow query log file with multi-line schema

quote a database name in the slow log
8ac30517af11...
8ac30517af11cd40e6098e91e7f31268ef857b99
Sergei Golubchik
MDEV-34384 restorecon call in RPM POSTIN script has hardcoded datadir path
85a36958e35b...
85a36958e35bc2d30edefc93638c1f7c62c69b40
Yuchen Pei
MDEV-27902 Some Spider code documentation regarding first_link_idx and remote HANDLER commands
8416fd323cf6...
8416fd323cf69f8fc1d7dcd5bd5e54e504e7f8b9
Yuchen Pei
MDEV-32627 [fixup] Spider: Fix conn key length

To avoid off-by-one in spider_get_share.

And document conn key and conn key length.
7ba12d42de8a...
7ba12d42de8ae4750ea0699084edb2ff6fdd85c0
Sergei Golubchik
MDEV-34434 Hide password passed on commandline from xtrabackup_info

refine mariadb-backup password zapping check
7478fabcff12...
7478fabcff127e52282e211632938067f75213bb
Oleksandr Byelkin
new PCRE2-10.44
6f3baec4f5bf...
6f3baec4f5bf32392532b5142e92ea2010a34815
Yuchen Pei
MDEV-32627 Spider: add tests for connection param overriding

When connection parameters are specified in COMMENT, CONNECTION and
SERVER, they are overriden in the following order:

COMMENT > CONNECTION > SERVER
696c2497fccc...
696c2497fccc320b1f306758cdf6b24c97669509
Yuchen Pei
MDEV-27902 Spider check trx and get conn in rnd_next()

This allows creation of SPIDER_CONN on demand, if the previous one was
freed.

Also, the first_link_idx's are reset during
spider_check_trx_and_get_conn(), which in the case of remote HANDLER
commands, might not match the link to use correct first_link_idx for
remote HANDLER statement that was later set in
ha_spider::rnd_handler_init() (causing testing regressions in the
spider/handler suite). Therefore we fix the first_link_idx there.
653050ac8495...
653050ac8495180bd18599756fc652471c155cfe
Yuchen Pei
MDEV-32492 MDEV-29676 Spider: some code documentation and cleanup

Some documentations come from commit for MDEV-29676, and the rest are
mainly related to SPIDER_TRX_HA.

Removed SPIDER_TRX_HA::trx as it is unused.
62dfd0c09dc2...
62dfd0c09dc2f138075047e726f2cab592807edb
Tuukka Pasanen
MDEV-33837: Workaround chown warnings

Blindly recursive chown is not way to do it.
This Workaround is not much better than just chown -R but
there is small adjustment just chown MariaDB statedir and logdir
then with find only chown those files that are not correctly
owned.

Fixes lintian warnings:
* W: mariadb-server: recursive-privilege-change "chown -R" [postinst:*]
* W: mariadb-server: recursive-privilege-change "chown -R" [postinst:*]
4a89f79b6aa0...
4a89f79b6aa05aed2ae39f0a3c968c4bb5196043
Souradeep Saha
Refactor import * with only required imports

Import only the required functions instead of all the functions from the
module to reduce the unnecessary functions in the namespace and prevent
shadowing. Note: All code changes are non-functional.

All new code of the whole pull request, including one or several
files that are either new files or modified ones, are contributed
under the BSD-new license. I am contributing on behalf of my
employer Amazon Web Services, Inc.
49dff5a4b621...
49dff5a4b62109ba38421e34cf2944ad0fc00a76
PinkFreud
MDEV-34604 mytop - fix specifying filters in .mytop

Specifying filters (filter_status, filter_user, etc) in the mytop config
previously wouldn't work, because any filter specified here was added to
the config hash as a literal string.

This change fixes that - if filter_* is defined in the config and matches
an existing filter_* key, then run the value through StringOrRegex() and
assign to the config hash.
384ec03e4884...
384ec03e4884fcd224d5b12a8ccd53a7766280b2
Yuchen Pei
MDEV-34421 Check the SQL command when resolving storage engine

ENGINE_SUBSTITUTION only applies to CREATE TABLE and ALTER TABLE, and
Storage_engine_name::resolve_storage_engine_with_error() could be
called when executing any sql command.
383d53edbcae...
383d53edbcaee7762e5e90473cda361b9c9e29d3
Sutou Kouhei
MDEV-21166 Add Mroonga initialized check to Mroonga UDFs

Mroonga UDFs can't be used without loading Mroonga.
36b867ad507a...
36b867ad507a3d3bf5a6ede110d589fcd42951e9
Sergei Golubchik
MDEV-34353 Revert "don't wait indefinitely for signal handler in --bootstrap"

This reverts commit 938b92937247. Not needed after 90d376e01710.
3359ac09a42c...
3359ac09a42c26cbf9002da268cbc949721464b8
Thirunarayanan Balathandayuthapani
MDEV-34066  Output of SHOW ENGINE INNODB STATUS uses the nanoseconds suffix for microseconds

- This issue is caused by commit e71e6133535da8d5eab86e504f0b116a03680780
(MDEV-24671). Change the output of transaction lock wait
time in microseconds suffix.
216fdb155683...
216fdb155683e960297b089e024c439593bbe6a8
Dave Gosselin
MDEV-33971 fix --view-protocol test failure

Allow the NAME_CONST unwrap optimization when the client is not
in the PREPARE step of prepared statement nor in the view
analysis mode.
20d99f3f86ab...
20d99f3f86abb5f37cec698f3ff3fa35f5d3a35c
Yuchen Pei
MDEV-32627 Distinguish between absence of a keyword and empty value for the keyword

Distinguish them in two place:

when constructing connection key in create_conn_key and
spider_create_conn for both ordinary queries and spider_direct_sql

For spider_create_conn and spider_udf_direct_sql_create_conn, the
created conn gets assigned a field from the source object if and only
if source->field is non-null.

For spider_create_conn_keys and spider_udf_direct_sql_create_conn_key,
we update the encoding so that absence of keyword and keyword with an
empty value result in different keys. More specifically, if the i-th
keyword has a value, the corresponding part in the conn key begins
with the char \i, followed by the possibly empty value and ends with a
\0. If the i-th keyword is not specified, then it does not get a
mention in the conn key.

As part of this change, we also update table param / option parsing to
recognise a singleton empty string when creating an string list,
instead of writing it off as NULL.
1f28350b59e0...
1f28350b59e022b4e968dd880d8f2de2def9f5f5
Rucha Deodhar
MDEV-32456: incorrect result of gis function in view protocol

There are 3 diff in result:
1) NULL value from SELECT
Due to incorrect truncating of the hex value, incorrect value is
written instead of original value to the view frm. This results in reading
incorrect value from frm, so eventual result is NULL.
2) 'Name_exp1' in column name (in gis.test)
This was because the identifier in SELECT is longer than 64 characters,
so 'Name_exp1' alias is also written to the view frm.
3)diff in explain extended
This was because the query plan for view protocol doesn't
contain database name. As a fix, disable view protocol for that particular
query.
1c11a19b3a91...
1c11a19b3a91520fe49f0e6e3ded196299f4f43d
Monty
Added option fix_innodb_cardinality to optimizer_adjust_secondary_key_costs

Using fix_innodb_cardinality disables the 'divide by 2' of rec_per_key_int
in InnoDB that in effect doubles the Cardinality for secondary keys.
This has the biggest effect for indexes where a few rows has the same key
value. Using this may also cause table scans for very small tables (which
in some cases may be better than an index scan).

The user visible effect is that 'SHOW INDEX FROM table_name' will for
InnoDB show the true Cardinality (and not 2x the real value). It will
also allow the optimizer to chose a better index in some cases as the
division by 2 could have a bad effect for tables with 2-5 identical values
per key.

A few notes about using fix_innodb_cardinality:
- It has direct affect for SHOW INDEX FROM table_name. SHOW INDEX
  will also update the statistics in table share.
- The effect of fix_innodb_cardinality for query plans or EXPLAIN
  is only visible after first open of the table. This is why one must
  do a flush tables or use SHOW INDEX for the option to take effect.
- Using fix_innodb_cardinality can thus affect all user in their query
  plans if they are using the same tables.

Because of this, it strongy recommended that one uses
optimizer_adjust_secondary_key_costs=fix_innodb_cardinality mainly
in configuartion files to not cause issues for other users.
14c40509923c...
14c40509923c156cab5ee7ebc457a943b485f03f
Yuchen Pei
MDEV-32492 Delete and remove trx_ha on spider share mismatch

A SPIDER_TRX_HA associated with a SPIDER_TRX could have longer
lifetime than its associated SPIDER_SHARE. And it is identified with
the associated table name. When the SPIDER_SHARE no longer valid, e.g.
when the associated spider table has been dropped and recreated, the
SPIDER_TRX_HA should be reset too.

Since spider could create a new SPIDER_SHARE with the exact same
address of a freed SPIDER_SHARE, we try to mark all SPIDER_TRX_HAs
associated with a SPIDER_SHARE invalid when the SPIDER_SHARE is about
to be freed.
132270d3de73...
132270d3de73163f0198c72e8352a388c69a1be5
Yuchen Pei
MDEV-34541 Clean up spider self reference check

SPIDER_CONN::loop_check_meraged_first is useless, because all
SPIDER_CONN_LOOP_CHECKs are in SPIDER_CONN::loop_check_queue, which in
spider_db_conn::fin_loop_check() is iterated over.

This fixes the use-after-free issue when there are three spider tables
sharing the same remote, and their corresponding
SPIDER_CONN_LOOP_CHECKs getting merged in
spider_conn_queue_and_merge_loop_check()

This also fixes MDEV-34555
0bb986288856...
0bb9862888567a5304aec18e85bf6dd002fc25d3
Yuchen Pei
MDEV-29962 Spider: creates connections if needed before lock_tables()

Same cause as MDEV-31996. This prevents reuse of conns freed
previously, e.g. during the commit of previous statement.

It does not occur in 10.4 because of the commit for MDEV-19002 removed
the call to spider_check_trx_and_get_conn().
03a350378ad6...
03a350378ad627d509a31a788896067b02f80e53
Yuchen Pei
MDEV-30408 Reset explicit_limit in exists2in

Item_exists_subselect::fix_length_and_dec() sets explicit_limit to 1.
In the exists2in transformation it resets select_limit to NULL. For
consistency we should reset explicity_limit too.

This fixes a bug where spider table returns wrong results for queries
that gets through exists2in transformation when semijoin is off.
008bddaa6c81...
008bddaa6c81fe30071475c24253950a4144863e
Robin Newhouse
GitLab CI Upgrade CentOS 8 to CentOS 9 build

> After May 31, 2024, CentOS Stream 8 will be archived and no further
updates will be provided. [1]

CentOS Stream 8 is now EOL and should be updated to using CentOS Stream
9 for compatibility testing in GitLab CI.

[1] https://blog.centos.org/2023/04/end-dates-are-coming-for-centos-stream-8-and-centos-linux-7/
https://www.centos.org/centos-linux-eol/

All new code of the whole pull request, including one or several files
that are either new files or modified ones, are contributed under the
BSD-new license. I am contributing on behalf of my employer Amazon Web
Services.
BuildBot (0.8.9) working for the MariaDB project.
Page built: Sat 27 Jul 2024 13:37:04 (UTC)