Console View

Categories: connectors experimental galera main

Legend:

Passed

Failed

Warnings

Failed Again

Running

Exception

Offline

No data

connectors

experimental

galera

main

e85bc659188b...

e85bc659188be021897e8578aec42becfbb58c27

Rex Johnston

rex.johnston@mariadb.com

MDEV-37220 Allow UPDATE/DELETE to read from a CTE

We extend from the SQL standard to match the functionality of other
databases that allow the inclusion of a CTE definition prior to update
and delete statements.

These CTEs are currently read only, like other derived tables, so
cannot have their columns updated in updates set clause, nor have rows
removed in the delete statement.

Approved by: Oleksandr Byelkin ([email protected])

dc664a47f765...

dc664a47f765d9331aa8ebf07e662382b45e4569

ParadoxV5

paradox.ver5@gmail.com

MDEV-38410: use array, not `std::initializer_list`

Some environments appear not to retain the backing array of a
static `std::initializer_list` in the MDEV-37530 release candidate,
and eventually crash when reading overwritten data.

This commit fixes this stealth issue by changing back to
conventional arrays; convenience is kept through deductive overloads.

d936d36d4f91...

d936d36d4f91a69ab599b7fbc9c954dc16b335ab

Raghunandan Bhat

raghunandan.bhat96@gmail.com

MDEV-30847: HashiCorp Plugin: Provide cache flush for key rotation

Introduces `FLUSH HASHICORP_KEY_MANAGEMENT_CACHE` command to flush the
cached keys in the HashiCorp Key Management plugin, enabling rotation of
encryption keys without needing to restart the server.

The new `INFORMATION_SCHEMA.HASHICORP_KEY_MANAGEMENT_CACHE` table lists
the key id and key version from the latest version cache. The table's
content can be viewed using `SHOW HASHICORP_KEY_MANAGEMENT_CACHE` or
queried directly.

Executing the `FLUSH` command requires `RELOAD` privilege and access to
INFORMATION_SCHEMA table requires `PROCESS` privilege.

Bugfix (squashed):
MDEV-38111: SIGSEGV when multiple servers use the same Vault KV storage for encrypted tables

Problem:
A data race between InnoDB background threads reading the cached keys
and the thread executing FLUSH command clearing it without acquiring
a lock. This non-synchronized memory write caused InnoDB threads that
were concurrently reading the cache to access freed memory, leading to
a crash.

Fix:
Acquire the lock before clearing the latest version cahce. This
ensures the cache clearing operation is serialized, preventing
concurrent access and resolving the data race.

d679430532aa...

d679430532aacac1bca4c7a35710934b309fc0ab

Rex Johnston

rex.johnston@mariadb.com

MDEV-37784 Introduce @@new_mode variable

@@new_mode is a set of flags to control introduced features.
Flags are by default off. Setting a flag in @@new_mode will introduce
a new different server behaviour and/or set of features.

We also introduce a new option 'hidden_values' into some system variable
types to hide options that we do not wish to show as options.

- Don't print hidden values in mysqld --help output.
- Make get_options() use the same logic as check_new_mode_value() does.
- Setting @@new_mode=ALL shouldn't give warnings.

(cherry picked from commit f7387cb13d0ecb252f39b572c27c79dfc3fd3678)
(Then cherry picked into 10.6)

cdb134949d0c...

cdb134949d0cc3fc6ad162d1a11f25631db2a0b2

Sergei Petrunia

sergey@mariadb.com

MENT-2045: Optimizer not choosing optimal index due to unknown ICP selectivity

(Fix against 10.6, not switchable, won't go into main tree in this form)

Make the optimizer take into account selectivity of Pushed Index Condition.

- Add KEY::selective_key_parts has bits for keyparts for which selective
conditions are available. (TODO: currently this is only done for
histogram-based selectivity data. Why not range access selectivity also?)

- Make cost_for_index_read() account for ICP selectivity when it computes
cost of ref access.

- Note that we don't adjust "rows_out". Computation of join access
selectivity does it for us.

TODO:
- Do we do similar for eq_ref or range access and if not why?
- Can one pick the cheapest range access while taking ICP selectivity
(which one gets from range access) into account? This seems to
require a two-step process...

c81fb7acd976...

c81fb7acd976aaed77e408f6150121a1e659656a

Monty

monty@mariadb.org

fixup! 3fad4502f1fd211cba674753efe04909975530c6

c3991f950c12...

c3991f950c12fc218808b07cfef63775b6ac953b

Sergei Golubchik

serg@mariadb.org

cleanup: CREATE_TYPELIB_FOR() helper

(cherry picked from commit d046aca0c76da36c8ba14359034a716af667aa51)
(Then, cherry picked into 10.6)

baae8f5a6f21...

baae8f5a6f21223f8177a9b5fcb8bbcf9030a92b

Sergei Petrunia

sergey@mariadb.com

b9fb0f78017d...

b9fb0f78017dc3cb5bfb7a8ae4f494d7ef7e9962

Monty

monty@mariadb.org

fixup! 3fad4502f1fd211cba674753efe04909975530c6

a49aadd50c26...

a49aadd50c269371776572a4b9f7c7329fe47ec0

ParadoxV5

paradox.ver5@gmail.com

Merge branch 'main' into MDEV-37530

8782227eb129...

8782227eb1295217d9951cd71873efd400a1d4fb

Andrei Elkin

andrei.elkin@pp.inet.fi

Revert "MDEV-37686 rpl.create_or_replace_mix2 fails in MDEV-35915 branch"

This reverts commit 3241798214b066d62ba3274ba5dc29549349ca65.
Due to MDEV-38212.

864c4dadd35e...

864c4dadd35e6dbb99463352458600511297b70c

Kristian Nielsen

knielsen@knielsen-hq.org

Binlog-in-engine: Fix race between FLUSH BINARY LOGS and GTID allocation

There was a race where a new GTID could be allocated (but not written to the
binlog)during the FLUSH, so that the GTID state written at the start of the
new binlog file was incorrect. This in turn could lead to duplicate GTID
being sent to the slave if it happens to reconnect at that exact point.

Signed-off-by: Kristian Nielsen <[email protected]>

84fa008d2591...

84fa008d25911ffddb117d6e394100993daadc54

Andrei Elkin

andrei.elkin@pp.inet.fi

MDEV-38254 replicated temporary tables must not be accessed by start_new_trans

The mdev is fixed by 7f3145e06 commit.

8456d438d770...

8456d438d77081f0d50a775a7f26128ab1fdeb2f

Monty

monty@mariadb.org

fixup! 65d2ef2cee9eaf0b93f9ce7c5961c2773ae6167b

82bb20d3439f...

82bb20d3439f2dbcf5de14aa5d1df71c9a4a5374

Monty

monty@mariadb.org

Added --debug-dbug option to mysqltest.cc

This was to get rid of warnings when using mtr --debug

7f3145e068b6...

7f3145e068b644cb5ec44fbc434da791b6a2d8bd

Andrei Elkin

andrei.elkin@pp.inet.fi

MDEV-38212 MDEV-37686 Breaks Parallel Replication

Instead of `NULL`ifying of this member a finer approach is taken to
screen the replicated temporary tables from the slave applier
when it runs within `start_new_trans` context.

For that *all* access critical `THD::{has,lock,unlock}_temporary_tables`
functions are made to check possible `start_new_trans` condition.
This measure forces `start_new_trans` executing slave thread to always take
the normal thread access path to a temporary table repository.

This commit also unifies with sql/temporary_tables.cc checking of the
current thread is slave with usage of THD::rgi_slave instead of
THD::slave_thread (last time chosen by MDEV-33426).

Tested with rpl.create_or_replace_mix2 of GTT feature branch.

7e7df10a1466...

7e7df10a14660892b2ca9b2e833c0589e67af6a7

ParadoxV5

paradox.ver5@gmail.com

MDEV-37530: Avoid C++17’s `<charconv>` entirely

* Some of our platforms (namely SUSE 15, which uses GCC 7.5) support
C++17 syntaxes, but not all libraries, `<charconv>` among those.
* We are yet to figure out what to do with our 10 choices of
string→int converters, so now is not the time to settle preferences
on `<charconv>` or whatever superset that covers all of their cases.

Co-authored-by: Sergei Golubchik <[email protected]>

7ae5802d0d17...

7ae5802d0d175af784a6eef602dd01ef24603b69

Kristian Nielsen

knielsen@knielsen-hq.org

78cdaa0e148c...

78cdaa0e148c0a7707a72cfaa16ea8414c154cf7

Kristian Nielsen

knielsen@knielsen-hq.org

Binlog-in-engine: Remove useless info messages in error log

Signed-off-by: Kristian Nielsen <[email protected]>

69ee922c1c5f...

69ee922c1c5f5a8f97d0cc6b392b1e6297c14cb2

Otto Kekäläinen

otto@kekalainen.net

Improve output from mariadb-secure-installation to be more honest

The script is likely misleading to users stating 'SUCCESS' about things
it didn't do anything about, leading to false sense of security. Improve
the output to be more clear about what it is doing or is not doing.

65d2ef2cee9e...

65d2ef2cee9eaf0b93f9ce7c5961c2773ae6167b

Monty

monty@mariadb.org

MDEV-38435 Add Gtid_binlog_pos to SHOW MASTER STATUS

Other things:
- Extended mysqltest to write GTID's for master and slave if
sync_slave_with_master fails.

64057ae7120f...

64057ae7120fce6ae712e4428132cfef2643a72c

Monty

monty@mariadb.org

ha_table_exists() cleanup and improvement

This is part of MDEV-25292 Atomic CREATE OR REPLACE TABLE.

Removed default values for arguments, added flags argument to specify
filename flags (FN_TO_IS_TMP, FN_FROM_IS_TMP) and forward the flag to
build_table_name().

Original patch from: Aleksey Midenkov <[email protected]>

5ed366889039...

5ed3668890390060526434b92271756392d77869

Otto Kekäläinen

otto@kekalainen.net

Deb: Format files with `debputy reformat --style black`

This formats and sorts the files the same way they are in the official
Debian packaging, making it easier to compare the files in Debian vs
upstream using commands such as `git difftool --dir-diff main --
debian`. Comparing the contents at least once a year is important in
ensuring all packaging improvements get their way into both Debian
official and upstream Debian packaging.

See https://salsa.debian.org/mariadb-team/mariadb-server/-/tree/debian/latest/debian

The formatting done by `debputy reformat --style black` is basically the
same as running `wrap-and-sort -vast`.

There are no functional changes, this is a pure formatting change.

This is intentionally done on the `main` branch in MariaDB. The stable
release branches are unlikely to ever get any changes in the
`debian/control` file, and thus formatting or maintaining it is
irrelevant. The merges from stable releases to latest `main` should not
bring any `debian/control` file changes, as adding or removing
dependencies, changing Debian compat levels or other changes are
invasive and shouldn't be done in stable releases at all.

5879c85f505d...

5879c85f505d3a11d4b8f479f2437416d8a1d724

Otto Kekäläinen

otto@kekalainen.net

Fix misc spelling in MariaDB Server repository

This is a combined patch of various spelling fixes originally done in
Debian.

* Fix misc typos in MariaDB Server

* Fix spelling of 'allows one to'

Fix the following Lintian nags introduced in commit
c8d040938a7ebe10e62506a726702c5990ef4dda:

I: mariadb-backup: spelling-error-in-binary "allows to" "allows one to" [usr/bin/mariadb-backup]
I: mariadb-server-core: spelling-error-in-binary "allows to" "allows one to" [usr/sbin/mariadbd]
I: mariadb-test: spelling-error-in-binary "allows to" "allows one to" [usr/bin/mariadb-client-test-embedded]
I: mariadb-test: spelling-error-in-binary "allows to" "allows one to" [usr/bin/mariadb-test-embedded]
I: mariadb-test: spelling-error-in-binary "allows to" "allows one to" [usr/bin/test-connect-t]

55a258f4a0de...

55a258f4a0de297a4d5d3282e1fd7d60b800a19e

Nikita Malyavin

nikitamalyavin@gmail.com

federated: deny tempoorary table creation

4f7302b84405...

4f7302b84405669014680e292bf068901b983f4d

ParadoxV5

paradox.ver5@gmail.com

MDEV-38410: Use array, not `std::initializer_list`

Some environments appear not to retain the backing array of a
static `std::initializer_list` in the MDEV-37530 release candidate,
and eventually crash when reading overwritten data.

This commit resolves the stealth issue by reverting to conventional
arrays, while maintaining convenience through deductive overloads.

4a0115749245...

4a01157492452f850c0c2804f0fab16bedd75d05

Monty

monty@mariadb.org

Fixed mtr test that fails with valgrind build and max_session_mem_used

perfschema.misc_session_status and main.max_session_mem_used fixed by
including not_valgrind_build.inc

44ae7222a955...

44ae7222a955f43596e95b5e3786e1b6acb1d204

Monty

monty@mariadb.org

Disable innodb_gis.rtree_split until MDEV-38373 is fixed

426c6e5d2802...

426c6e5d28029df3c0774972850f4f64c7a4a973

bsrikanth-mariadb

srikanth.bondalapati@mariadb.com

MDEV-37510: crash when tracing with max_sel_arg_weight equal to 1

When the optimizer_max_sel_arg_weight is set to 1, a nested query
crashed while tracing.

SEL_ARG object has a field named 'field', that is not set when the
type is other than KEY_RANGE. But, the field was accessed to store
its name, and weight to the trace. This resulted in a crash due to NULL
pointer.

Added a check to access field if the type is KEY_RANGE, and if not, just
trace the type.

3fad4502f1fd...

3fad4502f1fd211cba674753efe04909975530c6

Monty

monty@mariadb.org

MDEV-25292 Atomic CREATE OR REPLACE TABLE

Atomic CREATE OR REPLACE allows to keep an old table intact if the
command fails or during the crash. That is done by renaming the
original table to temporary name, as a backup and restoring it if the
CREATE fails. When the command is complete and logged the backup
table is deleted.

Atomic replace algorithm

Two DDL chains are used for CREATE OR REPLACE:
ddl_log_state_create (C) and ddl_log_state_rm (D).

1. (C) Log rename of ORIG to TMP table (Rename TMP to original).
2. Rename orignal to TMP.
3. (C) Log CREATE_TABLE_ACTION of ORIG (drops ORIG);
4. Do everything with ORIG (like insert data)
5. (D) Log drop of TMP
6. Write query to binlog (this marks (C) to be closed in
case of failure)
7. Execute drop of TMP through (D)
8. Close (C) and (D)

If there is a failure before 6) we revert the changes in (C)
Chain (D) is only executed if 6) succeded (C is closed on
crash recovery).

Foreign key errors will be found at the 1) stage.

Additional notes

- CREATE TABLE without REPLACE and temporary tables is not affected
by this commit.
set @@drop_before_create_or_replace=1 can be used to
get old behaviour where existing tables are dropped
in CREATE OR REPLACE.

- CREATE TABLE is reverted if binlogging the query fails.

- Engines having HTON_EXPENSIVE_RENAME flag set are not affected by
this commit. Conflicting tables marked with this flag will be
deleted with CREATE OR REPLACE.

- Replication execution is not affected by this commit.
- Replication will first drop the conflicting table and then
creating the new one.

- CREATE TABLE .. SELECT XID usage is fixed and now there is no need
to log DROP TABLE via DDL_CREATE_TABLE_PHASE_LOG (see comments in
do_postlock()). XID is now correctly updated so it disables
DDL_LOG_DROP_TABLE_ACTION. Note that binary log is flushed at the
final stage when the table is ready. So if we have XID in the
binary log we don't need to drop the table.

- Three variations of CREATE OR REPLACE handled:

1. CREATE OR REPLACE TABLE t1 (..);
2. CREATE OR REPLACE TABLE t1 LIKE t2;
3. CREATE OR REPLACE TABLE t1 SELECT ..;

- Test case uses 6 combinations for engines (aria, aria_notrans,
myisam, ib, lock_tables, expensive_rename) and 2 combinations for
binlog types (row, stmt). Combinations help to check differences
between the results. Error failures are tested for the above three
variations.

- expensive_rename tests CREATE OR REPLACE without atomic
replace. The effect should be the same as with the old behaviour
before this commit.

- Triggers mechanism is unaffected by this change. This is tested in
create_replace.test.

- LOCK TABLES is affected. Lock restoration must be done after new
table is created or TMP is renamed back to ORIG

- Moved ddl_log_complete() from send_eof() to finalize_ddl(). This
checkpoint was not executed before for normal CREATE TABLE but is
executed now.

- CREATE TABLE will now rollback also if writing to the binary
logging failed. See rpl_gtid_strict.test

backup ddl log changes

- In case of a successfull CREATE OR REPLACE we only log
the CREATE event, not the DROP TABLE event of the old table.

ddl_log.cc changes

ddl_log_execute_action() now properly return error conditions.
ddl_log_disable_entry() added to allow one to disable one entry.
The entry on disk is still reserved until ddl_log_complete() is
executed.

On XID usage

Like with all other atomic DDL operations XID is used to avoid
inconsistency between master and slave in the case of a crash after
binary log is written and before ddl_log_state_create is closed. On
recovery XIDs are taken from binary log and corresponding DDL log
events get disabled. That is done by
ddl_log_close_binlogged_events().

On linking two chains together

Chains are executed in the ascending order of entry_pos of execute
entries. But entry_pos assignment order is undefined: it may assign
bigger number for the first chain and then smaller number for the
second chain. So the execution order in that case will be reverse:
second chain will be executed first.

To avoid that we link one chain to another. While the base chain
(ddl_log_state_create) is active the secondary chain
(ddl_log_state_rm) is not executed. That is: only one chain can be
executed in two linked chains.

The interface ddl_log_link_chains() was defined in "MDEV-22166
ddl_log_write_execute_entry() extension".

Atomic info parameters in HA_CREATE_INFO

Many functions in CREATE TABLE pass the same parameters. These
parameters are part of table creation info and should be in
HA_CREATE_INFO (or whatever). Passing parameters via single
structure is much easier for adding new data and
refactoring.

InnoDB changes
Added ha_innobase::can_be_renamed_to_backup() to check if
a table with foreign keys can be renamed.

Aria changes:
- Fixed issue in Aria engine with CREATE + locked tables
that data was not properly commited in some cases in
case of crashes.

Other changes:
- Removed some auto variables in log.cc for better code readability.
- Fixed old bug that CREATE ... SELECT would not be able to auto repair
a table that is part of the SELECT.
- Marked MyISAM that it does not support ROLLBACK (not required but
done for better consistency with other engines).

Known issues:
- InnoDB tables with foreign key definitions are not fully supported
with atomic create and replace:
- ha_innobase::can_be_renamed_to_backup() can detect some cases
where InnoDB does not support renaming table with foreign key
constraints. In this case MariaDB will drop the old table before
creating the new one.
The detected cases are:
- The new and old table is using the same foreign key constraint
name.
- The old table has self referencing constraints.
- If the old and new table uses the same name for a constraint the
create of the new table will fail. The orignal table will be
restored in this case.
- The above issues will be fixed in a future commit.
- CREATE OR REPLACE TEMPORARY table is not full atomic. Any conflicting
table will always be dropped before creating a new one. (Old behaviour).

Bug fixes related to this MDEV:

MDEV-36435 Assertion failure in finalize_locked_tables()
MDEV-36439 Assertion `thd_arg->lex->sql_command != SQLCOM_CREATE_SEQUENCE...
MDEV-36498 Failed CoR in non-atomic mode no longer generates DROP in RBR...
MDEV-36508 Temporary files #sql-create-....frm occasionally stay after
crash recovery

Reverted commits:
MDEV-36685 "CREATE-SELECT may lose in binlog side-effects of
stored-routine" as it did not take into account that it safe to clear
binlogs if the created table is non transactional and there are no
other non transactional tables used.
- This was done because it caused extra logging when it is not needed
(not using any non transactional tables) and it also did not solve
side effects when using statement based loggging.

3b7abf34bab1...

3b7abf34bab1196be805b44ddd3c13e434438185

Sergei Petrunia

sergey@mariadb.com

MDEV-37784 Introduce @@new_mode: support all values being hidden

Fix my_print_help() to print "No currently supported values".
It used to print the first value even if it was hidden.

(cherry picked from commit 8664461e80bf39011d6c3e28b7fa4e8af95268cc)

3a08a8e3d221...

3a08a8e3d2212f3f60937b3fd97207c3ea7b933a

Georgi Kodinov

joro@mariadb.org

Display the exact amount of data updated by mariadb-secure-installation

33892e7ca777...

33892e7ca7770c02f3782623185f795bfab8029f

ParadoxV5

paradox.ver5@gmail.com

MDEV-37530: Avoid C++17’s `<charconv>` entirely

* Some of our platforms (namely SUSE 15, which uses GCC 7.5)
support C++17 syntaxes, but not all libraries, <charconv> among those.
* We are yet to figure out what to do with our 10 choices of string→int
converters, so now is not the time to settle preferences on <charconv>
or whatever superset that covers all of their cases.

Co-authored-by: Sergei Golubchik <[email protected]>

265f0cf89332...

265f0cf89332df60b62086c77dbe567d529ed8a3

Sergei Petrunia

sergey@mariadb.com

224efb91b4fc...

224efb91b4fc6c0df59abe6516a4931e08096d16

Sergei Petrunia

sergey@mariadb.com

MDEV-38426: Clustered PK not used for Loose Index Scan optimization

Loose Index Scan optimization can only be used when the index it is
uses covers all columns used by the query. So, it would not be
attempted for indexes that are not present in table->covering_keys.

Before commit ed0a72356691 (pushed to 11.0), Clustered PK would be
present in table->covering_keys if primary key columns are covering.

However, that commit gave Clustered PKs special treatment: they are
no longer present in table->covering_keys. This caused Loose Scan not
to be considered for Clustered PKs.

Fixed this by making the check in get_best_group_min_max() to allow
Loose Scan if all fields used by the query are parts of the Clustered PK.

Also made changes:
- The logic in JOIN_TAB::save_explain_data() assumed that Loose Scan
could only be used for index-only scans. This is not the case for
clustered PKs.
- One query in group_min_max_innodb started to use Loose Scan. It did so
in 10.11, too.

1b3ddf069a4c...

1b3ddf069a4cb1b7d374a441bc9c44e004764111

ParadoxV5

paradox.ver5@gmail.com

068a095750e6...

068a095750e66fe2fdbfaba7d99fa8f7af591a3b

haibo

haibo942us@gmail.com

MDEV-36737: Research and Estimation for Adapting VIDEX to MariaDB

VIDEX is a Disaggregated and Extensible Virtual Index Engine designed
to perform efficient and accurate what-if analysis for tasks such as
index recommendation.

Fix template linking error for gcc

debian: Add packaging for the VIDEX plugin

This commit adds the necessary files to build `mariadb-plugin-videx` as a separate Debian package.

- Add `COMPONENT videx-engine` to CMakeLists.txt to register the plugin.
- Define the `mariadb-plugin-videx` package in debian/control.
- Create `debian/mariadb-plugin-videx.install` to include the plugin .so and .cnf files.

debian: fix indent in debian/control

fix bugs from empty table

videx: fix RPM autobake by adding CPACK summary/description

058e3879cb7d...

058e3879cb7d3cb9984ae5ec62fa976d956a6273

Kristian Nielsen

knielsen@knielsen-hq.org

Binlog-in-engine: Remove useless info messages in error log

Signed-off-by: Kristian Nielsen <[email protected]>