Console View

Categories: connectors experimental galera main

Legend:

Passed

Failed

Warnings

Failed Again

Running

Exception

Offline

No data

connectors

experimental

galera

main

ff38773f457e...

ff38773f457e48120055910cb701fb838a9ae138

bsrikanth-mariadb

srikanth.bondalapati@mariadb.com

MDEV-40518: add both drop table and view stmts

The context only stored "DROP TABLE IF EXISTS t1" before adding a
"CREATE TABLE t1" statement. However, there can be a view named t1
already existing in the database. When the context was replayed,
the CREATE statement failed stating t1 already exists.

Solution is to add both "DROP TABLE IF EXISTS t1", and
"DROP VIEW IF EXISTS t1" before adding a
"CREATE TABLE t1" statement into the context.

f4a85225ea17...

f4a85225ea17b2c77c20e761773090a08aa3eceb

Raghunandan Bhat

raghunandan.bhat96@gmail.com

MDEV-39169: Replace deprecated network functions in resolveip (testfix 2)

Problem:
The test piped resolveip through sed patterns that rewrote its failure
message into the expected success line, and the pipe also discarded
the exit status - the test could not fail. Removing the masking
exposes the real issue: reverse lookup results are OS dependent. The
name of ::1 differs per system, and ::ffff:127.0.0.1 has a name on
glibc and musl (which map it to 127.0.0.1) but none on macOS.

The suite.pm check bound a socket to the address, which asks the
kernel, not the resolver: it fails under net.ipv6.bindv6only=1 where
the lookup works and succeeds on macOS where it doesn't.

Fix:
Split the test in two:
- main/resolveip.test: deterministic cases, never skips. Lookup
failures are pinned with addresses that resolve nowhere (192.0.2.1,
nonexistent.invalid), checking the exit status and that IPv4-mapped
literals take the reverse-lookup path on every OS.

- main/resolveip_lookup.test: the reverse lookups. A perl probe
resolves the three loopback addresses with the same call resolveip
makes, getnameinfo(NI_NAMEREQD), skips unless all have names, and
returns the names so the test requires them exactly.

Output is normalized with replace_result/replace_regex instead of
pipes, keeping the exit status checked.

Co-Authored-By: Claude Fable 5 (1M context) <[email protected]>

f2d31c787b9d...

f2d31c787b9d1c324a2babe8bb82cf69b53562f2

ParadoxV5

paradox.ver5@gmail.com

MDEV-39485 Heap-buffer-overflow upon read in `Rows_log_event` constructor

MariaDB recognizes Version 2 Rows Events from MySQL, including the
format of the “extra data” field added in this version. (MDEV-5115)

When parsing this extra data according to the format, whether this data
has sufficient length was only checked by assertions in the
`Rows_log_event` constructor and the `mariadb-binlog --verbose` printer.
When parsing an event with malformed extra data, these assertions
* would straight up terminate the program in debug builds.
* were stripped in non-debug (release) builds.
This would render the parser defenseless to reading from erroneous
memory locations outside of the containing event, which will either
crash the program or, for `mariadb-binlog --verbose`, snapshot the
running memory to be exposed when outputting the event.

This commit replaces those assertions with an actual validity check.

Since MariaDB does not generate v2 Rows Events,
the included test uses a handcrafted binlog file.

Reviewed-by: Kristian Nielsen <[email protected]>

eac9c380e347...

eac9c380e347620b70ab281b5261a03c2f236c17

bsrikanth-mariadb

srikanth.bondalapati@mariadb.com

Replace List<> with Mem_root_dynamic_array for double and uint types

e491a1e88049...

e491a1e8804940c23dccb1b513cdd439886a2423

ParadoxV5

paradox.ver5@gmail.com

MDEV-40365 OOB read on malformed `Format_description_log_event`

The binary-parsing Format Description Event constructor did not
validate content length beyond the superclass `is_valid()` call.
When parsing a malformed FDE, to load the content fields added in
FDE v4 that are missing in this not-FDE, the parser constructor
would read from erroneous memory locations beyond the buffer.
If this did not outright crash the program, this would corrupt the FDE.
With the Format Description playing a critical role in determining how
to parse the events to follow, a corrupted FDE would also corrupt (or
trigger a crash in) the parsing of subsequent non-FDE events as well.

This commit fills in the validation with a FDE-specific guard.
It adds the FDE constant `ST_POST_HEADER_LEN_OFFSET` to assist
with comparing to the correct minimum size in the future.
(Both of these points are designed to merge with the
superclass’s guard as part of the MDEV-30128 merger).

Reviewed-by: Kristian Nielsen <[email protected]>

e383fb0f4ed8...

e383fb0f4ed8eb7ca9b9bfee42798e06adb6ea20

ParadoxV5

paradox.ver5@gmail.com

MDEV-40674 Include the checksum for non-corrupted Unknown events

This commit reörders code so the checksum is populated after
`mariadb-binlog --force` generates `Unknown_log_event` substitutes.
Previously, `mariadb-binlog --force` inconsistently omitted those
checksums from the output even if the checksum is presumably usable.

After merging to 11.4 (MDEV-31273), this commit will also fix «
MDEV-40542 MSAN use-of-uninitialized-value on Unknown_log_event::read_checksum_alg
», which was exposed by MDEV-31273’s removal
of the base `Log_event::checksum_alg` field.

Reviewed-by: Kristian Nielsen <[email protected]>

dcfb0a451384...

dcfb0a451384c6e32ff1386e2e915b64afb1ac6f

ParadoxV5

paradox.ver5@gmail.com

MDEV-40544 Assertion fail / Memory leak in `mariadb-binlog --force-read`

A checksum error in
`mariadb-binlog --verify-binlog-checksum --force-read` previously
resulted in both an error message and an Unknown event substitute,
the latter of which failed an assertion in debug builds or
became forgotten (memory leak) in non-debug (release) builds.

Since `mariadb-binlog --force-read` outputs “Unknown event”s
rather than errors in other invalid event cases,
this commit removes the error status from this situation to match.

Reviewed-by: Kristian Nielsen <[email protected]>

d9e7dedddd5f...

d9e7dedddd5fe1d317efbddf882802bc94a02b6b

Rex Johnston

rex.johnston@mariadb.com

MDEV-38801 Item_sum & Item_cache implement deep_copy()

{Item_cache,Item_cache_row,Item_sum}::deep_copy() currently call
shallow_copy_with_checks(). This causes issues when a proper
independent copy is required, e.g. in add_key_part called on a key
with a value containing an item inherited from Item_cache.
We implement a proper deep copy that shares no nodes with the source,
and add a check to the default Item::deep_copy_with_checks to ensure
this.

d4106f5fdc44...

d4106f5fdc44d612b0fc64ccfd24a8b73c2a6812

ParadoxV5

paradox.ver5@gmail.com

ce155f1068ab...

ce155f1068ab8b519b6f790675f51095949d379d

Rex

rex.johnston@mariadb.com

MDEV-40465 table map consulted during setup fields on unfixed items

In setup_fields() we call item->update_used_tables() before split_sum_func
so that used_tables() is not consulted before the caches are set up on the
2nd execution of a prepared statement (fixes a 1st/2nd execution result
mismatch in main.subselect_nulls under --ps-protocol).

That recalculation exposes items whose caches are read while still being
(re)built, so add the guards it now depends on:
- Item_field::used_tables(): return 0 when field / field->table is not
yet set, instead of dereferencing a null pointer.
- Item_direct_view_ref::used_tables(): return 0 when the item is not
fixed yet, instead of asserting.
- Item_func::fix_fields(): reset used_tables_cache/const_item_cache at
entry (assignment) instead of asserting they are already clear, so a
re-fix is idempotent.

Remove select,ps.rdiff / select_jcl6,ps.rdiff / select_pkeycache,ps.rdiff:
the extra "resolved in SELECT #1" notes they recorded no longer appear
under --ps-protocol, so the select tests now match without an rdiff.

cd51639e4a52...

cd51639e4a52464e82550486cecd6b15d6307d9a

ParadoxV5

paradox.ver5@gmail.com

c847e5cd53c4...

c847e5cd53c419ca8225dcd8a867f77492eb5d3a

bsrikanth-mariadb

srikanth.bondalapati@mariadb.com

MDEV-40389: type_test.type_test_int8 fails on replay

plugins are not yet supported in replay mode.

So, disabling tests type_test.type_test_int8, and type_test.type_test_double
to be run in replay-server mode

c7a921565daa...

c7a921565daaec75dafa26c49d5b2a9768184ede

Sergei Golubchik

serg@mariadb.org

MDEV-40608 MariaDB-devel is incomplete for plugins

* create and install mariadb-plugin-config.cmake
* adjust plugin.cmake to work for external plugins
* move server-internal part to top-level CMakeLists.txt
* remove WITH_WSREP from my_config.h (it upsets external plugins)
* remove double-defined macros from unireg.h (the guard doesn't help
if unireg.h is included first)

ColumnStore, until fixed, needs a backward-compatibility workaround

c61b1a2ef7c3...

c61b1a2ef7c3c879e68be80b82f3456807c63241

ParadoxV5

paradox.ver5@gmail.com

MDEV-40366 OOB read on malformed `Format_description_log_event`

Neither the binary-parsing Format Description Event constructor
nor the constructor-bypassing `get_checksum_alg()` function
validated the content length of the passed event buffer.
If they receive an FDE with undersized contents,
they would obtain corrupt results from an erronous memory location,
if not outright crash the program with that memory error.

This commit fixes both sites by adding content length checks.
Because the goal is not to solve the existence of two binary parsers,
`get_checksum_alg()` receives a check duplicated from the Format
Description constructor and is no longer a function that never errors.
Note, it is implementation detail that `get_checksum_alg()`’s
fix catches the invalidity before any code reaches the
parser-contructor’s fix, though the latter would come
to effect if we refactor `get_checksum_alg()` away.

Reviewed-by: Kristian Nielsen <[email protected]>

c61100b8aed4...

c61100b8aed49c1cf5ebf21e88aa40d350231970

Sergei Petrunia

sergey@mariadb.com

Remove un-needed files

Added by
MDEV-39368: Trace replay: add --extra-server support, part 1.

should have been removed by

Revert the --replay-server mtr feature

abae5740203a...

abae5740203ac18f9c7b562bdcf6b0745e615e9f

Rex

rex.johnston@mariadb.com

a67e52682da9...

a67e52682da9dd6ca1380c001e740c242a810123

bsrikanth-mariadb

srikanth.bondalapati@mariadb.com

Do not dump stats and const rows for read only engines' tables.

Stats for tables from engines such as Archive, S3, PerfSchema, and
Sequence shouldn't be recorded in the context. Similarly, const row
records should also not be stored in the context.

Added few tests for Sequence's engine tables like seq_1_to_5.

a511780956cb...

a511780956cb4cbd1f779fa97a42da7894e756f3

Sergei Petrunia

sergey@mariadb.com

Code cleanup in JSON array-of-object reading, add unit tests.

9a0b554e1053...

9a0b554e1053b240ad2e58b72bf56e4b8948762a

bsrikanth-mariadb

srikanth.bondalapati@mariadb.com

MDEV-39360: set statement optimizer_record_context for query fails

Move the initialization of context recorder, and replay after
run_set_statement_if_requested() is invoked in the
mysql_execute_command() in sql_parse.cc

8923103439a0...

8923103439a0a2d06fad672cbf491c01de4e8e5c

ParadoxV5

paradox.ver5@gmail.com

7e42feff77ac...

7e42feff77ac8fecb283df88f00a9a892ee5a409

ParadoxV5

paradox.ver5@gmail.com

7af18af00d80...

7af18af00d80bb768109805496c10bde64463692

Sergei Petrunia

sergey@mariadb.com

Code cleanup (3).

67e342686b9c...

67e342686b9cb181abe81c5474fe7ceb09ce548e

bsrikanth-mariadb

srikanth.bondalapati@mariadb.com

MDEV-40390: compat/oracle.sp-package fails on replay

UDFs are not yet supported in replay mode.

So, disabling test compat/oracle.sp-package

5f71d4c187f9...

5f71d4c187f990cf30be9b1c4b56ac0260264526

ParadoxV5

paradox.ver5@gmail.com

MDEV-40647 OOB read in IO Thread if the FDEv does not support Rotate Events

If the replication IO Thread receives a Rotate event following a Format
Description event (FDE) with no post-header length for Rotate events,
the Rotate event’s parser constructor indexes
the FDE’s post-header lengths array out of bounds.
This commit defends against this situation by checking before the
constructor that the FDE describes Rotate events as recognized at all.

In practice, because the Binlog Dump thread generates a Fake
`ROTATE_EVENT` **before** sending the FDE, it has pinned
Rotate events’ post-header length to 8 regardless of FDEs.
This fix solution considers that the FDE’s description should still be
respected, matching the constructor.

Reviewed-by: Kristian Nielsen <[email protected]>

52a2bc27ccca...

52a2bc27cccaf27632c8c7f92d52604b3bb38b0a

ParadoxV5

paradox.ver5@gmail.com

4ec9d77dfab9...

4ec9d77dfab90a0dc4f46b48946d5019b0553cb5

bsrikanth-mariadb

srikanth.bondalapati@mariadb.com

MDEV-40384: innodb_gis.geometry fails on replay

The test had innodb_strict_mode turned OFF, when running the test. But,
in the replay, it was enabled, which caused the creation of tables with
KEY_BLOCK_SIZE=16 fail.

Solution is to record the innodb_strict_mode variable in the context, so
that it gets used during the replay.

49aa9cfdb2f9...

49aa9cfdb2f9c003d122102c30549dcbc7d45c85

Rucha Deodhar

rucha.deodhar@mariadb.com

MDEV-40127: Server hangs when setting NEW=OLD on a multi-row table

Analysis:
m_fields was keeping old fields around across executions instead of
being cleared, causing stale state and hangs/crashes on re-execution.

Fix:
Clear m_fields in cleanup().

499640197548...

499640197548a58060a7df112555bec1c70aa93b

Rex Johnston

rex.johnston@mariadb.com

470f447ec5ec...

470f447ec5ecaf31134a0bf5097e3b881a2fcf8f

Sergei Petrunia

sergey@mariadb.com

Fix unittest name: jons_reader -> json_reader

468f54efe5b9...

468f54efe5b90af31a51db13d061740bd4190b1b

Kristian Nielsen

knielsen@knielsen-hq.org

MDEV-37606: Extend atomic DDL to make replication crash-safe for DDL

More work-in-progress. Save the GTID of the currently replicating
transaction on the slave in the ddl log. Extend with some more testing.

Two new problems turn up in the test:

- When slave crashes inside DROP DATABASE, it can end up only dropping some
of the tables and not the database itself.

- When the slave crashes in CREATE TABLE, after binlogging the CREATE, it
can during ddl crash recovery still decide to roll back. Then it binlogs
a DROP TABLE (with the same GTID as the CREATE), leaving a duplicate GTID
in the binlog and the table not created despite the slave position having
advanced.

Signed-off-by: Kristian Nielsen <[email protected]>

41be97ae8385...

41be97ae838517984e7b5b74fa8fd2a5aead9fec

Sergei Golubchik

serg@mariadb.org

deb

* move all headers that plugins need to libmariadb-dev,
together with libmysqlservices.a. At least until we'll
create mariadb-plugin-dev.Nobody should need huge
libmariadbd-dev to develop a plugin.
* add mariadb-plugin-config.cmake there too

3a7a02b28833...

3a7a02b288337ff51c57cfc4ea12b2922486724a

bsrikanth-mariadb

srikanth.bondalapati@mariadb.com

MDEV-40387: perfschema.misc fails on replay

Disable the testfile, as we don't capture context for performance schema
tables.

39d97c2e6554...

39d97c2e65540aed68b2ff78dac70c21fe8b7a6a

bsrikanth-mariadb

srikanth.bondalapati@mariadb.com

MDEV-40220: Add server version to optimizer context

Additionaly, include Version_source_revision as well.
These are read only informative sya variables. So, they are included as
comments instead of SET commands.

387e9af84621...

387e9af8462114215ee8499636e873522c3704c1

ParadoxV5

paradox.ver5@gmail.com

2bb52007d37a...

2bb52007d37ae91118877024ffc55773489d908b

Sergei Petrunia

sergey@mariadb.com

Remove incorrectly added sql/opt_sum.cc.orig

2acac96d3429...

2acac96d34292633473b2c6f08e3d694bd568ca6

Sergei Petrunia

sergey@mariadb.com

More code cleanups.

27729717f596...

27729717f59603d5b905d2fa96e94265615d8819

Sergei Golubchik

serg@mariadb.org

MDEV-40608 MariaDB-devel is incomplete for plugins

* create and install mariadb-plugin-config.cmake
* deb: move all headers that plugins need to libmariadb-dev,
together with libmysqlservices.a. At least until we'll
create mariadb-plugin-dev.Nobody should need huge
libmariadbd-dev to develop a plugin
* rpm: all in MariaDB-devel already, no changes here
* adjust plugin.cmake to work for external plugins
* move server-internal part to top-level CMakeLists.txt
* remove WITH_WSREP from my_config.h (it upsets external plugins)
* remove double-defined macros from unireg.h (the guard doesn't help
if unireg.h is included first)

ColumnStore, until fixed, needs a backward-compatibility workaround

1baf22d80b10...

1baf22d80b1063144e53c5735a3a10747a130565

bsrikanth-mariadb

srikanth.bondalapati@mariadb.com

MDEV-40388: sequence.simple fails on replay

The problem is that, when recording is enabled for the query such as,
explain select * from seq_1_to_10;
it recorded the table context having a DDL definition as: -

CREATE TABLE `seq_1_to_10` (
-> `seq` bigint(20) unsigned NOT NULL,
-> PRIMARY KEY (`seq`)
-> ) ENGINE=SEQUENCE DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_uca1400_ai_ci;

Now, when that context is replayed, the DDL statement is executed.
But, we cannot create such a table, and instead it errors out saying
ERROR 1050 (42S01): Table 'seq_1_to_10' already exists.

Solution is to use: -
CREATE TABLE IF NOT EXISTS seq_1_to_10 ...;

=====

Also, there is a different way to use sequences as: -
Create sequence s1;
Explain select * from s1;

Here, we should be recording the DDL statement, but no need to store the
stats for it. However, we didn't record the DDL statement earlier.
Moreover, sequence's next value should be the same in the replay environment.

Solution here is to record the DDL for such a sequence as
CREATE TABLE IF NOT EXISTS s1 ...;
and also set its start value as the recorded environment's previous value using
SELECT SETVAL(s1, prev_value);

03356c46fb60...

03356c46fb605485e7b8a8286e02383a203e7b9c

bsrikanth-mariadb

srikanth.bondalapati@mariadb.com

MDEV-40383:innodb_gis.point_basic fails on replay

There are 2 problems: -
1. The REPLACE statement that is recorded doesn't store the
value of geometry type field correctly.
2. The table definition that got recorded has fields with non-null constraint,
and no default value is specified.
Also, the "REPLACE INTO" statement that gets stored in the context,
doesn't have any value specified for these non-null fields.

Solution is to: -
1. When using REPLACE INTO statement, store all the non-numeric values in HEX,
whenever conversion from field's charset to output's charset is lossy.
2. Instead of storing only the column values that were projected in the
query, store all the non-virtual column values into the recorded
REPLACE INTO statement.

Implementation details: -
1. Introduce a new method is_charset_conversion_lossless() in filesort.cc,
to check if the output charset to which field's data is being written to,
results in a lossless conversion. If so, non-numeric values being witten
using REPLACE INTO statement are stored in string representation,
else they are converted to HEX.
2. Modify join_read_const(), and join_read_system() methods in sql_select.cc,
and opt_sum_query() method in opt_sum.cc the following way: -
a. Extend the read_set to make sure, we read all the non-virtual column
using Optimizer_context_recorder::prepare_captured_row_read().
This method also saves the original read_set.
b. Read the row.
c. Dump the row into the context when no error is noticed while
reading. Irrespective of the error, restore back the read_set state to
the original using Optimizer_context_recorder::finish_captured_row_read()