Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
Sergei Golubchik
MDEV-38133 Package mariadb-common conflicts with mysql-common
gkodinov
MDEV-38546: Automatically label new unlabeled pull requests
with foundation/corporation/external contribution

The MariaDB server repository uses certain pull request labels as queue markers
for incoming pull requests as follows:
- External Contribution: for all external contributions
- MariaDB Corporation: for employees of the MariaDB corporation
- MariaDB Foundation: for the employees of the MariaDB foundation

Right now, when a new pull request is filed, these tags need to be applied
manually.
However a large % of these manual assignments can be automated by checking
if the author is in https://github.com/orgs/MariaDB/teams/staff
or in https://github.com/orgs/MariaDB/teams/developers.

If they are in staff "MariaDB Foundation" is assigned.

if they are not in staff, but are in developers, "MariaDB Corporation" is assigned.

If they are in neither staff nor developers, "External Contribution" is assigned.

A github workflow is created to do the assignments. It is being triggered
every day at 2AM. Or it can be triggered manually.

This is stage1 of the fix: it is read only and only *prints* the changes needed
Sergey Vojtovich
MDEV-37862 - innodb.gap_locks test failure: 0 lock structs, 0 row locks

Test was affected by incompletely closed preceding connections.

Make test agnostic to concurrent connections by querying
InnoDB status only for connections that it uses.

This is an addition to 3b2169f0d1e, which didn't handle a case when
preceding test has active transaction on disconnect.
Sergei Golubchik
MDEV-37920 Out-of-Bounds memory access in File_parser::parse()

correct the length check.
remove assertions that a file read from disk contains a specific substring
Sergei Golubchik
MDEV-37888 unexpected type changing after changing AVG to MAX

set collation for AVG, like it's done for MAX
Sergei Golubchik
MDEV-38096 Server crashes after INSERT.. ON duplicate KEY UPDATE i = DEFAULT

VALUE() should only use table->insert_values when
table->insert_values contains row values.

table->insert_values gets row values for the ODKU clause
so if VALUE() is used before that it shouldn't use table->insert_values
Sergei Golubchik
MDEV-36668 main.mysqld--help-aria test failure when no MAC address

don't use such a greedy regex_replace pattern
Sergei Golubchik
MDEV-37971 CHECK TABLE command can be executed by users with the table-level CREATE but not with global CREATE

CHECK TABLE was inconsistently requiring SELECT privilege on global/db level
or any privilege on the table/column level.

Change to require any table-applicable privilege on any level.
Sergei Golubchik
MDEV-37998 (Column) CHECK constraints can cause CREATE TABLE (SELECT) queries to fail

don't copy field default values and check constraints in
CREATE ... SELECT.

CREATE ... SELECT means a table is created from a *result set*
not from some other table.

For backward compatibility, though, let's keep copying constant
default values and the "compressed" attribute.
Sergei Golubchik
MDEV-38203 Hashicorp plugin lets keys timeout and doesn't use cached keys on vault errors

* let use_cache_on_timeout apply to other errors
* enable use_cache_on_timeout by default and deprecate it
* increase cache_timeout to max and deprecate it
* change it from long to portable longlong
* delete both in 13.3
Yuchen Pei
MDEV-9826 Hash to uint64 in my_hasher_st
Sergei Golubchik
cleanup: move constraint tests from check.test to check_constraint.test
gkodinov
[PATCH] MDEV-38546: Automatically label new unlabeled pull requests
with foundation/corporation/external contribution

The MariaDB server repository uses certain pull request labels as queue markers
for incoming pull requests as follows:
- External Contribution: for all external contributions
- MariaDB Corporation: for employees of the MariaDB corporation
- MariaDB Foundation: for the employees of the MariaDB foundation

Right now, when a new pull request is filed, these tags need to be applied
manually.
However a large % of these manual assignments can be automated by checking
if the author is in https://github.com/orgs/MariaDB/teams/staff
or in https://github.com/orgs/MariaDB/teams/developers.

If they are in staff "MariaDB Foundation" is assigned.

if they are not in staff, but are in developers, "MariaDB Corporation" is assigned.

If they are in neither staff nor developers, "External Contribution" is assigned.

A github workflow is created to do the assignments. It is being triggered
every day at 2AM. Or it can be triggered manually.

This is stage1 of the fix: it is read only and only *prints* the changes needed
Sergei Golubchik
MDEV-26618 OPTIMIZE table not replicating

restore OPTIMIZE/ANALYZE replication under @read_only
that was disabled in b62101f84be4
Sergei Golubchik
mysqldump --no-autocommit

* put autocommit/commit outside of LOCK/UNLOCK.
* use uppercase like all other commands
* restore the old value of autocommit
Mohammad Tafzeel Shams
MDEV-38140: InnoDB index corruption after UPDATE affecting virtual
columns

Issue:
- Purge thread attempts to purge a secondary index record that is not
  delete-marked.

Root Cause:
- When a secondary index includes a virtual column whose v_pos is
  greater than the number of fields in the clustered index record, the
  virtual column is incorrectly skipped while reading from the undo
  record.
- This leads the purge logic to incorrectly assume it is safe to purge
  the secondary index record.
- The code also confuses the nth virtual column with the nth stored
  column when writing ordering columns at the end of the undo record.

Fix:
- In trx_undo_update_rec_get_update(): Skip a virtual column only
  when v_pos == FIL_NULL, not when v_pos is greater than the number
  of fields.
- In trx_undo_page_report_modify(): Ensure ordering columns are
  written based on the correct stored-column positions, without
  confusing them with virtual-column positions.
Sergei Golubchik
MDEV-38001 NULL dereference in Trigger_creation_ctx::create()

don't trust the content of a file read from disk
Raghunandan Bhat
MDEV-37474: Privilege check of information_schema.TRIGGERS does not correspond the standard

A user should be able to see `ACTION_CONDITION` and `ACTION_STATEMENT`
from `INFORMATION_SCHEMA.TRIGGERS` table only if the user is the owner
of the schema. Since MariaDB doesn't have owner privileges, `TRIGGER`
privilege can be used.

The columns are visible only if the user has `TRIGGER` privilege, `NULL`
otherwise.
Sergei Golubchik
MDEV-38168 Lots of joins can crash the server

don't let the parser create ridiculously deep joins that
will be rejected later anyway
Sergei Golubchik
MDEV-38110 Sever shutdown prevented by RocksDB setting rocksdb_pause_background_work

enable background threads on shutdown, so that they could
respond to signals and free resources
Vlad Lesin
MDEV-31956 SSD based InnoDB buffer pool extension

Fix some tests. Make ext_buf_pool test more stable avoiding race
conditions for read/write counters.
Sergei Golubchik
fix main.mysqld_option_err test that didn't work for years

the "Test that bad value for plugin enum option is rejected correctly"
needed multiple fixes:

1. don't set plugin-dir based on $MYSQLTEST_VARDIR, all plugins are
  in var/plugins, but $MYSQLTEST_VARDIR is var/1/, var/2/, etc if
  --parallel is used (that is, practically always), thus the ha_example.so
  cannot be loaded, because cannot be found. Test fails with
  "unknown option --plugin-example-enum" as the plugin is not loaded

2. force --plugin-maturity=experimental, otherwise even if not parallel
  the plugin will fail to load because of low maturity, test still
  fails with "unknown option --plugin-example-enum"

3. don't specify .so extension explicitly otherwise the plugin still
  doesn't load on windows, even if paths and maturity are fixed

4. set --plugin-example=FORCE otherwise plugin fails to load after reading
  --plugin-example-enum-var=noexist because of unknown enum value,
  the server ignores the failure and starts normally. the test hangs.

5. This needs the fix in sql_plugin.cc to detect that the plugin is
  forced even when some options failed to parse. It used to consider
  plugin forced only if all options parsed correctly, which was wrong.

Now the test passes, testing what it was supposed to test - failure
to parse an enum value of a plugin option.

Without these fixes the test hanged as in 4 when run on the main branch
in non-prarallel (e.g. one test only) mode.
Sergei Golubchik
MDEV-37979 sys.ps_setup_save does not restore SQL_LOG_BIN after error, causes replication discrepancy
Raghunandan Bhat
MDEV-37474: Privilege check of information_schema.TRIGGERS does not correspond the standard

A user should be able to see `ACTION_CONDITION` and `ACTION_STATEMENT`
from `INFORMATION_SCHEMA.TRIGGERS` table only if the user is the owner
of the schema. Since MariaDB doesn't have owner privileges, `TRIGGER`
privilege can be used.

The columns are visible only if the user has `TRIGGER` privilege, `NULL`
otherwise.
Sergei Golubchik
MDEV-38237 Incorrect BuildRequires entry in RHEL10 srpm

apparently a file can be present in *more than one* rpm,
e.g. /usr/bin/dtrace on rhel10 is present *both* in
systemtap-sdt-dtrace and in systemtap-sdt-devel.

Make sure there's a separator between entries.
Sergei Golubchik
MDEV-38028 Userstat Plugin CPU_TIME much higher than BUSY_TIME in versions 10.11.X and beyond

my_getcputime() returns "cpu time in 1/10th on a microsecond (1e-7 s)"
Sergei Golubchik
MDEV-38006 Inconsistent behaviors when casting into time

number-to-time conversion was too eagerly capping the value.

A string "9000090" was invalid time, because of 90 seconds.
But number-to-time was capping first, validating later,
to 9000090->time worked. Let's fix it.

also, let's make invalid time values in a string field include
the field name in the warning message, just like invalid time
values in a numeric field do.
Sergei Golubchik
fix the test to not leave $datadir/test/imp_t1.ibd around

otherwise it causes random failures in some later test that lists
files in $datadir/test
Yuchen Pei
MDEV-38549 Use my_hash_sort_bin for numerical fields when using new hash algorithms
Sergei Golubchik
MDEV-38233 Inconsistent results for make_set of cast

if ((res=item->val_str(str)) != str)

is incorrect way to detect whether res can be safely used,
because Item_char_typecast::val_str() can return res
which is different from str, but shares the same buffer.
Sergei Golubchik
MDEV-38124 event scheduler spams the error log

event scheduler was printing a lot of info in [Note] in error log.

change to print its startup/shutdown notes only when log_warnings>0.
and runtime notes only when log_warnings>2.
one note was an abnormal error, change to [Error].
Sergei Golubchik
MDEV-38087 Unexpected error `Unknown column '???' in 'GROUP BY'`

with `ORDER BY number` if the number doesn't refer to a valid
result column, use this number in the error message not '???'.