Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
f1a1299d3d34...
f1a1299d3d3412797c52a5f81be79467ae0541d3
Nikita Malyavin
MDEV-37668 SIGSEGV on DROP TABLE GTT under LOCK TABLES and
different server_id

Fixed per MDEV-37673.

This commit only includes test.

Parent issue:
MDEV-35915 Implement Global temporary tables
ed2780ba6b35...
ed2780ba6b359d3924ae1adf58922cd4a9b4e5eb
Nikita Malyavin
MDEV-37596 enforce_storage_engine has an effect on child global temporary tables

Ignore the option when creating child global temporary tables.

Parent issue:
MDEV-35915 Implement Global temporary tables
ea70cd32ffe4...
ea70cd32ffe43bf61f547b10e444e8fd7a200be2
Nikita Malyavin
MDEV-37934 Assertion `thd->transaction->stmt.is_empty()...' in GRANT

...on GTT failed

Open a parent handle for GTT on GRANT.
ON COMMIT PRESERVE ROWS does not register handlerton, so it will work
fine.

Parent issue:
MDEV-35915 Implement Global temporary tables
dd66bbf01d4b...
dd66bbf01d4beae5a34d3f9af218b0c3dd9e6dc8
Nikita Malyavin
MDEV-38937 GTT: 1944 Error executing row event with trigger replication

Row events prelock tables for triggers even if those triggers are not
accessed. Write_row event is known to trigger a wider set of row
operations. In IDEMPOTENT mode it is

  trg2bit(TRG_EVENT_INSERT) | trg2bit(TRG_EVENT_DELETE);

So no surprise that AFTER DELETE trigger is prepared for insert event.

If the table in trigger doesn't exist though, the error wouldn't be
triggered.

Make the same for GTT:
ignore its open denials on slave if it's meant so.

Parent issue:
MDEV-35915 Implement Global temporary tables
d75d2d6cfc77...
d75d2d6cfc77fc3eadfc4c94c981d3c5f1598579
Nikita Malyavin
MDEV-37929 Assertion !thd->rgi_slave' failed on REPAIR TABLE on replica

1. REPAIR TABLES is logged even if open_table is failed. In this case,
we cannot determine whether it was opened for a global temporary table,
so we cannot make sure it is not replicated.

2. Also REPAIR/ANALYZE/CHECK can include more that one table, and has no
ability co control statement logging per-table, so anyway relying on
that it's not logged is incorrect.

Hence, enable writing to binlog for these three statements. Keep replica
to be able to handle these commands.
As such, force REPAIR/ANALYZE/CHECK to open a parent handle of global
temporary table.

Extract sql_command_flags flag CF_USE_PARENT_GTT_SHARE for global
temporary tables, as a critical mass of statements has been reached.

Also fixes:
MDEV-37929 Assertion !thd->rgi_slave' failed on REPAIR TABLE on replica

Parent issue:
MDEV-35915 Implement Global temporary tables
d277371f9766...
d277371f9766c63646d227435f896a2db9aee133
Alexey Botchkov
MDEV-39124 XMLTYPE: allow only well-formed XML.

Necessary checks added to the XMLTYPE.
d13fd2488fe4...
d13fd2488fe4cd8c822fecc2b6c2e4841aa69b1f
Nikita Malyavin
MDEV-37871 SIGSEGV in I_P_List_iterator on DROP DATABASE test

Happens on dropping the database on a newly created conneciton.

temporary_tables can be NULL in THD::global_tmp_drop_database.

Parent issue:
MDEV-35915 Implement Global temporary tables
c1d9fa82d2c2...
c1d9fa82d2c2c9ca3d38f0b37426f77cfbac0ca3
Nikita Malyavin
MDEV-37681 SIGSEGV on TRUNCATE GTT after failed RENAME under LOCK TABLE

WHILE RENAME was covered in the reference counting feature,
ALTER TABLE REMANE was missed, as it's turned to be a different code
path.

Exit earlier in mysql_alter_table, if global temporary table is opened
in this connection, or in the other connection. Add timeout argument to
simple_rename_or_index_change, which can be 0 to conform Oracle behavior

Parent issue:
MDEV-35915 Implement Global temporary tables
bf68005f8e51...
bf68005f8e51a458c25435060646f67e1f9ccf01
Nikita Malyavin
MDEV-37660 Make Global Temporary Tables DDL errors more specific

Add ER_TABLE_IN_USE code.
Use it for ALTER, DROP and RENAME when a child Global temporary table
exists in the same connection (effectively blocking the statement)

Parent issue:
MDEV-35915 Implement Global temporary tables
bf4bc91f3889...
bf4bc91f38894626b2f24bc82e0360a16d700b49
Nikita Malyavin
MDEV-37718 Assertion '!thd->rgi_slave' failed on GTT DML

Assertion '!thd->rgi_slave' failed in open_global_temporary_table on
CREATE/ANALYZE GTT, also a SIGSEGV in the release build.

This is a result of a fact that some operations led to opening a child
table on slave. The bug can be split in two parts:

1. SELECT part of CREATE...SELECT is replicated. It was binlogged,
despite table_creation_was_logged=0 explicitly set. To avoid, fall to
the row logging path of create_select, i.e. log SHOW CREATE output, but
don't actually log rows.
The relevant changes are in sql_insert.cc

2. Admin commands like ANALYZE TABLE still create a child table on open,
but are binlogged. Binlogging them would be otherwise harmless, but
better to avoid it, until the commands are fully supported and make
sense.
For now, avoid binlogging them with lex->no_write_to_binlog=false.

Parent issue:
MDEV-35915 Implement Global temporary tables
bcbdd66d99ca...
bcbdd66d99caf9ec03193f2b12cab8260ef15e4e
Nikita Malyavin
MDEV-37941 Assertion !thd->rgi_slave failed on INSERT w/ parallel slave

Replicas can't crash on the incorrect/unexpected data. It should react
with an error.

Change the assertion to if and return error if the relay log contains
query with GTT access.

Parent issue:
MDEV-35915 Implement Global temporary tables
bb31fd482484...
bb31fd48248456df834f5fdda172584b9e191827
Nikita Malyavin
MDEV-37872 SIGSEGV on some GTT operations under pseudo_thread_id changed

Deny pseudo_thread_id changing when there are some GTTs are open.
pseudo_thread_id is only used for replication testing. Since GTT child
tables are never opened on replicas, it's fine to do so -- there is no
case to test.

Parent issue:
MDEV-35915 Implement Global temporary tables
bad78bc6889b...
bad78bc6889b656fafa36d00a1f27ee29f3f111d
Nikita Malyavin
MDEV-37958 SIGSEGV in ha_mroonga::storage_create_foreign_key on INSERT

More a mroonga bug, but doesn't reproduce otherwise.
Use a correct alter_info, not the one stored in lex.

Parent issue:
MDEV-35915 Implement Global temporary tables
b9f33cbf811e...
b9f33cbf811e626483115b533deb70e683bdeeaa
Nikita Malyavin
MDEV-38468 GTT: use-after-free after failed BINLOG event in XA mode

Deny setting pseudo_slave_mode for GTT even when rli_fake is set.

Parent issue:
MDEV-35915 Implement Global temporary tables
b3ceb850e5f8...
b3ceb850e5f87f93cbb8bd681c4dc3734343387c
Nikita Malyavin
MDEV-37667 SIGSEGV on ALTER on locked GTT in low memory env

Alter table, as one of its stages, creates a temporary table from a
given table. If something goes wrong, this table will be freed.

We never distinguished a child table of global temporary table and a
temporary table created from parent for internal purposes, as this one:
They are even added to the temporary_tables list as a normal tmp table.

This commit denotes a difference for global temporary tables as with
share->mdl_request.ticket set to NULL.

Fix:
If it's a temporary table created from global temporary table for
internal purposes,
1. do not free mdl_ticket
2. do not alter global_temporary_tables_count

Parent issue:
MDEV-35915 Implement Global temporary tables
b295c4c7302c...
b295c4c7302c20115ed471b1dc96374a002009bb
Nikita Malyavin
MDEV-37798 Incomplete savepoint support with global temporary tables

Add empty savepoint support callbacks to global_temporary_tp
b1281788e3b4...
b1281788e3b41e879edd9dbf3864ef9b1ab4230c
Nikita Malyavin
MDEV-38603 GTT: Failing assertion prebuilt->template_type == ROW_MYSQL_WHOLE_ROW

FLUSH TABLES WITH READ LOCK differs from FLUSH TABLES in that the latter
doesn't open the tables. FLUSH TABLES works fine with temporary tables,
while FLUSH TABLES WITH READ LOCK results in ER_NO_SUCH_TABLE.

So we also shouldn't allow FLUSH TABLES WITH READ LOCK open a child GTT.
Doing so would result in many unpredicted problems, like this assertion.

Particularly: m_prebuilt->select_lock_type stays LOCK_S after
FLUSH TABLE WITH READ LOCK, and then is not reset by
handler::external_lock or handler::start_stmt. However, innodb would
expect LOCK_X in SERIALIZABLE isolation.

In this commit:
Always submit parent GTT to FLUSH TABLES. Since FLUSH TABLES doesn't
open tables, there'll be no difference for it, and FLUSH TABLES WITH
READ LOCK will use a parent table.

Parent issue:
MDEV-35915 Implement Global temporary tables
acc4037b3b59...
acc4037b3b59e3e461a615d1628992f7f949b0c3
Nikita Malyavin
MDEV-38448 assertion ...tdc->ref_count > 0 failed on LOCK gtt+open error

If open_global_temporary_table failed, a goto was to an incorrect place.
In locked_tables_mode, an extra acquire didn't happen, so a release on
error shouldn't have happened as well (i.e. goto err_lock).
That is, in locked_tables_mode, just return immediately on error.

The easiest way to reproduce it was with DML while pseudo_slave_mode=1,
but actually any error inside open_global_temporary_table would do.

Parent issue:
MDEV-35915 Implement Global temporary tables
ab51b18a6b38...
ab51b18a6b3893b8c37cb0676dc6645cad7b2ba1
Nikita Malyavin
MDEV-38567 GTT Context corruption on repeated SQL when autocommit=0

Always reset temporary_tables->committed when
drop_on_commit_delete_tables is called. Do it right in that function.

Parent issue:
MDEV-35915 Implement Global temporary tables
a094c3ebc4cd...
a094c3ebc4cd500fd8bfeacd3b475dd54a25049b
Nikita Malyavin
MDEV-37817 DROP TABLE GTT doesn't succeed for ON COMMIT DELETE ROWS

Drop child GTTs on pre-statement impllicit commit stage.

We can't do that inside trans_commit_implicit, because some implicit
commits are fake and part of a bigger logic, where we'd want to preserve
open GTTs.

We can't call mark_tmp_tables_as_free_for_reuse either, since there
could be tables just opened for this transaction, so only drop
exactly what's needed, assuming that tables were marked for reuse in
prev statement, but not dropped yet. One place where mark for reuse is
still required is after closing HANDLER tables.

Parent issue:
MDEV-35915 Implement Global temporary tables
9bd0ea0d0395...
9bd0ea0d039523a0d2294b6ee57d92f321ec6cc7
Abhishek Bansal
MDEV-38264: Fix failed assertion in json_find_path with trailing commas

The function json_skip_array_and_count() was trapping syntax errors
(e.g., trailing commas) in a local engine copy. Because the error state
wasn't propagated back to the main engine, json_find_path() would
proceed with an inconsistent state, eventually triggering an assertion
failure.

This patch ensures that any error encountered during the lookahead
scan is propagated to the primary engine. This allows the parser to
fail gracefully with a syntax error instead of crashing.
9b5de05bd86e...
9b5de05bd86ea49246b7fc0fc3c6ee5c39a23f5d
Nikita Malyavin
MDEV-37693 use-after-free in mysql_ha_flush after 2nd HANDLER OPEN execution

An error arises due to early deny after open_table in mysq_admin_table,
taken place in-between two handler opens, preceeding by SELECT in an
open transaction.

Analysis:
The crash happens when another mysql_ha_flush call (for example, in the
beginning of SELECT) writes table->mdl_ticket, which wasn't cleaned up
after release.
The ticket release happens normally, at mysql_ha_close_table call. This
could be another HANDLER CLOSE call, but it happens implicitly by LOAD
INDEX.
There are certain circumstances, under which table->mdl_ticket is
accessed by the handler:
  if (table_list->mdl_request.ticket &&
      thd->mdl_context.has_lock(mdl_savepoint,
                                table_list->mdl_request.ticket))
in mysql_ha_open,
meaning that the lock should have had existed in the transaction during
open.
This condition is true for the first HANDLER OPEN, because of
preceeding SELECT * FROM t, which is supposed to hold a lock during the
whole transaction.
However, killed LOAD INDEX releases that lock, resulting in skipping a
write into table_list->table->mdl_ticket durind a second HANDLER OPEN.

This doesn't happen for local temporary tables, because they don't hold
table_list->mdl_request.ticket.
This doesn't happen for normal tables, because table->mdl_ticket is
cleaned up during close_thread_table.

Solution:
Clean up table->mdl_ticket on mysql_ha_close_table, as that is the only
case when it's supposed to be set.

Parent issue:
MDEV-35915 Implement Global temporary tables
9871f9ca9aa0...
9871f9ca9aa06909739418489cc513c8abfa09b2
Marko Mäkelä
fixup! 1b853724e7424cd6c5fc8a59076f2afafff605f5
9375f8b5d68b...
9375f8b5d68b5b0ebc2d4d6e3d3b967ad4753ff9
Nikita Malyavin
MDEV-37957 Assertion lock_type >= TL_READ_SKIP_LOCKED failed on HANDLER

...READ

Don't set lock_type to TL_IGNORE: open_temporary_table intentionally
sets it to TL_WRITE to "simulate locking".

Parent issue:
MDEV-35915 Implement Global temporary tables
887cde94d31c...
887cde94d31c26b74e0b3e28a555d4236c1cc957
Sergei Golubchik
disable odbc_sqlite3_grant
8247ff5fa3e0...
8247ff5fa3e0a95247ab2da9dcd76705bfe8d1a5
Nikita Malyavin
MDEV-38481 GTT: Assertion failed in ha_maria::start_stmt on ANALYZE

Assertion 'file->trn == trn' failed in ha_maria::start_stmt on
ANALYZE TABLE, also assertion 'trn' failed in another test.

file->trn is NULL for a newly opened table and is normally assigned by
st_thr_lock::start_trans in mysql_lock_tables.

Same for thd->ha_data[maria_hton->slot].ha_ptr aka 'trn', which is
NULLed when the old table is dropped as part of OR REPLACE action, if
that was the only table in the aria locked tables. Similarly, it is
restored back on st_thr_lock::start_trans in mysql_lock_tables.

Since ANALYZE is registered as operating on the parent table,
open_only_one_table opens and locks the latter. lock_tables doesn't
issue a table lock in locked tables mode, but issues
table->file->start_stmt(...), which asserts for ha_maria.

Solution: lock the parent GTT table as well in
select_create::create_table_from_items. It will be unlocked altogether
within the lock saved in select_create as m_plock.

Parent issue:
MDEV-35915 Implement Global temporary tables
7cc7ca80ea6a...
7cc7ca80ea6a9dbdbc4c0d630a9d4286d4ebb3de
Sergei Golubchik
connect fix odbc_sqlite3 test 1
70bc8e7a8c44...
70bc8e7a8c44639d37aa1a6ea1ffb1b395c582e7
Marko Mäkelä
Do not hog LOCK_global_system_variables
47da650956f5...
47da650956f51e1644ac0b2e2b4f69843c19d044
Nikita Malyavin
MDEV-37896 global_temporary_table tests are not stable on 2nd run

replace con_id and purge logs

Parent issue:
MDEV-35915 Implement Global temporary tables
3e0d7829b068...
3e0d7829b06870382f01eb94858733c571f2c8eb
Nikita Malyavin
MDEV-38151 GTT: missing FUNCTION support

open_temporary_table[s] defaulted to searching only local temporary
tables (Tmp_table_kind::TMP). When in function, a temporary table was
"carefully re-opened": it was closed and then opened again, with
open_temporary_table. This resulted in "table not found".

The correct key in most cases is Tmp_table_kind::ANY.
In some cases it should be Tmp_table_kind::TMP:
* When operation is not supported for GTT (ANALYZE/REPAIR)
* When a global handle should be opened (CREATE VIEW)
* If it's a re-open

Apart from this bug, it caused a global temporary table to be always
opened through open_tables, meaning that tdc was queried first. This
means that the earlier code never relied on pre-opening
temporary tables.

This means that all the commands that follow the default
open_temporary_tables path in mysql_execute_command (the standard
temporary tables pre-opening) should be able to handle child GTT share.

This wasn't so for TRUNCATE, hence the changes in sql_truncate.cc.

Also, this broke the lookup order: first a local temporary table should
be looked up. If it doesn't exist, only then a global temporary table
should be looked up.
To fix the latter -- push back global temporary tables' local shares and
push front local temporary tables.

To support push_front, All_tmp_tables_list declaration is changed. It
should use I_P_List_fast_push_back adapter, which adds T **m_last to the
list body.

Parent issue:
MDEV-35915 Implement Global temporary tables
345849d9664a...
345849d9664ab95e292d8a71ebf3c0f48d0b7ebd
Nikita Malyavin
MDEV-38266 Infinite loop after LOCK+REPAIR

Case:
1. Two tables are locked, one of them is GTT
2. Invoke REPAIR on the last table in the list (not GTT)
3. SELECT from gtt

How the bug works:
1. REPAIR sets tdc->flushed=true
2. LOCK TABLE will prevent eviction
3. In SELECT, open_table will go by locked_tables_mode path
4. GTT is found, goto get_new_table (bug!).
5. This is true: thd->open_tables && thd->open_tables->s->tdc->flushed
6. ot_ctx->request_backoff_action
7. open_table retry (infinite).

Fix:
Straighten the flow.
We shouldn't check thd->open_tables->s->tdc->flushed in LTM, but
actually we should do none under get_new_table label right until
open_global_temporary_table.

get_new_table would access tdc and search for TABLE_SHARE, but actually
we already have it. We also shouldn't configure it from scratch - it's
already done. Overall, we can jump directly to opening GTT, with setting
a few variables.

Because TABLE_SHARE will not be opened through tdc (where acquire would
happen), we shouldn't release it in open_global_temporary_table under
locked_tables_mode+MYSQL_OPEN_GET_NEW_TABLE.

Parent issue:
MDEV-35915 Implement Global temporary tables
3214ad5f5c64...
3214ad5f5c64fc3305b2b52d6392cd812dbda64d
Nikita Malyavin
MDEV-38568 GTT: Assertion thd->mdl_context.is_lock_owner failed in CoR

The crash happens on the junction of GTT, CREATE OR REPLACE...SELECT,
LOCK TABLES, and error during select.

1. The parent table should be dropped with drop_open_table, not
quick_rm_table, because it should first be closed.
2. In select_create::abort_result_set, drop the parent table as well.
3. Store parent parent GTT in select_create -- this improves readability
  and access hugely.

Parent issue:
MDEV-35915 Implement Global temporary tables
2d0cc59a6257...
2d0cc59a6257628c0c7b9eec2e43d01688106404
Nikita Malyavin
MDEV-38125 Assertion !thd->rgi_slave failed on INSERT under LOCK TABLES

Locking a global temporary table causes a crash on slave,
even if the table wasn't used in the statement, but just locked.

The crash, and an inappropriate open of global temporary table happens
because its table mapping was replicated. Rows_log_event opens all the
tables that were aggregated by Table_map_log_event.

THD::binlog_write_table_maps aggressively logs all the tables that
were write-locked, even if they will never be used.

Solution: We should never log table maps for global temporary tables

Parent issue:
MDEV-35915 Implement Global temporary tables
1c1190e04813...
1c1190e048135885972854fc73aa00dd0b33fcdd
Nikita Malyavin
MDEV-37956 use-after-free in mysql_ha_close_table on DROP DATABASE

Drop global temporary tables after dropping handlers.

Parent issue:
MDEV-35915 Implement Global temporary tables
1b853724e742...
1b853724e7424cd6c5fc8a59076f2afafff605f5
Marko Mäkelä
squash! 02a3688fec7e7443c301ea7abde27dcb22c507a1

Implement file-level InnoDB page locking for backup.

buf_flush_list_space(): Check for concurrent backup before writing each
page. This is inefficient, but this function may be invoked from multiple
threads concurrently, and it cannot be changed easily, especially for
fil_crypt_thread().

TODO: Implement finer-grained locking around copying page ranges.
17097349919f...
17097349919f5b7dc15b37cb8d0e7312e171daad
Nikita Malyavin
MDEV-37898 No release GTT MTR tests due to debug_sync injection

Parent issue:
MDEV-35915 Implement Global temporary tables
14fc0dec2f0c...
14fc0dec2f0c5e4531312d46e089c6a8a5455f2a
Nikita Malyavin
MDEV-37720 use-after-free on CREATE OR REPLACE GTT under pseudo_slave_mode

... and LOCK TABLES.

Global temporary tables data is not replicated, and pseudo_slave_mode is
used internally for partial replication testing.

Hence forbid opening GTT (i.e. create child GTT handles) under
pseudo_slave_mode, and forbid setting pseudo_slave_mode=1 whenever child
GTT handles are open.

Parent issue:
MDEV-35915 Implement Global temporary tables
10d5ee6f11fe...
10d5ee6f11fece23398d6f98da34b1b0903a91e0
Jan Lindström
MDEV-38917 : Galera test failure on galera.galera_sst_mysqldump

This regression is caused by commit c380e165973 (MDEV-38833 "Suboptimal
or dead code at server startup"). Problem is that there should never
be an expectation that InnoDB bootstrap is crash-safe. Therefore,
after wsrep has initialized wsrep schema force checkpoint. This
ensured that InnoDB has successfully bootstrapped and wsrep chema
is initialized. This checkpoint ensures that wsrep-recover
is successful.

Other changes:
* Splitted galera_sst_mysqldump to two parts wsrep_sst_mysqldump
  and wsrep_sst_mysqldump_debug that is run only on debug builds.
* Changed wserp_schema initialization not to use std::string
  because it is unnecessary.
* Force checkpoint after wsrep_schema has been created.
* Make test wsrep_sst_mysqldump_with_key smaller
* Stabilize test cases
0aecc295c748...
0aecc295c74815a530ad97dd08f20bb2c3153a80
Nikita Malyavin
MDEV-38480 GTT: Aria gets error HA_ERR_CRASHED_ON_USAGE after TRUNCATE

Do not call HA_EXTRA_PREPARE_FOR_DROP for the parent table

Parent issue:
MDEV-35915 Implement Global temporary tables
0112d2568020...
0112d256802094f949119c263bd2a9518f32a2c7
Nikita Malyavin
MDEV-37850 Wrong error on DROP TABLE GTT after DROP DATABASE

Turns out that temporary tables are not dropped as part of DROP
DATABASE.

This patch implements dropping child global temporary tables for the
currently dropping database.

That is, if the child table was opened in this connection, it will be
dropped together with the parent table.

If another connection attempts to drop the database, it will wait while
the table is in use.

Parent issue:
MDEV-35915 Implement Global temporary tables
BuildBot (0.8.9) working for the MariaDB project.
Page built: Tue 31 Mar 2026 00:38:11 (UTC)