Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
fcdb650fc227...
fcdb650fc22758bfb0eff2b02619c1647500605e
Sergei Golubchik
remove LEX::make_sp_name_sql_path()

it confusingly didn't have anything to do with sql path,
so merged into LEX::make_sp_name()
fcc539b66642...
fcc539b6664230d11330cc4866e3a439e9afbc1a
Sergei Golubchik
clarify the test for triggers with different paths
f4787d9e4a0b...
f4787d9e4a0b209d46113eeb7d4e9fa365e48e8a
Sergei Golubchik
consistency in error message naming
f3e966995aff...
f3e966995aff9b80155367b001be7c4e9c5da62a
Sergei Golubchik
add new column mysql.proc.path at the end of the table

to simplify downgrades and to avoid breaking applications
ea596b2d41f8...
ea596b2d41f8c5982e6341929aebcd7b88465021
Sergei Golubchik
cleanup

* rename to follow the standard vprintf name convention
* remove `(LEX_CSTRING*) &lex_string` casts
* remove some redundant casts too
* LEX_CSTRING -> Lex_ident_db in path
* Hash_set<Sroutine_hash_entry>
* move assert out of the loop
* some comments and whitespace changes
e10621a19179...
e10621a19179920fd7ba2d45846651a0ebcbe18b
Sergei Golubchik
reserve PATH_SYM in the same way as NAMES_SYM
ddb41c84be5e...
ddb41c84be5eb8f29002f2936d0d4cdfefb514fa
Sergei Golubchik
more tests for duplicate values in path
c953696a149c...
c953696a149c9b89b3e8635bc67bd0ca19780ef2
Sergei Golubchik
relax assert to account for recursive RETURNS TEXT functions
c646f2f40ad1...
c646f2f40ad1a1aab60fcd95a714609eb18272ce
Sergei Golubchik
mysql.proc.path DEFAULT 'CURRENT_SCHEMA' NOT NULL
be486155aa89...
be486155aa89a30c4ff53741eb1b0beefdd4532c
Sergei Golubchik
remove Sql_path_stack and Sql_path_push

don't create a permanent stack of paths on the heap and in THD.

Do it on the stack like for sql_mode, sctx, abort_on_warning, and
other THD properties that often need to be changed temporarily.

Fix Sql_path constructor.
b9bea742ba11...
b9bea742ba11029051dd17af98c3e563f9609e64
Sergei Golubchik
old view doesn't store the path, need the same fallback as for triggers
af52c449842b...
af52c449842b6ad4ac6846ec94f999db523bb68e
Sergei Golubchik
merge ErrConvMDQName into ErrConvDQName

and remove incorrect thd->db behavior
abf4c3af52e4...
abf4c3af52e4a0f307754a2cad5aed367d110578
Sergei Golubchik
Don't implicitly search in CURRENT_SCHEMA

the intention was not to, but some code paths weren't fixed yet
aa1eb9f21cfa...
aa1eb9f21cfac78e7a0be66f78f67e22f92ed820
Sergei Golubchik
sporatic failures of mdev38431
aa185857201e...
aa185857201ee625fcf1850f702814af6cb6782d
Brandon Nesterenko
MDEV-38716: Part 2

The last patch was incorrect - it did not consider columns with both

DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP

and these records would be re-written with new timestamps.

The fix is to add the ON UPDATE based default_fields back to the
destination table after the actual data copy.

Reviewed-by: TODO
Signed-off-by: Brandon Nesterenko <[email protected]>
a3ac82de4805...
a3ac82de4805f25bed6afd92022ce421e75df143
sts-kokseng.wong
MDEV-34391 SET PATH statement

Definition
==========
Implement the SET PATH statement.
```
SET PATH 'schema1, schema2, schema3';
```

Function
--------
In MariaDB, the SQL-path will also be used to lookup packages in
package routine invocations, so the following script:

  SET PATH 'sys';
  SELECT UTL_ENCODE.BASE64_DECODE('data');

invokes SYS.UTL_ENCODE.BASE64_DECODE('data'), i.e. the function
BASE64_DECODE() in the packge UTL_ENCODE in the database SYS
(if such package and package routine exist).

MariaDB implementation details
------------------------------
The ticket's requirement stated the grammar should support delimited
identifiers with backticks or double quotes within the string quote,
ie: the single tick. A simple parser was implemented to handle this
requirement in Sql_path::from_text.

Only 16 schemas are supported per session - we do not want too many
schemas in the path anyway since it will impact performance. This also
means that the path cache is a simple static array for easier memory
management.
98c938a5bf7a...
98c938a5bf7a215b5bba8eba3f21b8c6b960db84
Sergei Golubchik
disallow SET PATH DEFAULT in stored routines and triggers

also fix Sys_var_charset_collation_map where this bug was copied from
97c0a6d9821a...
97c0a6d9821a8ba9563d48ac18f64edce7c36298
Sergei Golubchik
improve test readability

fix confusing duplicate lines like

Invoke from Db: test, Rt: proc
Invoke from Db: test, Rt: proc
9166d61e794d...
9166d61e794d1df8be72b9f95d69eddc603cea1d
Sergei Golubchik
don't backtick-quote CURRENT_SCHEMA
8f854fd0a299...
8f854fd0a29905915c60198e17de774ab76b0cbc
Sergei Golubchik
PATH is not a chistic, it's like sql_mode, remembered implicitly per routine
8e75cfbb7aee...
8e75cfbb7aee9b5a35ed6b784e8eb972c11af449
Sergei Golubchik
fix error message for assoc arrays
8e7131ea664d...
8e7131ea664d6ef641968f781a8d74a53ee5c36c
Brandon Nesterenko
MDEV-38716: Server crashes in TABLE::evaluate_update_default_function

This patch fixes two issues:

Problem (1)
A regression from MDEV-36290 would cause the server to crash when one
uses TIMESTAMP or DATETIME types with option ON UPDATE. The root cause
of this is actually from problem (2) described below, MDEV-36290 simply
forced the bug to be revealed.

Problem (2)
After a table is rebuilt (i.e. via ALTER TABLE .. FORCE), any fields
which use ON UPDATE lose the update trigger after the ALTER. This is
because recreated fields (i.e those in alter_info->create_list) had no
checks to ensure their representation in the target table's
default_fields list. The intent is provided by the following code
comment:

/*
  Update the set of auto-update fields to contain only the new fields
  added to the table. Only these fields should be updated automatically.
  Old fields keep their current values, and therefore should not be
  present in the set of autoupdate fields.
*/

However, fields with trigger-based default values were left
unconsidered.

Linking back to problem (1), the crash happened because of the
following MDEV-36290 changes:

diff --git a/sql/sql_table.cc b/sql/sql_table.cc
index 13ed810cac2..5cc74785ef7 100644
--- a/sql/sql_table.cc
+++ b/sql/sql_table.cc
@@ -12737,7 +12737,12 @@ copy_data_between_tables(THD *thd, TABLE *from, TABLE *to,
    }
  }
  if (dfield_ptr)
-    *dfield_ptr= NULL;
+  {
+    if (dfield_ptr == to->default_field)
+      to->default_field= 0; // No default fields left
+    else
+      *dfield_ptr= NULL; // Mark end of default field pointers
+  }

That is, the destination table's default_field becomes nullified when
no default_field changes exist. However, because ON UPDATE
default_fields were not moved to the destination table, the server
would crash with a segfault when updating the records in the
post-ALTER table (in TABLE::evaluate_update_default_function()) because
it would de-reference the nullified pointer in default_field.

The fix for these problems is the same. The default_field information
is copied from these recreated fields when default values are used
later by ON UPDATE options.

Reviewed-by: TODO
Signed-off-by: Brandon Nesterenko <[email protected]>
8e0668adee72...
8e0668adee7212d036a21f51a89fb3fb225b2bd0
Sergei Golubchik
fix --path to work

complex object sysvars (plugins, time zone, path) cannot be
set by my_getopt, they have to use NO_CMD_LINE and special
code in mysqld.cc
84dd75ea1f28...
84dd75ea1f28d96c6cb8db1c440bb0b62c1fbb39
Michael Widenius
MDEV-19683 Add support for Oracle TO_DATE()

Syntax:
TO_DATE(string_expression [DEFAULT string_expression ON CONVERSION ERROR],
        format_string [,NLS_FORMAT_STRING])
The format_string has the same format elements as TO_CHAR(), except a
few elements that are not supported/usable for TO_DATE().
TO_DATE() returns a datetime or date value, depending on if the format
element FF is used.

Allowed separators, same as TO_CHAR():
space, tab and any of !#%'()*+,-./:;<=>

'&' can also be used if next character is not a character a-z or A-Z
"text' indicates a text string that is verbatim in the format. One cannot
use " as a separator.

Format elements supported by TO_DATE():
AD          Anno Domini ("in the year of the Lord")
AD_DOT      Anno Domini ("in the year of the Lord")
AM          Meridian indicator (Before midday)
AM_DOT      Meridian indicator (Before midday)
DAY        Name of day
DD          Day (1-31)
DDD        Day of year (1-336)
DY          Abbreviated name of day
FF[1-6]    Fractional seconds
HH          Hour (1-12)
HH12        Hour (1-12)
HH24        Hour (0-23)
MI          Minutes (0-59)
MM          Month (1-12)
MON        Abbreviated name of month
MONTH      Name of Month
PM          Meridian indicator (After midday)
PM_DOT      Meridian indicator (After midday)
RR          20th century dates in the 21st century. 2 digits
            50-99 is assumed from 2000, 0-49 is assumed from 1900.
RRRR        20th century dates in the 21st century. 4 digits
SS          Seconds
SYYYY      Signed 4 digit year; MariaDB only supports positive years
Y          1 digit year
YY          2 digits year
YYY        3 digits year
YYYY        4 digits year

Note that if there is a missing part of the date, the current date is used!
For example if 'MM-DD HH-MM-SS' then the current year will be used.
(Oracle behaviour)

Not supported options:
- BC, D, DL, DS, E, EE, FM, FX, RM, SSSSS, TS, TZD, TZH, TZR, X,SY
  BC is not supported by MariaDB datetime.
- Most of the other are exotic formats does not make sence in MariaDB as
  we return datetime or datetime with fractions, not string.
- D (day-of-week) is not supported as it is not clear exactly how it would
  map to MariaDB. This element depends on the NLS territory of the session.
- RR only works with 2 digit years (In Oracle RR can also work with 4
  digit years in some context but the rules are not clear).

Extensions / differences compared to Oracle;
- MariaDB supports FF (fractional seconds).  If FF[#] is used,
  then TO_DATE will return a datetime with # of subseconds.
  If FF is not used a datetime will be returned.
  There is warning (no error) if string contains more digts than what
  is specified with F(#]
- Names can be shortened to it's unique prefix. For example January and Ja
  works fine.
- No error if the date string is shorter format_string and the next
  not used character is not a number.. This is useful to get a date
  from a mixed set of strings in date or datetime format.
  Oracle gives an error if date string is too short.
- MariaDB supports short locales as language names
- NLS_DATE_FORMAT can use both " and ' for quoting.
- NLS_DATE_FORMAT must be a constant string.
  - This is to ensure that the server knows which locale to use
    when executing the function.

New formats handled by TO_CHAR():
FF[1-6]    Fractional seconds
DDD        Daynumber 1-366
IW          Week 1-53 according to ISO 8601
I          1 digit year according to ISO 8601
IY          2 digit year according to ISO 8601
IYY        3 digit year according to ISO 8601
IYYY        4 digit year according to ISO 8601
SYYY        4 digit year according to ISO 8601 (Oracle can do signed)

Supported NLS_FORMAT_STRING options are:
NLS_CALENDAR=GREGORIAN
NLS_DATE_LANGUAGE=language

Support languages are:
- All MariaDB short locales, like en_AU.
- The following Oracle language names:
ALBANIAN, AMERICAN, ARABIC, BASQUE, BELARUSIAN, BRAZILIAN PORTUGUESE
BULGARIAN, CANADIAN FRENCH, CATALAN, CROATIAN, CYRILLIC SERBIAN CZECH,
DANISH, DUTCH, ENGLISH, ESTONIAN, FINNISH, FRENCH, GERMAN,
GREEK, HEBREW, HINDI, HUNGARIAN, ICELANDIC, INDONESIAN ITALIAN,
JAPANESE, KANNADA, KOREAN, LATIN AMERICAN SPANISH, LATVIAN,
LITHUANIAN, MACEDONIAN, MALAY, MEXICAN SPANISH, NORWEGIAN, POLISH,
PORTUGUESE, ROMANIAN, RUSSIAN, SIMPLIFIED CHINESE, SLOVAK, SLOVENIAN,
SPANISH, SWAHILI, SWEDISH, TAMIL, THAI, TRADITIONAL CHINESE, TURKISH,
UKRAINIAN, VIETNAMESE

Development bugs fixed:
MDEV-38403 Server crashes in Item_func_to_date::fix_length_and_dec upon
          using an invalid argument
MDEV-38400 compat/oracle.func_to_date fails with PS protocol and cursor
          protocol (Fixed by Serg)
MDEV-38404 TO_DATE: MTR coverage omissions, round 1
MDEV-38509 TO_DATE: AD_DOT does not appear to be supported
MDEV-38513 TO_DATE: NULL value for format string causes assertion failure
MDEV-38521 TO_DATE: Date strings with non-ASCII symbols cause warnings
          and wrong results
MDEV-38578 TO_DATE: Possibly unexpected results upon wrong input
MDEV-38582 TO_DATE: NLS_DATE_LANGUAGE=JAPANESE does not parse values
          which work in Oracle
MDEV-38584 TO_DATE: NLS_DATE_LANGUAGE=VIETNAMESE does not parse values
          which work in Oracle
MDEV-38703 TO_DATE: Quotation for multi-word NLS_DATE_LANGUAGE leads
          to syntax error in view definition
MDEV-38675 TO_DATE: MSAN/Valgrind/UBSAN errors in
          extract_oracle_date_time
MDEV-38635 TO_DATE: UBSAN errors in item_timefunc.h upon comparison with
          a view column
MDEV-38719 TO_DATE: Assertion `&my_charset_bin != charset()' failed in
          String::append_for_single_quote_using_mb_wc

Known issues:
- Format string character matches inside quotes are done
  one-letter-to-one-letter, like in LIKE predicate. That means things
  like expansions and contractions do not work.
  For example 'ss' does not match 'ß' in collations which treat them
  as equal for the comparison operator.
  Match is done taking into account case and accent sensitivity
  of the subject argument collation, so for example this now works:
  MariaDB [test]> SELECT TO_DATE('1920á12','YYYY"a"MM') AS c;
  +---------------------+
  | c                  |
  +---------------------+
  | 1920-12-17 00:00:00 |
  +---------------------+

Co-author and reviewer: Alexander Barkov <[email protected]>
844b0123b82c...
844b0123b82c9f0105ba39f75452e75dfe8fe151
Sergei Golubchik
change Sql_path::from_text() to take a String, not LEX_CSTRING

* use str->c_ptr() for the error message
* pass correct charset
* remove redundant parsing Table_triggers_list::check_n_load
6ef289416e2e...
6ef289416e2e07b3fd12827d8497079805f1b842
Brandon Nesterenko
MDEV-36290: Update binlog_row_event_fragment_threshold type to uint

When adding in variable type binlog_row_event_fragment_threshold, it
was made a ulong to mimick max_allowed_packet and
slave_max_allowed_packet variables (as they are intertwined). However,
using ulong is bad practice as it has a different type depending on the
architecture. This is shown by test sys_vars.sysvars_server_notembedded
where the variable shows as `BIGINT UNSIGNED` on 64-bit systems, and
`INT UNSIGNED` on 32-bit systems.

This patch updates the variable to be uint (32-bit), as there is a
fundamental limitation of 4GB on event size, so the new
Partial_rows_log_event event couldn't exceed that size anyway.

Signed-off-by: Brandon Nesterenko <[email protected]>
626728af73e2...
626728af73e232f602c642b92e444f15fe99ae89
Sergei Golubchik
ubsan error, memcpy(dst, NULL, 0)
5f88bcfc562c...
5f88bcfc562c7ac0653a9f8dabd9f478bbda22f1
Sergei Golubchik
disallow SET PATH in sf or trg while parsing

but also when executing, of course
55c7f46af0e0...
55c7f46af0e091e3087015590010d0527949eda4
Sergei Golubchik
MDEV-38523 Freeing unallocated data THD::set_db when path-resolved routine in trigger

add a test case
53b5f3fddd99...
53b5f3fddd99786999cd5cc47d33d8446637f4d6
Sergei Golubchik
free Sql_path in the destructor, perform cleanup in cleanup()
5078b31c68f5...
5078b31c68f563f2eb1b939964df9255fef94693
Alexander Barkov
Adding REF CURSOR in parameters and return
4aac57440961...
4aac574409616cfbf74536748401cc702b28ef7b
Sergei Golubchik
use standard SET PATH syntax in tests
47b3dbc390a9...
47b3dbc390a91a2467e8ad61d2d09658ecebddda
Sergei Golubchik
do NOT prefer itself in seemingly recursive calls, follow the path
44c2dffe25ec...
44c2dffe25ec4cb9e9de84aa9969ac8ecf8e1954
Sergei Golubchik
fix parts.key_compare_result_on_equal --cursor
3c5f7d014107...
3c5f7d014107186195da4a2b1b2433eb94cd2071
Brandon Nesterenko
MDEV-38435: Re-record engines/funcs tests

Some additional tests needed to be re-recorded after MDEV-38435 to mask
the GTID Binlog position

Signed-off-by: Brandon Nesterenko <[email protected]>
3a4b1be8364f...
3a4b1be8364f2deeb4778d69d11d8146eaa16f6d
Sergei Golubchik
remove unused arguments
32fa3c5f53a1...
32fa3c5f53a1c56ea8630115680a024a11028c55
Oleg Smirnov
MDEV-38045 Address code review comments, part 1 (commit to squash)
23e3efc5c4ed...
23e3efc5c4eddd178c468fb1d2c5f6036ba1f4d2
Sergei Golubchik
bug: `current_schema` is not current_schema

quoted `current_schema` is literally a schema name and must
but treated as such. because Sql_path stores all names unquoted
let's store the current_schema as an empty name, length=0.
No valid schema name can be empty.
15bc50c50854...
15bc50c50854899553c01bbfb27639ebc42f4225
Sergei Golubchik
fix name resolution of name1.name2()

only search in thd->db if the path includes CURRENT_SCHEMA

Also, fix a bug with recursive function calls.
08ffa7a8a8f7...
08ffa7a8a8f7eb3c6b1412472de679c0da059f2d
Sergei Golubchik
allocate Sql_path in one memory chunk, not one per schema

because it's always allocated and freed as a whole, there is
no operation "replace one name in the middle of the path"

this needed a reworked parser to create the whole list
of names, not append one name at a time.

Fixed a bug where Sql_path::from_text() pretended it can take
a string in any charset, but was always implicitly
assuming it's in my_charset_utf8mb3_general_ci.
BuildBot (0.8.9) working for the MariaDB project.
Page built: Tue 03 Feb 2026 21:48:19 (UTC)