Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
Alessandro Vetere
fixup! fixup! MDEV-37070  Implement table options to enable/disable features
Sergei Petrunia
Fixup to previous commit
Abdelrahman Hedia
MDEV-37842 Skip implicit Using_Gtid warning when value is unchanged

When a replica already has Using_Gtid=No and a CHANGE MASTER TO is
issued with log coordinates (e.g. relay_log_pos, master_log_file),
the server emits a spurious warning:

  Note 4190 CHANGE MASTER TO is implicitly changing the value of
  'Using_Gtid' from 'No' to 'No'

The value isn't actually changing, so the warning is misleading.

In change_master() (sql/sql_repl.cc), when log coordinates are specified
without an explicit master_use_gtid, the code implicitly sets Using_Gtid
to No and emits a warning. The condition only checks whether
master_use_gtid=No was explicitly given but does not check whether
Using_Gtid is already No.

Added a check that the current Using_Gtid value differs from
USE_GTID_NO before emitting the warning. The warning now only fires
when the value actually changes.

Re-recorded rpl.rpl_from_mysql80 which previously expected the
spurious No-to-No warning.

Reviewed-by: Georgi Kodinov <[email protected]>
Reviewed-by: Brandon Nesterenko <[email protected]>

https://github.com/MariaDB/server/pull/4678
Sergei Petrunia
Cleanup: remove read-side structures that have write-side copies

Remove:
-class range_context_for_replay;
-class irc_context_for_replay;
-class rir_context_for_replay;
Mohammad Tafzeel Shams
MDEV-22186: Add innodb_trim_core_file to exclude InnoDB memory from cores

Problem:
There is no control to include or exclude large InnoDB memory regions
such as the buffer pool and log buffer from core files, which can lead to
unnecessarily large core dumps or prevent capturing useful memory state.

Solution:
Introduce a new global dynamic system variable innodb_trim_core_file that
allows excluding large InnoDB memory regions (buffer pool and log buffer)
from core dumps using MADV_DONTDUMP where supported. When enabled and
@@core_file=ON, the server marks relevant memory regions to be omitted
from core files. The madvise state is dynamically updated when the
variable changes.

Additionally, a test helper script is introduced to inspect
/proc/<pid>/smaps and verify whether large memory regions are marked
for trimming.

- innodb_trim_core_file
  Global boolean system variable controlling whether InnoDB memory
  regions should be excluded from core dumps. Has no effect if
  @@core_file=OFF. Default: ON on non-debug builds with MADV_DONTDUMP
  support, OFF otherwise.

- innobase_should_trim_core_dump()
  Determines whether InnoDB memory allocations should be marked with
  MADV_DONTDUMP, based on @@core_file and @@innodb_trim_core_file.

- innodb_srv_trim_core_file_update()
  Update hook that sets srv_trim_core_file and triggers runtime updates
  of madvise state for both the buffer pool and log buffers.

- srv_trim_core_file
  Global variable backing @@innodb_trim_core_file.

- buf_pool_t::buf_pool_should_madvise_dont_dump
  Tracks the current madvise state for the buffer pool memory.

- buf_pool_t::madvise_update_dump()
  Re-evaluates whether the buffer pool should be excluded from core
  dumps and applies ut_dontdump() or ut_dodump() accordingly.

- buf_pool_t::create()
  Initializes madvise state based on innobase_should_trim_core_dump()
  and conditionally applies MADV_DONTDUMP to the buffer pool memory.

- buf_pool_t::resize()
  Reapplies MADV_DONTDUMP to newly allocated memory regions when
  resizing if innodb_trim_core_file=ON

- log_t::log_buf_should_madvise_dont_dump
  Tracks the madvise state for the InnoDB log buffers.

- log_t::madvise_dontdump()
  Marks log buffers and resize buffers with MADV_DONTDUMP.

- log_t::madvise_dodump()
  Restores inclusion of log buffers in core dumps using MADV_DODUMP.

- log_t::madvise_update_dump()
  Updates the madvise state for log buffers when
  @@innodb_trim_core_file changes.

- log_t::attach()
  Call ut_dodump() for log_t::buf & log_t::flush_buf on successful
  allocation and innodb_trim_core_file=OFF

- log_t::resize_start()
  Call ut_dodump() for log_t::resize_buf & log_t::resize_flush_buf on
  successful allocation and innodb_trim_core_file=OFF

- check_core_dump_trim.inc
  Test helper that inspects /proc/<pid>/smaps to detect memory regions
  with the dd VmFlag and determine whether the core file is expected
  to be trimmed based on buffer pool and log buffer sizes.
Sergei Petrunia
Small cleanups. Remove table_context_for_replay::ddl
Vladislav Vaintroub
MDEV-39027 suboptimal code for InnoDB big endian access functions

Optimize big endian (and some little endian) Innodb access functions by
using my_htobeN/my_betohN and memcpy.
forkfun
MDEV-38967: STR_TO_DATE() cannot be used in indexed virtual columns

Update STR_TO_DATE() to accept an optional third argument for the locale.
DATE_FORMAT() and STR_TO_DATE() return NULL when the locale argument is NULL;
issue a warning and fall back to the session @@lc_time_names for invalid locale names.
STR_TO_DATE() can now be used in indexed virtual columns while having all 3 arguments,
but not allowed when 2 as it depends then on the session @@lc_time_names
ParadoxV5
MDEV-38907 Optimistic Relay Log Crash Recovery

This commit adds an automatic recovery
procedure to GTID relay log initialization.

This procedure scans the write end of a log to remove any
trailing (or corrupted) incomplete event or event group.
Unlike `@@relay_log_recovery`, this procedure won’t discard
the portion of logs that managed to survive the crash.
For exceptional cases that require manual intervention,
`@@relay_log_recovery` is not altered.

Note, because START SLAVE purges the relay log in GTID mode,
this feature doesn’t bring immediate value.
However, this commit is a crash-safety
preparation for lifting that limitation.
Non-GTID mode can also build upon this procedure
to improve its crash safety precautions.

Reviewed-by: Kristian Nielsen <[email protected]>
Dmitry Shulga
MDEV-30645: CREATE TRIGGER FOR { STARTUP | SHUTDOWN }

Follow-up to fix issue with starting server on server with broken table mysql.event
Marko Mäkelä
fixup! 1d57f26b50436d3e59ccce9a2b8cd7a9836c07ac

buf_flush_sync_for_checkpoint(): Prevent a shutdown hang
when innodb_log_recovery_target is set.
Sergei Petrunia
Coding style renames: Saved_index_stats, Saved_table_stats
Sergei Petrunia
Improve comments and readability.
Sergei Petrunia
Fix for sub-statements: handle PROCEDURE also.
Vladislav Vaintroub
MDEV-39027 suboptimal code for InnoDB big endian access functions

Optimize big endian (and some little endian) Innodb access functions by
using my_htobeN/my_betohN and memcpy.
Fariha Shaikh
MDEV-36725 Fix innodb_ctype_ldml test in view-protocol mode

The test innodb.innodb_ctype_ldml was failing in view-protocol mode due
to different column naming behavior for complex expressions.

Without explicit column aliases, view-protocol mode generates automatic
names (Name_exp_1, Name_exp_2) while normal mode uses the full
expression as the column name.

Add explicit column aliases to SELECT statements in innodb_ctype_ldml to
ensure consistent column names across both normal and view-protocol
modes.

All new code of the whole pull request, including one or several files
that are either new files or modified ones, are contributed under the
BSD-new license. I am contributing on behalf of my employer Amazon Web
Services, Inc.
Sergei Petrunia
JSON parsing: rename classes to cleaner names

Read_container_value -> Read_array.
Read_list_of_context -> Read_array_into_list
Alexey Botchkov
MDEV-37262 XMLTYPE: validation.
  13.03
Marko Mäkelä
fixup! 32b7005d3463f95a03bf1dd9e7be4b59f3f9f591
Alessandro Vetere
fixup! MDEV-37070  Implement table options to enable/disable features
bsrikanth-mariadb
MDEV-38803: Rename 2 files

change opt_store_replay_context.h and .cc files to
opt_context_store_replay.h and .cc respectively
Alexey Botchkov
MDEV-37262 XMLTYPE: validation.
ParadoxV5
[to squash] a coupa fixes for ci

Some issues might be existing bugs, where relay log open
errors leads to further problems similar to MDEV-24625.
Marko Mäkelä
fixup! 1d57f26b50436d3e59ccce9a2b8cd7a9836c07ac

log_t::write_checkpoint(): Properly resume set_archive().
Sergei Petrunia
Further code cleanups. Don't print empty objects for VIEWs.
Sergei Petrunia
Fixup (2)
luckyxhq
MDEV-38915 Fix signed/unsigned type mismatch in setval() for GET_ULONG
forkfun
MDEV-38967: STR_TO_DATE() cannot be used in indexed virtual columns

Update STR_TO_DATE() to accept an optional third argument for the locale.
DATE_FORMAT() and STR_TO_DATE() return NULL when the locale argument is NULL;
issue a warning and fall back to the session @@lc_time_names for invalid locale names.
STR_TO_DATE() can now be used in indexed virtual columns while having all 3 arguments,
but not allowed when 2 as it depends then on the session @@lc_time_names
Marko Mäkelä
fixup! 8ee3ddfb46654f2dc49f5b3f141a83e85b833a11

innodb_log_recovery_target fixes
bsrikanth-mariadb
MDEV-38805: use charset utf8mb4, for client-server communication

REPLACE INTO statements would now use my_charset_utf8mb4_bin conversion
Also, the sql_script file structure would now look like

SET NAMES utf8mb4;
SET var1=value1;
.
.
CREATE DATABASE 'name' if NOT..;
USE DATABASE 'name';
CREATE TABLE ...;
.
REPLACE INTO ..;
.
.
set @opt_context='...';
.
.

Additionally, made few changes to the documentation comments
Vladislav Vaintroub
MDEV-39027 suboptimal code for InnoDB big endian access functions

Optimize big endian (and some little endian) Innodb access functions by
using my_htobeN/my_betohN and memcpy.
Denis Protivensky
MDEV-30612: Fix usage of lex->definer in wsrep_create_trigger_query

Setting thd->lex->definer is excessive as it's only used within the
function call.
Moreover, it would lead to a use-after-free on the second execution
of a CREATE TRIGGER prepared statement.
Sergei Petrunia
Fix optimizer context recording and sub-statements:

Sub-statements don't start or stop recording.
Marko Mäkelä
fixup! 1d57f26b50436d3e59ccce9a2b8cd7a9836c07ac

Allow the last checkpoint slot to be overwritten after recovery
Vladislav Vaintroub
MDEV-39027 suboptimal code for InnoDB big endian access functions

Optimize big endian (and some little endian) Innodb access functions by
using my_htobeN/my_betohN and memcpy.
Sergei Petrunia
Rename dump_XXXX() functions and make them more readable.
Alexey Yurchenko
MDEV-38383 Fix MDEV-38073 MTR test warning

MDEV-38073 MTR test started to fail with a warning after upstream merge
from 11.4 a7528a6190807281d3224e4e67a9b76083a202a6 because THD responsible
for creating SST user became read-only when the server was started with
--transaction-read-only=TRUE.
make sure the readonly flag on THDs created for wsp::thd utility class is
cleared regardless of the --transaction-read-only value as it is intended
only for client-facing THDs.
Vladislav Vaintroub
MDEV-39027 suboptimal code for InnoDB big endian access functions (MSVC, GCC)

Optimize big endian (and some little endian) Innodb access functions
Vladislav Vaintroub
MDEV-39027 suboptimal code for InnoDB big endian access functions

Optimize big endian (and some little endian) Innodb access functions by
using my_htobeN/my_betohN and memcpy.