Console View

Categories: connectors experimental galera main

Legend:

Passed

Failed

Warnings

Failed Again

Running

Exception

Offline

No data

connectors

experimental

galera

main

fa723683b02b...

fa723683b02b450a1c221b9ac60993d8de004aa7

Raghunandan Bhat

raghunandan.bhat96@gmail.com

MDEV-39559: Assertion `b` failed in `my_strnncoll_xxxx_nopad_ci`

Problem:
When verifying a `UNIQUE` constraint over an empty BLOB/TEXT column,
`Field_blob::cmp(a_ptr, b_ptr)` extracts a NULL data pointer (with
length 0) from the record slot and forwards it to the charset-level
comparison, which asserts non-NULL pointers (added in MDEV-35717).

A zero-length blob is allowed to have a NULL data pointer in its
record slot; `Field_blob::val_decimal()` already treats (NULL, 0) as
an empty value. The comparison paths missed that substitution.

Fix:
- In `Field_blob::cmp(a_ptr, b_ptr)`and
`Field_blob::key_cmp(key_ptr, max_key_length)`, substitute "" for a
NULL data pointer before delegating to the comparison.
- Add a debug assert in each of the above functions to document the
invariant that a NULL pointer is only valid alongside zero length
and (NULL, length>0) is invalid.

f80219f1ffad...

f80219f1ffade1ec861b25b5da7b837f94f09889

Sergei Golubchik

serg@mariadb.org

MDEV-39292 fix incorrect merge

f63689c3ad5d...

f63689c3ad5dd954ce8f36b8758ea3dd39e07365

Thirunarayanan Balathandayuthapani

thiru@mariadb.com

- Handled other maribackup commands

f139e207175b...

f139e207175b5bbb9f8f0bc24227c61379746218

Jan Lindström

jan.lindstrom@mariadb.com

MDEV-40027 : Galera Cluster-peer > Donor command execution

An appropriately privileged user (with SUPER privileges) could
execute shell commands as the uid of the mariadbd process
because the values of the system variable wsrep_sst_auth,
which can be modified at runtime, were not properly
sanitized when used to construct a shell command.

Combined rsync and mariabackup test cases and added
test case for incorrect values for wsrep_sst_auth.

eccdef627382...

eccdef627382b7b1f5338450ba328d16216c4fa2

Kristian Nielsen

knielsen@knielsen-hq.org

Post-merge fix

Signed-off-by: Kristian Nielsen <[email protected]>

d8d8f8a624ac...

d8d8f8a624acf842343ea352a886deaba07cd144

Mohammad Tafzeel Shams

tafzeel.shams@mariadb.com

MDEV-26123: Always mark spatial index reads as locking

A SELECT query could fail with ER_READ_ONLY_TRANSACTION when search
on spatial index is done after search on non-spatial index.

R-tree index search always require page locks. Previously,
trx->will_lock was only set for spatial indexes when the transaction
had not yet been started. If a transaction was already active due to
a prior non-spatial index access, index_read() for spatial index
returned HA_ERR_READ_ONLY_TRANSACTION instead of marking the transaction
as locking.

Fix:
- ha_innobase::index_read() : Set trx->will_lock unconditionally for
spatial index, ensuring that R-tree searches can acquire the required
page locks regardless of transaction state.

d8984aab2598...

d8984aab2598989ae5f700fd154a3a243f8ef36c

Thirunarayanan Balathandayuthapani

thiru@mariadb.com

MDEV-39061 mariadb-backup compatible wrapper for BACKUP SERVER

scripts/mariabackup/mariabackup.sh: a drop-in, mariadb-backup
compatible POSIX sh wrapper that drives the server-side BACKUP
SERVER command, so existing mariadb-backup invocations keep working
without changing user scripts.

--backup translates into "BACKUP SERVER TO '<dir>'" over the mariadb
client, forwarding connection options; --parallel=N becomes the "<N> CONCURRENT" clause.
After a successful backup the wrapper writes backup-prepare.cnf into
the target directory, recording the running server's mariadbd path and
InnoDB layout (page size, data file path, undo tablespaces, checksum algorithm,
log file size). When the server is encrypted it also records how to reload
the key-management plugin (plugin name, key-file path, algorithm).

--prepare runs mariadbd --bootstrap on the backup with
backup-prepare.cnf as its defaults file, replays the archived redo
over the [recovery_start, recovery_target] window read from
backup.cnf, then replaces the archived log with a freshly built
circular ib_logfile0 so an ordinary server can start on the directory.

--copy-back / --move-back place a prepared backup into the datadir
with cp / mv, create the datadir if missing, refuse a non-empty
datadir unless --force-non-empty-directories is given, and print the
post-restore chown reminder.

wrapper with these options are not supported yet
--incremental backup/prepare,
--apply-log-only,
--rollback-xa,
partial backup (--databases/--tables, which would need server-side backup_include/backup_exclude),
and output streaming/compression/encryption.

--export is accepted but warns and runs a plain recovery.

extra/mariabackup/CMakeLists.txt: install the wrapper as
mariadb-backup-server behind a new WITH_MARIABACKUP_WRAPPER option (OFF by default)

scripts/mariabackup/README.md documents the modes, the unsupported
options, and the backup.cnf / backup-prepare.cnf formats.

include/have_mariabackup_wrapper.inc redirects $XTRABACKUP to the
wrapper so a test opts in by sourcing one file, skipping when the
wrapper, sh, or the mariadb client is unavailable.

include/have_mariabackup_combination.inc runs a test under both the
[OLD] mariadb-backup binary and the [NEW] wrapper

d1693276d534...

d1693276d5344ba794805e8b5902aaff61edb77f

Sergei Golubchik

serg@mariadb.org

MDEV-40059 too long character_set_collations crash

cc02edb088e9...

cc02edb088e9b0f97acf84e326415cc70d54a7b5

Raghunandan Bhat

raghunandan.bhat96@gmail.com

MDEV-39744: Assertion `buf != end` failed in `decimal_mul`

Problem:
With `div_precision_increment=0`, a division whose quotient rounds
away to zero (e.g. -299/450) produced a decimal with no digit words
(intg=0 and frac=0) while still keeping the sign bit set. That is a
malformed value.

Multiplying such a malformed zero value by another zero reached the
negative-zero check in `decimal_mul`, where there were no digit words
to scan, leading to assertion failure.

Fix:
Fix `do_div_mod`, which produced the malformed zero. `do_div_mod`
already normalizes this case to a canonical zero on the modulo path;
do the same on the division path: when the quotient has no digits
(intg0 = 0 && frac0 = 0) return a correct decimal zero instead of a
digit-less, signed value.

c8f382faa795...

c8f382faa795c6e64dd3514586b2b8e191b57db3

drrtuy

drrtuy@gmail.com

disable sfinae-incomplete warning for DuckDB code.

bbd558c38616...

bbd558c38616ce24bd2973486763c2a7c4db0969

forkfun

alice.sherepa@gmail.com

Merge branch '10.11' into '11.4'

bb269e7e5cec...

bb269e7e5cec7a5a95e97cf9e711ca9b726df205

forkfun

alice.sherepa@gmail.com

Merge branch '11.4' into '11.8'

bb0874867f0b...

bb0874867f0b0b8d4762ce89025e6827b8518715

Mohammad Tafzeel Shams

tafzeel.shams@mariadb.com

b9809c07b412...

b9809c07b412456b194ab342e26d6432e85edf09

Kristian Nielsen

knielsen@knielsen-hq.org

Document the correct use of replication terminology

Signed-off-by: Kristian Nielsen <[email protected]>

a22154c00712...

a22154c0071227459794ed6423e6768e34bcb7c7

PranavKTiwari

pranav.tiwari@mariadb.com

MDEV-38988: Assertion failure in Protocol::end_statement or lack of warning upon query with INTERSECT and LIMIT ROWS EXAMINED

Problem:
LIMIT ROWS EXAMINED sets ABORT_QUERY, but in set operations (EXCEPT ALL / INTERSECT) this was incorrectly treated as a fatal saved_error, causing early exit from exec_inner(). This skipped fake_select and left Diagnostics_area uninitialized, leading to Protocol::end_statement() assertion failure.

Cause:
saved_error triggered goto err without considering that ABORT_QUERY is a recoverable stop condition intended to return partial results with a warning.

Fix:
Treat ABORT_QUERY as non-fatal in set-operation execution, allowing normal completion path (fake_select, DA finalization, protocol end) to run and return partial results correctly.

93ca62ca5fcb...

93ca62ca5fcb5a53e6052d44e830279171c41d51

Marko Mäkelä

marko.makela@mariadb.com

Fix streaming backup

8b27beead627...

8b27beead6277f1fc15a750f7c226be3761e14cc

Jan Lindström

jan.lindstrom@mariadb.com

MDEV-40056 : Analyze Galera Dynamic Variables Susceptible to RCEs

Fix potential issue with wsrep_node_address by allowing
only correctly constructed address.

867d16cea744...

867d16cea74450d2cd331f9e8d6564bd70c6fe13

forkfun

alice.sherepa@gmail.com

Merge branch '11.4' into '11.8'

85ec122c15b7...

85ec122c15b76ded6c384e06b6d6116e51d3de8f

Kristian Nielsen

knielsen@knielsen-hq.org

Merge 10.11 to 11.4

Signed-off-by: Kristian Nielsen <[email protected]>

82cc6f32b8fb...

82cc6f32b8fbd4a190159d5a7139afc052b52154

Monty

monty@mariadb.org

MDEV-25292 Atomic CREATE OR REPLACE TABLE

Atomic CREATE OR REPLACE allows to keep an old table intact if the
command fails or during the crash. That is done by renaming the
original table to temporary name, as a backup and restoring it if the
CREATE fails. When the command is complete and logged the backup
table is deleted.

Atomic replace algorithm

Two DDL chains are used for CREATE OR REPLACE:
ddl_log_state_create (C) and ddl_log_state_rm (D).

1. (C) Log rename of ORIG to TMP table (Rename TMP to original).
2. Rename orignal to TMP.
3. (C) Log CREATE_TABLE_ACTION of ORIG (drops ORIG);
4. Do everything with ORIG (like insert data)
5. (D) Log drop of TMP
6. Write query to binlog (this marks (C) to be closed in
case of failure)
7. Execute drop of TMP through (D)
8. Close (C) and (D)

If there is a failure before 6) we revert the changes in (C)
Chain (D) is only executed if 6) succeded (C is closed on
crash recovery).

Foreign key errors will be found at the 1) stage.

Additional notes

- CREATE TABLE without REPLACE and temporary tables is not affected
by this commit.
set @@drop_before_create_or_replace=1 can be used to
get old behaviour where existing tables are dropped
in CREATE OR REPLACE.

- CREATE TABLE is reverted if binlogging the query fails.

- Engines having HTON_EXPENSIVE_RENAME flag set are not affected by
this commit. Conflicting tables marked with this flag will be
deleted with CREATE OR REPLACE.

- Replication execution is not affected by this commit.
- Replication will first drop the conflicting table and then
creating the new one.

- CREATE TABLE .. SELECT XID usage is fixed and now there is no need
to log DROP TABLE via DDL_CREATE_TABLE_PHASE_LOG (see comments in
do_postlock()). XID is now correctly updated so it disables
DDL_LOG_DROP_TABLE_ACTION. Note that binary log is flushed at the
final stage when the table is ready. So if we have XID in the
binary log we don't need to drop the table.

- Three variations of CREATE OR REPLACE handled:

1. CREATE OR REPLACE TABLE t1 (..);
2. CREATE OR REPLACE TABLE t1 LIKE t2;
3. CREATE OR REPLACE TABLE t1 SELECT ..;

- Test case uses 6 combinations for engines (aria, aria_notrans,
myisam, ib, lock_tables, expensive_rename) and 2 combinations for
binlog types (row, stmt). Combinations help to check differences
between the results. Error failures are tested for the above three
variations.

- expensive_rename tests CREATE OR REPLACE without atomic
replace. The effect should be the same as with the old behaviour
before this commit.

- Triggers mechanism is unaffected by this change. This is tested in
create_replace.test.

- LOCK TABLES is affected. Lock restoration must be done after new
table is created or TMP is renamed back to ORIG

- Moved ddl_log_complete() from send_eof() to finalize_ddl(). This
checkpoint was not executed before for normal CREATE TABLE but is
executed now.

- CREATE TABLE will now rollback also if writing to the binary
logging failed. See rpl_gtid_strict.test

backup ddl log changes

- In case of a successfull CREATE OR REPLACE we only log
the CREATE event, not the DROP TABLE event of the old table.

ddl_log.cc changes

ddl_log_execute_action() now properly return error conditions.
ddl_log_disable_entry() added to allow one to disable one entry.
The entry on disk is still reserved until ddl_log_complete() is
executed.

On XID usage

Like with all other atomic DDL operations XID is used to avoid
inconsistency between master and slave in the case of a crash after
binary log is written and before ddl_log_state_create is closed. On
recovery XIDs are taken from binary log and corresponding DDL log
events get disabled. That is done by
ddl_log_close_binlogged_events().

On linking two chains together

Chains are executed in the ascending order of entry_pos of execute
entries. But entry_pos assignment order is undefined: it may assign
bigger number for the first chain and then smaller number for the
second chain. So the execution order in that case will be reverse:
second chain will be executed first.

To avoid that we link one chain to another. While the base chain
(ddl_log_state_create) is active the secondary chain
(ddl_log_state_rm) is not executed. That is: only one chain can be
executed in two linked chains.

The interface ddl_log_link_chains() was defined in "MDEV-22166
ddl_log_write_execute_entry() extension".

Atomic info parameters in HA_CREATE_INFO

Many functions in CREATE TABLE pass the same parameters. These
parameters are part of table creation info and should be in
HA_CREATE_INFO (or whatever). Passing parameters via single
structure is much easier for adding new data and
refactoring.

InnoDB changes
Added ha_innobase::can_be_renamed_to_backup() to check if
a table with foreign keys can be renamed.

Aria changes:
- Fixed issue in Aria engine with CREATE + locked tables
that data was not properly commited in some cases in
case of crashes.

Other changes:
- Removed some auto variables in log.cc for better code readability.
- Fixed old bug that CREATE ... SELECT would not be able to auto repair
a table that is part of the SELECT.
- Marked MyISAM that it does not support ROLLBACK (not required but
done for better consistency with other engines).

Known issues:
- InnoDB tables with foreign key definitions are not fully supported
with atomic create and replace:
- ha_innobase::can_be_renamed_to_backup() can detect some cases
where InnoDB does not support renaming table with foreign key
constraints. In this case MariaDB will drop the old table before
creating the new one.
The detected cases are:
- The new and old table is using the same foreign key constraint
name.
- The old table has self referencing constraints.
- If the old and new table uses the same name for a constraint the
create of the new table will fail. The orignal table will be
restored in this case.
- The above issues will be fixed in a future commit.
- CREATE OR REPLACE TEMPORARY table is not full atomic. Any conflicting
table will always be dropped before creating a new one. (Old behaviour).

Bug fixes related to this MDEV:

MDEV-36435 Assertion failure in finalize_locked_tables()
MDEV-36439 Assertion `thd_arg->lex->sql_command != SQLCOM_CREATE_SEQUENCE...
MDEV-36498 Failed CoR in non-atomic mode no longer generates DROP in RBR...
MDEV-36508 Temporary files #sql-create-....frm occasionally stay after
crash recovery
MDEV-38479 Crash in CREATE OR REPLACE SEQUENCE when new sequence cannot
be created
MDEV-36497 Assertion failure after atomic CoR with Aria under lock in
transactional context
MDEV-36501 EITS data is lost after failed attempt to CREATE OR REPLACE
table
MDEV-36493 Atomic CREATE OR REPLACE ... SELECT blocks InnoDB purge
MDEV-39367 MSAN/valgrind errors in temp_file_size_cb_func,
main.tmp_space_usage fails
MDEV-39446 Atomic CREATE OR REPLACE fails if a table cannot be decrypted

InnoDB related changes:
- ha_innodb::rename_table() does not handle foreign key constraint
when renaming an normal table to internal tempory tables. This
causes problems for CREATE OR REPLACE as the old constraints causes
failure when creating a new table with the same constraints.
This is fixed inside InnoDB by not threating tempfiles (#sql-create-..),
created as part of CREATE OR REPLACE, as temporary files.
- In ha_innobase::delete_table(), ignore checking of constraints when
dropping a #sql-create temporary table.
- In tablename_to_filename() and filename_to_tablename(), don't do
filename conversion for internal temporary tables (#sql-...)

Other things:
- maria_create_trn_for_mysql() does not register a new transaction
handler for commits. This was needed to ensure create or replace
will not end with an active transaction.
- We do not get anymore warnings about "Engine not supporting atomic
create" when doing a legal CREATE OR REPLACE on a table with
foreign key constraints.
- Updated VIDEX engine flags to disable CREATE SEQUENCE.

Reverted commits:
MDEV-36685 "CREATE-SELECT may lose in binlog side-effects of
stored-routine" as it did not take into account that it safe to clear
binlogs if the created table is non transactional and there are no
other non transactional tables used.
- This was done because it caused extra logging when it is not needed
(not using any non transactional tables) and it also did not solve
side effects when using statement based loggging.

Other things:
- EITS data is preserved if create or replace fails if
drop_before_create_or_replace=OFF. If ON, then create or replace
will drop EITS before the drop of the original table (as before).
- Using CREATE OR REPLACE on a encrypted table that the user cannot
decrypt will fail instead of replacing the encrypted table.
The encrypted table will unchanged.

821fe49dbbb2...

821fe49dbbb29235f721ebdfbefad17002f0272c

Vladislav Vaintroub

vvaintroub@gmail.com

MDEV-40001 my_sync() does not use NtFlushBuffersFileEx()

Copy the logic from Innodb. Use a fallback to FlushFileBuffers(), if
NtFlushBuffersFileEx() fails.

my_winfile.c is renamed to my_winfile.cc, since it is using a C++ feature,
initialization of global variable using non-constant expression.
Exported functions remain extern "C"

7fc6fce20dbb...

7fc6fce20dbb89b04af77bee540e4451a6a7c9c6

Sergei Golubchik

serg@mariadb.org

update CODING_STANDARDS.md for agent era

* moved human-oriented hopefully eventually consistent codiing style
document to https://mariadb.org/about/coding-style/
* rewrote the document in an agent friendly way: main rule first,
don't repeat rules that the agent would follow by default anyway,
highlight differences with the defaults, don't overdo explaining.
* asked claude to look through sql/ and mysys/ extract common patterns and
add them here as rules

7defdb4c856a...

7defdb4c856a77fb09371084d747739bd0674c90

PranavKTiwari

pranav.tiwari@mariadb.com

MDEV-36990: SIGFPE in get_max_range_rowid_filter_elems_for_table

Problem:
ALTER TABLE allowing a column defined as BINARY(0) to be used as part of a PRIMARY KEY or UNIQUE KEY can lead to a zero-length index column. This results in tab->file->ref_length becoming 0 inside the storage engine, which later causes a division-by-zero crash in get_max_range_rowid_filter_elems_for_table() during optimizer cost estimation for range queries.

Cause:
During key initialization in init_key_part_spec(), validation relied on column->flags & NOT_NULL_FLAG to detect non-nullable key columns. However, in ALTER TABLE ... CHANGE COLUMN, the Create_field is only partially initialized and does not yet propagate implicit constraints such as PRIMARY KEY ⇒ NOT NULL. As a result, NOT_NULL_FLAG may be 0 even for primary key columns, allowing key_part_length == 0 cases to bypass validation.

This leads to invalid index definitions where a primary key column contributes zero bytes to the index.

Fix:
Strengthen key validation in init_key_part_spec() by rejecting zero-length
key parts for columns that are effectively non-nullable in key context,
including PRIMARY KEY columns whose implicit NOT NULL property may not yet
be reflected in Create_field::flags during ALTER TABLE processing.

This prevents creation of invalid zero-length index definitions and avoids
propagation of ref_length=0 metadata that can later trigger optimizer
crashes.

796690c30845...

796690c308459dc9c72d106d322c2489dcc7777c

Daniel Black

daniel@mariadb.org

MDEV-39585: Support SHUTDOWN command on Windows in bootstrap

Don't perform mysqld_win_initiate_shutdown under --bootstrap when
triggered by SHUTDOWN. With this we don't perform any service
interactions.

Then the shutdown can proceeded without then hard process termination
in mysqld_win_initiate_shutdown. This previously occurred because the
handle_connections_win() was never called in --bootstrap and therefore
startup_complete() was false.

Thanks Vladislav Vaintroub for investigation and providing
implementation guidance.

763cc4077510...

763cc40775102116b93c85c6a6e8f6d14447d1f2

bsrikanth-mariadb

srikanth.bondalapati@mariadb.com

MDEV-21735: Wrong result with prefix indexes using rocksdb

Rows are missing from the output when searching by indexed text column
when the value is longer than the index's prefix length.
Using "like 'prefix%'" only works when the prefix is shorter than the
index's length (or equal, if value=prefix).
The issue seems to only happen when using utf8/utf8mb4/utf16/utf32 collations.
However, latin1/ascii/ucs2 collations work correctly.

For non-working collations, the mem-comparable buffer created for values
put into the index and the one read from the index are different.

When buffer is being filled with binary form data, the length, and
weights arguments are set to the same value for strnxfrm() when invoked
from Field_blob::sort_string(). Since weights are set to a larger value, we
fill space with unnecessary data in the buffer, and hence
the buffer comparison fail.

Solution
--------
Set the weights argument to length/charset::mbmaxlen() value, which is
what was being done in other types such as Field_varstring, as well as
other methods in Field_blob.

647f8e34c0af...

647f8e34c0af812ef59ed8b3e4ca5692bc942959

Daniel Black

daniel@mariadb.org

MDEV-39585 mariadb bootstrap fails to perform plugin deinitalization

mariadbd under --bootstrap failed to preform plugin deinitialization.

The sleep(2);exit is removed and replaced to a goto termination label
to perform the same shutdown procedure of the server after all the
connection closing.

To prevent a compile error about char *user being uninitialized
this sql_print_information(ER_DEFAULT(ER_NORMAL_SHUTDOWN)) is moved to
its own block. The memory free did need to occur in the bootstrap mode
too to avoid memory leak errors.

wait_for_signal_thread_to_end(), was previously in close_connections()
however its required too for --bootstrap.

4ec1ff493ea8...

4ec1ff493ea8da5867f9763b2ee4ef70684e4d80

drrtuy

drrtuy@gmail.com

chore: avoid building DuckDB at x86_32.

4eaf03492dab...

4eaf03492dab7fa8dfe71e2b0b16e533e6948876

Marko Mäkelä

marko.makela@mariadb.com

fixup! 93ca62ca5fcb5a53e6052d44e830279171c41d51

Fix streaming backup for Microsoft Windows

420e28ce2846...

420e28ce2846e8a4050b1c01dc9e135206b428cc

Kristian Nielsen

knielsen@knielsen-hq.org

Merge 11.4 to 11.8

Signed-off-by: Kristian Nielsen <[email protected]>

40a31a4a6997...

40a31a4a6997bcb3af8d41e8f93ce233c5490126

Daniel Black

daniel@mariadb.org

MDEV-39541 mem_pressure::~mem_pressure() causes a crash on bootstrap

Fill in the anomaly shutdown paths of InnoDB to include call to
buf_mem_pressure_shutdown now that MDEV-39585 provides some
proper calls shutdown InnoDB and other plugins during the shutdown
under --bootstrap.

Alternate: destructor attribute on buf_mem_pressure_shutdown would
acheive the same thing and given Linux compilers are capabile of
this. This is possible as mem_pressure is currently implemented
in Linux onny.

3c684f1e6942...

3c684f1e694281a48c257496f09ccc61dde960fc

Oleg Smirnov

olernov@gmail.com

MDEV-36344: UBSAN Lifo_buffer::have_space_for change

Adjust Lifo_buffer::have_space_for to not lead itself to UBSAN
overflows.

29e43967f4f2...

29e43967f4f2c1a1d4af3372354bd203b8418152

Sergei Golubchik

serg@mariadb.org

only check for duckdb stuff if target duckdb is enabled

295697c29cd6...

295697c29cd6472470d7e816ae3cc1a4fe797ae3

Alexey Botchkov

holyfoot@askmonty.org

MDEV-36261 XMLTYPE: methods - step 1

Method functions added to the XMLTYPE.

1fcb44ecd6c4...

1fcb44ecd6c4e3a2595b749e758a335793271319

Thirunarayanan Balathandayuthapani

thiru@mariadb.com

- Added rr trace and renamed mysqld to mariadb client

1fb075512a7a...

1fb075512a7aeab8646a163cbb6f265c49f4c075

Sergei Golubchik

serg@mariadb.org

refactor submodule.cmake to fetch less

don't update all submodules automatically,
only update those that are actually used by the build

0d59c434fab0...

0d59c434fab044ad5a28e24c5608959da14e5b0b

Oleksandr Byelkin

sanja@mariadb.com

Merge branch '10.6' into 10.11

0cb2cc959eb4...

0cb2cc959eb4ecaed42deadb5eb93e13dd6835e3

Dmitry Shulga

dmitry.shulga@mariadb.com

MDEV-40004: Server crashes in sp_head::register_instr_mem_root_for_deallocation upon shutdown

n shutdown server could crash in case triggers executed during server run
and some of triggers instructions were re-compiled.

The crash is caused by attempt to allocate a memory for storing pointers
on mem_roots used for memory allocation taken place on re-parsing failing
trigger's statements. The reason of crash is dereferencing of nullptr
returning by the function current_thd().

To fix the issue, use dummy THD on shutdown the table definition cache.
tdc_start_shutdown() is solely invoked from the function clean_up()
but the later is called from many places around the source code, not only
from mysql_main(), particularly clean_up() is called from unireg_abort().
Therefore, the extra argument added into the signature of the function
cleanup() to allow explicit request of use dummy THD on shutdown the table
definition cache.

0bf0e13a2238...

0bf0e13a2238a97593feda1fea133340861c0736

Sergei Golubchik

serg@mariadb.org

MDEV-40058 cached_sha2_password crashes on zero-length password

valid encrypted password cannot have zero length and must end with '\0'

0b6edbe865c7...

0b6edbe865c7d05b0c9922d308953f3f20b8b443

Mohammad Tafzeel Shams

tafzeel.shams@mariadb.com

087a948e2e46...

087a948e2e4620901d2c358b46907a15b0987059

Daniel Black

daniel@mariadb.org

MDEV-36344: UBSAN DsMrr_impl::dsmrr_init on null ptr

Under SQL_SELECT::test_quick_select there isn't
a mrr buffer. The TRP_RANGE.mrr_buf_size is explictly
sets its size to 0 in get_best_index_intersect.

Rather than hit undefined behaviour in what
eventually results in full_buf being nullptr,
jump the case and go directly to use_default_impl.