Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
fb0564a61dd1...
fb0564a61dd12856939f6ebd8e8ad956c30f0241
Dave Gosselin
MDEV-38136: Prevent elimination of tables in a FULL OUTER JOIN

Prevent elimination of tables participating in a FULL OUTER JOIN during
eliminate_tables as part of phase one FULL OUTER JOIN development.

Move the functionality gate for FULL JOIN further into the codebase: convert
LEX::has_full_outer_join to a counter so we can see how many FULL JOINs
remain which makes the gate work correctly after simplify_joins and
eliminate_tables are called.

Fixes an old bug where, when running the server as a debug build and in
debug mode, a null pointer deference in
Dep_analysis_context::dbug_print_deps would cause a crash.
f7b947fe8e50...
f7b947fe8e5078b06dec22fab2a762812ae410f0
Dave Gosselin
MDEV-38508: Constant table detection

If a table that's in a FULL OUTER JOIN is found to be a const
table, then don't allow the constant table optimization to
take place.

Later, when we support FULL OUTER JOIN on the inner side of
other join types then we may be able to relax this restriction.
ea00d4c2cf02...
ea00d4c2cf02dd4883ad96a5bb410c5599797c65
ParadoxV5
MDEV-39788 CHANGE MASTER savefiles read and write one line to many

The MDEV-37530 refactor missed the detail that the line counts in
`@@master_info_file` and `@@relay_log_info_file`
also counted the line-count line itself.
Consequently, although fresh 12.3 installations
and downgrades to earlier versions are unaffected,
upgrades from pre-12.3 will encounter surprises when
the 12.3 upgrade tries to read and discard the extra line:
* `master_use_gtid` is reset to DEFAULT.
* `@@relay_log_info_file` fails to load
  unless its data has previously shrunk.

Since downgrading remained compatible,
this commit fixes this content difference by correcting
the code to read and write one fewer (unused) line.

Reviewed-by: Brandon Nesterenko <[email protected]>
e9ad943bc7d8...
e9ad943bc7d83abebe8bdd4b561297658f217d1b
Vladislav Vaintroub
x
e64544e63ce6...
e64544e63ce671872e34f336864915c01f5f8b19
ParadoxV5
Merge branch 'MDEV-39788.test' into MDEV-39788
df587c18a2a9...
df587c18a2a9cef6048048f24fc6c2b28a60a370
ParadoxV5
whoops. (RIP our CI today)
d870b3b1d297...
d870b3b1d297819307486ee7458e6af9f4ebcfa5
Dave Gosselin
MDEV-38692: COALESCE() on NATURAL FULL JOIN result sets

FULL JOIN yields result sets with columns from both tables participating in
the join (for the sake of explanation, assume base tables).  However,
NATURAL FULL JOIN should show unique columns in the output.

Given the following query:
  SELECT * FROM t1 NATURAL JOIN t2;
transform it into:
  SELECT COALESCE(t1.f_1, t2.f_1), ..., COALESCE(t1.f_n, t2.f_n) FROM
    t1 NATURAL JOIN t2;

This change applies only in the case of NATURAL FULL JOIN.  Otherwise,
NATURAL JOINs work as they have in the past, which is using columns
from the left table for the resulting column set.
cef52e226947...
cef52e2269473606440f605d03cb3793e43ae415
ParadoxV5
fixup

use RESET SLAVE ALL in case other tests restart the server without
specifying `--skip-slave-start` (why not default in MTR I do not know)
ce76ee593fd7...
ce76ee593fd7cac5a329d1a41dc6f80a9a699649
Vladislav Vaintroub
MDEV-14443 - address some review comments

Make sure deny_entry_to_json does not fail in memory allocation,
by providing StringBuffer with a large enough statically allocated
size DENY_JSON_ENTRY_BUFSIZE, currently 1230 bytes.

update_deny_entry() - handle json.append() errors
c81142705caa...
c81142705caa3fa3e3313c5caf437fde9a73df2a
Dave Gosselin
MDEV-37932: Parser support FULL OUTER JOIN syntax

Syntax support for FULL JOIN, FULL OUTER JOIN, NATURAL FULL JOIN, and
NATURAL FULL OUTER JOIN in the parser.

While we accept full join syntax, such joins are not yet supported.
Queries specifying any of the above joins will fail with
ER_NOT_SUPPORTED_YET.
c0e48fc966d3...
c0e48fc966d3d3926bade68c7c5bfdb9fe88ad3a
Marko Mäkelä
WIP MDEV-39092, and back up non-InnoDB files
bc425df9bca0...
bc425df9bca03c19b2ae0e55dde3d56d02801b8f
Dave Gosselin
MDEV-39746: FULL JOIN with a nested join on the right loses rows

The outermost FULL JOIN's right operand can be a nested join rather
than a single base table.  The parser places the nest on the right
when the outermost FULL JOIN's ON is the last one written, because the
parser keeps the outermost FULL JOIN pending until its ON arrives, and
the inner FULL JOINs reduce first into a nest that becomes the right
operand.
alloc_full_join_duplicate_filters allocates the fj_dups filter on a
JOIN_TAB carrying JOIN_TYPE_FULL | JOIN_TYPE_RIGHT, so with the
FULL|RIGHT bits on the nest, which is never a JOIN_TAB, no filter was
allocated and the null complement pass never fired.  The unmatched
rows from the right side were never emitted, producing a result with
missing rows.

Add swap_full_join_sides, called from rewrite_full_outer_joins
when a FULL JOIN survives simplify_joins with a leaf on the left
and a nested join on the right.  FULL JOIN is symmetric on its
operands, so swapping does not change query semantics; after the
swap the leaf carries the FULL|RIGHT bits and the rescan target
is a single base table.
b6921bbfb07d...
b6921bbfb07d37ead22a0697499fe1c753896ef6
ParadoxV5
Test for MDEV-39788

MDEV-39788 found that the recent refactor on the `main` (now 12.3)
branch forgot that the line count includes the line count line itself.
This test checks future changes in any supported
version that they don’t make this mistake again.
aa474c5eff48...
aa474c5eff4864d88535b1155cc9931769b2f36c
Vladislav Vaintroub
x
aa16156a4f58...
aa16156a4f58fc4d2cfa603aa5e97db73a2137a5
Dave Gosselin
Reject a nested join on the right of a rewritten FULL JOIN

check_full_join_base_tables runs before simplify_joins and rejects the
disallowed FULL JOIN shapes that are visible in the parse tree.
simplify_joins can rewrite a FULL JOIN to a LEFT, RIGHT, or INNER
JOIN, so sometimes disallowed queries appear only afterward.

Add check_full_join_after_simplify, called from optimize_inner once
simplify_joins is done, to reject unsupported queries after
rewrite by simplify_joins.
96fdceaa02ac...
96fdceaa02acd29893f0e095fd6ec9c3df9718cb
Dave Gosselin
MDEV-37933: Rewrite [NATURAL] FULL OUTER to LEFT, RIGHT, or INNER JOIN

Rewrite FULL OUTER JOIN queries as either LEFT, RIGHT, or INNER JOIN
by checking if and how the WHERE clause rejects nulls.

For example, the following two queries are equivalent because the
WHERE condition rejects nulls from the left table and allows matches
in the right table (or NULL from the right table) for the remaining
rows:

  SELECT * FROM t1 FULL JOIN t2 ON t1.v = t2.v WHERE t1.v IS NOT NULL;
  SELECT * FROM t1 LEFT JOIN t2 ON t1.v = t2.v;

  SELECT * FROM t1 FULL JOIN t2 ON t1.v = t2.v WHERE t1.a=t2.a;
  SELECT * FROM t1 INNER JOIN t2 ON t1.v = t2.v WHERE t1.a=t2.a;
903e00b624c3...
903e00b624c3c2a3a06696a9996a84e0f16445e5
Jan Lindström
MDEV-39783 : Galera test failure on MDEV-35018

Test did echo wsrep_apply_waits+1 value, but this value
is dependent what was value of the wsrep_apply_waits when
test started. If previous test run by same worker
increased the value of wsrep_apply_waits, expected
value 1 in result file would be different than current
value. Removed output as it does not give any real value,
because test already has wait_condition for expected
increase of wsrep_apply_waits value.
875fc068e4f5...
875fc068e4f584a7527fff0c454c0453ee9afc74
Dave Gosselin
MDEV-39569: Skip FULL JOIN rewrite to inner side of an outer join

Prevent simplify_joins from rewriting a chained FULL JOIN into a query
where a FULL JOIN could end up on the inner side of another outer
join.  Of course, this means that we will have a null complement pass
that the rewritten query would have avoided.  Once we support FULL
JOINs on the inner side of outer joins, in phase 3, then we can relax
this constraint.
7fdd381cf67e...
7fdd381cf67e0aee48d3a418a986ab8f12f56fdb
ParadoxV5
Merge branch 'MDEV-39788.test' into MDEV-39788
7f207a291cb8...
7f207a291cb8b9903c08a05b0daa0a7eb90c3921
Marko Mäkelä
WIP MDEV-14992 BACKUP SERVER

This introduces a basic driver Sql_cmd_backup, storage engine interfaces,
and basic copying of InnoDB data files.
On Windows, we pass a target directory name; elsewhere, we pass a
target directory handle.

backup_target: A structured data type to represent a directory or a
stream. On Microsoft Windows, we must use directory paths because
there is no variant of CopyFileEx() that would work on file handles.

copy_entire_file(): A file copying service for POSIX systems.

copy_file(): A sparse file-copying service for POSIX systems.

backup_context: An InnoDB backup context, attached to trx->lock.backup
so that context can exist between InnoDB_backup::end(), which is
releasing all locks, and InnoDB_backup::fini() in the same thread,
which is expected to finalize the backup without modifying files
in the server data directory.

fil_space_t::write_or_backup: Keep track of in-flight page writes and
pending backup operation. We must not allow them concurrently, because
that could lead into torn pages in the backup.

fil_space_t::backup_end: The first page number that is not being backed up
(by default 0, to indicate that no backup is in progress).

TRX_STATE_BACKUP: A special InnoDB transaction state indicating association
with BACKUP SERVER, which allows us to pass some context in trx_t from
innodb_backup_end() to innodb_backup_finalize().

log_t::backup: Whether BACKUP SERVER is in progress. The purpose of this
is to make BACKUP SERVER prevent the concurrent execution of
SET GLOBAL innodb_log_archive=OFF or SET GLOBAL innodb_log_file_size
when innodb_log_archive=OFF.

log_sys.archived_checkpoint: Keep track of the earliest available
checkpoint, corresponding to log_sys.archived_lsn. This reflects
SET GLOBAL innodb_log_recovery_start (which is settable now), for
incremental backup.

buf_flush_list_space(): Check for concurrent backup before writing each
page. This is inefficient, but this function may be invoked from multiple
threads concurrently, and it cannot be changed easily, especially for
fil_crypt_thread().
78ac3f84e043...
78ac3f84e04310aaef4b54dd5ad24994f408600d
ParadoxV5
ye smol problem with test-result pairs is that it’s easy to forget to update the result
78607229a44d...
78607229a44d4d27c31e483b54d036a492ddd621
ParadoxV5
Merge branch 'MDEV-39788.test' into MDEV-39788
7696f3d7b9d5...
7696f3d7b9d572c51e9f3c62ed6b4d830a615a81
forkfun
MDEV-24557 mariadb-dump: translate MySQL 8.x user/grant syntax for MariaDB import

  mariadb-dump --system=users (and --system=all) can now capture a
  MySQL 8.0+ source and emit the users, roles and grants as statements
  that load on MariaDB. The dump targets MariaDB only (migration is
  one-way), so each statement is emitted once, in MariaDB form.

  - privileges: mapped to a MariaDB equivalent where one exists
    (e.g. BINLOG_ADMIN -> BINLOG REPLAY, BINLOG ADMIN), otherwise dropped
    with a # WARNING;
  - CREATE USER clauses, that MariaDB has no equivalent for (PASSWORD HISTORY,
    PASSWORD REUSE INTERVAL, DEFAULT ROLE, ...): dropped;
  - auth plugins, that MariaDB does not ship (e.g. sha256_password): the
    IDENTIFIED clause is dropped and the account is forced ACCOUNT LOCK;
  - roles and the role-admin hierarchy, default roles, and partial
    REVOKE (no MariaDB equivalent -> # WARNING).
73265e655c9b...
73265e655c9ba6d57faefc02cc5b65e7ef65a57e
Dave Gosselin
Update table_elim for FULL JOIN base table check

Two EXPLAIN queries in table_elim place a nested join on the right
side of a FULL JOIN.  Phase 2 supports only base tables there, so
check_full_join_base_tables rejects them with
ER_FULL_JOIN_BASE_TABLES_ONLY.
6ec59dcc0a1c...
6ec59dcc0a1c09530c16b57f8d63f38cb9d2c53a
Sergei Petrunia
[No MDEV#] Invalid conversion is done when reading JSON

When reading JSON strings. we call json_unescape_to_string()
with a StringBuffer with "binary" charset.

That causes conversion from utf8mb4 (data in JSON is in this
charset) to "wide characters".

Create the StringBuffer with utf8mb4 to make sure no conversion
is done.

Now with unit test.
6c5fbc8bf4d6...
6c5fbc8bf4d682bfd9006e7366082df0ffd82609
Dave Gosselin
MDEV-37995: FULL OUTER JOIN name resolution

Allow FULL OUTER JOIN queries to proceed through name resolution.

Permits limited EXPLAIN EXTENDED support so tests can prove that the
JOIN_TYPE_* table markings are reflected when the query is echoed back by the
server.  This happens in at least two places:  via a Warning message during
EXPLAIN EXTENDED and during VIEW .frm file creation.

While the query plan output is mostly meaningless at this point, this
limited EXPLAIN support improves the SELECT_LEX print function for the new
JOIN types.

TODO: fix PS protocol before end of FULL OUTER JOIN development
6b455f8810c0...
6b455f8810c0ae32f3ece3ff18339ae8dcff827c
Dave Gosselin
MDEV-39014: FULL JOIN Phase 2

In phase 1, FULL [OUTER] JOIN was only supported when simplify_joins()
could rewrite it into an equivalent LEFT, RIGHT, or INNER JOIN based
on NULL-rejecting WHERE predicates.  Queries that could not be
rewritten raised ER_NOT_SUPPORTED_YET.  (Phase 1 was not released.)

This commit removes that restriction by adding proper support for FULL
JOIN by executing a 'LEFT JOIN pass' that emits matched rows and left
null-complemented rows, then a second "null-complement" pass which
rescans the right table to emit null-complement rows that were never
matched.

FULL JOIN supports nested joins on the left of the FULL JOIN,
NATURAL FULL JOIN, semi-joins, CTEs / derived tables (kept
materialized when they participate in a FULL JOIN), prepared
statements, stored procedures, and aggregates.  Examples:

  SELECT * FROM (d1 FULL JOIN d2 ON d1.a = d2.a)
              FULL JOIN t3 ON d1.a = t3.a;

  SELECT * FROM t1 NATURAL FULL JOIN t2;

  SELECT * FROM t1 INNER JOIN t2 FULL JOIN t3 ON t1.a = t3.a;

  PREPARE st FROM
    'SELECT COUNT(*) FROM t1 FULL JOIN t2 ON t1.a = t2.a';

Limitations:
  - Statistics and cost estimates for the null-complement pass have
    not been fully implemented; the optimizer may under- or
    over-estimate FULL JOIN costs in plans involving multiple
    FULL JOINs.  Again, a follow-up will optimize the cost calculations.
  - Optimizations for constant tables not fully supported.
  - Nested tables on the right side of a FULL JOIN are not yet supported.
609466488708...
609466488708984d88e3dd5d9805479f72bc75a5
Dave Gosselin
MDEV-38502: FULL OUTER JOIN get correct sargable condition

Fetches the ON condition from the FULL OUTER JOIN as the sargable condition.
We ignore the WHERE clause here because we don't want accidental conversions
from FULL JOIN to INNER JOIN during, for example, range analysis, as that
would produce wrong results.

GCOV shows that existing FULL OUTER JOIN tests exercise this new codepath.
5f01ae40b367...
5f01ae40b3672f7dce855fb6f70ca5c13f6ffdaa
ParadoxV5
Merge branch 'MDEV-39788.test' into MDEV-39788
4ae5a1aab2ee...
4ae5a1aab2ee9c6a92404c0f76c36e8ef87bd102
Dave Gosselin
MDEV-38502: FULL OUTER JOIN get correct sargable condition

Move the temporary gate against FULL OUTER JOIN deeper into the
codebase, which causes the FULL OUTER JOIN query plans to have
more relevant information (hence the change).  In some cases, the
join order of nested INNER JOINs within the FULL OUTER JOIN changed.

Small cleanups in get_sargable_cond ahead of the feature work in
the next commit.
39a0f4dd0923...
39a0f4dd0923d4c21fd4e11d331105a1cea008bc
Alexander Barkov
MDEV-39518 Allow prepared statements in stored functions in assignment right hand

In progress
100666801d2c...
100666801d2cf639a9849c3103305e4d985de453
Dave Gosselin
Remove unnecessary and unused 'top' parameter from simplify_joins.
0d654f6bbf96...
0d654f6bbf9643158792c4f2b69fbbf7af8c9ddb
ParadoxV5
didn’t notice that null lists were allowed in pre-12.3
0d468c929925...
0d468c9299251be5ab0d455cda27fc819b100f03
Sergei Petrunia
Update test results
09b9772eec85...
09b9772eec85b72bca633f5885b4c4a029326214
Daniel Bartholomew
bump the VERSION
BuildBot (0.8.9) working for the MariaDB project.
Page built: Sat 30 May 2026 08:32:06 (UTC)