Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
Rucha Deodhar
MDEV-39119: Improve error handling when using OLD_VALUE as alias name

Analysis:
Since OLD_VALUE_SYM was part of reserved keywords, it did not allow
old_value in the alias.
Fix:
Change OLD_VALUE_SYM from reserved keyword to keyword_sp_var_and_label.
Rex Johnston
MDEV-38070 wrong resultset with having and or condition

During join execution of a query involving an aggregation,
ref items pointing to types that call Item_ref::val_native
(which includes TIMESTAMP fields) will return a value from
Item_field::field, rather than Item_field::result_field.
This will result in a potentially incorrect grouping comparison
and an incorrect result.

Affected statements will involve a derived grouped table with
an aggregation function TIMESTAMP field and outer having clause.
mohitbalwani
MDEV-38696 Fix infinite loop in my_copy() function

The bug occurred when my_read() returned (size_t)-1 but was
compared against (uint)-1.It was causing the loop to
never exit when reading from a directory or other error conditions.

Changed comparison from (uint)-1 to (size_t)-1 to match the
return type of my_read().
Marko Mäkelä
MDEV-39087 os_file_set_size() may behave inconsistently during shutdown

os_file_set_size(): Ignore srv_shutdown_state and consistently extend
the file to completion. If someone is in a hurry, they can forcibly
kill the mariadbd process and test the crash recovery.
Hemant Dangi
MDEV-36621: galera.GCF-360 test: IST failure

Removed redundant per-node wsrep_provider_options overrides that
were dropping all timeout settings.
Marko Mäkelä
MDEV-39139 InnoDB fails to start up with small RLIMIT_AS

innodb_init_params(): When no innodb_buffer_pool_size_max has been
specified, cap the default to a quarter of the address space limit.

Reviewed by: Vladislav Vaintroub
Marko Mäkelä
Merge 11.4 into 11.8
Abdelrahman Hedia
MDEV-37842 Skip implicit Using_Gtid warning when value is unchanged

When a replica already has Using_Gtid=No and a CHANGE MASTER TO is
issued with log coordinates (e.g. relay_log_pos, master_log_file),
the server emits a spurious warning:

  Note 4190 CHANGE MASTER TO is implicitly changing the value of
  'Using_Gtid' from 'No' to 'No'

The value isn't actually changing, so the warning is misleading.

In change_master() (sql/sql_repl.cc), when log coordinates are specified
without an explicit master_use_gtid, the code implicitly sets Using_Gtid
to No and emits a warning. The condition only checks whether
master_use_gtid=No was explicitly given but does not check whether
Using_Gtid is already No.

Added a check that the current Using_Gtid value differs from
USE_GTID_NO before emitting the warning. The warning now only fires
when the value actually changes.

Re-recorded rpl.rpl_from_mysql80 which previously expected the
spurious No-to-No warning.

Reviewed-by: Georgi Kodinov <[email protected]>
Reviewed-by: Brandon Nesterenko <[email protected]>

https://github.com/MariaDB/server/pull/4678
Vladislav Vaintroub
Revert "MDEV-38989 main.ctype_utf16le SEGV in Ubuntu 26.04 (x86-64-v3)"

This reverts commit 6318d5001597fff28ea7ba7f957d66edd7e3e954.

uint2korr is now fixed in MDEV-37788, thus partial workarounds are not necessary anymore.
Geng Tian
MDEV-38454 CHANGE MASTER TO master_heartbeat_period does not accept numbers with `+` sign

Fixed parser inconsistency where CHANGE MASTER TO master_heartbeat_period
rejected numeric values with an explicit '+' sign, while other parameters
like master_connect_retry accepted them.

The issue was in sql/sql_yacc.yy where master_heartbeat_period used
NUM_literal (which doesn't accept '+'), while other parameters used
ulong_num (which includes opt_plus).

Solution: Added opt_plus before NUM_literal in the master_heartbeat_period
grammar rule, making it consistent with other numeric parameters.

Added test case to verify:
- master_heartbeat_period=+60 now works (was broken)
- master_heartbeat_period=60 still works (backward compatible)

All new code of the whole pull request, including one or several files
that are either new files or modified ones, are contributed under the
BSD-new license. I am contributing on behalf of my employer Amazon Web
Services, Inc.
Vladislav Vaintroub
MDEV-39027 suboptimal code for InnoDB big endian access functions

Optimize big endian (and some little endian) Innodb access functions by
using my_htobeN/my_betohN and memcpy.
Christian Hesse
systemd: add missing quotes in examples

The line is commented, but let's have valid quoting anyway...
Marko Mäkelä
Merge 10.11 into 11.4
Daniel Black
MDEV-39086 MSAN/UBSAN/ASAN builds run without basic optimization

MSAN/UBSAN/ASAN/TSAN builds are preforming addition runtime
checks requiring additional CPU to do so. To help the test
systems of these run with a bit faster, but still be debuggable,
we should add -Og where another C/CXX optimization flag isn't
specified.

Gcc/Clang environment that support these range of sanitizers
use -O followed by 0-3, g, s, z, and apparently "fast". These
are the flags matched by the regex.
Varun Deep Saini
MDEV-33070 Thread pool starvation at oversubscribe

Allow one more worker at the oversubscribe threshold so a group
only becomes oversubscribed after it exceeds the configured
limit.

Add a regression test that reproduces the starvation case in the
generic thread pool and verifies queued work still drains.

Signed-off-by: Varun Deep Saini <[email protected]>
Denis Protivensky
MDEV-39011: Fix THD leak in async slave error path with wsrep_restart_slave

- fix the leak by properly releasing resources before repeat
- rework the error path handling to wait for Wsrep readiness state
  instead of repeating endlessly
- improve Wsrep readiness state by also singlaing node's shutdown
Aleksey Midenkov
MDEV-38798 Assertion `mdl_key->length() == 3' failed in MDL_map::find_or_insert

MDEV-33985 wrongly checked db.length for pure alias, but
empty_c_string is not pure alias. Reverted this check to db.str.
Vladislav Vaintroub
MDEV-37788 fix uintNkorr/intNstore macros to avoid unaligned access

Replaced macros with optimized inline functions, that use memcpy
instead of unaligned access (translates to single instruction
on architectures we support). Used compiler byteswap intrinsics
where appropriate.

Removed byte_order_generic.h as well as Intel specific headers
byte_order_generic_{x86|x86_64}.h

Added some casts to places where intNstore writes into "const char*".
Yuchen Pei
MDEV-38732 Correctly construct queries with NULL uservar values in spider

The subsequent assertion failure in end_statement is likely caused by
HA_ERR_OUT_OF_MEM not correctly handled, but it should not return an
HA_ERR_OUT_OF_MEM here in the first place.
Marko Mäkelä
MDEV-39040 log_sys.latch performance lost to PERFORMANCE_SCHEMA

log_sys.latch: Remove the PERFORMANCE_SCHEMA instrumentation.
We already know that this is a very busy latch. All code paths
where a shared log_sys.latch is being held should already be
highly optimized. The few paths where an exclusive log_sys.latch
is being held are known to be potentially problematic, but rare.

Removing the PERFORMANCE_SCHEMA instrumentation for this latch
is expected to improve performance. On a quick Sysbench run with

performance_schema_instrument=wait/synch/rwlock/%=on

I observed an 2.9% improvement on throughput.

srw_lock_debug_simple: A non-instrumented version of srw_lock_debug,
to allow PERFORMANCE_SCHEMA to work WITH_INNODB_EXTRA_DEBUG=ON.

Reviewed by: Alessandro Vetere
Marko Mäkelä
Make innodb_log_recovery_start settable (for incremental backup)

Also, implement a little more of backup_innodb.
Sutou Kouhei
MDEV-39098: UBSAN: insufficient-object-size in mroonga groonga/lib/db.c:10882

The incorrect destructor was used in delete_reference_records_in_index
Anway Durge
MDEV-XXXXX: Fix Mroonga post-install script path

Update legacy /usr/share/mysql path to /usr/share/mariadb in the debian postinst script for the mroonga plugin.
Fariha Shaikh
MDEV-38020 Master & relay log info files read 2^31 and above incorrectly

Master and relay log positions are 64-bit unsigned but were read using
atoi(), which only handles signed 32-bit integers. Values >= 2^31 overflow
and corrupt after restart.

Add init_ullongvar_from_file() using my_strtoll10() to correctly parse
64-bit values. Update rpl_rli.cc and rpl_mi.cc to use ulonglong variables
and this new function.

All new code of the whole pull request, including one or several files
that are either new files or modified ones, are contributed under the
BSD-new license. I am contributing on behalf of my employer Amazon Web
Services, Inc.

Reviewed-by: Brandon Nesterenko <[email protected]>
Daniel Black
MDEV-39109 main.sp-error stack overflow debug, MSAN and ASAN

MSAN seems error on stack depth 39 so set limit to 20.

ASAN error-ed on stack depth 248 so set limit to 200.

The actua;ly depth wasn't important for the purposes
of the fatal error handling in MySQL bug #15192
from which this test originates.

Reviewed/Approved by: Oleksandr "Sanja" Byelkin ([email protected])
Fariha Shaikh
MDEV-36725 Fix innodb_ctype_ldml test in view-protocol mode

The test innodb.innodb_ctype_ldml was failing in view-protocol mode due
to different column naming behavior for complex expressions.

Without explicit column aliases, view-protocol mode generates automatic
names (Name_exp_1, Name_exp_2) while normal mode uses the full
expression as the column name.

Add explicit column aliases to SELECT statements in innodb_ctype_ldml to
ensure consistent column names across both normal and view-protocol
modes.

All new code of the whole pull request, including one or several files
that are either new files or modified ones, are contributed under the
BSD-new license. I am contributing on behalf of my employer Amazon Web
Services, Inc.
Georg Richter
Fix for CONC-812:

The `length` element of the MYSQL_BIND structure is
used to obtain the size of variable-length data
types, such as BLOBs or strings, in order to
determine the required buffer size, as described in
the documentation:

"Pointer to the length of the buffer (not used for
parameters). The length is ignored for numeric and
fixed-size data types, as the buffer_type value
determines the size of the data."

Since the prepared statement implementation of
MariaDB Connector/C is based on the PHP mysqlnd
extension code, the initial implementation
incorrectly set the `length` field for fixed-size
data types.

As agreed with the support team, we do not remove
the `length` value for fixed-size types, but retain
it to handle NULL values correctly.
Mohamed
MDEV-38494 .mariadb_history rename race condition

When multiple mariadb sessions exit at the same time, they all write
to the same $HISTFILE.TMP then rename it to $HISTFILE.  The second
rename fails with Errcode 2 because the first already moved the file.

Fix: include the process PID in the temp file name so each session
uses its own unique path and no rename collision can occur.
Marko Mäkelä
Merge 10.11 into 11.4
Daniel Black
Bump columnstore to latest stable-23.10
Marko Mäkelä
MDEV-39104 Hang in the test innodb.log_file_size,debug

srv_prepare_to_delete_redo_log_file(), srv_start(): When injecting a
failure, resume the ability to write a checkpoint, so that the
shutdown will not hang. Also, adjust the test so that it tolerates
the checkpoint during shutdown.

Fixes up commit bf363a573ab8f96657545de97ead568d09a9f1a0 (MDEV-38968)
luckyxhq
MDEV-38915 Fix signed/unsigned type mismatch in setval() for GET_ULONG
Aleksey Midenkov
MDEV-38854 Assertion table->vers_write fails upon ODKU into table with versioned column

In MDEV-25644 vers_check_update() sets vers_write to false in case it
returns false. It is ok for UPDATE but is not correct for ODKU is bulk
insert requires vers_write on next tuple.

The fix return vers_write value back when vers_check_update() and
related vers_insert_history_row() are done in ODKU.
Marko Mäkelä
Merge 10.6 into 10.11
Denis Protivensky
MDEV-30612: Fix usage of lex->definer in wsrep_create_trigger_query

Setting thd->lex->definer is excessive as it's only used within the
function call.
Moreover, it would lead to a use-after-free on the second execution
of a CREATE TRIGGER prepared statement.
Brian White
fix build with WITH_EXTRA_CHARSETS=none again
Jan Lindström
MDEV-38895 : Regression on MDL conflict handling

The reason for this timeout is a regression introduced in commit
https://github.com/MariaDB/server/commit/e40277d29b7c531e1ed6b3bed7ecfc8cfeff4c7e.
Where there is incorrect condition wsrep_thd_is_BF(granted_thd, false)
because if granted thread is BF it may not be BF-killed.

In this patch following has been changed
    * Split wsrep_handle_mdl_conflict to smaller easier to understand parts
    * Improved code comments
    * Improved debug logging to contain thread ids and necessary information
    * Corrected and simplified conditions so that BF threads are not killed
    * Added few debug assertions to verify that BF threads are not killed
    * Code cleanups so that tab-characters are not used
    * Existing test cases already test rest of the cases
hadeer
Mroonga: fix SIGSEGV on NULL mroonga_log_file

Add mrn_log_file_check() to validate that
mroonga_log_file is not set to NULL or an empty
string, which previously caused a segfault.
Alexey Yurchenko
MDEV-38383 Fix MDEV-38073 MTR test warning

MDEV-38073 MTR test started to fail with a warning after upstream merge
from 11.4 a7528a6190807281d3224e4e67a9b76083a202a6 because THD responsible
for creating SST user became read-only when the server was started with
--transaction-read-only=TRUE.
make sure the readonly flag on THDs created for wsp::thd utility class is
cleared regardless of the --transaction-read-only value as it is intended
only for client-facing THDs.