Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
Sergei Golubchik
report platform in mtr
Yuchen Pei
MDEV-38522 Reset m_pi_scan_method at table init
Nikita Malyavin
MDEV-37898 No GTT MTR coverage on release builds due to debug_sync
requirement

Deny temporary tables creation for sphinx.
Sergey Vojtovich
MDEV-10677 - perfschema.threads_mysql fails in buildbot (type=BACKGROUND mismatch)

Test was affected by incompletely closed preceding connections.

Make test agnostic to concurrent connections by querying
performance_schema.threads only for connections that it uses.
Sergei Golubchik
fix tests for --ps: GTT
Yuchen Pei
MDEV-38327 Do not use rowid filter when switching to index merge

Index merge and rowid filter should not be used together, however,
even if index merge is not chosen earlier in best_access_path, it may
be chosen again in make_join_select. Therefore this patch ensures that
rowid filter is not used when index merge is chosen in
make_join_select.
Sergei Golubchik
fix rpm upgrade tests after MDEV-37726

MDEV-37726 moved wsrep-start-position to INSTALL_RUNDATADIR
and made the latter to be created by systemd-tmpfiles.

Now postin scriptlet has to run systemd-tmpfiles explicitly
to make sure INSTALL_RUNDATADIR exists before restarting
the server.

followup for 649216e70d87
gkodinov
MDEV-38499: cmake and compile errors on MacOSX when compiling mariadb from a git tree

Problems:
1. bison incorrectly issues a warning when it sees "b4_bin"
2. MacOSX linker issues a warning about duplicate mysys/dbug/etc libraries.

On 1: worked around by adding a compiler define with a different name
aliasing the character set variable used with a name that
won't trigger the bison warning

On 2: This is due to the fact that there's a circular dependecy between
mysys and dbug (among others). Turned the warning off by adding a compiler
option to be applied to targets lined with mysys to turn the warning off.
Raghunandan Bhat
MDEV-38487: Prevent aggregate function cloning when pushing HAVING into WHERE

Problem:
  When building a pushable condition that can be pushed from HAVING into
  WHERE, the server tries to clone aggregate functions. This is not
  necessary because aggregate functions can not be pushed into WHERE
  anyway.

Fix:
  This fix introduces a check within `Item::build_pushable_cond` to skip
  cloning aggregate functions.

Also fixes assert failure in MDEV-38492, by adding a missing copy method
for `Item_aggregate_ref`.
gkodinov
MDEV-38499: cmake and compile warnings on MacOSX when
compiling mariadb from a git tree

Fixed sprintf deprecation warnings compiling on MacOSX.

Replaced some sprintf calls with equivalent snprintf calls,
enough so that "normal" compile on MacOSX (as documented
in the docs) completes without warnings.
Raghunandan Bhat
MDEV-38487: Prevent aggregate function cloning when pushing HAVING into WHERE

Problem:
  When building a pushable condition that can be pushed from HAVING into
  WHERE, the server tries to clone aggregate functions. This unnecessary
  because aggregate functions will not be pushed into WHERE anyway.

Fix:
  This fix introduces a check within `Item::build_pushable_cond` to skip
  cloning aggregate functions.

Also fixes assert failure in MDEV-38492, by adding a missing copy method
for `Item_aggregate_ref`.
Vladislav Vaintroub
MDEV-38498 mariadb-dump -dir doesn't convert database names

Similar to MDEV-37483, use file name encoding for dbnames to create
directories. Adapt mariadb-import to convert the names back.
Sergei Golubchik
MDEV-38532 Debian packages are missing many server include headers, such as handler.h

include headers needed to build plugins, same as in RPMs
Nikita Malyavin
MDEV-38448 assertion ...tdc->ref_count > 0 failed on LOCK gtt+open error

If open_global_temporary_table failed, a goto was to an incorrect place.
In locked_tables_mode, an extra acquire didn't happen, so a release on
error shouldn't have happened as well (i.e. goto err_lock).
That is, in locked_tables_mode, just return immediately on error.

The easiest way to reproduce it was with DML while pseudo_slave_mode=1,
but actually any error inside open_global_temporary_table would do.
Christian Hesse
MDEV-35904/MDEV-19210: use environment file in systemd units for _WSREP_START_POSITION

MDEV-35904 - backport MDEV-19210 to 10.11 as referenced
by unset environment variables become warnings.

We used to run `systemctl set-environment` to pass
_WSREP_START_POSITION. This is bad because:

* it clutter systemd's environment (yes, pid 1)
* it requires root privileges
* options (like LimitNOFILE=) are not applied

Let's just create an environment file in ExecStartPre=, that is read
before ExecStart= kicks in. We have _WSREP_START_POSITION around for the
main process without any downsides.
Aleksey Midenkov
MDEV-28619 with_flags cleanup

The best practice is to init as much info as possible in class
constructor. with_flags access may be needed before fix_fields() or
fix_fields() may be not called at all like it takes place in
MDEV-28619. The fix for MDEV-28619 requires WINDOW_FUNC check on
unfixed item.
Nikita Malyavin
MDEV-38480 GTT: Aria gets error HA_ERR_CRASHED_ON_USAGE after TRUNCATE

Do not call HA_EXTRA_PREPARE_FOR_DROP for the parent table
Nikita Malyavin
MDEV-37941 Assertion !thd->rgi_slave failed on INSERT w/ parallel slave

Replicas can't crash on the incorrect/unexpected data. It should react
with an error.

Change the assertion to if and return error if the relay log contains
query with GTT access.
Daniel Black
MDEV-15502 debian: systemd, with tmpfiles install not required

With PermissionsStartOnly deprecated, remove this from the
systemd service file.

Replace Debian's ExecStartPre "install -d" with a tmpfile
configuration directive creating the directory with this.

Debian's ExecStartPost of the mariadb upgrade uses the !
special executable prefix added in systemd v231 to use
root privs.
Alexander Barkov
MDEV-38451 `SHOW FUNCTION CODE package_func` crashes on the second execution

Routine name resolution performed on a temporary memory root
during execution. So on the second execution LEX::spname members
pointed to a cleared memory.

Fixing to peform the resolution to parse time, like the CALL statement does.
During the execution time LEX::spname members now stay untouched.
gkodinov
MDEV-38499: cmake and compile warnings on MacOSX when compiling mariadb from a git tree

Fixed sprintf deprecation warnings compiling on MacOSX.

Replaced some sprintf calls with equivalent snprintf calls,
enough so that "normal" compile on MacOSX (as documented
in the docs) completes without warnings.

Also advanced the connector/C submodule to include the commit fixing
compilation warnings in it.
Alessandro Vetere
[skip ci] fixup: implement fixed AHI parameters

Valid parameters are set for future recommendations in
innodb_ahi_enable and used in btr_search_info_update_hash.

TODO Allow fixing "0" as complete_fields (fields) and
bytes_from_incomplete_fields (bytes)
Nikita Malyavin
MDEV-37898 No release GTT MTR tests due to debug_sync injection
Yuchen Pei
MDEV-38327 Do not use rowid filter when switching to index merge

Index merge and rowid filter should not be used together, however,
even if index merge is not chosen earlier in best_access_path, it may
be chosen again in make_join_select. Therefore this patch ensures that
rowid filter is not used when index merge is chosen in
make_join_select.
Yuchen Pei
MDEV-38327 Do not use rowid filter when using index merge
Aleksey Midenkov
MDEV-28619 Server crash and UBSAN null-pointer-use in Window_funcs_sort::setup

Optimization in st_select_lex_unit::prepare() removes ORDER BY for
certain subqueries. That excludes ORDER BY items from being fixed, but
sl->window_funcs still contains window function items and those
related to optimized out ORDER BY are unfixed. The error about missing
window spec is thrown when the item is fixed. Hence we get redundant
processing of window function items without checking window spec
existence.

The fix removes the related window function items when ORDER BY is
optimized out. The fix also updates similar optimization in
mysql_make_view().
Sergey Vojtovich
MDEV-38534 - perfschema.user_var_func fails sporadically

Test was affected by incompletely closed preceding connections.

Make test agnostic to concurrent connections by querying
performance_schema.user_variables_by_thread only for connections
that it uses.
gkodinov
MDEV-38499: cmake and bison warnings on MacOSX when compiling
mariadb from a git tree

Problems:
1. bison incorrectly issues a warning when it sees "b4_bin"
2. MacOSX linker issues a warning about duplicate mysys/dbug/etc libraries.

On 1: worked around by adding a compiler define with a different name
aliasing the character set variable used with a name that
won't trigger the bison warning

On 2: This is due to the fact that there's a circular dependency between
mysys and dbug (among others). Turned the warning off by adding a compiler
option to be applied to targets lined with mysys to turn the warning off.
Marko Mäkelä
Refine the innodb_encrypt_log format
Jan Smutný
fsp0fsp.cc: log unexpected table in sys tablespace

Fix log message about unexpected table in system tablespace as the current
message can be missleading due to still existing (but already deprecated)
system tables SYS_DATAFILES and SYS_TABLESPACES, reported in
- MDEV-38412

Also adding the informative message with table name of the unexpected table
in system table space.
Sergey Vojtovich
MDEV-38531 - perfschema.statement_digest_consumers2 fails sporadically

Test was affected by incompletely closed preceding connections.

Make test agnostic to concurrent connections by querying
performance_schema.events_statements_current only for connections
that it uses.
Sergey Vojtovich
MDEV-38534 - perfschema.user_var_func fails sporadically

Revert part of bead24b7f3d, which broke this test. The wait is still
needed to make variables of preceding connection disappear.
Daniel Black
MDEV-37726 wsrep-new-cluster and wsrep-start-position in wrong directory with wrong selinux permissions

After moving the systemd service to using environment files
instead of `systemctl set-environment` in 11.6 (MDEV-19210),
they (wsrep-new-cluster and wsrep-start-position) are located
in /var/lib/mysql along with the socket file in
Fedora/RHEL-based distros. This causes them to have incorrect
selinux permissions and therefore be not readable by systemd.

A solution is to generate these files in the run directory,
instead, which already has correct selinux label mysqld_var_run_t
mysql-selinux-1.0.12. Dissociating these files and the socket
in CMake configs can also prove useful for other things.

This also corrects some of the duplicate code in the build
scripts and made INSTALL_RUNDATADIR into a proper location
and used this for the tmpfiles where the temporary files
are created.

Debian's location is /run/mysqld/ matching its INSTALL_UNIX_ADDRDIR,
which is now a temporary location controlled by tmpfiles.
Nikita Malyavin
MDEV-38468 GTT: use-after-free after failed BINLOG event in XA mode

Deny setting pseudo_slave_mode for GTT even when rli_fake is set.
gkodinov
MDEV-38499: cmake and compile warnings on MacOSX when
compiling mariadb from a git tree

Fixed sprintf deprecation warnings compiling on MacOSX.

Replaced some sprintf calls with equivalent snprintf calls,
enough so that "normal" compile on MacOSX (as documented
in the docs) completes without warnings.
Nikita Malyavin
MDEV-38481 GTT: Assertion failed in ha_maria::start_stmt on ANALYZE

Assertion 'file->trn == trn' failed in ha_maria::start_stmt on
ANALYZE TABLE, also assertion 'trn' failed in another test.

file->trn is NULL for a newly opened table and is normally assigned by
st_thr_lock::start_trans in mysql_lock_tables.

Same for thd->ha_data[maria_hton->slot].ha_ptr aka 'trn', which is
NULLed when the old table is dropped as part of OR REPLACE action, if
that was the only table in the aria locked tables. Similarly, it is
restored back on st_thr_lock::start_trans in mysql_lock_tables.

Since ANALYZE is registered as operating on the parent table,
open_only_one_table opens and locks the latter. lock_tables doesn't
issue a table lock in locked tables mode, but issues
table->file->start_stmt(...), which asserts for ha_maria.

Solution: lock the parent GTT table as well in
select_create::create_table_from_items. It will be unlocked altogether
within the lock saved in select_create as m_plock.
Marko Mäkelä
fixup! 30116f4c70078a0587b69afb3f55b16d1fe6c683