Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
Sergei Golubchik
don't backtick-quote CURRENT_SCHEMA
Sergei Golubchik
old view doesn't store the path, need the same fallback as for triggers
Sergei Golubchik
MDEV-38523 Freeing unallocated data THD::set_db when path-resolved routine in trigger

thd->db must always be malloc-ed, because thd->set_db() frees it.
The correct way to change thd->db temporarily is a pair of
mysql_opt_change_db()/mysql_change_db().

triggers were using a shortcut hack which kind of worked
as long as nobody tried to change thd->db during tigger parsing
when the hack was active.

Now path resolution code does that and triggers have to
change thd->db properly.
Oleg Smirnov
MDEV-38574 Rename cloning functions of class Item and descendants

This commit renames method `clone_item()` of class Items and its
descendants to `clone_constant()` to better clarity.
Vladislav Vaintroub
MDEV-36737 postfix - fix compilation and packaging on Windows

* Compile error
  GCCism - unportable use of __PRETTY_FUNCTION__

* Compile warning
  ha_rows to ulong cast missing

* Link error
  Due to unnecessary use of _dig_vec_lower
  _dig_vec_lower would have to be marked MYSQL_PLUGIN_IMPORT if we
  really wanted it.

* Packaging error (MSI)
  Newly introduced component videx-engine needs a place in
  MSI Feature tree
Sergei Golubchik
remove Sql_path_stack and Sql_path_push

don't create a permanent stack of paths on the heap and in THD.

Do it on the stack like for sql_mode, sctx, abort_on_warning, and
other THD properties that often need to be changed temporarily.

Fix Sql_path constructor.
Sergei Golubchik
reserve PATH_SYM in the same way as NAMES_SYM
Sergei Golubchik
bug: `current_schema` is not current_schema

quoted `current_schema` is literally a schema name and must
but treated as such. because Sql_path stores all names unquoted
let's store the current_schema as an empty name, length=0.
No valid schema name can be empty.
Sergei Golubchik
improve test readability

fix confusing duplicate lines like

Invoke from Db: test, Rt: proc
Invoke from Db: test, Rt: proc
Sergei Golubchik
misc
Sergei Golubchik
cleanup: Sroutine_hash

change sp_head::m_sroutines from HASH to Hash_set<Sroutine_hash_entry>
Sergei Golubchik
PATH is not a chistic, it's like sql_mode, remembered implicitly per routine
Sergei Golubchik
merge ErrConvMDQName into ErrConvDQName

and remove incorrect thd->db behavior
Sergei Golubchik
fix --path to work

complex object sysvars (plugins, time zone, path) cannot be
set by my_getopt, they have to use NO_CMD_LINE and special
code in mysqld.cc
Sergei Golubchik
mysql.proc.path DEFAULT 'CURRENT_SCHEMA' NOT NULL
Sergei Golubchik
do NOT prefer itself in seemingly recursive calls, follow the path
Sergei Golubchik
relax assert to account for recursive RETURNS TEXT functions
Sergei Golubchik
free Sql_path in the destructor, perform cleanup in cleanup()
Sergei Golubchik
consistency in error message naming
Sergei Golubchik
remove unused argument
Sergei Golubchik
clarify the test for triggers with different paths
Sergei Golubchik
disallow SET PATH in sf or trg while parsing

but also when executing, of course
Sergei Golubchik
use standard SET PATH syntax in tests
Sergei Golubchik
Don't implicitly search in CURRENT_SCHEMA

the intention was not to, but some code paths weren't fixed yet
Sergei Golubchik
cleanup: rename to follow the standard name convention
Sergei Golubchik
misc
Sergei Golubchik
disallow SET PATH DEFAULT in stored routines and triggers

also fix Sys_var_charset_collation_map where this bug was copied from
Sergei Golubchik
allocate Sql_path in one memory chunk, not one per schema

because it's always allocated and freed as a whole, there is
no operation "replace one name in the middle of the path"

this needed a reworked parser to create the whole list
of names, not append one name at a time.

Fixed a bug where Sql_path::from_text() pretended it can take
a string in any charset, but was always implicitly
assuming it's in my_charset_utf8mb3_general_ci.
Sergei Golubchik
change Sql_path::from_text() to take a String, not LEX_CSTRING

* use str->c_ptr() for the error message
* pass correct charset
* remove redundant parsing Table_triggers_list::check_n_load
Sergei Golubchik
more tests for duplicate values in path
Sergei Golubchik
cleanup: remove `(LEX_CSTRING*) &lex_string` casts

and some whitespace changes
Sergei Golubchik
ubsan error, memcpy(dst, NULL, 0)
Sergei Golubchik
remove always-false agument
Sergei Golubchik
add new column mysql.proc.path at the end of the table

to simplify downgrades and to avoid breaking applications
Sergei Golubchik
small cleanup
Sergei Golubchik
fix name resolution of name1.name2()

only search in thd->db if the path includes CURRENT_SCHEMA

Also, fix a bug with recursive function calls.
Sergei Golubchik
remove LEX::make_sp_name_sql_path()

it confusingly didn't have anything to do with sql path,
so merged into LEX::make_sp_name()
Sergei Golubchik
fix error message for assoc arrays
Sergei Golubchik
cache routines during path resolution
Sergei Golubchik
misc