Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
f941fc810cb6...
f941fc810cb64c04a38751080e04887f627a182c
Thirunarayanan Balathandayuthapani
MDEV-41666 Corruption on statement rollback when ON UPDATE SET NULL affects the base column

Problem:
=======
  - When a foreign key column is the base column of a
virtual column that is indexed together with other virtual
columns, a cascaded update (ON UPDATE/DELETE SET NULL)
computed the old value of only the dependent virtual column.
The other virtual key parts of the index stayed NULL in
update->old_vrow. If the statement was rolled back,
row_upd_store_v_row() used those NULLs, so
row_upd_sec_index_entry() searched the secondary
index for a record  that did not exist and hit
the "Record in index was not found on update" assertion.

Solution:
=========
dict_mem_fill_vcol_set_for_base_col():  Add every virtual key part
of each index that contains the dependent virtual column to
dict_foreign_t::v_cols, as dict_mem_fill_vcol_from_v_indexes()
already does. row_ins_foreign_fill_virtual() then computes the
old values of all of them.

Based on mysql/mysql-server@c48fa1e57a8e810f89b43d3e94bcbefa1fd69806
f5f6a3e1f27a...
f5f6a3e1f27a6c1d478eadc8969f35725aa31e73
Oleksandr Byelkin
Fix sporadic failure of main.charset_client_win_utf8mb4

The test set the password via "chcp 850 && echo ...", but the console
codepage is shared by all parallel mtr workers, so another process could
switch it to UTF8 and the password got stored as UTF8.

Write the cp850 password byte to a file and feed it to the client instead.
ed2944b96033...
ed2944b960331b73e440a2a7e5479485c8baab91
Oleksandr Byelkin
New HeidiSQL v12.21
e55411904543...
e55411904543b65e49c1cc3fca1138dca9cd3a1b
Teemu Ollakka
MDEV-40727 rsync SST donor stalls in a whole-host sync()

The rsync SST donor ran a bare sync() between the table flush and the
transfer. sync() flushes every mounted filesystem on the host, so its
duration depends on I/O unrelated to the SST. The donor holds FTWRL,
LOCK_log and a paused provider at that point, so the whole server is
frozen until sync() returns.

Flush only the filesystems that hold the files to transfer: the data
directory, an absolute binlog directory, and each symlinked database
directory.

Use the full sync() where 'sync -f' (syncfs) is not available.
e0cd1593893a...
e0cd1593893ab57ffb81813da5f7896c0e04e96c
Kristian Nielsen
Merge branch 'knielsen_fixes_10.11' 10.11
dea436e618af...
dea436e618af63feabac05ba8ffa1fcd4088ecce
Oleksandr Byelkin
bump version
c68fe071c331...
c68fe071c33182876098201c23e64011f8f13a47
Andrzej Jarzabek
MDEV-40239, MDEV-41616: Fix undo log page add failure injection

The debug injection ib_err_ins_undo_page_add_failure in
trx_undo_report_row_operation() cleared undo_block to simulate a
failure of trx_undo_add_page(), but left err as DB_SUCCESS.
The function then returned DB_SUCCESS without writing an undo log
record or setting *roll_ptr, so callers stored an invalid DB_ROLL_PTR
in clustered index records. This caused assertion failures in
trx_undo_page_report_modify() and trx_undo_prev_version_build().

The injection now also sets err=DB_OUT_OF_FILE_SPACE, simulating
running out of tablespace capacity.

MDEV-41616: when that failure was reported, ib_errf() was given the
dberr_t value DB_OUT_OF_FILE_SPACE where an error number was expected,
so the client received an unrelated message. Use
ER_INNODB_UNDO_LOG_FULL.
b6286fd2767e...
b6286fd2767e59b10e84ae7165e93a0e3819d5f7
Jan Lindström
MDEV-41490 ignore_db_dirs not working with SST

rsync and mariabackup SST ignored ignore_db_dirs: rsync copied and
deleted such directories like a normal schema dir, and mariabackup's
joiner wiped them during its pre-apply cleanup, failing SST outright
on a read-only mount. A directory name is also unvalidated by the
server, so it was spliced unchecked into an eval'd rsync filter.

Fix both SST scripts to read ignore_db_dirs and exclude those
directories, accepting only safe characters in the name.

Assisted-by: https://mariadb.org/governance/governance-ai-policy/
b120cd5054e8...
b120cd5054e882c06d8b8a3cf60aef3e7cd8cdf2
Aleksey Midenkov
MDEV-41493 AFTER UPDATE trigger reads wrong NEW value of BLOB/TEXT virtual column in system-versioned table

UPDATE, multi-table UPDATE, INSERT ... ON DUPLICATE KEY UPDATE and the
RBR Update_rows applier save the new row into record[2] and call
vers_insert_history_row(), which restores the old row from record[1]
and sets its row_end with vers_update_end(). The
VCOL_UPDATE_FOR_WRITE computation in vers_update_end() stored the
virtual blobs of the old row into Field_blob::value, the buffer that
the virtual blobs of the new row in record[2] point to, or reallocated
it when the old value was longer. After restore_record(record[2]),
AFTER UPDATE triggers read the old value, or freed memory, as NEW.

remember_blob_values() and restore_blob_values() skipped virtual
GEOMETRY columns: they selected MYSQL_TYPE_BLOB, while
virtual_not_stored_blob_fields counts all fields with BLOB_FLAG. So
GEOMETRY had the same problem also in TABLE::delete_row() for REPLACE
and DELETE.

UPDATE ... FOR PORTION OF has the same problem in period_make_insert(),
which computes the inserted leftover rows into record[0] while the new
row is saved in record[2], also for tables without system versioning.

The fix saves Field_blob::value with remember_blob_values() before the
history row in vers_insert_history_row() or the leftover row in
period_make_insert() is computed, and puts it back with
restore_blob_values() afterwards, as TABLE::delete_row() already does
for REPLACE (for DELETE it frees the saved values instead).
remember_blob_values() and restore_blob_values() now select fields by
BLOB_FLAG.
b0cb207dfe71...
b0cb207dfe71ee51f2460cb1e9f07f23d2a35532
Sergei Petrunia
Remove JOIN::need_distinct

The member was assigned in JOIN::init(), JOIN::optimize_inner() and
JOIN::optimize_stage2(), but never read. Its last reads, the arguments
of prepare_sum_aggregators() calls, were removed by:
commit 2cfc450bf78c2d951729d1a0e8f731c0d987b1d5
Author: Igor Babaev <[email protected]>
Date:  Tue Feb 9 2016

    This is the consolidated patch for mdev-8646: "Re-factor the code
    for post-join operations".

Since then the callers compute the value themselves from
is_using_agg_loose_index_scan().

JOIN::prepare_sum_aggregators() has a parameter of the same name, which
is unrelated and is kept.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
94cdbdf6d504...
94cdbdf6d504a9d30e0c594fa993c8d3a2bf9544
Oleksandr Byelkin
Revert "Fix MSAN failure in mysqltest with --cursor-protocol after CC update"

This reverts commit 22270903f19e02d40537ec688e3385374da33346.
85534724fa30...
85534724fa304d6ca3e7d07c694a53f1133fc020
Vladislav Vaintroub
MDEV-41691 PROXY protocol v1 header parser is too lenient

Follow the specification: the line is at most 107 bytes including CRLF,
ends with CRLF (not a bare LF), and fields are separated by exactly one
space, with nothing trailing (except after UNKNOWN). Ports are decimal
numbers up to 65535, without signs or leading zeroes. Also reject NUL
bytes and unknown address families (these were accepted before).

test_proxy_header_limits() now checks that malformed headers are
rejected, and also avoid DNS name resolution.

Assisted-by: Claude:claude-sonnet-5-5
845ad721d092...
845ad721d09241bf26d0db8751a51cf352f0b55f
Kristian Nielsen
Merge branch 'knielsen_log_event_read_validation_base_10.11' into 10.11
7c28d25227ad...
7c28d25227ada11ae8ab33f1a3b6aa597c9efa89
Oleksandr Byelkin
new wolfssl v5.9.4-stable
76590804bf31...
76590804bf31006f559b6b8cc9b297e0442910ff
Thirunarayanan Balathandayuthapani
MDEV-41550 MTR doesn't produce core dump or stack trace when a server hangs during startup

Problem:
========
If a server hangs in startup, mtr either waits for its pid file for
--start-timeout seconds and gives up with "Failed to start" (or)
when the test restarts the server, leaves the waiting to mysqltest,
which ends after about 500 seconds with "Server failed to restart".
In both cases the hung server is killed with SIGKILL, so
no core dump and no stack trace is produced, and it is
impossible to find out where the server got stuck.

Solution:
=========
dump_core_for_hung_server(): Sends SIGABRT to a server that is
still alive and waits for it to finish dumping core.
The server's fatal signal handler writes the stack trace
to the error log.

sleep_until_file_created(): call it when the wait for the pid file
times out and the process is still alive. This covers the servers
that mtr starts and waits for itself.

check_expected_crash_and_restart(): when mtr restarts a server on
behalf of the test, remember the time by which the
server must have created its pid file ($opt_start_timeout)

run_testcase() wakes up at that time, and if the server is
still alive without a pid file, it dumps core, fails the test with
"Failed to restart mysqldN, no pid file after N seconds" and kills
mysqltest, instead of waiting for it to give up.

mysql_server_wait(): append the server log of the failed server
to the failure report, as the other failure paths do.

Behavior change:
================
A restart done by the test now has to finish within --start-timeout
(180 seconds by default, MTR_START_TIMEOUT), the same as an initial
start. Before, only the test's own wait applied, about 500 seconds
with restart_mysqld.inc. A slow but healthy restart that needs more
than --start-timeout now fails with a core dump. Raise
MTR_START_TIMEOUT for such tests. Under a debugger the timeouts are
much longer, so nothing changes there.

Servers that are only slow, or that mtr has not waited for yet
are not aborted before the timeout.
72a7635ba66c...
72a7635ba66c75365013536a87c408fd17d9ee11
Oleksandr Byelkin
new PCRE2 10.49
65f524d81df2...
65f524d81df207a81dcdd1fb06c8ecea87acce36
David Schilling
MDEV-41450 TOI DDL BF-aborts InnoDB purge, purge loops forever

Fix for MDEV-38218 changed MDL conflict handling to allow high priority
cluster threads to BF abort any conflicting MDL lock holder.
With this, the InnoDB purge coordinator became also potential target
for BF aborts.
However, InnoDB purge thread has no statement boundary and could never
reset THD::killed state, after the BF abort. Purge THDs are taken
from a pool of innodb_purge_threads_MAX THDs, so about 32 purge runs
later the killed THD coordinates purge again. From then on every
open_purge_table() for a table with an indexed virtual column fails,
and purge_sys_t::close_and_reopen() retries forever. Purge stops and
server shutdown hangs.

Separately, open_purge_table() allocates a TABLE_LIST on thd->mem_root
and the coordinator THD never freed its mem_root, so it grew with every
purge batch and every close_and_reopen() retry.

Fix:
- wsrep_handle_mdl_conflict(): when the granted thread is a
  SYSTEM_THREAD_GENERIC THD holding explicit MDL, make the BF requestor
  wait instead of aborting it. In practice this covers the InnoDB
  background threads (purge, statistics, FTS optimizer), which release
  their locks on their own. This restores the pre-MDEV-38218 behaviour
  for these threads only.
- open_purge_table(): open with MYSQL_OPEN_IGNORE_KILLED so that a stale
  kill flag cannot block purge.
- trx_purge_close_tables(): call reset_thd() instead of
  close_thread_tables() to free the coordinator's mem_root per batch.

This commit has a new mtr test galera.MDEV-41450

This work is based on pull request https://github.com/MariaDB/server/pull/5854
by David Schilling, which is now rebased to MariaDB 10.11 and extended to
have a mtr test.

Assisted-by: https://mariadb.org/governance/governance-ai-policy/
6220bc91c095...
6220bc91c0953077d8779b63bb3ac59c4b0b421d
Aleksey Midenkov
MDEV-40854 Use of uninitialized table_will_be_deleted in federated engine

MemorySanitizer report:

==851408==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 ha_federated::end_bulk_insert() storage/federated/ha_federated.cc:2035:30
    #1 mysql_insert(THD*, ...) sql/sql_insert.cc:1258:11
    ...
  Memory was marked as uninitialized
    #0 __msan_allocated_memory
    #1 my_malloc mysys/my_malloc.c:116:7
SUMMARY: MemorySanitizer: use-of-uninitialized-value ... end_bulk_insert()

table_will_be_deleted is a handler member with no in-class
initializer, and the handler object itself is heap-allocated via
my_malloc(), so it starts out as garbage. It was only ever set in
extra(HA_EXTRA_PREPARE_FOR_DROP) and in external_lock(). For a
TEMPORARY table, statement execution can reach end_bulk_insert(),
which reads the flag, without external_lock() having run first, so the
read sees uninitialized memory.

The fix initializes table_will_be_deleted in reset(). Both
ha_federated::open() and ha_federatedx::open() call reset(), so the
flag is initialized on first open and cleared after every statement.
That also covers the first statement after open (e.g. CREATE TEMPORARY
TABLE ... ENGINE=FEDERATED ... SELECT, where external_lock() is not
called).
5fc864ece453...
5fc864ece453a5465141cb8ca23d743af35fc0fd
Oleksandr Byelkin
Fix MSAN failure in mysqltest with --cursor-protocol after CC update

CONC-821 in Connector/C 3.3.21 no longer resets *length for string
binds, so for NULL just assume 0.
599416569db1...
599416569db11c266380b027092ecbd5b7ca4445
Aleksey Midenkov
MDEV-39306 Index corruption on UPDATE when using versioned InnoDB table (on UPDATE)

Duplicated by:

MDEV-39711 UPDATE on System-Versioned Tables uses the after-value
          in Row-format Binlog's before-image
MDEV-24646 ASAN heap-use-after-free in Field_blob::pack /
          THD::binlog_update_row upon DML on table with virtual column

vers_update_fields() recomputed virtual fields with VCOL_UPDATE_FOR_READ.
For BLOB virtual columns this mode swaps Field_blob::value and read_value
after the computation (swap_values). After the swap, Field_blob::value
holds the buffer that record[1] (the old row image) points to. The next
VCOL_UPDATE_FOR_WRITE computation, done by fill_record() right after
vers_update_fields(), stores the new value into that buffer and so
overwrites the old row image. As a result, InnoDB builds the old
secondary-index key from the new value (MDEV-39306), and the row-format
binlog writes the new value into the before-image (MDEV-39711), or a
freed buffer (MDEV-24646).

REPLACE had the same problem with record[2]. TABLE::delete_row() saves
the new row into record[2] and turns the conflicting row into history
with vers_update_end(). Its VCOL_UPDATE_FOR_WRITE computation stored
the virtual blobs of the old row into Field_blob::value, the buffer
record[2] points to, so the new row was written with them. Versioned
DELETE had the same problem with record[1]: it points to the virtual
blobs computed with VCOL_UPDATE_FOR_DELETE in Field_blob::value, and
vers_update_end() overwrote them.

The fix removes the virtual fields computation from vers_update_fields().
Its callers now recompute virtual fields with VCOL_UPDATE_FOR_WRITE after
the system fields are set: fill_record() already did, while
update_generated_fields(), multi_update::do_updates() and the RBR
appliers do it explicitly. multi_update::do_updates() still computes
virtual fields twice per row: before BEFORE triggers and after
vers_update_fields(), since the system fields cannot be set before
compare_record(). For REPLACE and DELETE, TABLE::delete_row() keeps
Field_blob::value with remember_blob_values() while it updates the
history row.

In the RBR appliers no VCOL_UPDATE_FOR_WRITE followed
vers_update_fields(), so record[1] was not overwritten there. Their
explicit computation replaces the one removed from vers_update_fields().
It uses VCOL_UPDATE_FOR_WRITE, so an error in a virtual field
expression now stops the slave instead of being turned into a warning.

In the Update_rows applier, vers_insert_history_row() also overwrote
the error of ha_update_row(), so a failed update on the slave was
ignored and its history row was written. The history row is now
written only when the update succeeded.

Based on the MDEV-24646/MDEV-39711 fix by ParadoxV5 (0c2f3de1a2d),
which switched vers_update_fields() to VCOL_UPDATE_FOR_WRITE.
54fa15e8ea5e...
54fa15e8ea5ee9eb96682db3820b8605a93ccdba
Oleksandr Byelkin
Remove FILE_OPTIONS_STRING after version bump

FILE_OPTIONS_STRING was disabled for 10.11.20 by MDEV-40484.
Use FILE_OPTIONS_ESTRING for the remaining fields (md5,
charset names never contain escaped characters).
515f4dc6c3cd...
515f4dc6c3cd1c2d3301c98f3fb9aa17a19063b6
Oleksandr Byelkin
MDEV-22374 VIEW with security definer require FILE privilege from definer not invoker in case of INTO OUTFILE

Already fixed by MDEV-39493; add a test for the view case.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
4ec6cdd9f8c5...
4ec6cdd9f8c594ebfc7205064f181c4a29c590b6
Oleksandr Byelkin
New 3.3 CC
4c5e87b631c4...
4c5e87b631c49163e0d47d06af3eaa21bfe24aed
Marko Mäkelä
InnoDB_backup::backup(): Try O_DIRECT for the output .ibd files
4b1f3b290cc0...
4b1f3b290cc01b4bb1ed8c29fee9c51e8ac7515b
Sergei Petrunia
Remove JOIN::union_part

The member is assigned in JOIN::prepare() but never read. Its last
reads (in the EXPLAIN code) were removed by:
commit 46a22a5be75
Author: [email protected]
Date:  Thu Sep 26 2002

    new EXPLAIN
    fixed bug in mysql-test/create-test-result
    fixed bug in union-subselect engine

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
4946e661399d...
4946e661399d3b73130461bb1e8d4598696c8be2
Aleksey Midenkov
MDEV-41621 Stored generated BLOB column is wrong on REPLACE into versioned table

REPLACE into a system-versioned table turns the conflicting row into
history in TABLE::delete_row(): it saves the new row into record[2],
restores the conflicting row from record[1] and sets its row_end with
vers_update_end(). The VCOL_UPDATE_FOR_WRITE computation in
vers_update_end() also recomputes stored generated columns. When
Field_blob::store() copies the value into Field_blob::value (e.g. on a
character set conversion), it overwrote the buffer that the stored
generated blob of the new row in record[2] points to, and the new row
was written with the value of the history row. The index on the column
holds the same value, so CHECK TABLE does not detect it.

remember_blob_values(), which keeps Field_blob::value around
vers_update_end() in TABLE::delete_row() and vers_insert_history_row()
and around update_generated_fields() in period_make_insert(), covered
only virtual columns.

The fix adds the with_stored parameter to remember_blob_values(),
restore_blob_values() and free_blob_values(), which also covers stored
generated blob columns. TABLE::delete_row(), vers_insert_history_row()
and period_make_insert() use it and size the storage by
TABLE_SHARE::virtual_fields, the number of all generated columns.
48d70262c107...
48d70262c1077ed2d6e97813f4ef92c145fd4660
Jan Lindström
MDEV-40727 rsync SST symlink coverage gaps

Failure:
- Filesystem flush before transfer only checks symlinks directly under
  the data directory, missing a per-table DATA/INDEX DIRECTORY symlink
  one level deeper (MyISAM, Aria), and missing InnoDB's per-table DATA
  DIRECTORY entirely, since that uses a '.isl' text file, not a symlink.
- The database directory transfer recreates symlinks as symlinks. The
  joiner's rsync daemon cannot keep an absolute symlink target as-is,
  so a MyISAM or Aria table placed by DATA DIRECTORY or INDEX DIRECTORY
  comes out unreadable after the SST.

Fix:
- Extend the flush's symlink search to two levels deep, and add a scan
  for '.isl' files, flushing the filesystem each one points to.
- Transfer the database directories with --copy-links instead of
  --links, so a table file reached through a symlink is copied by
  content instead of recreated as a broken symlink.

Test:
- MDEV-40727.test creates an Aria table with DATA DIRECTORY and INDEX
  DIRECTORY and an InnoDB table with DATA DIRECTORY, forces a full SST,
  then checks the donor's log for the flush of both external
  directories and checksums every table in database test between the
  two nodes.

Assisted-by: https://mariadb.org/governance/governance-ai-policy/
44eec404b35d...
44eec404b35d1e1415bac34aff366bd487cee5a4
Marko Mäkelä
MDEV-41661: Leak and corruption on btr_page_reorganize_low()

btr_page_reorganize_low(): If corruption is found, release the
backup block that had been allocated. This leak was already fixed
in commit fe0c06a232c54f1054778dd59126abc2be451f44 (MDEV-40408).
Furthermore, restore the contents of the old page in order not
to introduce further corruption.

This was motivated by
mysql/mysql-server@9e497b07731a9806afea2365966af1b8032a51b7
which seems to aim to do the opposite of
commit c9498f33dea998de7a128dcd86368f064513cea6 (MDEV-18519)
by introducing an intentional crash on corrupted data.

Reviewed by: Alessandro Vetere
44b576bd4998...
44b576bd4998c82a9cfba8b3fbb90f3930020c1a
Marko Mäkelä
MDEV-41669 ALTER TABLE…IMPORT TABLESPACE may break MVCC

row_import_for_mysql(): Invalidate any old read views that
may have an old snapshot.

Based on mysql/mysql-server@b1fc1e18b76ceb1204634beb65be81ddc6c4104a
44116eca17c7...
44116eca17c7b4230e85a5a48840b4a9c279a8fd
Rex Johnston
MDEV-36295 INTERVAL function returns inconsistent results when used in a WHERE clause

A query like

  select * from (select a, b from t1 group by a, b) d
    where interval(d.a, 3, 7) = 1

returned no rows when the condition was pushed into the derived table,
although the row (5,20) matches, as condition_pushdown_for_derived=off
shows.

Item_func_interval kept its first argument, the Item_row, in a member
of its own as well as in args[0]. Condition pushdown copies the condition
with deep_copy(). The copy of the node got new arguments but kept the
member, so it went on reading the original row: the INTERVAL() pushed into
the derived table compared the original outer column, and the pushed
condition rejected every row.

Item_func_interval now reads the row through args[0] alone, so a copy
cannot point anywhere else.

This commit was prepared with Claude Code (Opus 5).
438b373b911c...
438b373b911cebcc3109c0accd92628c739af55b
Aleksey Midenkov
MDEV-41617 Index corruption on UPDATE of table with long unique hash collision and indexed virtual blob

handler::check_duplicate_long_entry_key() reads all rows with the same
long unique hash. Each read (ha_index_read_map() and every
ha_index_next_same() hit) runs TABLE::update_virtual_fields() with
VCOL_UPDATE_FOR_READ, which swaps Field_blob::value and read_value of
virtual blob columns. The swap was undone only after the first read.
Every further read swapped again, so the buffer that record[1] (the old
row of UPDATE) points to ended up in value: the next read stored the
lookup row into it, or restore_blob_values() freed it. InnoDB then
built the old secondary index key from overwritten or freed memory and
did not find the record to update.

The fix undoes the swap after each read.
2ed262bfb28c...
2ed262bfb28cbb782c7671f5c5301ab85316528e
Kristian Nielsen
Fix hang on master when disabling semi-sync

There is a global variable global_ack_signal_fd used to signal the receiver
thread to wake up when disabling semi-sync. This variable was cleared to -1
in the Ack_listener destructor, which ran at the end of the
Ack_receiver::run() function without any locking. If the thread was delayed
at that point, it could end up overwriting the new value set by a new
receiver thread. This would leave the server in a state with an invalid
global_ack_signal_fd and could cause a subsequent disable of semisync to
fail due to the wakeup not arriving at the receiver thread.

This was seen as a sporadic failure of the test case
rpl.rpl_semi_sync_cond_var_per_thd.

Fix by not modifying the global in constructor/destructor; instead set and
clear the global explicitly, allowing to clear the fd with proper locking
while the mutex is still being held.

Also fix a missing pthread_join(), which would leak thread descriptors and
allow to start a new receiver thread before the old one shut down fully.

(Either of these two changes fix the hang bug).

Signed-off-by: Kristian Nielsen <[email protected]>
291c71dc8a0f...
291c71dc8a0fc95aef4235eefb24586f907cf5fb
Sergei Petrunia
Remove JOIN_TAB::related_tables

The member was added by:
commit 1d82e5daf71
Author: Monty
Date:  Mon Jun 13 2022

    Move join->emb_smj_nest setting to choose_plan()

and has never been used, neither read nor assigned.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
25a366f10fc4...
25a366f10fc41d2f939431155d56b15e55ccaca5
Sergei Petrunia
Remove JOIN::select_list_used_tables, eval_select_list_used_tables()

JOIN::select_list_used_tables is computed by
JOIN::eval_select_list_used_tables(), but never read. Its last reads
(in the code that optimizes DISTINCT on a subset of the tables, and in
JOIN_TAB::save_explain_data()) were removed by:
commit 2cfc450bf78c2d951729d1a0e8f731c0d987b1d5
Author: Igor Babaev <[email protected]>
Date:  Tue Feb 9 2016

    This is the consolidated patch for mdev-8646: "Re-factor the code
    for post-join operations".

Remove the member and the function that computes it.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
22270903f19e...
22270903f19e02d40537ec688e3385374da33346
Oleksandr Byelkin
Fix MSAN failure in mysqltest with --cursor-protocol after CC update

CONC-821 in Connector/C 3.3.21 no longer resets *length for string
binds, so for NULL values the length array in append_stmt_result()
stayed uninitialized. Zero-fill it on allocation.
1d12434a4f9e...
1d12434a4f9e0a91fc2ddff3f9e9da95aee1eb28
Thirunarayanan Balathandayuthapani
MDEV-41667 InnoDB: Failing assertion: buf <= (byte*) original_upd_buff + buff_len

Problem:
=======
An UPDATE on an InnoDB table with several indexed virtual columns
could corrupt the heap in calc_row_difference() because the
write pointer went past the end of the update buffer.

ha_innobase::update_row() sized the buffer from the row length, the
maximum key length and fixed padding. That did not allow for the
extra packed values calc_row_difference() stores for indexed
virtual columns for both the new value and the old value.

Solution:
========
  When allocating the update buffer in ha_innobase::update_row(),
add pack_length() of every virtual column. The row length
already counts each virtual column once, so the buffer can now
hold both the new and old packed values. All virtual columns
are counted, not only the indexed ones, because the buffer
is reused and a column may become indexed after it is allocated.

Based on mysql/mysql-server@12655140610674db615547cdf86af1f7cbf563c1
16aa5d6f4a5b...
16aa5d6f4a5b0fe3355082c6b90930a221e9b74b
Oleksandr Byelkin
MDEV-41566 Allow ROW_NUMBER as unquoted column name

MDEV-26611 made ROW_NUMBER an always-recognized keyword (for
GET DIAGNOSTICS / SIGNAL) and put it in the reserved keyword list,
so it could no longer be used as an unquoted identifier.

Make ROW_NUMBER_SYM a non-reserved keyword (keyword_sp_var_and_label,
like LAST_VALUE), so ROW_NUMBER() still parses only as the window
function.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
120162359b05...
120162359b059b5abf0eb310c5ad590731dd17eb
Raghunandan Bhat
MDEV-40616: MSAN - use-of-uninitialized-value in extract_date_time()

Problem:
  STR_TO_DATE(str, format) with %., %@ and %# format specifiers could
  read past the end of str, because the loops in extract_date_time()
  read a byte before checking for the end of str. When str was not
  NUL-terminated, that byte was uninitialized, causing the MSAN error.

Fix:
  Check for the end of str before reading the next byte.
100c630b0a8e...
100c630b0a8e5d685aa1589e6c3921040177c726
Aleksey Midenkov
MDEV-39306 Comments on update_virtual_fields() modes
BuildBot (0.8.9) working for the MariaDB project.
Page built: Fri 23 Oct 2026 17:01:07 (UTC)