Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
Mohamed
MDEV-40423 use-of-uninitialized-value in Gis_point::get_data_as_wkt(String*, char const**) const

read_point_from_json() returned success for a GeoJSON position with
fewer than two numbers, leaving x and/or y uninitialized. They were
then stored in the WKB and read by ST_AsText().

Reject such positions as incorrect GeoJSON, since RFC 7946 requires
at least two numbers.
Dave Gosselin
MDEV-42078:  Map macOS errno 63 in main.create_notembedded

Maps errno 63 to 36 in the output of the first CREATE TABLE in
main.create_notembedded, as main.symlink does.  That statement creates
a table whose file name is 255 bytes and expects ENAMETOOLONG in the
error, which is 36 on Linux and 63 on macOS.  The test has failed on
macOS since d0b279f1852 added it.

Assisted-By: Claude Opus 5.5 <[email protected]>
Oleksandr Byelkin
Merge branch '13.1' into bb-13.1-release
drrtuy
feat: MDEV-40672 implement basic support for the pluggable aggregate functions
bsrikanth-mariadb
MDEV-42186: Info leak with optimizer_replay_context

When @@optimizer_replay_context is set, the replay reports mismatches
between the context and the optimizer's statistics as warnings that name
tables, indexes and ranges. For a view, stored routine or trigger those
names can belong to objects the invoker has no privilege to see, for
example the base tables of a DEFINER view, or a key number and the
view's hidden predicate through a records_in_range() call.

Apply the same privilege checks the optimizer trace and the optimizer
context recorder already use:

* Optimizer_context_replay gets a missing_priv flag, set through
  missing_privilege(). Optimizer_context_replay::has_records() returns
  false once it is set, and every infuse_*()/store_*() entry point
  already bails out on !has_records(), so no warning is produced and no
  replayed data is used.
* opt_trace.cc: report_missing_privilege() also notifies the replay, and
  the checks for tables, views, stored routines and the security context
  no longer return early when only a replay is active.

Table-level SELECT is required, so column-level grants do not enable the
replay, even when they cover all columns. The flag is never cleared
within a statement. For a stored function or trigger the check runs when
it is called, so output for tables already optimized stays.

Add test opt_context_replay_view_leak.
Vladislav Vaintroub
MDEV-38741 mtr: do not suppress the reason of a client disconnect

The global suppressions of "Aborted connection", in mariadb-test-run.pl
and mtr_warnings.sql, hid the line that the client disconnect watcher
writes when it aborts a command: "Aborted connection N to db: 'x' user:
'u' host: 'h' (Client disconnected)". Nothing showed when the watcher
aborted a connection that it should have left alone. main.locale found
one, because its server log is in German and the English entry did not
match.

Make the two entries skip a line that ends in "(Client disconnected)".
Other aborted connections are suppressed as before. The tests that drop
a client on purpose accept the reason with mtr.add_suppression(),
details in PR#6035.

Assisted-by: Claude:claude-sonnet-5-5
Vladislav Vaintroub
MDEV-38741 Abort the running statement when its client disconnects

A watcher thread subscribes to the OS notification that a client has
gone (e.g. TCP FIN or RST for a TCP socket, a gone client process for a
named pipe) and aborts the running statement like KILL CONNECTION does.
Controlled by the global variable disconnect_watcher. Details in
PR#6035.

Assisted-by: Claude:claude-sonnet-5-5
Vladislav Vaintroub
MDEV-42258: Windows ignores --back-log, simultaneous connects are refused

On Windows, listen() with a positive backlog is limited to a small value,
so a burst of simultaneous connections (e.g. 256 clients) overflows the
accept queue and some are refused with WSAECONNREFUSED (10061).

For TCP listening sockets, including the extra port, pass
SOMAXCONN_HINT(back_log) when back_log >= 200, the range it supports
(200-65535). Smaller values are passed as before.

Assisted-by: Claude:claude-sonnet-5-5
Oleksandr Byelkin
Merge branch 'main' into bb-13.2-release
Vladislav Vaintroub
MDEV-38741 Abort the running statement when its client disconnects

A watcher thread subscribes to the OS notification that a client has
gone (e.g. TCP FIN or RST for a TCP socket, a gone client process for a
named pipe) and aborts the running statement like KILL CONNECTION does.
Controlled by the global variable disconnect_watcher. Details in
PR#6035.

Assisted-by: Claude:claude-sonnet-5-5
ParadoxV5
forgot to update this test
ParadoxV5
missed this spot
bsrikanth-mariadb
MDEV-42044: I_S.OPTIMIZER_CONTEXT exposes rows, DDL and statistics ...

Optimizer Context has DDLs of used tables and VIEWs, table statistics,
and even captured table rows which include all, even the columns that
the query doesn't read.

The user running the query might not have access to some of this
information. Making it available in the optimizer context would create
an opportunity to bypass the security controls.

There is a similar issue in the Optimizer Trace. It is solved by NOT
producing optimizer trace if it would expose data that's not available
otherwise. We have to extend that logic for context recorder as well.

Optimizer Trace relied on opt_trace_disable_if_no_tables_access(), to
check if the query object had privilege to execute.

Solution
========
Run opt_trace_disable_if_no_tables_access() once in
mysql_execute_command(), after the trace, and recorder are created.
Along with it set missing_priv flag in the recorder object if needed.
This flag is used to skip recording the stats, and not dump the
context at the end of query execution.
Alexey Yurchenko
MGL-301 Add MTR tests and fix error reporting
Vladislav Vaintroub
MDEV-38741 mtr: do not suppress the reason of a client disconnect

The global suppressions of "Aborted connection", in mariadb-test-run.pl
and mtr_warnings.sql, hid the line that the client disconnect watcher
writes when it aborts a command: "Aborted connection N to db: 'x' user:
'u' host: 'h' (Client disconnected)". Nothing showed when the watcher
aborted a connection that it should have left alone. main.locale found
one, because its server log is in German and the English entry did not
match.

Make the two entries skip a line that ends in "(Client disconnected)".
Other aborted connections are suppressed as before. The tests that drop
a client on purpose accept the reason with mtr.add_suppression(),
details in PR#6035.

Assisted-by: Claude:claude-sonnet-5-5
forkfun
MDEV-42222 String copy must not share a heap buffer

A copy of a String pointed to the buffer of the original and kept its
capacity without owning the buffer. Condition pushdown copies items
with shallow_copy(): all String members of the copy, and
Arg_comparator::value1/value2 of a copied comparison, shared the
buffers of the original item. When the original item reallocated
a buffer for a longer value, the copy kept using the freed one,
e.g. UPPER, CAST(.. AS CHAR), STR_TO_DATE and JSON_EXTRACT
comparison on 2nd execution of a prepared statement.

The copy constructor of a String that owns its buffer copies the data
now. A copy of a String that doesn't own its buffer points to the same
data and has no capacity.

Assignment still makes the String point to the data of the other one,
but without capacity. No code that writes through an assigned String
was found.

SFORMAT copied every String argument twice per row. It passes them by
reference now, to avoid copying the data.

Tests: main.in_subq_cond_pushdown and main.ctype_ucs.

Assisted-By: Claude:claude-sonnet-5-5
Vladislav Vaintroub
MDEV-42258: Windows ignores --back-log, simultaneous connects are refused

On Windows, listen() with a positive backlog is limited to a small value,
so a burst of simultaneous connections (e.g. 256 clients) overflows the
accept queue and some are refused with WSAECONNREFUSED (10061).

For TCP listening sockets, including the extra port, pass
SOMAXCONN_HINT(back_log) when back_log >= 200, the range it supports
(200-65535). Smaller values are passed as before.

Assisted-by: Claude:claude-sonnet-5-5
Oleksandr Byelkin
Merge branch 'bb-13.1-release' into bb-13.2-release
drrtuy
Item_sum_test_plugin_first shallow copy changed b/c its implementation leaked memory.
Vladislav Vaintroub
MDEV-38741 mtr: do not suppress the reason of a client disconnect

The global suppressions of "Aborted connection", in mariadb-test-run.pl
and mtr_warnings.sql, hid the line that the client disconnect watcher
writes when it aborts a command: "Aborted connection N to db: 'x' user:
'u' host: 'h' (Client disconnected)". Nothing showed when the watcher
aborted a connection that it should have left alone. main.locale found
one, because its server log is in German and the English entry did not
match.

Make the two entries skip a line that ends in "(Client disconnected)".
Other aborted connections are suppressed as before. The tests that drop
a client on purpose accept the reason with mtr.add_suppression(),
details in PR#6035.

Assisted-by: Claude:claude-sonnet-5-5
Vladislav Vaintroub
MDEV-38741 Abort the running statement when its client disconnects

A watcher thread subscribes to the OS notification that a client has
gone (e.g. TCP FIN or RST for a TCP socket, a gone client process for a
named pipe) and aborts the running statement like KILL CONNECTION does.
Controlled by the global variable disconnect_watcher. Details in
PR#6035.

Assisted-by: Claude:claude-sonnet-5-5
Vladislav Vaintroub
MDEV-38741 mariabackup: run the debug DDL as one statement

The debug thread of mariabackup that emulates a DDL sends several
statements in one query, and closes its connection as soon as the first
of them returned. The server used to run the rest. A server that aborts
the statement of a client that is gone does not, and
mariabackup.innodb_ddl_on_intermediate_table hangs, as the debug sync
signals the main thread waits for do not come. Run the statements in
one BEGIN NOT ATOMIC block, so that the client waits for all of them.
The ALTER of that test fails with a lock wait timeout on purpose, which
the handler of the block ignores, as the thread did before.

Assisted-by: Claude:claude-sonnet-5-5
drrtuy
MDEV-41352 Pluggable Aggregate Functions now supports FILTER syntax.
Vladislav Vaintroub
MDEV-38741 mtr: do not suppress the reason of a client disconnect

The global suppressions of "Aborted connection", in mariadb-test-run.pl
and mtr_warnings.sql, hid the line that the client disconnect watcher
writes when it aborts a command: "Aborted connection N to db: 'x' user:
'u' host: 'h' (Client disconnected)". Nothing showed when the watcher
aborted a connection that it should have left alone. main.locale found
one, because its server log is in German and the English entry did not
match.

Make the two entries skip a line that ends in "(Client disconnected)".
Other aborted connections are suppressed as before. The tests that drop
a client on purpose accept the reason with mtr.add_suppression(),
details in PR#6035.

Assisted-by: Claude:claude-sonnet-5-5
ParadoxV5
MDEV-21322 Report Slave Progress to the Master

(Draft: Commit message is staged on the PR.)
drrtuy
MDEV-41270: every PAF implementation decides whether it supports DISTINCT argument or not.
Oleksandr Byelkin
Fix crossbreed of MDEV-41491 and MDEV-35254 (plugins.parsec crash).

Check length first.
Sergei Golubchik
stabilize I_S.VECTOR_INDEXES.INDEX_SIZE after an INSERT

innodb needs time for the value to stop changing. wait for it.
drrtuy
MDEV-41269 PAF fix for DISTINCT + literal argument.
ParadoxV5
MDEV-21322 Report Slave Progress to the Master

(Draft: Commit message is staged on the PR.)
sjaakola
MDEV-41597: Do privilege checks of triggers and views before TOI

CREATE TRIGGER, CREATE VIEW and ALTER VIEW did some of their privilege
checks only after TOI had replicated the statement. The applier runs
with all privileges, so a statement refused on the originating node
was still applied by the other nodes:
- the DEFINER clause (sp_process_definer(), which requires SET USER
  for a DEFINER other than the current user), for all three
  statements, creating the trigger or view with a DEFINER the user
  was not allowed to use
- the column privileges of a view (ER_COLUMNACCESS_DENIED_ERROR),
  creating a view that gives more privileges than the user has on
  the underlying tables

ALTER VIEW without a DEFINER clause also replicated the wrong
definition. fill_defined_view_parts(), which takes DEFINER, ALGORITHM
and SQL SECURITY from the existing view, ran after the replicated
statement had been built, so the other nodes got the current user as
DEFINER and the default SQL SECURITY.

Do the checks before TOI begins, as is already done for stored
routines and events:
- mysql_create_or_drop_trigger() calls sp_process_definer() for
  CREATE TRIGGER before WSREP_TO_ISOLATION_BEGIN, and
  Table_triggers_list::create_trigger() no longer calls it.
- mysql_create_view() calls fill_defined_view_parts() (ALTER VIEW)
  and sp_process_definer() early, and begins TOI only after all
  checks, just before mysql_register_view().

The order of checks changes for all builds: the DEFINER error is now
reported before some errors that were found later in the statement.

The test galera.galera_toi_definer_check checks that:
- CREATE TRIGGER, CREATE VIEW and ALTER VIEW refused for a foreign
  DEFINER on node_1 are not applied on node_2
- CREATE VIEW refused for missing column privileges on node_1 is not
  applied on node_2
- ALTER VIEW without a DEFINER clause keeps the same DEFINER and
  SQL SECURITY on both nodes

Assisted By: Claude Opus 5.5
Vladislav Vaintroub
MDEV-38741 Abort the running statement when its client disconnects

A watcher thread subscribes to the OS notification that a client has
gone (e.g. TCP FIN or RST for a TCP socket, a gone client process for a
named pipe) and aborts the running statement like KILL CONNECTION does.
Controlled by the global variable disconnect_watcher. Details in
PR#6035.

Assisted-by: Claude:claude-sonnet-5-5
ParadoxV5
MDEV-21322: Delete extra `remove_slave()` call

The `Ack_receiver::remove_slave()` call in
`kill_zombie_dump_threads()`’s loop callback is not necessary,
because binlog dump threads that have called `Ack_receiver::add_slave()`
will call `remove_slave()` during cleanup anyway.
This commit erases this extraneous call, for it wastes the dump thread’s
normal `remove_slave()` step, which locks `Ack_receiver`’s global mutex.
MDEV-21322 (report ACKs on SHOW SLAVE HOSTS) also has trouble
matching its synchronization needs with this global lock acquisition.