Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
Brandon Nesterenko
MDEV-34348: Review 1-  remove unused spider_ha_get_key()
Brandon Nesterenko
MDEV-34348: Review1 - make tztime funcs static (that are only used in that file)
Yuchen Pei
MDEV-28413 Temp review changes
Thirunarayanan Balathandayuthapani
MDEV-34529  Shrink the system tablespace when system tablespace contains MDEV-30671 leaked undo pages

- InnoDB fails to shrink the system tablespace when it contains
the leaked undo log pages caused by MDEV-30671.

- InnoDB does free the unused segment in system tablespace
before shrinking the tablespace.

inode_info: Structure to store the inode page and offsets.

fil_space_t::garbage_collect(): Frees the system tablespace
unused segment

fsp_free_unused_seg(): Frees the unused segment

fsp_get_sys_used_segment(): Iterates through all default
file segment and index segment present in system tablespace.

fseg_inode_free(): Frees the extents, fragment pages for the
given index node and ignores any error similar to
trx_purge_free_segment()

trx_sys_t::reset_page(): Retain the TRX_SYS_FSEG_HEADER value
in trx_sys page while resetting the page.
Monty
Fixed bug in main.connect test where Connection_errors showed wrong value
Jan Lindström
wip
Daniel Black
MDEV-34348: Add cast-function-type-strict to warnings
Brandon Nesterenko
MDEV-34348: Review1 - Add my_cmp.h
Monty
fixup! 26dd3af6c52d9cdad175967d56257acdb82fac30
Brandon Nesterenko
MDEV-34348: Review1 - make tztime funcs static (that are only used in that file)
Brandon Nesterenko
MDEV-34348: Review 1-  remove unused spider_ha_get_key()
Brandon Nesterenko
MDEV-34348: Review1 - Remove queue_compare, use qsort_cmp2
Daniel Black
MDEV-34509: UBSAN: call to function option_cmp(my_option*, my_option*) through pointer to incorrect function type

Clang-18 was detecting these calls as undefined behaviour.

Comparison functions to conform to the specification require constant
arguments.

Make this the same for filesort too.
Brandon Nesterenko
MDEV-34348: typedef qsort2_cmp queue_compare

A large contributor to -Wcast-function-type-strict errors comes from
qsort2_cmp and queue_compare functions often cast as one-another.
Each function’s signature pre-patch is:

typedef int (*qsort2_cmp)(const void *, const void *, const void *);

typedef int (*queue_compare)(void *,uchar *, uchar *);

This patch changes the queue_compare signature to use the stricter
qsort2_cmp interface definition.
Marko Mäkelä
MDEV-34830: LSN in the future is not being treated as serious corruption

The invariant of write-ahead logging is that before any change to a
page is written to the data file, the corresponding log record must
must first have been durably written.

On crash recovery, there were some sloppy checks for this. Let us
implement accurate checks and flag an inconsistency as a hard error,
so that we can avoid further corruption of a corrupted database.
For data extraction from the corrupted database, innodb_force_recovery
can be used.

Before recovery is reading any data pages or validating the
doublewrite buffer, it will have parsed the log until the
final LSN and updated log_sys.lsn to that. So, we can rely on
log_sys.lsn at all times.

A section of the test mariabackup.innodb_redo_overwrite
that is parsing some mariadb-backup --backup output has
been removed, because that output "redo log block is overwritten"
would often be missing in a Microsoft Windows environment
as a result of these changes.

recv_sys_t::max_page_lsn: Replaces recv_max_page_lsn.

recv_sys_t::early_batch: Whether apply(false) is executing.
Before the final recovery batch, we will not have read the
log records until the end and therefore will not know the final LSN.

recv_lsn_checks_on: Remove.

recv_sys_t::validate_checkpoint(): Validate the write-ahead-logging
condition at the end of the recovery. This includes validating
max_page_lsn in case a multi-batch recovery was executed.

recv_dblwr_t::validate_page(): Keep track of the maximum LSN
(if we are checking a non-doublewrite copy of a page) but
do not complain LSN being in the future. The doublewrite buffer
is a special case, because it will be read early during recovery.
Besides, starting with commit 762bcb81b5bf9bbde61fed59afb26417f4ce1e86
the dblwr=true copies of pages may legitimately be "too new".

recv_sys_t::set_max_page_lsn(): Update recv_sys.max_page_lsn.

recv_dblwr_t::find_page(): Find a valid page with the smallest
FIL_PAGE_LSN that is in the valid range for recovery.

recv_dblwr_t::restore_first_page(): Require the recv_sys.mutex
to be held by the caller, and return an error code.

buf_dblwr_t::recover(): Simplify the message output. Do attempt
doublewrite recovery on user page read error. Ignore doublewrite
pages whose FIL_PAGE_LSN is outside the usable bounds. Previously,
we could wrongly recover a too new page from the doublewrite buffer.

buf_page_is_corrupted(): Distinguish the return values
CORRUPTED_FUTURE_LSN and CORRUPTED_OTHER.

buf_page_check_corrupt(): Return the error code DB_CORRUPTION
in case the LSN is in the future.

Datafile::read_first_page(): Handle FSP_SPACE_FLAGS=0xffffffff
in the same way on both 32-bit and 64-bit architectures.

recv_sys_t::free_corrupted_page(): Take the file as a parameter
and return whether a message was displayed. This avoids some duplicated
and incomplete error messages.

buf_page_t::read_complete(): Remove some redundant output and always
display the name of the corrupted file. Never return DB_FAIL;
use it only in internal error handling.

IORequest::read_complete(): Assume that buf_page_t::read_complete()
will have reported any error.

fil_space_t::set_corrupted(): Return whether this is the first time
the tablespace had been flagged as corrupted.
Monty