Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
e999ed651aaf...
e999ed651aaf60bc2c4b7bf2f4b9f6586896059d
PranavKTiwari
MDEV-40167: GTT created with the InnoDB incorrectly accept FULLTEXT/VECTOR indexes
Problem:
GLOBAL TEMPORARY tables were not subject to the same option/index restrictions as session TEMPORARY tables. Several InnoDB and server-layer checks tested only tmp_table(), so GLOBAL TEMPORARY tables could bypass validation for VECTOR/FULLTEXT indexes, DATA DIRECTORY, KEY_BLOCK_SIZE, and ROW_FORMAT=COMPRESSED.

Cause:
global_tmp_table() was added as a separate predicate from tmp_table(), but not all temp-table checks were updated to test both, so GLOBAL TEMPORARY tables fell through to "permanent table" logic in several places.

Fix:
Added global_tmp_table() alongside tmp_table() at each affected check:

Reject VECTOR and FULLTEXT indexes on GLOBAL TEMPORARY tables.
Reject/warn on DATA DIRECTORY, KEY_BLOCK_SIZE, and ROW_FORMAT=COMPRESSED for GLOBAL TEMPORARY tables, with accurate wording in the DATA DIRECTORY warning.
Fixed zip_allowed and related ut_ad assertions to exclude GLOBAL TEMPORARY tables.
Fixed m_use_file_per_table in set_tablespace_type() to exclude GLOBAL TEMPORARY tables (also fixes m_use_data_dir).
GLOBAL TEMPORARY tables now validate the same as session TEMPORARY tables across these options.
e0219876f430...
e0219876f430603f313dcc60a5762f9b5d7259aa
Sergei Golubchik
MDEV-40340 mariadb-import --lock-tables crashes

don't change `argv` pointer, it's needed later for --lock-tables
deed18f42d59...
deed18f42d59193afbc8f64ebd8fdcff4cafd9e1
Dave Gosselin
MDEV-40143: st_isvalid() does not clear NULL state between rows

The st_isvalid() function evaluates nullability on every row.  Previously,
it would preserve potentially stale null state between rows, so the first
row yielding a null result for st_isvalid() would propagate to the results
for the remaining rows.

Implementation-wise, this patch changes the Item_func_isvalid::val_int
method implementation to work like Item_func_validate::val_str in that it
assumes that the method will indicate a null result for the row unless
it returns a non-null result, at which point it clears the null_value flag.
d703f0ef5164...
d703f0ef516435fa5c66b4a0fdbf0384ba25bf8e
Dave Gosselin
MDEV-39914:  Crash in ST_SIMPLIFY used in an IN list

A geometry function writes its binary result into a buffer given by
the caller.  ST_SIMPLIFY did not set the charset of that buffer.  A
constant value in an IN list, though, is stored into the array that IN
builds for its comparisons, and that array has no charset.  Appending
the geometry then read an invalid charset and crashed the server.

Set the result buffer to the binary charset before writing the
geometry, matching what the other geometry functions already do.
d4b7fcf13e4d...
d4b7fcf13e4de2540878aa0a316c900d9873da5e
Sergei Golubchik
MDEV-40312 SHOW CREATE SERVER incorrect quoting

quote protocol name and option names
cf4215c4625e...
cf4215c4625edfc13c0d97b97c36e4ef15c91dbd
Brandon Nesterenko
MDEV-39302: main.xa wrong errno ER_XAER_NOTA instead of ER_XA_RBROLLBACK

Revert some changes of bead24b7f3dff5a1fe8bcd283eccb7b654495b3e
which incorrectly removed wait_until_count_sessions.inc from xa.test.
This test relies on having fully disconnected sessions with prepared XA
transactions before progressing with the test. I.e., the prepared
transaction must be made fully recoverable before the test progresses to
try and XA COMMIT/ROLLBACK the transaction.

Signed-off-by: Brandon Nesterenko <[email protected]>
c7b23ec8c3ad...
c7b23ec8c3ad06f25c120e0877a28cdac3fbb052
Aleksey Midenkov
MDEV-39306 Index corruption on UPDATE when using versioned InnoDB table (on UPDATE)

VCOL_UPDATE_FOR_READ does not update virtual fields for the following
cases:

1. It is not in read_set;
2. It is not in the index, but can be calculated from index columns;
3. It is stored virtual column.

VCOL_UPDATE_FOR_WRITE does not have conditions 2. and 3.

Test case fails condition 3., stored vcol was not updated by
VCOL_UPDATE_FOR_READ. Since vers_update_fields() is only for write
operations it is safe to change it to VCOL_UPDATE_FOR_WRITE.
b548dfa6bebb...
b548dfa6bebbc6558979734306185a7edacaa94d
bsrikanth-mariadb
MDEV-39916: Crash when pushing "NOT col" from HAVING into WHERE

"NOT column" rewrites itself into "column = 0" in fix_fields().
However the rewrite is not done when the "column" is wrapped in an Item_ref.

Later, pushdown_from_having_into_where() will strip the Item_ref object
and will call
  Item_func_not(Item_field())->fix_fields(thd, ref=NULL);
This call will attempt the rewrite and crash when writing into NULL pointer.

Fixed this in two places:
* Make Ittem_func_not::fix_fields() use real_item() and so recognize fields
  wrapped in Item_ref-like objects.

* Make pushdown_from_having_into_where() pass the right pointer as
  fix_fields() argument.
a976641c105d...
a976641c105d0575b19d7f79198d45650a87854e
Aleksey Midenkov
WITHOUT_ABI_CHECK followup

Followup for b337e14440b as info_src takes time too.
info_src does not make much sense without ABI check.
a619e2ca0c66...
a619e2ca0c66e02bc045a9afed7db64c389df056
bsrikanth-mariadb
MDEV-16462: explain format=json produces illegal json text

The attached_condition field of the produced json text had
"String with illegal unicode symbol" instead of the proper unicode
value.

The reason is that, the item field when being written to the json
writer in write_item(), used a String with charset my_charset_bin,
and that prevented the string from being escaped.

Solution is to change: -
1. charset to my_charset_utf8mb4_bin in sql_explain.cc.
2. Item::print_value(), handle string type specially if
  the charset is my_charset_bin by appending hex value.
a53bd28dce26...
a53bd28dce26f149a13278ca93deb561084e19f1
Sergei Golubchik
MDEV-40311 mariadb-dump doesn't always quote identifiers

11.8 part. SHOW CREATE SERVER
91ce15913625...
91ce15913625c2706f7b1376efbba69b9d4678f7
Sergei Golubchik
CREATE SERVER: fix option parsing to support backticks properly

CREATE SERVER used to:
* support arbitrary options in backticks and not in backticks
* hard-coded historical options worked *only* without backticks
* PORT range was different when given as a number or a string

all that is fixed, unused keywords are removed
8f0aef931a2c...
8f0aef931a2c8a5ef68f51c185ac2225746cb819
Yuchen Pei
MDEV-31182 Make Field_geom::set_key_image do nothing

In fact, it should not be called at all, as GIS indexes do not store
the whole data.

Remove the only known callsite covered by a testcase (added in this
commit), in print_key_part_value
8da34620ac39...
8da34620ac3935814cc7f9ba30bb51a6e2070237
Daniel Black
MDEV-40275: plugins.auth_ed25519 test falky - dropped users with connection warning

The slow cleanup of disconnected connections means that they
may still be visible as the DROP USER is executed. Ignore these
warnings.
88366c4ff105...
88366c4ff1055d16370981377526ba82a0140e6b
Alexey (Holyfoot) Botchkov
MDEV-39683 Numeric aggregates should end up with an error for xmltype.

Appropriate xxx_fix_length_and_dec() added to the Type_handler_xmltype.
85e02312a274...
85e02312a274fd0295061515777a4930f0e0638b
Aleksey Midenkov
MDEV-32317 Trace for ref_ptrs array (ref_array keyword)

Usage:

  mtr --mysqld=--debug=d,ref_array,query:i:o,/tmp/mdl.log
84312a7e2edc...
84312a7e2edc2a78bf470b39b99ef9cbf0e6c894
Sergei Golubchik
mysqldump: remove dead and broken code

since 2006 (3840774309bc) mysqldump tried to be smart when dumping
events - it tried to automatically detected a delimiter per event
that was not present in the event body, using ";;" by default.

This never worked, was broken since the first commit. It either used
the default ";;" or failed after trying the same ";;" delimiter
2147483646 times.

All other objects (routines, triggers, etc) used a hard-coded ";;"
for 20 years, which apparently worked fine. Let's remove the old
broken logic and dump events like all other objects,
80ff192cb37b...
80ff192cb37b3b6b9dac8bd05f91312d5153bfde
Sergei Petrunia
MDEV-39005: Assertion failure on hint-forced Split-Materialized plan

The problem: consider a query in form:
  t1 JOIN (SELECT a FROM t2 GROUP BY a) dt ON dt.a=t1.a

After fix for MDEV-30877, the optimizer computes the number of GROUP BY
groups that we will have in the materialized derived table. It is saved
into TABLE(dt)->used_stat_records and propagates into
TABLE(dt)->opt_range_condition_rows.

On the other hand, the Split-Materialized optimization tries to compute
the number of rows it expects to find in the Split-Materialized derived
table.

These two numbers may come into disagreement: Split-Materialized may
produce a higher number, save it into JOIN_TAB::records and cause this
assertion in apply_selectivity_for_table() to fail:

    double table_records= rows2double(s->records);
    DBUG_ASSERT(table_records == 0 ||
                sel <= s->table->opt_range_condition_rows /
                table_records);

We will have sel=1.0 but opt_range_condition_rows < table_records.

Cardinality computations in Split-Materialized code omit a lot, for example
they omit the fact GROUP BY operation will reduce the number or rows.

For now, use a trivial fix: make sure Split-Materialized's estimate of
JOIN_TAB::records doesn't exceed the derived table size.
8038295728d8...
8038295728d85c1883436c81b23a9e3b21992bb4
Rex Johnston
MDEV-26940 Item_cond::remove_eq_conds leaves corrupt Item_equal

pushdown_cond_for_derived/merge_into_list/remove_eq_conds leaves
an Item_equal in an invalid state.  This Item_equal is later used
by find_producing_item causing an assert in debug builds and perhaps
incorrect results in a release build. This Item_equal should no longer
be referred to, so rather than correct the Item_equal, we correct the
reference used later to look up our base table field.

Affected queries will likely have an outer condition pushed down into
2 different derived tables based on the same base table.
7ec210f7c1c3...
7ec210f7c1c3bce3a63b1f644d226b42bcebc6b5
Aleksey Midenkov
MDEV-39384 Comments on update_virtual_fields() modes
79c7437e64bf...
79c7437e64bf1a70a796690bc627a35a8b42ffe8
Sergei Golubchik
MDEV-40311 mariadb-dump doesn't always quote identifiers

11.8 part. SHOW CREATE SERVER
7322881f977d...
7322881f977ddace899aca46a4180b2f93fb78c7
Sergei Golubchik
MDEV-40311 also fix mariadb-show and mariadb-convert-table-format
6c72f570c5a5...
6c72f570c5a5a7fce28ab3f851209e82595f4226
Aleksey Midenkov
MDEV-39184 TABLE_LIST C++-friendly initialization refactoring

The problem with the current initialization is that TABLE_LIST ctors
as well as init_one_table*() functions call reset() that byte-zeroes
the object after encapsulated objects were initialized by their
constructors. That specifically creates the wrong value for
mdl_request.type which must be MDL_NOT_INITIALIZED (-1) by default and
bzero() reverts it to MDL_INTENTION_EXCLUSIVE (0). And these constant
values is not easy (if not possible) to change.

The fix introduces utility base class Byte_zero which moves bzero()
call before the encapsulated ctors (as parent classes' ctors are
called first). So now encapsulated ctors are not called redundantly
and no double initialization is needed.

All the C++-constructed objects call init_one_table*() as before, only
without reset(). The C-alloced objects call init_one_tab*_r() versions
that call reset(). These will be replaced back to no-reset() versions
after their allocation is refactored to C++ version.
40de612592e1...
40de612592e1c99f3c2132b5e19fdcf663ba9936
bsrikanth-mariadb
MDEV-40006: Prepared Statement Crash in varchar_upper_cmp_transformer() for '?'

Item_func_in::varchar_upper_cmp_transformer() clones Item_func_in
and its arguments and doesn't check if cloning has succeed.

Item_param (PS parameter, '?') doesn't implement cloning so will return
NULL from clone(). This will cause a crash.

Fixed by making varchar_upper_cmp_transformer() check clone results for NULL.
(Adding cloning support to Item_param is out of scope of this patch).
3adf432a9fc6...
3adf432a9fc68f428e9c8b38129c3b51f78b187f
Marko Mäkelä
Merge 11.8 into 12.3
354a54527dde...
354a54527dde860b1e272498e989b72a34839488
Brandon Nesterenko
MDEV-39302: main.xa wrong errno ER_XAER_NOTA instead of ER_XA_RBROLLBACK

When a session has a prepared an XA transaction (via XA PREPARE), if it
is not yet finalized (via XA COMMIT / ROLLBACK) when the session
disconnects, there is cleanup logic by the disconnecting session to put
this hanging transaction into a recoverable state. The main.xa test
follows a pattern where it disconnects these transactions, but doesn't
wait for the session to finalize before it tries to finalize these
transactions. If the transaction hasn't yet been put into a recoverable
state, when the test tries to XA COMMIT or XA ROLLBACK the transaction,
it results in the error:

mysqltest: At line 831: query 'xa commit 'c:foo'' failed: ER_XAER_NOTA (1397): XAER_NOTA: Unknown XID

The test is fixed by waiting for the XA PREPARE'ing session
to finalize and be disconnected before trying to recover/commit/rollback
it.

Signed-off-by: Brandon Nesterenko <[email protected]>
34ef9dc8d04c...
34ef9dc8d04c146c0ff7c4725eb0517cddefccda
PranavKTiwari
Added check.
34c13d107956...
34c13d1079565ecf485812e19e3505490f74f4a9
ParadoxV5
Fix `Gtid_log_event::is_part_of_group()`

It is the only event type that returns `true` in
`Log_event::is_part_of_group(enum Log_event_type)` but `false` in
`Log_event::is_part_of_group()`.
31e0e67931ad...
31e0e67931adbb614f43563900d72106e33265b0
Sergei Golubchik
MDEV-40340 mariadb-import --lock-tables crashes

don't change `argv` pointer, it's needed later for --lock-tables
2ff230f5fa9b...
2ff230f5fa9b2883646559711d91104e9ed1d8ff
Dave Gosselin
MDEV-39911:  Crash in ST_SIMPLIFY of a collection geometry

ST_SIMPLIFY of a multilinestring, polygon, multipolygon, or geometry
collection reserved space for the result header but omitted the four
byte element count that it then appends.  This resulted in a buffer
overrun.

Reserve the full header size, including the count, in each of the four
collection simplify functions, the same fix applied for MDEV-35062 and
MDEV-36042.
27df5668c2e3...
27df5668c2e3eef406a5357672d3d8e89d25ff48
Daniel Black
MDEV-39763 main.innodb_mrr_cpk fails under view protocol

The rows returned by this under view protocol where inconsistent.

Under view protocol the CREATE VIEW in a different connection
was providing statistics that ended up in the result.

To normalize the output:
* include/innodb_stable_estimates.inc for the test
* Use analyze with persistent stats on the tables.

Despite the CREATE VIEW being executed under view protocol, it
always failed as most cases in the test had t1 and t2 with the same
columns names and a SELECT * FROM t1,t2 form of query. Creating a
view from this query resulting in duplicate result field names
which can't happen in a view. To make the view protocol useful
the SELECT queries where modified to return columns from both
tables with different result field names.

Thanks Rex Johnston for guidance.
269f80792c74...
269f80792c747d3fe3e23cf37a73a056fa02c982
Yuchen Pei
MDEV-31182 Make Field_geom::set_key_image do nothing

In fact, it should not be called at all, as GIS indexes do not store
the whole data.

Remove the only known callsite covered by a testcase (added in this
commit), in print_key_part_value
1db8aceb03c5...
1db8aceb03c58a703b1338ed67da685d575ec640
Sergei Golubchik
mysqldump: remove dead and broken code

since 2006 (3840774309bc) mysqldump tried to be smart when dumping
events - it tried to automatically detected a delimiter per event
that was not present in the event body, using ";;" by default.

This never worked, was broken since the first commit. It either used
the default ";;" or failed after trying the same ";;" delimiter
2147483646 times.

All other objects (routines, triggers, etc) used a hard-coded ";;"
for 20 years, which apparently worked fine. Let's remove the old
broken logic and dump events like all other objects,
1a469c2bbf74...
1a469c2bbf74fe790f931a83bacd17b41c0c4351
Aleksey Midenkov
MDEV-39063 Server crashes at Item_func_lastval and Item_func_setval with CTE alias

Pure aliases are not handled properly by Item_func_lastval::val_int()
and Item_func_setval::val_int().

This is followup fix for MDEV-33985 where it missed similar cases for
LASTVAL() and SETVAL().

add_table_to_list() does not create MDL request for pure aliases,
i.e. when there is no table_list->db set or TL_OPTION_ALIAS was
set. When the expression is not inside CTE the case with empty db is
handled by:

  else if (!lex->with_cte_resolution && lex->copy_db_to(&db))
    DBUG_RETURN(0);

So, table_list gets current database name and the query is failed with
ER_NO_SUCH_TABLE error.

The fix adds the case of is_pure_alias() check for val_int() methods
and fails it with ER_NOT_SEQUENCE2 error.

Note: semantics for TL_OPTION_ALIAS cannot be based on empty db, only
parser can set TL_OPTION_ALIAS as resolve_references_to_cte() relies
on TL_OPTION_ALIAS after copy_db_to().
16020a09e81f...
16020a09e81f4f14176d00d4eab75cf3202ce885
bsrikanth-mariadb
MDEV-16462: explain format=json produces illegal json text

The attached_condition field of the produced json text had
"String with illegal unicode symbol" instead of the proper unicode
value.

The reason is that, the item field when being written to the json
writer in write_item(), used a String with charset my_charset_bin,
and that prevented the string from being escaped.

Solution is to change: -
1. charset to my_charset_utf8mb4_bin in sql_explain.cc.
2. Item::print_value(), handle string type specially if
  the charset is my_charset_bin by appending hex value.
12abe0fed171...
12abe0fed1711e655fd049eded1f73d8b41607aa
Sergei Golubchik
MDEV-40336 SET AUTHORIZATION un-expired passwords

don't allow SET SESSION AUTHORIZATION if the password expired
0dcf049b8894...
0dcf049b8894f3d50b2d4c5b127ae325d68a9704
Aleksey Midenkov
MDEV-38854 Assertion table->vers_write fails upon ODKU into table with versioned column

In MDEV-25644 vers_check_update() sets vers_write to false in case it
returns false. It is ok for UPDATE but is not correct for ODKU is bulk
insert requires vers_write on next tuple.

The fix return vers_write value back when vers_check_update() and
related vers_insert_history_row() are done in ODKU.
0dc08680e36a...
0dc08680e36a7917387b061ab342df106deea693
Yuchen Pei
MDEV-31182 Check for blob too in create_key_parts_for_pseudo_indexes

BLOB and VARCHAR has keys prefixed with length of the payload. This
length data itself has length HA_KEY_BLOB_LENGTH which is 2, as
demonstrated for example in Field_blob::set_key_image and
Field_varstring::set_key_image.

In this patch, when preparing key info for a range analysis, we
account for this extra HA_KEY_BLOB_LENGTH in the total key length for
BLOB. Previously it was only done for VARCHAR. This way, when doing
the actual range analysis, LIKE (Item_func_like::get_mm_leaf) can
correctly identify that it is dealing with a BLOB, thereby allowing
the space of 2 for the length data. This avoids later
Field_blob::set_key_image reading the payload as length data and
causing reading the wrong memory segment for the payload.
0980732af256...
0980732af25606a4488ec9aabe4bd4312729c799
Aleksey Midenkov
MDEV-39184 Cleanup for MDL_NOT_INITIALIZED

As C++ style initialization of TABLE_LIST now works correctly after
Byte_zero refactoring. We may remove MDL_NOT_INITIALIZED double
initialiation.
051f7d95415a...
051f7d95415a53d5b0e11cf55b2dee47f8397e77
Hemant Dangi
MDEV-40280: FreeBSD galera.galera_max_ws_rows test failure

Issue:
For unknown error numbers, BSD-derived libc (macOS, FreeBSD, ...) formats
"Unknown error: <n>" with a colon, while glibc uses "Unknown error <n>".
my_strerror()'s colon-stripping (MDEV-35578) was gated on __APPLE__ only,
so FreeBSD output diverged from the .result.

Solution:
Normalize by behavior instead of by platform: always strip the colon after
"Unknown error". glibc never emits it, so it is a no-op there, and
macOS/FreeBSD/other BSD libc are all covered without enumeration. This is
what MDEV-35578 already intended ("consistent across the platforms ...
when present"); the __APPLE__ guard was just narrower than that intent.
Runs only in the unknown-error path.
BuildBot (0.8.9) working for the MariaDB project.
Page built: Mon 13 Jul 2026 11:59:06 (UTC)