Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
fecb998c2004...
fecb998c20045ee24e25e90309b210519812b6a9
Sergei Golubchik
UBSAN: sql/table.h:237:16: runtime error: load of value 4, which is not a valid value for type 'bool'

the warning was about uninitialized `bool in_field_list`
let's initialize the whole ORDER when it's allocated.
f82577a77b19...
f82577a77b1953bbeb2ec2b511b7185f2fefb1ca
ParadoxV5
MDEV-40236: Generalize `--flashback` error messages for non-flashback

MDEV-20749 moved its improved error reporting from the flashback
code path down to a common function that non-flashback mode also uses.
This makes a side effect that MDEV-20749 also added error reporting to
`mariadb-binlog` non-flashback mode for this particular code path,
whose errors previously were **completely** silent.

These error messages assume that `mariadb-binlog` is in flashback mode,
though; this commit removes this description from these messages
so they make sense in both flashback and non-flashback modes.
It keeps these messages at this location to
maintain the detail level and cross-mode sharing.

(Currently, only unrecognized data types are known to
trigger one of these descritive errors outside of flashback.)
f41bb6ca0479...
f41bb6ca04796ecbe82c2b60780ae7e3430a42c3
Sergei Golubchik
MDEV-40186 MEMORY tables incorrectly restart index scan on DELETE

remember the last found key and restart the search (if needed)
from it not from the original one.
ee6badad0c43...
ee6badad0c4349b2ca60ce01322df31f8135a73b
Sergei Golubchik
MDEV-40337 store user vars in a dedicated memroot

user_var_entry objects and their names have a connection lifetime,
they exist until the connection ends (or is reset), and then they're
all deleted at once. This is exactly the use case for MEM_ROOT,
let's store them there.

Additionally, let's set MY_ROOT_USE_MPROTECT flag to keep this memroot
off the general heap where user_var_entry values are stored
and where heap buffer overflows can happen.

The latter makes memory allocations for the MEM_ROOT about 10x more
expensive, so let's always start with an empty memroot (= zero overhead
if no user variables are used) and on THD cleanup let's retain one
memroot block (= zero overhead if the next connection takes THD from the
cache and uses user variables up to one block size).

Assisted-By: Claude:claude-4.8-opus
e9deead43d49...
e9deead43d49b4d8e04049e54edc36d335303405
Sergei Golubchik
MDEV-40341 store read-only sysvars in a read-only root

Store all READ_ONLY sysvar values in the read_only_root

Even though READ_ONLY sysvars are protected, for string variables
it usually means that the pointer cannot be changed. The value it
points to - the string itself - still can be. Let's store all
values of string READ_ONLY sysvars in the read_only_root.

sysvars that point directly into argv are copied to read_only_root.
sysvars that have their values calculated and allocated now
must be explicitly marked with PREALLOCATED to let it know they
have to be free()-d.

Assisted-By: Claude:claude-4.8-opus
e6b010d82efc...
e6b010d82efcb4797111596184bb3a1b570ef5d6
Sergei Golubchik
fix sporadic galera test failures

* query @@datadir before audit is enabled, not directly before reading
  the log. just in case cat gets the log before SELECT is flushed.
* wait for a table to be dropped
df64bf8114a7...
df64bf8114a7bc8c8c144cb36efb15165daccdbf
Sergei Golubchik
MDEV-40217 restore error handling

get_table_structure() needs to distinguish between
the error condition and 0 fields to dump
df37beffdabd...
df37beffdabdac123565f18e7387f358b69c94c3
monthdev
MDEV-20749 Improve mysqlbinlog --flashback error reporting

Handle corrupted row events by reporting whether the field length could
not be determined from metadata or whether the field extends past the
row buffer instead of falling out through debug-only assertion paths
or ad hoc exits during flashback row conversion. Propagate flashback
conversion failures through the normal mysqlbinlog error path so debug
builds produce the intended diagnostics cleanly.

Add replication tests covering corrupted BLOB metadata and corrupted
BLOB length prefixes using server-side debug injection to write broken
binlog contents and mysqltest-friendly mysqlbinlog invocation patterns.

Reviewed-by: Brandon Nesterenko <[email protected]>
Reviewed-by: Georgi Kodinov <[email protected]>
d3afdd162bf8...
d3afdd162bf8aecde785ccff0fd3dbe47e14923f
Daniel Black
MDEV-35738 mariadb build -fsanitize=pointer-compare

invalid pointer pairs are when the length/memory of one string are
intermixed with another.

For comp_err, the end null pointer was compared to soffset within
my_strtoll10. As we didn't need the end position a NULL arg option
was compatble.

For uca-dump, Address Sanitizer raises invalid pointer pair because
argv options (opt) don't have an obvious correlation of having a start
at opt_X.length, even though the lstrncmp makes this true.

The DBUG_ASSERTS of strmov (added MDEV-11752) where incompatible with
pointer-compare. Replaced strmov with static inline version in
m_string.h using memmove that allows overlaps, and being inline allows
the uneeded parts of the implementation to be optimized away.
ccbc11538e1b...
ccbc11538e1bf766191ecbe010f0224cf5fd65e8
Sergei Golubchik
MDEV-40186 MEMORY tables incorrectly restart index scan on DELETE

remember the last found key and restart the search (if needed)
from it not from the original one.
c5a784873b42...
c5a784873b42aef2981e0f6056336ddc62c3ded3
Sergei Golubchik
MDEV-36147 MariaDB cannot open page-compressed InnoDB tables at startup if innodb_compression_algorithm other than zlib is specified

When innodb_compression_algorithm is set to a non-zlib algorithm (e.g.
lz4) and the provider plugin is loaded from mysql.plugin rather than
command line, InnoDB failed to start because it checked for the provider
at plugin initialization time, before plugin_load() reads mysql.plugin.

Fix:
* InnoDB returns HA_ERR_RETRY_INIT when the compression provider is
  missing.
* In sql_plugin.cc, the retry loop is changed to not reap until
  mysql.plugin has been loaded

Assisted-By: Claude:claude-4.6-sonnet
c594ad6e28ac...
c594ad6e28ac92ad3b9520a2176561e8a0a0f2c9
Sergei Golubchik
cleanup: only include my_compare.h into heap code as needed

to avoid name conflict on `get_key_length`
c20c1b291eab...
c20c1b291eaba696818931ecef299274f0bf28e9
Sergei Golubchik
MDEV-40411 SFORMAT ignores max_allowed_packet

do our own allocator that implements std::allocator interface
but uses our memory accounting (my_malloc) and limits max allocation
(e.g. to max_allowed_packet).

use it for fmt::vformat_to.
later can be used for various std:: stuff too.
ba543f7e5a7b...
ba543f7e5a7be91e437d8261f37545576c544c70
Sergei Golubchik
MDEV-37840 Server crashes when executing FLUSH PRIVILEGES after starting with skip-grant-tables and creating mysql.host table

hash_filo's mutex was lazily initialized in clear(), but grant_reload()
locks acl_cache->lock without first calling clear(). With
--skip-grant-tables, acl_cache is created but clear() is never called
(acl_reload() skips it on error), leaving the mutex uninitialized.

Fix: initialize the mutex eagerly in the hash_filo constructor and
remove the now-redundant init flag.

Assisted-By: Claude:claude-4.6-sonnet
b8b750ece0bf...
b8b750ece0bf45888f71fa6eb6b7389f3d7a3ba8
Sergei Golubchik
cleanup: main.view test
b55c182a4aa6...
b55c182a4aa67f043464ee79cf05c6327d093909
ParadoxV5
MDEV-40236: Generalize `--flashback` error messages for non-flashback

MDEV-20749 moved its improved error reporting from the flashback
code path down to a common function that non-flashback mode also uses.
This brings a side effect that MDEV-20749 also added error reporting
to `mariadb-binlog` non-flashback mode for this particular code path,
whose errors were **completely** silent previously.

These error messages assume that `mariadb-binlog` is in flashback mode,
though; this commit removes this description from these messages
so they make sense in both flashback and non-flashback modes.
It keeps these messages at this location to
maintain the detail level and cross-mode sharing.

(Currently, only unrecognized data types are known to
trigger one of these descriptive errors outside of flashback.)
af4378398b65...
af4378398b656b8deb579ba7617cc6c98ab50b2d
Sergei Golubchik
MDEV-23086 Error codes/messages reveal information about table structure

if a user tries to access a table or a database they have no priivleges
on, the error is alwaus "access denied", independently from whether
the object exists or not. Do the same for columns.
ac1e6ce99d2b...
ac1e6ce99d2b83926f15e5df715472d86a39c3fb
Sergei Golubchik
MDEV-40411 SFORMAT ignores max_allowed_packet

do our own allocator that implements std::allocator interface
but uses our memory accounting (my_malloc) and limits max allocation
(e.g. to max_allowed_packet).

use it for fmt::vformat_to.
later can be used for various std:: stuff too.
a8c5abfe89ae...
a8c5abfe89aed2e22a3aff3757118c870cda4c3a
Sergei Golubchik
MDEV-40217 mariadb-dump --complete-insert emits INSERT statements for tables with only generated columns

post-push fix. if all columns are generated, don't dump any values,
use INSERT INTO `t5` () VALUES (), (), ();
a82cec1d44dc...
a82cec1d44dc05a0c6d0b988428595636512f1c7
Sergei Golubchik
MDEV-40341 store read-only sysvars in a read-only root

Store all READ_ONLY sysvar values in the read_only_root

Even though READ_ONLY sysvars are protected, for string variables
it usually means that the pointer cannot be changed. The value it
points to - the string itself - still can be. Let's store all
values of string READ_ONLY sysvars in the read_only_root.

sysvars that point directly into argv are copied to read_only_root.
sysvars that have their values calculated and allocated now
must be explicitly marked with PREALLOCATED to let it know they
have to be free()-d.

Assisted-By: Claude:claude-4.8-opus
9fd35d996f7d...
9fd35d996f7de797235f4b777562bbc3eecc2ddf
Sergei Golubchik
cleanup: only include my_compare.h into heap code as needed

to avoid name conflict on `get_key_length`
97e8c629f717...
97e8c629f717d0eac0ae301e709f357797cc95ab
bsrikanth-mariadb
MDEV-40518: add both drop table and view stmts

The context only stored "DROP TABLE IF EXISTS t1" before adding a
"CREATE TABLE t1" statement. However, there can be a view named t1
already existing in the database. When the context was replayed,
the CREATE statement failed stating t1 already exists.

Solution is to add both "DROP TABLE IF EXISTS t1", and
"DROP VIEW IF EXISTS t1" before adding a
"CREATE TABLE t1" statement into the context.
8370daf7686b...
8370daf7686b8b5429b5c10ab1d6c6fb2cdbd7b7
Daniel Black
MDEV-40414 Server crash in Charset::charset upon JSON operations

JSON_EQUALS didn't check that ::val_str() of its arguments
where not-null before attempting to test their equality.

JSON_OVERLAPS also ensure that ::val_json() isn't null.
7d3103e0e728...
7d3103e0e728796f24228e258d4694eded8d0ac7
Sergei Golubchik
cleanup: get_item_copy<>(item)

make get_item_copy<T>(item) return T* not a generic Item*
helps to avoid casts when a copy needs to be fixed before returning.
6ce0682b269e...
6ce0682b269e9df7ef94aa6f55fe105917adc04e
Sergei Golubchik
MDEV-26910 mysqld_multi starts same instance multiple times with the risk to crash database

a group name may be present in a file more than once.
use hash to deduplicate.
6c3b24414a43...
6c3b24414a43dcab41b5a59666073fb0ddf7116c
Sergei Golubchik
MDEV-39821 heap-use-after-free in heap_rnext with tree indexes

heap_update() forgot to update key_changed
6a29f4fd5afc...
6a29f4fd5afce88d03a1ab07d8cff93d1f7e0b9f
Sergei Golubchik
MDEV-23086 Error codes/messages reveal information about table structure

if a user tries to access a table or a database they have no priivleges
on, the error is alwaus "access denied", independently from whether
the object exists or not. Do the same for columns.
6225bd2659e4...
6225bd2659e4c25334b7ee31cb829d2f8bdf247c
Sergei Golubchik
MDEV-25813 ASAN errors in err_conv / field_unpack upon multi-UPDATE causing ER_DUP_ENTRY

InnoDB always frees allocated in record[0] blobs even
when reading into record[1].
Let's read into record[0] for consistency.
58e6c94945ee...
58e6c94945ee81f2d38b8cfe39d8c61d82f5318a
Sergei Golubchik
MDEV-39821 heap-use-after-free in heap_rnext with tree indexes

heap_update() forgot to update key_changed
3a50edf96624...
3a50edf9662470cd3f729cf05f506096b5201391
Sergei Golubchik
MDEV-40341 store read-only sysvars in a read-only segment

Protect all READ_ONLY sysvars from run-time changes.

Put them into a separate ELF section with a special attribute
and mprotect() this section after the server is fully initialized.

Verify that they're all protected in the sys_var constructor.

One exception: opt_noacl (--skip-grant-tables) can be changed
from 1 to 0 on FLUSH PRIVILEGES. Let's briefly drop the
protection for this 1->0 change. It can be needed only once
in a server lifetime and only if it was started with --skip-grant-tables

On shutdown the protection is removed, making variables writable
again because shutdown resets some of them during the cleanup

Assisted-By: Claude:claude-4.8-opus
2eb28e3e79ca...
2eb28e3e79cae549f88776395f5e592e3100b40f
Sergei Golubchik
MDEV-31024 Server crash / ASAN use-after-poison in Binary_string::free_buffer / Item_func_sformat::~Item_func_sformat

re-allocate Item_func_sformat::val_arg in shallow_copy()
to keep it in the same memroot as the item.
27742c656e13...
27742c656e13c9bc8f6226497fba649fa6615d50
Rex Johnston
MDEV-19941 "Duplicate column name" while using VALUES table constructor

Copy mysql column name scheme for TVCs (column_N).
129f410029ae...
129f410029aed4671bab73ab46a649b6ac076ce3
Sergei Golubchik
MDEV-40337 store user vars in a dedicated memroot

user_var_entry objects and their names have a connection lifetime,
they exist until the connection ends (or is reset), and then they're
all deleted at once. This is exactly the use case for MEM_ROOT,
let's store them there.

Additionally, let's set MY_ROOT_USE_MPROTECT flag to keep this memroot
off the general heap where user_var_entry values are stored
and where heap buffer overflows can happen.

The latter makes memory allocations for the MEM_ROOT about 10x more
expensive, so let's always start with an empty memroot (= zero overhead
if no user variables are used) and on THD cleanup let's retain one
memroot block (= zero overhead if the next connection takes THD from the
cache and uses user variables up to one block size).

Assisted-By: Claude:claude-4.8-opus
0cd96f0bf303...
0cd96f0bf30399d570e52e9f7fe30228de489ef3
KhaledR57
MDEV-36552 mariadb-dump fails with error 1370 for a view that uses a function

SHOW COLUMNS on a view checked EXECUTE on every function the view
uses. Reading column metadata does not run the function, so
EXECUTE should not be needed. SHOW VIEW is enough.

Check EXECUTE only when the view is created, not when it is opened
just to read its columns.
0ad258722819...
0ad2587228191472a5b5d0a8bf902eaee7145e01
Sergei Golubchik
MDEV-40341 store read-only sysvars in a read-only segment

Protect all READ_ONLY sysvars from run-time changes.

Put them into a separate ELF section with a special attribute
and mprotect() this section after the server is fully initialized.

Verify that they're all protected in the sys_var constructor.

One exception: opt_noacl (--skip-grant-tables) can be changed
from 1 to 0 on FLUSH PRIVILEGES. Let's briefly drop the
protection for this 1->0 change. It can be needed only once
in a server lifetime and only if it was started with --skip-grant-tables

On shutdown the protection is removed, making variables writable
again because shutdown resets some of them during the cleanup

Assisted-By: Claude:claude-4.8-opus
09fdbcc85277...
09fdbcc852770fc190678d78ec9af208d0a63976
Sergei Golubchik
cleanup: main.view test
02593d10dc67...
02593d10dc6745bdab2bf84ab1abf6e37b1cc947
ParadoxV5
MDEV-40236: Generalize `--flashback` error messages for non-flashback

MDEV-20749 moved its improved error reporting from the flashback
code path down to a common function that non-flashback mode also uses.
This brings a side effect that MDEV-20749 also added error reporting
to `mariadb-binlog` non-flashback mode for this particular code path,
whose errors (if anticipated) were **completely silent** previously.

These error messages assume that `mariadb-binlog` is in flashback mode,
though; this commit removes this description from these messages
so they make sense in both flashback and non-flashback modes.
It keeps these messages at this location to
maintain the detail level and cross-mode sharing.

(Currently, only unrecognized data types are known to
trigger one of these descriptive errors outside of flashback.)
0200fd905fb1...
0200fd905fb17f62214ad0d26679c3ae8e8c2e0f
ParadoxV5
MDEV-40236: Generalize `--flashback` error messages for non-flashback

MDEV-20749 moved its improved error reporting from the flashback
code path down to a common function that non-flashback mode also uses.
This brings a side effect that MDEV-20749 also added error reporting
to `mariadb-binlog` non-flashback mode for this particular code path,
whose errors (if anticipated) were **completely silent** previously.

These error messages assume that `mariadb-binlog` is in flashback mode,
though; this commit removes this description from these messages
so they make sense in both flashback and non-flashback modes.
It keeps these messages at this location to maintain the detail
level and cross-mode sharing (albeit only bug MDEV-40511 is known
to trigger one of these descriptive errors outside of flashback).
BuildBot (0.8.9) working for the MariaDB project.
Page built: Sat 25 Jul 2026 22:18:54 (UTC)