Console View

Categories: connectors experimental galera main

Legend:

Passed

Failed

Warnings

Failed Again

Running

Exception

Offline

No data

connectors

experimental

galera

main

ffab7f3170e0...

ffab7f3170e002605297f72d506acc08697dc2ce

Sergei Golubchik

serg@mariadb.org

fix sporadic galera test failures

* query @@datadir before audit is enabled, not directly before reading
the log. just in case cat gets the log before SELECT is flushed.
* wait for a table to be dropped

fab2d49ab909...

fab2d49ab90951b56c8142ce63e1992d46b98216

Rucha Deodhar

rucha.deodhar@mariadb.com

MDEV-36653: main.mysql_upgrade-28915 test case timeout

Analysis:
Leaving 'event_scheduler=ON' with a 1-second interval creates a background
loop that constantly hits mysql.event with MDL_SHARED_WRITE locks.

Fix:
Turn 'GLOBAL event_scheduler=OFF' right before running upgrade. This drains
the background worker threads and drops the shared locks so the
upgrade can acquire its exclusive lock and finish instantly.

faa28396ce86...

faa28396ce86e8e9603672000d95ac4c34e27f99

forkfun

alice.sherepa@gmail.com

MDEV-38061 Assertion `args[0]->decimal_precision() < 22' in Item_func_round::fix_arg_hex_hybrid

Item_name_const forwarded type_handler() to the wrapped value but not
decimal_precision(), so a hex literal wrapped in NAME_CONST reported the
generic precision instead of its own. Forward decimal_precision() too.

f277eefa4248...

f277eefa424850a8cba5c2371406047f6395e8bb

Sergei Golubchik

serg@mariadb.org

MDEV-40362 #mysql50# mixes up with table names in the table cache and on disk

1.
Only allow #mysql50# prefix on table names that
can not be decoded from a file name to a table name.
It is an error to put this prefix on a name that can be accessed
as a valid table name without a prefix. Use `t1` not `#mysql50#t1`,
use `a-b` not `#mysql50#a@002db`.

2.
Don't allow creation of new tables with the #mysql50# prefix.

Except when in SQLCOM_ALTER_DB_UPGRADE - main.upgrade test runs
ALTER DATABASE `#mysql50#mysqltest-1` UPGRADE DATA DIRECTORY NAME;
This command moves tables from the old db name to the new db name,
and some of these tables also have old #mysql50# names.

3.
Also don't allow to create such databases, views, partitions,
subpartitions, sequences, triggers.

f221495d590d...

f221495d590d1a90392335333811446e0f3490b8

Sergei Golubchik

serg@mariadb.org

MDEV-40409 ST_GeomFromText stack overrun on deeply nested GeometryCollection

efbd98fdc6cb...

efbd98fdc6cb79f8c7fafbcbf31f11eb388d4e7e

forkfun

alice.sherepa@gmail.com

ebeb3c80e7bc...

ebeb3c80e7bc03f1316ee73dc049ecee7ad99f3a

Rucha Deodhar

rucha.deodhar@mariadb.com

dbd60d0ad8da...

dbd60d0ad8daa2d01050346aa50b7b102490e456

Sergei Golubchik

serg@mariadb.org

MDEV-40470 GRANT PROXY with empty password incorrectly checks grantor's privileges

empty password and empty plugin name don't mean "authentication
was not specified", they mean "empty authentication was specified"

d7ceeb9fa0b2...

d7ceeb9fa0b286a4b641c0343b84ff05f4fc19b7

bsrikanth-mariadb

srikanth.bondalapati@mariadb.com

MDEV-40383:innodb_gis.point_basic fails on replay

There are 2 problems: -
1. The REPLACE statement that is recorded doesn't store the
value of geometry type field correctly.
2. The table definition that got recorded has fields with non-null constraint,
and no default value is specified.
Also, the "REPLACE INTO" statement that gets stored in the context,
doesn't have any value specified for these non-null fields.

Solution is to: -
1. Store all the non-numeric values in HEX, when using REPLACE INTO
statement.
2. Instead of storing only the column values that were projected in the
query, store all the column values into the recorded REPLACE INTO
statement.

Implementation details: -
1. Modify the format_and_store_row() method in filesort.cc, to accept an
argument that tells whether to store non-numeric vales in hex or the
default string type. The value of new argument is by default false,
but is set to TRUE, when recording a const row for base tables.
The default value of FALSE is used when mysql.[table|column|index]_stats
table is used in the REPLACE INTO statement.
2. From join_read_const(), and join_read_system() methods in sql_select.cc,
re-read the const row for all the fields in the table. After the row
is read, restore the table->read_set to the value that was before.

d07bddeb6c84...

d07bddeb6c8458426419ce3cc71e8cbff9b78e66

Rucha Deodhar

rucha.deodhar@mariadb.com

MDEV-17943: Unfortunate error code/message upon SET DEFAULT ROLE FOR

Analysis:
Wrong error code

Fix:
Used the correct error code

cf296cd38ebc...

cf296cd38ebcc0e67ff6dca5a9b4dfdd371328b4

Rex Johnston

rex.johnston@mariadb.com

MDEV-17846 Wrong result with grouping select from merged derived table

When a grouping select referring to a derived table has an outer
reference within it's select list, that outer reference isn't
properly fixed. It isn't added to
outer_context->select_lex->inner_refs_list for later resolution during
JOIN::prepare. As it is not fixed, the Item pointer arrays associated
with the temporary table filled during the join process are now incorrect
and we end up with an incorrect join->outer_ref_cond evaluation and
potentially a wrong result.

c3a89bd3f9e4...

c3a89bd3f9e4e11eea2731bce26eca24b7c26ead

Rucha Deodhar

rucha.deodhar@mariadb.com

MDEV-31477: Inconsistent handling while fetching values in json

Analysis:
When we get value in json_value(), if any error occurs while scanning the
json, it is not reported. Only true is returned.
Fix:
Report error along with returning true (error)

bc0913ee2265...

bc0913ee2265ee93821ca2ba92e10fb1068edd10

Sergei Golubchik

serg@mariadb.org

MDEV-40395 MyISAM/Aria silently truncate extensions from filenames, if too long

* move all common fn_format flags that mi_create/maria_create use
into one single #define.
* simplify (MY_APPEND_EXT is redundant and MY_REPLACE_EXT does nothing
when no . is present in the filename)
* use MY_SAFE_PATH everywhere (return NULL if too long)
* set my_errno= ENAMETOOLONG on too long
* abort mi_create/maria_create if returned NULL

b11664054607...

b11664054607c7f696233b05d42a12bc7289680b

forkfun

alice.sherepa@gmail.com

Update HeidiSQL to 12.20, update libfmt to 12.2.0, fix galera_sst_mariabackup_lost_found.test (forgotten semicolon)

ad7f29afb3a4...

ad7f29afb3a401cd03ad230e343438a5da3336b7

forkfun

alice.sherepa@gmail.com

Merge branch 10.6 into 10.11

abbf30f3291b...

abbf30f3291ba6ee51f77911f1dfa9c6d856bebb

Sergei Golubchik

serg@mariadb.org

post-merge fixes

* restore result=NULL after free (to prevent double-free)
* remove DBUG_EVALUATE_IF again
* remove useless 'stop slave'
* restore charset encoding in mysqltest.{test,result}
* correct error for unparseable BINLOG data is ER_SYNTAX_ERROR now

a6e435f19c98...

a6e435f19c98607c5000c49aba048c8b13a39145

Rucha Deodhar

rucha.deodhar@mariadb.com

MDEV-23500: Assertion `!is_set() || (m_status == DA_OK_BULK && is_bulk_op())'
failed in Diagnostics_area::set_ok_status upon multi-table update

Analysis:
When NULL field from internal temporary table is copied to
NOT-NULL so there is error about truncation but this error is not
reported so we get the failure.

Fix:
Return the error state.

a6c9db7cc2d9...

a6c9db7cc2d9f115840a047b7f534d5871d251c0

forkfun

alice.sherepa@gmail.com

MDEV-39380 Assertion `arg2_int >= 0' failed in Item_func_additive_op::result_precision

A 0xHHHH / b'..' literal keeps its hex_hybrid type through COALESCE/IF/CASE/...,
but was evaluated, sized and stored as a string, so it behaved differently from
a bare literal (10+COALESCE(0x31) gave 11, not 59).

Type_handler_hex_hybrid now implements the numeric side to match the bare
literal: val_int/val_real/val_decimal read bytes as a hybrid, Item_decimal_precision
returns the integer precision, Item_save_in_field stores like the bare literal.
The traditional type merge keeps the hybrid through a typeless NULL (as for BIT),
and Item_hybrid_func_fix_attributes attributes it binary/unsigned.

a07b6be377e3...

a07b6be377e318bc99a8a966e69fe4f3bdbc52d0

Vladislav Vaintroub

vvaintroub@gmail.com

MDEV-24245 REPAIR/OPTIMIZE on ARCHIVE table corrupts blob/text data

pack_row() and unpack_row() both used record_buffer. After unpack_row(),
blob field pointers in record[0] reference data stored in record_buffer.
When pack_row() then writes the new packed row into the same record_buffer,
it overwrites the blob data that those pointers still reference. Subsequent
Field_blob::pack() calls follow the stale pointers and read corrupted data.

This only matters in the optimize/repair loop where the same handler reads
then writes each row. Normal INSERT has no prior unpack_row() on the same
handler.

Fix: in the optimize loop, before writing, copy blob data out of
record_buffer (the same approach already used by get_row_version2),so that
blob pointers no longer reference record_buffer when pack_row() overwrites it.

Free the temporary blob buffer after the loop.

9c8f08a1a3a9...

9c8f08a1a3a9a4151fb41b25efb56b1364b61b56

Oleksandr Byelkin

sanja@mariadb.com

MDEV-38722 server crash hp_rec_key_cmp

In an extended set operation (select_unit_ext, used when EXCEPT ALL or
INTERSECT ALL is present) the HEAP unique index is released once, at
the node pointed to by union_distinct, assuming every operation after
it is a plain UNION ALL that can be unfolded. That does not hold for a
trailing EXCEPT ALL: select_unit_ext::send_data() still calls
find_unique_row() for it (only the UNION ALL branch checks
is_index_enabled), so it dereferenced the already released index and
the server crashed in hp_rec_key_cmp().

optimize_bag_operation() now postpones the index release past such a
trailing EXCEPT ALL, so the index is available while it is executed.

Keeping the index alive uncovered a second problem. A leading
INTERSECT that stays inline in the extended operation (instead of being
materialized in a derived table) left the rows that did not match every
INTERSECT operand in the temporary table. select_unit::send_eof()
removes them for a materialized subsequence, but the select_unit_ext
override did not, so once the crash was gone the following operations
counted those stale rows and produced a wrong multiset.

select_unit_ext::send_eof() already scans the temporary table (to reset
the duplicate counter, to fold INTERSECT ALL counters, or to unfold),
so the filtering of the non-matching INTERSECT records is done inside
those loops (guarded by the filter_intersect flag) and the table is
still scanned only once.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

8f65f861c1e4...

8f65f861c1e4bb1418eeb7148b2e876906619b6a

Rucha Deodhar

rucha.deodhar@mariadb.com

8c68ef76c74b...

8c68ef76c74bd9a4b2bdece2736853b477a2b11c

Mohammad Tafzeel Shams

tafzeel.shams@mariadb.com

MDEV-40504: Fix memory leak in mariabackup incremental copy

ibx_copy_incremental_over_full() : Replace die() with
proper error handling to avoid memory leaks when RocksDB
backup directory operations fail.

8a642bc8103a...

8a642bc8103aadc6b2087d781ba8e1595616a2c4

Sergei Golubchik

serg@mariadb.org

MDEV-40484 ambiguous view frm parsing when username includes \n

escape user and host names in view frm

in fact, there is no reason to write any field as is, unescaped,
so let's remove FILE_OPTIONS_STRING in the next release

7f275ff1b2b8...

7f275ff1b2b8d2746009ecaf151c7e7e71777cdc

forkfun

alice.sherepa@gmail.com

Update HeidiSQL to 12.20, fix galera_sst_mariabackup_lost_found.test (lacked semicolon)

78ac771c67fd...

78ac771c67fdc97be8ae08872c637d5e77c56bf5

Rucha Deodhar

rucha.deodhar@mariadb.com

MDEV-22675: Assertion `offset < table->s->reclength' failed in dump_leaf_key

Analysis:
The reclength depends on the size of each field of the temporary table plus
the null_bytes. Since null_bytes is 0 (because we’re in non-strict mode and
the source table fields can never be null), there is no need to keep track
of null values. Hence the total record length is just the sum of the sizes
of both fields. The second field will always have size 0 because its value
will always be an empty string. Hence it starts exactly where the first
field ends which equal to reclength. Hence the assertion failure.

Fix:
If pack_length() is 0 (which means the size of field is 0) so assigning the
result as empty string directly, the assertion is not valid in that case.

7857958e916a...

7857958e916a8012fbd17390a91db7b999a06956

Rex Johnston

rex.johnston@mariadb.com

7736b22719da...

7736b22719da8f205563bd9a80340a8c209b9078

Oleksandr Byelkin

sanja@mariadb.com

6d40ccd67fb6...

6d40ccd67fb6dbff0138e4313494d48a5c2792e1

Sergei Golubchik

serg@mariadb.org

UBSAN warning:

sql/table.h:237:16: runtime error: load of value 4, which is not a valid value for type 'bool'

the warning was about uninitialized `bool in_field_list`
let's initialize the whole ORDER when it's allocated.

605de7281855...

605de7281855ee8e279fa8acec7102204f45e20f

Rucha Deodhar

rucha.deodhar@mariadb.com

MDEV-25099: Inconsistent error upon updating read-only table with
ROW_FORMAT=COMPRESSED

Analysis:

Warning level is incorrect
Fix:
Changed to correct warning level

5833efe99d74...

5833efe99d74f42bd33b98f10e866ba8984efcee

Sergei Golubchik

serg@mariadb.org

MDEV-25813 ASAN errors in err_conv / field_unpack upon multi-UPDATE causing ER_DUP_ENTRY

InnoDB always frees allocated in record[0] blobs even
when reading into record[1].
Let's read into record[0] for consistency.

581562f94a83...

581562f94a83f29dcf2c6cc761b49ad55d9c287a

Jan Lindström

jan.lindstrom@mariadb.com

MDEV-40056 - Galera Dynamic Variables Susceptible to RCEs

Make check stronger and require OpenSSL version > 1.1.1
for test case.

45154f7ab3f5...

45154f7ab3f5fc1fa41712310ad7a1b290fe74c6

Vladislav Vaintroub

vvaintroub@gmail.com

MDEV-25817 proxy protocol: successful login does not reset connect errors

With proxy protocol thd_set_peer_addr() runs twice (proxy host, then the
real client from the proxy header). Connect errors are accounted against
the real client, but check_connection() incorrectly uses condition on the
proxy host's count, rather than real client's address.

Fix: reset both the proxy host, and real client's connect errors on
successful connection.

Added tests for incomplete handshake, and reset behavior,
under proxy protocol, for both real client errors, and proxy host errors.

40c5d537933a...

40c5d537933abccdedf943a98a47864d7688d5a9

Sergei Golubchik

serg@mariadb.org

MDEV-30942 MSAN_OPTIONS=poison_in_dtor=1 causes failures in free_root()

Materialized_cursor included MEM_ROOT where it itself (Materialized_cursor)
was allocated. Materialized_cursor inherits from Server_side_cursor,
and Server_side_cursor::operator delete frees this mem_root.

This offends MSAN with poison_in_dtor, because when Materialized_cursor
is destroyed, MEM_ROOT is poisoned and Server_side_cursor::operator delete
accesses memory it really shouldn't.

Fix:
* MEM_ROOT is moved into Server_side_cursor. Materialized_cursor is
the only class inheriting from it, so nobody is affected.
* operator delete is replaced with a function cdestroy() which
saves the MEM_ROOT, deletes the object, then frees the root.
* cannot close() from ~Materialized_cursor anymore, main_mem_root
should be copied before the destruction

4073c91c5634...

4073c91c5634197243045cc75f457744b6d57fff

forkfun

alice.sherepa@gmail.com