Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
fe2e034656fc...
fe2e034656fcf2278dc8422f87735acd76d97cc8
bsrikanth-mariadb
MDEV-40388: sequence.simple fails on replay

When the recording is enabled for the query,
explain select * from seq_15_to_1_step_12345;
it recorded the table context having a DDL definition as: -

CREATE TABLE `seq_15_to_1_step_12345` (
    ->  `seq` bigint(20) unsigned NOT NULL,
    ->  PRIMARY KEY (`seq`)
    -> ) ENGINE=SEQUENCE DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_uca1400_ai_ci;

Now, when that context is replayed, the DDL statement is executed.
But, we cannot create such the table and instead it errors out saying
ERROR 1050 (42S01): Table 'seq_15_to_1_step_12345' already exists.

The problem is that,
sequence table was determined using tbl->table->s->sequence. The
intention was to not record sequence table information. However, the
check was only partially correct.

Instead, we could compare using the engine name like
if (!tbl->is_view() && tbl->table)
{
  handlerton *hton= tbl->table->file->partition_ht();
  const LEX_CSTRING *engine_name= hton_name(hton);
  if (strcmp(engine_name->str, "SEQUENCE") == 0 ||
      strcmp(engine_name->str, "SQL_SEQUENCE") == 0)
    continue;
}

This makes both the following kinds of queries on sequences, to not
record any table contexts on them: -
1. explain select * from seq_15_to_1_step_12345;
2. create sequence s1;
  EXPLAIN select * from s1;
fc2cca05b64e...
fc2cca05b64e9a3e2ecb2cbd491b90b84b62d31a
KhaledR57
MDEV-40353 Add eval parameter to write_file and append_file

mysqltest substituted variables in the file name of write_file and
append_file, but not in the content, so tests had to fall back to
"exec echo ... >> file" to put a computed value into a file.

Add an optional third parameter, eval, which makes the content go
through do_eval(). It is off by default, because existing tests write
content that contains a literal $ or backslash.
f277eefa4248...
f277eefa424850a8cba5c2371406047f6395e8bb
Sergei Golubchik
MDEV-40362 #mysql50# mixes up with table names in the table cache and on disk

1.
Only allow #mysql50# prefix on table names that
can not be decoded from a file name to a table name.
It is an error to put this prefix on a name that can be accessed
as a valid table name without a prefix. Use `t1` not `#mysql50#t1`,
use `a-b` not `#mysql50#a@002db`.

2.
Don't allow creation of new tables with the #mysql50# prefix.

Except when in SQLCOM_ALTER_DB_UPGRADE - main.upgrade test runs
ALTER DATABASE `#mysql50#mysqltest-1` UPGRADE DATA DIRECTORY NAME;
This command moves tables from the old db name to the new db name,
and some of these tables also have old #mysql50# names.

3.
Also don't allow to create such databases, views, partitions,
subpartitions, sequences, triggers.
f221495d590d...
f221495d590d1a90392335333811446e0f3490b8
Sergei Golubchik
MDEV-40409 ST_GeomFromText stack overrun on deeply nested GeometryCollection
dbd60d0ad8da...
dbd60d0ad8daa2d01050346aa50b7b102490e456
Sergei Golubchik
MDEV-40470 GRANT PROXY with empty password incorrectly checks grantor's privileges

empty password and empty plugin name don't mean "authentication
was not specified", they mean "empty authentication was specified"
d5d741a3076f...
d5d741a3076f911b468518d6b06a917593498c5b
Sergei Golubchik
MDEV-39776 SHOW CREATE TABLE corrupts `-quoted table options

Three problems:

1. Option value specified as `foo bar` was not quoted,
  printed as foo bar, breaking CREATE TABLE.
2. Option value that included */ was printed as is, in unknown
  options when the whole option was commented out, this broke the
  comment: /* opt='val*/ue' */
3. Option names can include */ too, `opt*/ion`=1

Fix: simplify value printing, ignore the original quoting, always
print the value quoted as a string. Break comment markers with an
escape (as *\/) if inside a comment. As \-escapes don't work inside,
backticks, we cannot use `-quoting for option values at all.

For the same reason we cannot allow */ inside option names, thus
let's only allow keywords for option names and reject fancy names
even if IGNORE_BAD_TABLE_OPTIONS is in force.
ce0b7254d52a...
ce0b7254d52a596b6b7e560587b0ec561bb02ae4
Sergei Golubchik
MDEV-40311 also fix mariadb-show and mariadb-convert-table-format
c0fbc376993e...
c0fbc376993e94214874c246dc04c8e909a8ae9b
Georgi (Joro) Kodinov
MDEV-17746: perfschema.dml_threads failed in buildbot with wrong errno

The test was trying to update the performance_schema.threads row for
the current connection. And if that row was not found or was the same,
there's nothing to update hence no update not allowed error.

MariaDB has a device to skip calling ha_update_row() if the old and the
new records are identical.

The connection id is increasing by at least 2 for every test run.
Eventually it will hit the constant 12 in the UPDATE and the server
will not call ha_update_row() at all and won't get the error.
This is not a bug: it's reasonable behavior.

Stablizied the test by changing the UPDATE value to thread_id
+ const.

Co-authored-by: Grok
bc0913ee2265...
bc0913ee2265ee93821ca2ba92e10fb1068edd10
Sergei Golubchik
MDEV-40395 MyISAM/Aria silently truncate extensions from filenames, if too long

* move all common fn_format flags that mi_create/maria_create use
  into one single #define.
* simplify (MY_APPEND_EXT is redundant and MY_REPLACE_EXT does nothing
  when no . is present in the filename)
* use MY_SAFE_PATH everywhere (return NULL if too long)
* set my_errno= ENAMETOOLONG on too long
* abort mi_create/maria_create if returned NULL
b55f5649289b...
b55f5649289b3feb0f8b0ea99448e22f28e0cf75
Sergei Golubchik
cleanup: silence (wrong) maybe-uninitialized warning

gcc 15.2.1 with -Og:

filamdbf.cpp:355:33: error: 'tfp' may be used uninitialized [-Werror=maybe-uninitialized]
  355 |            } else if (fread(tfp, HEADLEN, 1, infile) != 1) {
      |                        ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
b2e0351a9108...
b2e0351a91089241e8561eebbad73513451f0bd2
Sergei Golubchik
MDEV-40065 bundled command-line clients don't always enforce length limits on server results

replace strmov/strxmov with strnmov, strmake, or my_snprintf
a9983bfbb07a...
a9983bfbb07a00c6a8968168fa896ccbdc4ec945
bsrikanth-mariadb
MDEV-40388: sequence.simple fails on replay

When the recording is enabled for the query,
explain select * from seq_15_to_1_step_12345;
it recorded the table context having a DDL definition as: -

CREATE TABLE `seq_15_to_1_step_12345` (
    ->  `seq` bigint(20) unsigned NOT NULL,
    ->  PRIMARY KEY (`seq`)
    -> ) ENGINE=SEQUENCE DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_uca1400_ai_ci;

Now, when that context is replayed, the DDL statement is executed.
But, we cannot create such the table and instead it errors out saying
ERROR 1050 (42S01): Table 'seq_15_to_1_step_12345' already exists.

The problem is that,
sequence table was determined using tbl->table->s->sequence. The
intention was to not record sequence table information. However, the
check was only partially correct.

Instead, we need an enhanced condition like: -
if (!tbl->is_view() && tbl->table)
{
  if (tbl->table->s->sequence ||
      lex_string_eq(hton_name(tbl->table->s->db_type()),
                    STRING_WITH_LEN("SEQUENCE")))
  {
    continue;
  }
}

This makes both the following kinds of queries on sequences, to not
record any table contexts on them: -
1. explain select * from seq_15_to_1_step_12345;
2. create sequence s1;
  EXPLAIN select * from s1;
9cff8aa0242d...
9cff8aa0242dddcae4cc0fc967ec1fe738a30ab0
Georg Richter
Fix copy/paste error, introduced by rev. a7072b5bf0907c38bacf928ea3ee839314e379c6
93078fb753e8...
93078fb753e8a4c34e18d305abd7002a65772695
Sergei Golubchik
MDEV-40358 symlinked table name is not encoded

encode table name in file name in DATA/INDEX DIRECTORY
8ee69168a8a5...
8ee69168a8a5c72a2859cbdfef4d638f998b5622
Sergei Golubchik
cleanup: silence (wrong) maybe-uninitialized warning

gcc 15.2.1 with -Og:

filamdbf.cpp:355:33: error: 'tfp' may be used uninitialized [-Werror=maybe-uninitialized]
  355 |            } else if (fread(tfp, HEADLEN, 1, infile) != 1) {
      |                        ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
8a642bc8103a...
8a642bc8103aadc6b2087d781ba8e1595616a2c4
Sergei Golubchik
MDEV-40484 ambiguous view frm parsing when username includes \n

escape user and host names in view frm

in fact, there is no reason to write any field as is, unescaped,
so let's remove FILE_OPTIONS_STRING in the next release
6a9305da0a59...
6a9305da0a59edc19669c27e738ccf21703d7372
Sergei Golubchik
more portability fixes for galera.galera_sst_mariabackup_encrypt_with_key_server

make sure pkill doesn't kill itself. it's documented not to do that,
but if it's not called directly (e.g. my_safe_process -> sh -> pkill)
it can still kill its parents.
5c04ca552438...
5c04ca5524385356ff7cf84974a7d491974c1f85
Sergei Golubchik
MDEV-40329 Binary_string::qs_append(char): Assertion `str_length + (uint32) (1) <= Alloced_length' failed in AsText

Geometry::as_wkt() didn't take into account bytes written into the
result string in the recusrive call of get_data_as_wkt().
Gis_geometry_collection::get_data_as_wkt() didn't reserve space at all.
Thus nested geometry collections could overflow the buffer.
5acb43522863...
5acb43522863c9bd6b91f354104ea247bf513e9a
Sergei Golubchik
MDEV-39818 backtick in FK names breaks SHOW CREATE TABLE

InnoDB used to have two versions of innobase_quote_identifier().
One that handled embedded backticks and one that didn't.

Let's use just one implementation that handles backticks.
Keep the other one as a helper that writes to FILE but does not
implement the quoting logic.
59141cbd2c4e...
59141cbd2c4ee21e7c6df67db6c47f1183f7513b
Sergei Golubchik
MDEV-39817 JSON_ARRAYAGG() returns garbage because of off-by-one error

don't truncate to a position somewhere between
[old_length, max_length-1] if old_length == max_length.
Simply set the length to old_length in this case.

Also, max_length cannot be zero.
581562f94a83...
581562f94a83f29dcf2c6cc761b49ad55d9c287a
Jan Lindström
MDEV-40056 - Galera Dynamic Variables Susceptible to RCEs

Make check stronger and require OpenSSL version > 1.1.1
for test case.
49bcb6e3e9c2...
49bcb6e3e9c2c4ea43327f9fc02f728685e07da2
Georg Richter
Fix maxcolumns test
46bcedce0e8f...
46bcedce0e8fa86cb3f86bc79079a711e8d68480
Sergei Golubchik
MDEV-39812 32-bit size truncation in RocksDB
42ac9df02c92...
42ac9df02c92a65f2586e128f04da9a5b56727a0
ParadoxV5
MDEV-40298 Use-After-Free when SQL Thread stops in the middle of SHOW SLAVE STATUS

MDEV-36287 acknowledged that SHOW SLAVE STATUS needed to acquire a mutex
lock before accessing the SQL Thread’s THD, as otherwise it may access
invalid memory if a concurrent STOP SLAVE deletes the THD.
But it missed that the SQL Thread’s mutex is `mi->rli.run_lock`,
not `mi->run_lock`, so the bug was still not fixed.

This commit fills in the oversight by acquiring the correct
corresponding lock for each of `Slave_IO_State` & `Slave_SQL_State`.

Reviewed-by: Kristian Nielsen <[email protected]>
40c5d537933a...
40c5d537933abccdedf943a98a47864d7688d5a9
Sergei Golubchik
MDEV-30942 MSAN_OPTIONS=poison_in_dtor=1 causes failures in free_root()

Materialized_cursor included MEM_ROOT where it itself (Materialized_cursor)
was allocated. Materialized_cursor inherits from Server_side_cursor,
and Server_side_cursor::operator delete frees this mem_root.

This offends MSAN with poison_in_dtor, because when Materialized_cursor
is destroyed, MEM_ROOT is poisoned and Server_side_cursor::operator delete
accesses memory it really shouldn't.

Fix:
* MEM_ROOT is moved into Server_side_cursor. Materialized_cursor is
  the only class inheriting from it, so nobody is affected.
* operator delete is replaced with a function cdestroy() which
  saves the MEM_ROOT, deletes the object, then frees the root.
* cannot close() from ~Materialized_cursor anymore, main_mem_root
  should be copied before the destruction
364656922575...
3646569225758c8225e7342783d775ef7c7570e5
Sergei Golubchik
MDEV-40308 single quotes make SHOW CREATE USER invalid

use append_unescaped() for '-quoted strings in SHOW CREATE USER
and SHOW GRANTS. Use append_identifier() for user- and hostnames.
3079790e006a...
3079790e006a196dcb67a1f292ca6e09c78d19f5
Sergei Golubchik
MDEV-39816 MyISAM crash on corrupted MYI with invalid keyseg length

check that the keyseg lengths are sane.

fix Aria too.
2bf355e361db...
2bf355e361db85153fdfba7b8a0f0d114d6a26ce
Sergei Golubchik
MDEV-40328 ASAN error on malformed WKB multipolygon

before `data+= WKB_HEADER_SIZE` verify that there's enough data.

rewrite this line in Gis_multi_line_string::get_mbr to make clear
that it does not need this check.
2b28d1c42410...
2b28d1c424104429eeed43115ee6d8a803671d52
Sergei Golubchik
MDEV-40311 mariadb-dump doesn't always quote identifiers

covers:
* DROP TRIGGER
* CHANGE MASTER
* CREATE FUNCTION
* CREATE SERVER
* INSTALL PLUGIN
0c8cfc362063...
0c8cfc362063b8cff16001e6e77b5ed06c16f4dd
Sergei Golubchik
MDEV-40426 CONNECT writes unvalidated data from remote server into fixed-len buffer

use size-bounded scanf formats
09153c23ca2f...
09153c23ca2f5333f8f50c6dca812292bdb84d40
Sergei Golubchik
cleanup: main.drop test
04ba5ac7c063...
04ba5ac7c0630954918fed31d70ebf90d60c5404
Rucha Deodhar
MDEV-33843: Server crashes by stack-overflow with UPDATEXML

Analysis:
The stack size if insufficient and there is no stack overrun check.

Fix:
Add stack overrun check.
0260e84ad303...
0260e84ad303d7a5bc52e332a89019caa0a80d79
Sergei Golubchik
MDEV-40360 CONNECT REST can pass arguments to curl via HTTP parameter

tell curl to not try to interpret url as a parameter
BuildBot (0.8.9) working for the MariaDB project.
Page built: Wed 22 Jul 2026 17:37:50 (UTC)