Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
ffafddeace6a...
ffafddeace6a7da66ad9ea1d845a5b5599441cab
Sergei Golubchik
improve test readability

fix confusing duplicate lines like

Invoke from Db: test, Rt: proc
Invoke from Db: test, Rt: proc
fb96d83ca92b...
fb96d83ca92b245db747f2031d4cc42c7d41253f
Sergei Golubchik
change Sql_path::from_text() to take a String, not LEX_CSTRING

* use str->c_ptr() for the error message
* pass correct charset
* remove redundant parsing Table_triggers_list::check_n_load
f1271aff2837...
f1271aff283746ed2ccc92fdb0b9ebe90a1cd84c
Sergei Golubchik
use standard SET PATH syntax in tests
ea11d5a3afac...
ea11d5a3afac985d2ffeedd8fafb0086672186b1
Sergei Golubchik
PATH is not a chistic, it's like sql_mode, remembered implicitly per routine
e84cb2d95f5f...
e84cb2d95f5f7b657e25ad6770d459798ffb9c5b
Sergei Golubchik
relax assert to account for recursive RETURNS TEXT functions
e161d4cfca18...
e161d4cfca18f2a88c023d5f131c9be15d92ba69
sts-kokseng.wong
MDEV-34391 SET PATH statement

Definition
==========
Implement the SET PATH statement.
```
SET PATH 'schema1, schema2, schema3';
```

Function
--------
In MariaDB, the SQL-path will also be used to lookup packages in
package routine invocations, so the following script:

  SET PATH 'sys';
  SELECT UTL_ENCODE.BASE64_DECODE('data');

invokes SYS.UTL_ENCODE.BASE64_DECODE('data'), i.e. the function
BASE64_DECODE() in the packge UTL_ENCODE in the database SYS
(if such package and package routine exist).

MariaDB implementation details
------------------------------
The ticket's requirement stated the grammar should support delimited
identifiers with backticks or double quotes within the string quote,
ie: the single tick. A simple parser was implemented to handle this
requirement in Sql_path::from_text.

Only 16 schemas are supported per session - we do not want too many
schemas in the path anyway since it will impact performance. This also
means that the path cache is a simple static array for easier memory
management.
dec5624f80bf...
dec5624f80bfab34058696f1e30719af727642a7
Sergei Golubchik
do NOT prefer itself in seemingly recursive calls, follow the path
db88c65924f6...
db88c65924f67b316b37e0c2273a142a90d84bcd
Sergei Golubchik
free Sql_path in the destructor, perform cleanup in cleanup()
d65acc51d90f...
d65acc51d90fe39f5f3663200b1adb818d09f636
Sergei Golubchik
MDEV-37815 table engine attributes in partitioning is broken

remove copying of part_elem->option_struct to table->s->option_struct.
It meant that most of the time a handler had no access to its options
(that's why some handlers resorted to a complex process of guessing the
correct partition) and couldn't work concurrenty. Instead

* introduce handler::option_struct which will point to
  table->s->option_struct or part_elem->option_struct as appropriate,
  the handler can use it any time as needed. A handler should not use
  table->s->option_struct unless it really knows what it's doing and has
  verified that it doesn't break partitioning
* rename option_struct in table->s to option_struct_table and in
  part_elem to option_struct_part to emphasize it's semantics and
  prevent incorrect usage.
* fix engines accordingly.
ca6b73c9a6cb...
ca6b73c9a6cb8d88b7152851d7e2570589d5dff0
Sergei Golubchik
remove LEX::make_sp_name_sql_path()

it confusingly didn't have anything to do with sql path,
so merged into LEX::make_sp_name()
c9f10fa3bc1b...
c9f10fa3bc1b608284b5481fda9d80e5b63cda54
Sergei Golubchik
mysql.proc.path DEFAULT 'CURRENT_SCHEMA' NOT NULL
c92fe7cb0d5e...
c92fe7cb0d5ee760d66205afaa038cbdd658cdcf
Sergei Golubchik
disallow SET PATH DEFAULT in stored routines and triggers

also fix Sys_var_charset_collation_map where this bug was copied from
c4dc1155f631...
c4dc1155f63111c630588b66fbae10a7864f344a
Sergei Golubchik
sporadic failure in galera.MDEV-35511
ba4eb41303db...
ba4eb41303db29d736bd93fa10c5de4000a6bfd5
Sergei Golubchik
cleanup: remove #ifdef MYSQL_VERSION_ID

remove conditional compilation for old MariaDB versions.
Some were as old as MYSQL_VERSION_ID > 32300

Didn't touch engines hosted externally, like connect, mroonga,
and columnstore
afa9095b7fda...
afa9095b7fda8292264bbd8ce0d36501548ed236
Sergei Golubchik
parsing of table/index/field attributes: auto-alias all boolean values

also allow TRUE/FALSE for booleans
a9080a0d59bb...
a9080a0d59bb5baf521fd272c292acc6c56e6f88
Sergei Golubchik
don't backtick-quote CURRENT_SCHEMA
a285a206ca38...
a285a206ca38aa5ee743d638cad58d26d68590b3
Sergei Golubchik
cleanup: remove HTON_CAN_READ_CONNECT_STRING_IN_PARTITION

only set in spider, but not used even there.
no behavior changes.
93d0e56cfbe7...
93d0e56cfbe7c7c5ef3a7337e5d506dad80d8836
Sergei Golubchik
remove unused arguments
8c0f8f4d1376...
8c0f8f4d1376ed0bf228035bff4f2a8ac7a31c6a
Sergei Golubchik
cleanup: partition_element_iterator

reduce code duplication by introducing an iterator that
walks all partitions and subpartitions
88ed51372318...
88ed51372318a73479cd40157dfca8ec13f4aabf
Sergei Golubchik
MDEV-37815 field and index engine attributes in partitioning are broken

just like table attributes, field and index attributes must
be parsed using the underlying engine, not ha_partition.
87553322ceb0...
87553322ceb0fb24a2e423993f2a32e00b48c32f
Sergei Golubchik
MDEV-38523 Freeing unallocated data THD::set_db when path-resolved routine in trigger

add a test case
80e402e65c9d...
80e402e65c9dba95b1a96cf6b758a214207bfd12
Sergei Golubchik
fix error message for assoc arrays
7fbc3a96d2db...
7fbc3a96d2db8c3ecdc6f22b3a3f2cfe6ddfaa94
Sergei Golubchik
MDEV-37815 connect_string in partitioning is broken

let's simplify the code by removing copying of part_elem->connect_string
to table->s->connect_string. Move CONNECTION support from he server into
engines, engines define TOPTION("CONNECTION") if they want to support it,
it's stored in the option_struct and handled by the option_struct fix.
Problems:

* Mroonga used CONNECTION for something but there were no tests for it.
  Removed Mroonga support for CONNECTION as requested by the maintainer
  in MDEV-38530
* DROP/ALTER SERVER command used to close all tables using the server
  in question, avoiding the need for FLUSH TABLES. This functionality
  never worked for partitioned tables anyway and is now removed. Will be
  done properly in MDEV-37827.
76735a794a89...
76735a794a89bfa307889e6a460bf81f1a01fc42
Sergei Golubchik
remove Sql_path_stack and Sql_path_push

don't create a permanent stack of paths on the heap and in THD.

Do it on the stack like for sql_mode, sctx, abort_on_warning, and
other THD properties that often need to be changed temporarily.

Fix Sql_path constructor.
7621ba991db9...
7621ba991db98c26967345884a9e48d25acbe6f9
Sergei Golubchik
add new column mysql.proc.path at the end of the table

to simplify downgrades and to avoid breaking applications
731c01536256...
731c0153625667eee81430c2acaabb6a22e85ed3
Sergei Golubchik
allocate Sql_path in one memory chunk, not one per schema

because it's always allocated and freed as a whole, there is
no operation "replace one name in the middle of the path"

this needed a reworked parser to create the whole list
of names, not append one name at a time.

Fixed a bug where Sql_path::from_text() pretended it can take
a string in any charset, but was always implicitly
assuming it's in my_charset_utf8mb3_general_ci.
6de48b829c60...
6de48b829c60db6f3db3f63e1efb701ca3189d7b
Sergei Golubchik
clarify the test for triggers with different paths
6820f07ce993...
6820f07ce993aea02ce61057863b160d9ee444d7
Sergei Golubchik
cleanup

* rename to follow the standard vprintf name convention
* remove `(LEX_CSTRING*) &lex_string` casts
* remove some redundant casts too
* LEX_CSTRING -> Lex_ident_db in path
* Hash_set<Sroutine_hash_entry>
* move assert out of the loop
* some comments and whitespace changes
63669a4874c3...
63669a4874c36b0834b84f417b5258881a3f46c5
Sergei Golubchik
bug: `current_schema` is not current_schema

quoted `current_schema` is literally a schema name and must
but treated as such. because Sql_path stores all names unquoted
let's store the current_schema as an empty name, length=0.
No valid schema name can be empty.
5d8692f3ac8b...
5d8692f3ac8b5f653a82df71eb91ba758f5b3a12
Sergei Golubchik
fix name resolution of name1.name2()

only search in thd->db if the path includes CURRENT_SCHEMA

Also, fix a bug with recursive function calls.
5a77de8bf9d2...
5a77de8bf9d2f6f34822556b26b1f6588fc0dd8d
Sergei Golubchik
fix printing of per-partition engine options

paritioning has its own method for printing engine options,
it wasn't consistent with how table options were printed - didn't
use quotes, ignored sql_mode, so wasn't future and dump/import safe.

let's get rid of it and use the same method that prints per-table
engine options.
577a8b7cc127...
577a8b7cc127179a19d769315604881db44c6a1d
Sergei Golubchik
Don't implicitly search in CURRENT_SCHEMA

the intention was not to, but some code paths weren't fixed yet
52ca5afb0081...
52ca5afb0081894881cd4dafd0eb8ca01739f0cd
Sergei Golubchik
more tests for duplicate values in path
4afd79f9dfb2...
4afd79f9dfb2f741d5c3ea4a512b0913f8f115dd
Sergei Golubchik
old view doesn't store the path, need the same fallback as for triggers
417e7be694bb...
417e7be694bb14d9f05d9904a4367effac24b91c
Sergei Golubchik
fix --path to work

complex object sysvars (plugins, time zone, path) cannot be
set by my_getopt, they have to use NO_CMD_LINE and special
code in mysqld.cc
3e3eda93980d...
3e3eda93980d7faf2ac5991ff265f86435b7b108
Sergei Golubchik
disallow SET PATH in sf or trg while parsing

but also when executing, of course
246803204890...
246803204890d2d378620ee0159411a2c4a5b483
Sergei Golubchik
consistency in error message naming
14c99f237118...
14c99f23711830916f92a97d1813bc1839282e9f
Sergei Golubchik
ubsan error, memcpy(dst, NULL, 0)
0f36d2732a95...
0f36d2732a950080e3a8e44e7093bffcae12c217
Sergei Golubchik
reserve PATH_SYM in the same way as NAMES_SYM
09fbf980c050...
09fbf980c0504d60c37a56b11879d75728d99d32
Sergei Golubchik
merge ErrConvMDQName into ErrConvDQName

and remove incorrect thd->db behavior
BuildBot (0.8.9) working for the MariaDB project.
Page built: Fri 06 Feb 2026 15:11:46 (UTC)