Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
ecca0f28aa55...
ecca0f28aa556565afdd64f796adc620a07d8bd2
Sergei Golubchik
reserve PATH_SYM in the same way as NAMES_SYM
e13869f9e909...
e13869f9e9096ad6b2871f2411cf3f519c3da90d
Sergei Golubchik
remove LEX::make_sp_name_sql_path()

it confusingly didn't have anything to do with sql path,
so merged into LEX::make_sp_name()
d613f03c2019...
d613f03c201915667dafb80152338ac4d012b59e
Andrei Elkin
MDEV-37541 Race of rolling back and committing transaction to binlog

Two transactions could binlog their completions in opposite to how it
is done in Engine. That is is rare situations ROLLBACK in Engine of
the dependency parent transaction could be scheduled by the
transaction before its binlogging. That give a follower dependency
child one get binlogged ahead of the parent.

For fixing this bug its necessary to ensure the binlogging phase is
always first one in the internal one-phase rollback protocol.

The commit combines
1. a code polishing piece over a part of MDEV-21117 that
  made binlog handlerton always commit first in no-2pc cases and
2. the same rule now applies to the rollback.

An added test demonstrates how the child could otherwise reach binlog
before its parent.
c7770fc6c128...
c7770fc6c128bbc2b4f25a5b69e85538463c02d8
Kristian Nielsen
Binlog-in-engine: Add mariadb-backup option to omit binlog from the backup

Signed-off-by: Kristian Nielsen <[email protected]>
c5aac3e64e44...
c5aac3e64e44a7237fa656b9670d4560ac81ebf2
Sergei Golubchik
clarify the test for triggers with different paths
c4cf78f2fb6b...
c4cf78f2fb6bfce4684bae1cad23a538aa17334d
Sergei Golubchik
use standard SET PATH syntax in tests
c349dbc8ad94...
c349dbc8ad943aca63979f314066816fdd95e09d
Sergei Golubchik
small cleanup
c01df379ad65...
c01df379ad6536784a9e82b11a8481210e2d0e15
Oleg Smirnov
MDEV-38045: Implement implicit query block names for optimizer hints

This patch implements support for implicit query block (QB) names in
optimizer hints, allowing hints to reference query blocks and tables
within derived tables, views and CTEs without requiring explicit
QB_NAME hints.

Examples.
-- Addressing a table inside a derived table using implicit QB name
select /*+ no_index(t1@dt) */ *
  from (select * from t1 where a > 10) as DT;
-- this is an equivalent to:
select /*+ no_index(t1@dt) */ * from
  (select /*+ qb_name(dt)*/ * from t1 where a > 10) as DT;
-- Addressing a query block corresponding to the derived table
select /*+ no_bnl(@dt) */ *
  from (select * from t1, t2 where t.1.a > t2.a) as DT;

-- View
create view v1 as select * from t1 where a > 10 and b > 100;
-- referencing a table inside a view by implicit QB name:
select /*+ index_merge(t1@v1 idx_a, idx_b) */ *
  from v1, t2 where v1.a = t2.a;
-- equivalent to:
create view v1 as select /*+ qb_name(qb_v1) */ *
  from t1 where a > 10 and b > 100;
select /*+ index_merge(t1@qb_v1 idx_a, idx_b) */ *
  from v1, t2 where v1.a = t2.a;

-- CTE
with aless100 as (select a from t1 where b <100)
  select /*+ index(t1@aless100) */ * from aless100;
-- equivalent to:
with aless100 as (select /*+ qb_name(aless100) */ a from t1 where b <100)
  select /*+ index(t1@aless100) */ * from aless100;

Key changes:

1. Two-stage hint resolution
  - Introduced hint_resolution_stage enum (EARLY/LATE) to control
    when different hint types are resolved:
    - EARLY stage: before opening tables (QB_NAME, MERGE hints)
    - LATE stage: after opening tables (all other hints)

2. Implicit QB name support
  - Derived table/view/CTE aliases can now be used as implicit query
    block names in hint syntax: @alias, table@alias
  - Derived tables inside views can be addressed from outer queries
    using their aliases
ba09844decd2...
ba09844decd2b422e86b2d17a0f6e0dd6cbb9197
Sergei Golubchik
improve test readability

fix confusing duplicate lines like

Invoke from Db: test, Rt: proc
Invoke from Db: test, Rt: proc
b66588bac00a...
b66588bac00a570bf04b8860279ab4fb3acd6c7e
Andrei Elkin
MDEV-37541 Race of rolling back and committing transaction to binlog

Two transactions could binlog their completions in opposite to how it
is done in Engine. That is is rare situations ROLLBACK in Engine of
the dependency parent transaction could be scheduled by the
transaction before its binlogging. That give a follower dependency
child one get binlogged ahead of the parent.

For fixing this bug its necessary to ensure the binlogging phase is
always first one in the internal one-phase rollback protocol.

The commit combines
1. a code polishing piece over a part of MDEV-21117 that
  made binlog handlerton always commit first in no-2pc cases and
2. the same rule now applies to the rollback.

An added test demonstrates how the child could otherwise reach binlog
before its parent.
b27266ed48dd...
b27266ed48dd6ec42111734160a005acbafb3abe
Sergei Golubchik
disallow SET PATH in sf or trg while parsing

but also when executing, of course
9de9811511a6...
9de9811511a679eeebe658bc83c875ff0edf8b0d
Sergei Golubchik
mysql.proc.path DEFAULT 'CURRENT_SCHEMA' NOT NULL
96b3e76dd38e...
96b3e76dd38ef80ff20813553f461e36e06ac777
Sergei Golubchik
bug: `current_schema` is not current_schema

quoted `current_schema` is literally a schema name and must
but treated as such. because Sql_path stores all names unquoted
let's store the current_schema as an empty name, length=0.
No valid schema name can be empty.
9505d82c249e...
9505d82c249e4771ecc915f68715dc047cfdd23a
Sergei Golubchik
more tests for duplicate values in path
8d942cccdb58...
8d942cccdb58a53aa8f7a02d32306aa24100bd92
Kristian Nielsen
Binlog-in-engine: Add mariadb-backup option to omit binlog from the backup

Signed-off-by: Kristian Nielsen <[email protected]>
8647354f6b36...
8647354f6b36e019c1d768e682f26f0754aa8fef
Sergei Petrunia
MDEV-38164: Fix the estimates reported by TABLE::key_storage_length()

(Cherry-pick into 12.2: the fix is enabled by default,
control via @@new_mode=FIX_INDEX_LOOKUP_COST is removed)

They were based on the maximum possible length key length, which
can be much larger than the actual data.

The return value is used by handler::keyread_time(), which is used
to estimate the cost of range access.
This could cause range access not to be picked, even if it uses
the clustered PK and reads about 8% of the table.

The fix is to add KEY::stat_storage_length (next to KEY::rec_per_key) and
have the storage engine fill it in handler::info(HA_STATUS_CONST).

Currently, only InnoDB fills this based on its internal statistics:
index->stat_index_size and ib_table->stat_n_rows.

Also changed:
- In handler::calculate_costs(), use ha_keyread_clustered_time() when
  computing clustered PK read cost, not ha_keyread_time().
7ba678e7355b...
7ba678e7355b8b9cae963fe3eb8646031b363712
Sergei Golubchik
relax assert to account for recursive RETURNS TEXT functions
7a06264a0b12...
7a06264a0b121615ac825d07138245c865be5b06
Sergei Golubchik
merge ErrConvMDQName into ErrConvDQName

and remove incorrect thd->db behavior
739270e75d4f...
739270e75d4f0bcb7b7d1c691d1fc16e8af1b862
Sergei Golubchik
PATH is not a chistic, it's like sql_mode, implicitly per routine
6c9155f48bd7...
6c9155f48bd796cfdf6c1b2f59a03d6205b53ba4
Kristian Nielsen
Binlog-in-engine: Add mariadb-backup option to omit binlog from the backup

Signed-off-by: Kristian Nielsen <[email protected]>
6c04aa915bc3...
6c04aa915bc37d964f0694da2e72665960ae310d
Sergei Golubchik
misc
6b6189718873...
6b6189718873c0d0fb3d1301ec28140746c665d4
Sergei Golubchik
remove Sql_path_stack and Sql_path_push

don't create a permanent stack of paths on the heap and in THD.

Do it on the stack like for sql_mode, sctx, abort_on_warning, and
other THD properties that often need to be changed temporarily.

Fix Sql_path constructor.
645bfa878d39...
645bfa878d39bcfabb399c629410dae1f66796fd
Sergei Golubchik
allocate Sql_path in one memory chunk, not one per schema

because it's always allocated and freed as a whole, there is
no operation "replace one name in the middle of the path"

this needed a reworked parser to create the whole list
of names, not append one name at a time.

Fixed a bug where Sql_path::from_text() pretended it can take
a string in any charset, but was always implicitly
assuming it's in my_charset_utf8mb3_general_ci.
633bae84c2e0...
633bae84c2e017df46f7c18176924d82d6cc45e7
Sergei Golubchik
add new column mysql.proc.path at the end of the table

to simplify downgrades and to avoid breaking applications
620fe12933a1...
620fe12933a1a17711563ad22cb279198148dc13
Sergei Golubchik
free Sql_path in the destructor, perform cleanup in cleanup()
607325ae3392...
607325ae3392ccafe0ea4d9661ada360fef467b4
Sergei Golubchik
fix name resolution of name1.name2()

only search in thd->db of the path includes CURRENT_SCHEMA

Also, fix a bug with recursive function calls.
4cff562f3f89...
4cff562f3f89d4df03e09233d835d0451bc37cc4
Sergei Petrunia
MDEV-38164: Fix the estimates reported by TABLE::key_storage_length()

They were based on the maximum possible key tuple length, which can be
much larger than the real data size.

The return value is used by handler::keyread_time(), which is used
to estimate the cost of range access.
This could cause range access not to be picked, even if it uses
the clustered PK and reads about 8% of the table.

The fix is to add KEY::stat_storage_length (next to KEY::rec_per_key) and
have the storage engine fill it in handler::info(HA_STATUS_CONST).

Currently, only InnoDB fills this based on its internal statistics:
index->stat_index_size and ib_table->stat_n_rows.

Also changed:
- In handler::calculate_costs(), use ha_keyread_clustered_time() when
  computing clustered PK read cost, not ha_keyread_time().

The fix is OFF by default and enabled by setting FIX_INDEX_LOOKUP_COST flag
in @@new_mode.
4c355a4d21a5...
4c355a4d21a56df6e0a350d08770aa673f5655cf
Sergei Golubchik
fix error message for assoc arrays
4b1861c4bce2...
4b1861c4bce28aa90226e4f42063be19f9e1d176
Sergei Golubchik
do NOT prefer itself in seemingly recursive calls, follow the path
3e61464f7e5c...
3e61464f7e5c2948d15c8586ace4c0ce5056d349
Sergei Golubchik
disallow SET PATH DEFAULT in stored routines and triggers

also fix Sys_var_charset_collation_map where this bug was copied from
3ba1425b442b...
3ba1425b442bd8f2835fd4b89c27cd85b78805ca
Sergei Golubchik
consistency in error message naming
3733ccf0c7c0...
3733ccf0c7c0c2be4301e9aa98f1c484aaba3cc6
Sergei Golubchik
fix --path to work

complex object sysvars (plugins, time zone, path) cannot be
set by my_getopt, they have to use NO_CMD_LINE and special
code in mysqld.cc
30dc9715fb6e...
30dc9715fb6e558bd32efd2c29311e06a4fce0a5
Sergei Golubchik
remove always-false agument
2fd25d77f031...
2fd25d77f031f48f501344b5d77aeea62b42da88
Andrei Elkin
MDEV-37541 Race of rolling back and committing transaction to binlog

Two transactions could binlog their completions in opposite to how it
is done in Engine. That is is rare situations ROLLBACK in Engine of
the dependency parent transaction could be scheduled by the
transaction before its binlogging. That give a follower dependency
child one get binlogged ahead of the parent.

For fixing this bug its necessary to ensure the binlogging phase is
always first one in the internal one-phase rollback protocol.

The commit makes sure the binlog handlerton always rollbacks as first
handlerton in no-2pc cases.

An added test demonstrates how the child could otherwise reach binlog
before its parent.
22db2df60c30...
22db2df60c30172379f856afe0460b8cc733ad49
Andrei Elkin
Merge commit '2fd25d77f031f48f501344b5d77aeea62b42da88' into
bb-10.11-release with will be replace by 10.11 specific one.
0cff00690a6a...
0cff00690a6a0c34cfeade7fb60745bb9220f1b0
Sergei Golubchik
don't backtick-quote CURRENT_SCHEMA
092789606a62...
092789606a62474b7349f7e832b94e8e15138c8d
Sergei Golubchik
cache routines during path resolution
BuildBot (0.8.9) working for the MariaDB project.
Page built: Wed 03 Dec 2025 05:13:19 (UTC)