Console View

Categories: connectors experimental galera main

Legend:

Passed

Failed

Warnings

Failed Again

Running

Exception

Offline

No data

connectors

experimental

galera

main

fba3db8f8816...

fba3db8f88163103fd6a3681f6b292c3fa537bea

Sergei Golubchik

serg@mariadb.org

report platform in mtr

fafa57b12bf3...

fafa57b12bf362d80afe0edbd40070ebbc537c26

gkodinov

joro@mariadb.com

Follow up for MDEV-384999: fix cmake warnings:

Moved the include inside the check for cmake version so that
it doesn't fail on older cmake's.

f07d06e6a503...

f07d06e6a503bedd91d59d863c823f6cba029a69

gkodinov

joro@mariadb.com

MDEV-38546: Automatically label new unlabeled pull requests
with foundation/corporation/external contribution

The MariaDB server repository uses certain pull request labels as queue markers
for incoming pull requests as follows:
- External Contribution: for all external contributions
- MariaDB Corporation: for employees of the MariaDB corporation
- MariaDB Foundation: for the employees of the MariaDB foundation

Right now, when a new pull request is filed, these tags need to be applied
manually.
However a large % of these manual assignments can be automated by checking
if the author is in https://github.com/orgs/MariaDB/teams/staff
or in https://github.com/orgs/MariaDB/teams/developers.

If they are in staff "MariaDB Foundation" is assigned.

if they are not in staff, but are in developers, "MariaDB Foundation" is assigned.

If they are in neither staff not developers, "External Contribution" is assigned.

A github workflow is created to do the assignments. It is being triggered
every day at 2AM. Or it can be triggered manually.

ed259743032b...

ed259743032b353558c4d3373de5c75aabdf17d0

Monty

monty@mariadb.org

MDEV-38435 Add Gtid_binlog_pos to SHOW MASTER STATUS

Other things:
- Extended mysqltest to write GTID's for master and slave if
sync_slave_with_master fails.

Reviewer: Brandon Nesterenko <[email protected]>

e79ed898a613...

e79ed898a613d0f2914eb539a62ea688e347daab

Brandon Nesterenko

brandon.nesterenko@mariadb.com

MDEV-38435: Update test results

dc01781dba70...

dc01781dba70c9467c09c431121d23d14156399a

Vlad Lesin

vlad_lesin@mail.ru

MDEV-31956 SSD based InnoDB buffer pool extension

In one of the practical cloud MariaDB setups, a server node accesses its
datadir over the network, but also has a fast local SSD storage for
temporary data. The content of such temporary storage is lost when the
server container is destroyed.

The commit uses this ephemeral fast local storage (SSD) as an extension of
the portion of InnoDB buffer pool (DRAM) that caches persistent data
pages. This cache is separated from the persistent storage of data files
and ib_logfile0 and ignored during backup.

The following system variables were introduced:

innodb_extended_buffer_pool_size - the size of external buffer pool
file, if it equals to 0, external buffer pool will not be used;

innodb_extended_buffer_pool_path - the path to external buffer pool
file.

If innodb_extended_buffer_pool_size is not equal to 0, external buffer
pool file will be created on startup.

Only clean pages will be flushed to external buffer pool file. There is
no need to flush dirty pages, as such pages will become clean after
flushing, and then will be evicted when they reach the tail of LRU list.

The general idea of this commit is to flush clean pages to external
buffer pool file when they are evicted.

A page can be evicted either by transaction thread or by background
thread of page cleaner. In some cases transaction thread is waiting for
page cleaner thread to finish its job. We can't do flushing in external
buffer pool file when transaction threads are waithing for eviction,
that would heart performance. That's why the only case for flushing is
when page cleaner thread evicts pages in background and there are no
waiters. For this purprose buf_pool_t::done_flush_list_waiters_count
variable was introduced, we flush evicted clean pages only if the
variable is zeroed.

Clean pages are evicted in buf_flush_LRU_list_batch() to keep some
amount of pages in buffer pool's free list. That's why we flush every
second page to external buffer pool file, otherwise there could be not
enought amount of pages in free list to let transaction threads to
allocate buffer pool pages without page cleaner waiting. This might be
not a good solution, but this is enought for prototyping.

External buffer pool page is introduced to store information in buffer
pool page hash about the certain page can be read from external buffer
pool file. The first several members of such page must be the same as the
members of internal page. External page frame must be equal to the
certain value to disthinguish external page from internal one. External
buffer pages are preallocated on startup in external pages array. We
could get rid of the frame in external page, and check if the page's
address belongs to the array to distinguish external and internal pages.

There are also external pages free and LRU lists. When some internal page
is decided to be flushed in external buffer pool file, a new external
page is allocated eighter from the head of external free list, or from
the tail of external LRU list. Both lists are protected with
buf_pool.mutex. It makes sense, because a page is removed from internal
LRU list during eviction under buf_pool.mutex.

Then internal page is locked and the allocated external page is attached
to io request for external buffer pool file, and when write request is
completed, the internal page is replaced with external one in page hash,
external page is pushed to the head of external LRU list and internal
page is unlocked. After internal page was removed from external free list,
it was not placed in external LRU, and placed there only
after write completion, so the page can't be used by the other threads
until write is completed.

Page hash chain get element function has additional template parameter,
which notifies the function if external pages must be ignored or not. We
don't ignore external pages in page hash in two cases, when some page is
initialized for read and when one is reinitialized for new page creating.

When an internal page is initialized for read and external page with the
same page id is found in page hash, the internal page is locked,
the external page in replaced with newly initialized internal page in the
page hash chain, the external page is removed from external LRU list and
attached to io request to external buffer pool file. When the io request
is completed, external page is returned to external free list,
internal page is unlocked. So during read external page absents in both
external LRU and free lists and can't be reused.

When an internal page is initialized for new page creating and external
pages with the same page id is found in page hash, we just remove external
page from the page hash chain and external LRU list and push it to the
head of external free list. So the external page can be used for future
flushing.

The pages are flushed to and read from external buffer pool file with
the same manner as they are flushed to their spaces, i.e. compressed and
encrypted pages stay compressed and encrypted in external buffer pool
file.

d20a3fce3907...

d20a3fce3907b36cee69cbfccbbffce24673229f

Sergei Golubchik

serg@mariadb.org

fix rpm upgrade tests after MDEV-37726

MDEV-37726 moved wsrep-start-position to INSTALL_RUNDATADIR
and made the latter to be created by systemd-tmpfiles.

Now postin scriptlet has to run systemd-tmpfiles explicitly
to make sure INSTALL_RUNDATADIR exists before restarting
the server.

followup for 649216e70d87

c13adf161d26...

c13adf161d26e7cca230a045f4675e7059e0c2eb

Vlad Lesin

vlad_lesin@mail.ru

MDEV-31956 SSD based InnoDB buffer pool extension

Fix some tests. Make ext_buf_pool test more stable avoiding race
conditions for read/write counters.

c12e94a38bed...

c12e94a38bed688e668cc7d8eac06d79e6d21763

Sergei Golubchik

serg@mariadb.org

fix sporadic failures on main.user_var --view

b02337c05705...

b02337c057050e2bd7ded459354982254528ad79

gkodinov

joro@mariadb.com

MDEV-38499: cmake and compile errors on MacOSX when compiling mariadb from a git tree

Problems:
1. bison incorrectly issues a warning when it sees "b4_bin"
2. MacOSX linker issues a warning about duplicate mysys/dbug/etc libraries.

On 1: worked around by adding a compiler define with a different name
aliasing the character set variable used with a name that
won't trigger the bison warning

On 2: This is due to the fact that there's a circular dependecy between
mysys and dbug (among others). Turned the warning off by adding a compiler
option to be applied to targets lined with mysys to turn the warning off.

aff38a382870...

aff38a382870e8d9a90bfb8e479d5a30496c4eff

gkodinov

joro@mariadb.com

Follow up for MDEV-384999: fix cmake warnings:

Moved the include inside the check for cmake version so that
it doesn't fail on older cmake's.

a27d3491575e...

a27d3491575e8671facb76905fc132a95834d3aa

Michael Widenius

monty@mariadb.org

MDEV-19683 Add support for Oracle TO_DATE()

Syntax:
TO_DATE(string_expression [DEFAULT string_expression ON CONVERSION ERROR],
format_string [,NLS_FORMAT_STRING])
The format_string has the same format elements as TO_CHAR(), except a
few elements that are not supported/usable for TO_DATE().
TO_DATE() returns a datetime or date value, depending on if the format
element FF is used.

Allowed separators, same as TO_CHAR():
space, tab and any of !#%'()*+,-./:;<=>

'&' can also be used if next character is not a character a-z or A-Z
"text' indicates a text string that is verbatim in the format. One cannot
use " as a separator.

Format elements supported by TO_DATE():
AD Anno Domini ("in the year of the Lord")
AD_DOT Anno Domini ("in the year of the Lord")
AM Meridian indicator (Before midday)
AM_DOT Meridian indicator (Before midday)
DAY Name of day
DD Day (1-31)
DDD Day of year (1-336)
DY Abbreviated name of day
FF[1-6] Fractional seconds
HH Hour (1-12)
HH12 Hour (1-12)
HH24 Hour (0-23)
MI Minutes (0-59)
MM Month (1-12)
MON Abbreviated name of month
MONTH Name of Month
PM Meridian indicator (After midday)
PM_DOT Meridian indicator (After midday)
RR 20th century dates in the 21st century. 2 digits
50-99 is assumed from 2000, 0-49 is assumed from 1900.
RRRR 20th century dates in the 21st century. 4 digits
SS Seconds
SYYYY Signed 4 digit year; MariaDB only supports positive years
Y 1 digit year
YY 2 digits year
YYY 3 digits year
YYYY 4 digits year

Note that if there is a missing part of the date, the current date is used!
For example if 'MM-DD HH-MM-SS' then the current year will be used.
(Oracle behaviour)

Not supported options:
BC, D, DL, DS, E, EE, FM, FX, RM, SSSSS, TS, TZD, TZH, TZR, X,SY
BC is not supported by MariaDB datetime.
Most of the other are exotic formats, format modifies other things that
does not make in MariaDB as we return datetime or datetime with fractions,
not string.
D (day-of-week) is not supported as it is not clear exactly how it would
map to MariaDB. This element depends on the NLS territory of the session.

Extensions / differences compared to Oracle;
- MariaDB supports FF (fractional seconds). If FF[£] is used,
then TO_DATE will return a datetime with # of subseconds.
If FF is not used a datetime will be returned.
- Names can be shortened to it's unique prefix. For example January and Ja
works fine.
- No error if the date string is shorter format_string. This is useful to
get a date from a mixed set of strings in date or datetime format.
Oracle gives an error if date string is too short.
- MariaDB supports short locales as language names
- NLS_DATE_FORMAT can use both " and ' for quoting.

New formats handled by TO_CHAR():
FF[1-6] Fractional seconds
DDD Daynumber 1-366
IW Week 1-53 according to ISO 8601
I 1 digit year according to ISO 8601
IY 2 digit year according to ISO 8601
IYY 3 digit year according to ISO 8601
IYYY 4 digit year according to ISO 8601
SYYY 4 digit year according to ISO 8601 (Oracle can do signed)

Supported NLS_FORMAT_STRING options are:
NLS_CALENDAR=GREGORIAN
NLS_DATE_LANGUAGE=language

Support languages are:
- All MariaDB short locales, like en_AU.
- The following Oracle language names:
ALBANIAN, AMERICAN, ARABIC, BASQUE, BELARUSIAN, BRAZILIAN PORTUGUESE
BULGARIAN, CANADIAN FRENCH, CATALAN, CROATIAN, CYRILLIC SERBIAN CZECH,
DANISH, DUTCH, EGYPTIAN, ENGLISH, ESTONIAN, FINNISH, FRENCH, GERMAN,
GREEK, HEBREW, HINDI, HUNGARIAN, ICELANDIC, INDONESIAN ITALIAN,
JAPANESE, KANNADA, KOREAN, LATIN AMERICAN SPANISH, LATVIAN,
LITHUANIAN, MACEDONIAN, MALAY, MEXICAN SPANISH, NORWEGIAN, POLISH,
PORTUGUESE, ROMANIAN, RUSSIAN, SIMPLIFIED CHINESE, SLOVAK, SLOVENIAN,
SPANISH, SWAHILI, SWEDISH, TAMIL, THAI, TRADITIONAL CHINESE, TURKISH,
UKRAINIAN, URDU, VIETNAMESE

Development bugs fixed:
MDEV-38403 Server crashes in Item_func_to_date::fix_length_and_dec upon
using an invalid argument
MDEV-38400 compat/oracle.func_to_date fails with PS protocol and cursor
protocol (Fixed by Serg)
MDEV-38404 TO_DATE: MTR coverage omissions, round 1
MDEV-38509 TO_DATE: AD_DOT does not appear to be supported
MDEV-38513 TO_DATE: NULL value for format string causes assertion failure

a1cb630bffb8...

a1cb630bffb875fbdfeceb0a0e9c43551eee07df

Monty

monty@mariadb.org

squash! bfeb39d07208ea5cd56ef818421772ea8bb412a3

MDEV-38521 TO_DATE: Date strings with non-ASCII symbols cause warnings
and wrong results

Known limitations:
- Format string cannot contain non ascii characters. This is because
TO_DATE depends on the format string parser 'parse_format_string()'
used by TO_STR(). Should be fixed at some point in time.

9ea72086ae6a...

9ea72086ae6a3a4469862072cc78adc3d8a82e89

gkodinov

joro@mariadb.com

MDEV-38499: cmake and compile warnings on MacOSX when
compiling mariadb from a git tree

Fixed sprintf deprecation warnings compiling on MacOSX.

Replaced some sprintf calls with equivalent snprintf calls,
enough so that "normal" compile on MacOSX (as documented
in the docs) completes without warnings.

9c71ee6df2f5...

9c71ee6df2f564e4d71e6af8200d95b62ef49904

Monty

monty@mariadb.org

Add detection of partial matches for strnncoll

This is achived by changing the 'is_prefix' parameter to strncoll
from a my_bool to my_bool*. This parameter is null if not specified by
the caller. If the is_prefix parameter is set to point to a my_bool
variable, this variable will be set to 1 if the second argument is
a prefix of the first.

This is needed by TO_DATE to be able to detect partial uniqiue matches of
months etc. find_type() did this for latin1 strings, but we did not
do this for utf8mb4 strings.
This patch fixes this incompatibility.

96a3b95fd92c...

96a3b95fd92c5ad7ad8945450775b33cad3d3d70

Vlad Lesin

vlad_lesin@mail.ru

MDEV-31956 SSD based InnoDB buffer pool extension

Fix some tests. Make ext_buf_pool test more stable avoiding race
conditions for read/write counters.

8c3fc32d4c6c...

8c3fc32d4c6ce2939638291820f04b7d7de07622

Christian Hesse

mail@eworm.de

MDEV-35904/MDEV-19210: use environment file in systemd units for _WSREP_START_POSITION

MDEV-35904 - backport MDEV-19210 to 10.11 as referenced
by unset environment variables become warnings.

We used to run `systemctl set-environment` to pass
_WSREP_START_POSITION. This is bad because:

* it clutter systemd's environment (yes, pid 1)
* it requires root privileges
* options (like LimitNOFILE=) are not applied

Let's just create an environment file in ExecStartPre=, that is read
before ExecStart= kicks in. We have _WSREP_START_POSITION around for the
main process without any downsides.

87757223e994...

87757223e994869afb8a5f51c7a4ef045f386f6b

Christian Hesse

mail@eworm.de

7e22fb6d23d1...

7e22fb6d23d19390b5f12223b265283bd7d560ac

gkodinov

joro@mariadb.com

Follow up for MDEV-384999: fix cmake warnings:

Moved the include inside the check for cmake version so that
it doesn't fail on older cmake's.

79cdac5c3c2c...

79cdac5c3c2cf173c67cc15850f2e52ef2593846

Aleksey Midenkov

midenok@gmail.com

MDEV-28619 with_flags cleanup

The best practice is to init as much info as possible in class
constructor. with_flags access may be needed before fix_fields() or
fix_fields() may be not called at all like it takes place in
MDEV-28619. The fix for MDEV-28619 requires WINDOW_FUNC check on
unfixed item.

6c835b163415...

6c835b1634158b120eb1da28baa0cbf87038b16d

Sergei Golubchik

serg@mariadb.org

5cc0306a0765...

5cc0306a076506d8d43e334816cfac0b54df32b6

Marko Mäkelä

marko.makela@mariadb.com

Allow memory-mapped reads of the archived log

log_t::attach(), log_mmap(): Add the parameter bool read_only.

53d037ba03b6...

53d037ba03b6aa206e539e0591ac3bbf893f9ffd

Alessandro Vetere

iminelink@gmail.com

fixup: fix innodb.index_ahi_option,if_specified

Should currently behave as innodb.index_ahi_option,no_ahi excluding
the global variable value.

52862656a6a1...

52862656a6a11376e45b343acbeda4ce5dba4ed5

Brandon Nesterenko

brandon.nesterenko@mariadb.com

MDEV-38435: Follow-up to use StringBuffer instead of String

Credit goes to Serg for the fix

506004be6221...

506004be622172d9ed8de066e6f56070daf1779f

Daniel Black

daniel@mariadb.org

MDEV-15502 debian: systemd, with tmpfiles install not required

With PermissionsStartOnly deprecated, remove this from the
systemd service file.

Replace Debian's ExecStartPre "install -d" with a tmpfile
configuration directive creating the directory with this.

Debian's ExecStartPost of the mariadb upgrade uses the !
special executable prefix added in systemd v231 to use
root privs.

4de773e90cc8...

4de773e90cc8ff5a38e5585780643bdcb986f515

Alexander Barkov

bar@mariadb.com

MDEV-38451 `SHOW FUNCTION CODE package_func` crashes on the second execution

Routine name resolution performed on a temporary memory root
during execution. So on the second execution LEX::spname members
pointed to a cleared memory.

Fixing to peform the resolution to parse time, like the CALL statement does.
During the execution time LEX::spname members now stay untouched.

4b5e6846066a...

4b5e6846066a5bd53b72688a7dc881bfa103e2c3

Daniel Black

daniel@mariadb.org

MDEV-37726 wsrep-new-cluster and wsrep-start-position in wrong directory with wrong selinux permissions

After moving the systemd service to using environment files
instead of `systemctl set-environment` in 11.6 (MDEV-19210),
they (wsrep-new-cluster and wsrep-start-position) are located
in /var/lib/mysql along with the socket file in
Fedora/RHEL-based distros. This causes them to have incorrect
selinux permissions and therefore be not readable by systemd.

A solution is to generate these files in the run directory,
instead, which already has correct selinux label mysqld_var_run_t
mysql-selinux-1.0.12. Dissociating these files and the socket
in CMake configs can also prove useful for other things.

This also corrects some of the duplicate code in the build
scripts and made INSTALL_RUNDATADIR into a proper location
and used this for the tmpfiles where the temporary files
are created.

Debian's location is /run/mysqld/ matching its INSTALL_UNIX_ADDRDIR,
which is now a temporary location controlled by tmpfiles.

4b026730c211...

4b026730c21101f0feb0e6f9c8b39e8a84375b7c

gkodinov

joro@mariadb.com

MDEV-38499: cmake and compile warnings on MacOSX when compiling mariadb from a git tree

Fixed sprintf deprecation warnings compiling on MacOSX.

Replaced some sprintf calls with equivalent snprintf calls,
enough so that "normal" compile on MacOSX (as documented
in the docs) completes without warnings.

Also advanced the connector/C submodule to include the commit fixing
compilation warnings in it.

48b02d34f5a7...

48b02d34f5a762169c81c444b8b5022512b15c03

Alessandro Vetere

iminelink@gmail.com

[skip ci] fixup: implement fixed AHI parameters

Valid parameters are set for future recommendations in
innodb_ahi_enable and used in btr_search_info_update_hash.

TODO Allow fixing "0" as complete_fields (fields) and
bytes_from_incomplete_fields (bytes)

41dd8bfc3873...

41dd8bfc3873b0dbd9cf094b67a3c6f5888ef5f0

Aleksey Midenkov

midenok@gmail.com

MDEV-28619 Server crash and UBSAN null-pointer-use in Window_funcs_sort::setup

Optimization in st_select_lex_unit::prepare() removes ORDER BY for
certain subqueries. That excludes ORDER BY items from being fixed, but
sl->window_funcs still contains window function items and those
related to optimized out ORDER BY are unfixed. The error about missing
window spec is thrown when the item is fixed. Hence we get redundant
processing of window function items without checking window spec
existence.

The fix removes the related window function items when ORDER BY is
optimized out. The fix also updates similar optimization in
mysql_make_view().

33413c631898...

33413c631898ecfc97abd51e272330feca55bf03

gkodinov

joro@mariadb.com

MDEV-38499: cmake and bison warnings on MacOSX when compiling
mariadb from a git tree

Problems:
1. bison incorrectly issues a warning when it sees "b4_bin"
2. MacOSX linker issues a warning about duplicate mysys/dbug/etc libraries.

On 1: worked around by adding a compiler define with a different name
aliasing the character set variable used with a name that
won't trigger the bison warning

On 2: This is due to the fact that there's a circular dependency between
mysys and dbug (among others). Turned the warning off by adding a compiler
option to be applied to targets lined with mysys to turn the warning off.

30116f4c7007...

30116f4c70078a0587b69afb3f55b16d1fe6c683

Marko Mäkelä

marko.makela@mariadb.com