Console View

Categories: connectors experimental galera main

Legend:

Passed

Failed

Warnings

Failed Again

Running

Exception

Offline

No data

connectors

experimental

galera

main

fecbad0a6e85...

fecbad0a6e857e7d550a873f774e5571a40d2409

Rex Johnston

rex.johnston@mariadb.com

MDEV-41179 MAX_KEY_PARTS ranges in select causing SEGV

When a select containing 32 ranges is made on a table containing a
compound key with 32 parts, the range optimizer can run off the end
of a stack variable, invalidly overwriting subsequent stack variables.

In the struct st_sel_arg_range_seq, we have an array
RANGE_SEQ_ENTRY stack[MAX_REF_PARTS];

MAX_REF_PARTS is 32.

check_quick_select
/ sel_arg_range_seq_init
initialises stack[0] as NOT a key part
/ sel_arg_range_seq_next
iterates through the key parts, adding key part n to stack[n+1]

key part #32 gets referenced by step_down_to(), setting seq->i off the
end of the array.

Fix: RANGE_SEQ_ENTRY stack[MAX_REF_PARTS+1];

The above change exposed an issue with key length calculation on
MS Windows. Calling make_prev_keypart_map(32) caused the resultant
bitmap to be calculated as (1UL << 32) - 1. Using the MSVC compiler
this resulted in an empty key length calculation during
handler::index_read_map, causing an assertion in ha_innobase::index_read().

As we only need 32 bits to represent our key map, we change the type thus
-typedef ulong key_part_map;
+typedef uint32 key_part_map;

We correct make_keypart_map() and make_prev_keypart_map() to call our
overflow safe my_set_bits(). We also correct bka_range_seq_next()
and bkah_range_seq_next() to use make_prev_keypart_map().

We also add some DBUG_ASSERTS in key_part_map processing elsewhere,
exposing some issues in our BNLH implementation. We cap the number of
keyuse parts here, altering the explain output of 2 of our tests.

ee5064d2b8a9...

ee5064d2b8a9f9d7e7827ba86f3e0602e668c982

Vladislav Vaintroub

vvaintroub@gmail.com

MDEV-40955 mysql_client_test needs a resolvable DNS on Linux.

The tests test_proxy_header_connect_errors_reset() and
test_proxy_header_host_denied_not_counted() rely on their client IPs
(192.0.2.x test IPs, per RFC 5737) failing reverse DNS lookup permanently,
which is what a real, working resolver reports for them. Linux's resolver
isn't so RFC-compliant, when it has no route to any nameserver at all: it
reports EAI_AGAIN (temporary) instead, which is deliberately excluded from
connect-error accounting to avoid blocking hosts during a DNS outage.
That silently defeats the max_connect_errors check these tests exercise.

Fix by forcing the deterministic "permanent failure" outcome via the
existing getnameinfo_error_noname debug instrumentation, same as its
sibling tests. Debug-only, like those siblings, since the workaround
needs DBUG_EXECUTE_IF.

Assisted-By: Claude Sonnet 5 <[email protected]>

e90b83ad9be5...

e90b83ad9be5356968671fde9b79aff9a98612e5

Rex Johnston

rex.johnston@mariadb.com

e2b15641ecbb...

e2b15641ecbbad3a827fb9aeaa793e9a99aa5d57

Oleksandr Byelkin

sanja@mariadb.com

Merge branch '10.6' into 10.11

d72c7290d393...

d72c7290d39368479947dc5c89f03b082d813de3

Daniel Black

daniel@mariadb.org

Merge branch '10.11' into 10.11-MDEV-40955

c93bedccf630...

c93bedccf630a13398e4d15b5f09dbb18efe5573

Vladislav Vaintroub

vvaintroub@gmail.com

MDEV-40955 mysql_client_test needs a resolvable DNS on Linux.

The tests test_proxy_header_connect_errors_reset() and
test_proxy_header_host_denied_not_counted() rely on their client IPs
(192.0.2.x test IPs, per RFC 5737) failing reverse DNS lookup permanently,
which is
what a real, working resolver reports for it. Linux's resolver isn't so
RFC-compliant, when it has no route to any nameserver at all: it reports
EAI_AGAIN (temporary) instead, which is deliberately excluded from
connect-error accounting to avoid blocking hosts during a DNS outage.
That silently defeats the max_connect_errors check this test exercises.

Fix by forcing the deterministic "permanent failure" outcome via the
existing getnameinfo_error_noname debug instrumentation, same as its
sibling tests. Debug-only, like those siblings, since the workaround
needs DBUG_EXECUTE_IF.

Assisted-By: Claude Sonnet 5 <[email protected]>

c62d7895c35c...

c62d7895c35cafe00a0d516778ddfbd2ab66028e

Daniel Black

daniel@mariadb.org

sql_test: mallinfo2 msan exclusion no longer needed

MSAN interceptor was added in clang-18.1.

bd127faa659b...

bd127faa659bffb91cd659c5f739af30c8aba690

Fariha Shaikh

farihais@amazon.com

MDEV-33660 Add note when setting AUTO_INCREMENT lower than next value

Currently, ALTER TABLE ... AUTO_INCREMENT = N silently fails when using
values lower than the next AUTO_INCREMENT value in the column.

Add a note when attempting to set AUTO_INCREMENT to a lower value than
the next AUTO_INCREMENT value, and maintain the higher value.

Update existing test suites and add a new test to the maria suite for
the newly added note.

All new code of the whole pull request, including one or several files
that are either new files or modified ones, are contributed under the
BSD-new license. I am contributing on behalf of my employer Amazon Web
Services, Inc.

bc8ef06ee960...

bc8ef06ee96002de33e35bbd43f077801290b692

Dave Gosselin

dave.gosselin@mariadb.com

MDEV-39441: Add dbug_print() helpers for join-related types

Introduces new dbug_print() functions for the following types:
dbug_print(NESTED_JOIN)
dbug_print(JOIN)
dbug_print(TABLE_LIST)
dbug_print(JOIN_TAB)
dbug_print(List<Item>)

Typically pointers to instances of the given types are passed.
The dbug_print(List<Item>) is intended to show result row before
sending to client (e.g., invoke in debugger while tracing end_send)
but may work in other contexts.

These functions produce nicely formatted output, please use them
in conjunction with the formatted printfs available in GDB or LLDB:
(gdb) printf "%s", dbug_print(join_tab)
(lldb) p printf("%s", dbug_print(table))

Example output from dbug_print(JOIN) in LLDB. The last line with
value 1302 is the number of characters produced by the printf
command.

(lldb) p printf("%s",dbug_print(join))
JOIN [0x15801bfe8] table_count=3 const_tables=0
join_list 0x158018340 [1 element(s)]:
--- #0 ---
[0x15801af10] "(nest_last_join)" join=INNER (outer_join=0) nested_join=0x15801b618 (elements=2)
NESTED_JOIN [0x15801b618]
used_tables: 0x0
not_null_tables: 0x0
n_tables: 0
counter: 0
nest_type: 1 (JOIN_OP_NEST)
nj_map: 0x0
join_list:
join_list 0x15801b618 [2 element(s)]:
--- #0 ---
[0x15801a308] "t3" join=LEFT (outer_join=1) map=0x4
ON: `test`.`t2`.`a` = `test`.`t3`.`a`
--- #1 ---
[0x158019b30] "(nest_last_join)" join=INNER (outer_join=0) nested_join=0x15801a238 (elements=2)
NESTED_JOIN [0x15801a238]
used_tables: 0x0
not_null_tables: 0x0
n_tables: 0
counter: 0
nest_type: 0
nj_map: 0x0
join_list:
join_list 0x15801a238 [2 element(s)]:
--- #0 ---
[0x1580187c0] "t1" join=RIGHT (outer_join=2) map=0x1
ON: `test`.`t1`.`a` = `test`.`t2`.`a`
--- #1 ---
[0x158018f08] "t2" join=INNER (outer_join=0) map=0x2
(int) 1302

bc3939b84b71...

bc3939b84b71baa816cf9011fd04f7bbbf43dffd

Daniel Black

daniel@mariadb.org

MDEV-17846 Wrong result with grouping select (fix)

Prevent unused variable 'ref_type' warnings on non-debug builds.

ae3ac874c08e...

ae3ac874c08eb4e4bcb0f62f42d0504f2819f5c1

Mohammad Tafzeel Shams

tafzeel.shams@mariadb.com

MDEV-37467: InnoDB Instant ALTER TABLE is not crash safe

The hidden metadata record of instant ALTER TABLE was not written
crash-safely, and recovery could fail to roll it back. These are
independent problems.

First, the metadata record may include externally stored BLOB
metadata. The existing BLOB storage path in
btr_store_big_rec_extern_fields() writes the clustered index record
first, with zero BLOB pointers, and only fills in the BLOB pointers
afterwards. If the server is killed after the mini-transaction that
wrote the (incomplete) metadata record was durably committed, but
before the BLOB pointers were written, the table could become
inaccessible on recovery.

Make metadata BLOB storage crash-safe by writing the BLOB pages and
computing their pointers before the metadata record itself is
inserted or updated, so that the record is always written with
complete BLOB pointers. If the server is killed before the metadata
record is written, the already-written BLOB pages are merely
orphaned, which is safe.

Second, trx_undo_report_row_operation() writes the undo log record in
a mini-transaction of its own, which is committed before the
mini-transaction that writes the metadata record. Because
innobase_instant_try() had already updated SYS_COLUMNS and SYS_TABLES
in earlier mini-transactions, a kill in between left a durable undo
log record for the table while the metadata record was unchanged. On
recovery, trx_resurrect_table_locks() would then load the table
definition before the incomplete transaction was rolled back. The
data dictionary described the table as it would be after the
operation, while the metadata record still described it as it was
before, and btr_cur_instant_init() failed on that disagreement.

Write the undo log record of the metadata record in the same
mini-transaction that inserts or updates the record, so that the two
cannot be separated by a crash: until that mini-transaction is
committed, neither of them is durable.

An undo log record is never split between pages. If the DEFAULT
values of the columns being added are large enough that the undo log
record for updating the metadata record would not fit on one page,
innobase_instant_try() would fail. Determine this before the operation
starts, so that it can be performed by another algorithm instead.

Third, the table definition that recovery loads need not correspond to
the metadata record. dict_load_table_one() reads the committed version
of the SYS_TABLES record, and escalates to READ UNCOMMITTED only when
it finds a SYS_COLUMNS record that was written by a transaction that is
still active. The number of SYS_COLUMNS records that dict_load_columns()
reads is derived from SYS_TABLES.N_COLS, which was read from the
committed version. The record of a column that the operation appended is
located after that many records, so it is never read and the operation
goes unnoticed. Only an instant ALTER TABLE that merely appends columns
can escape this way: ADD COLUMN ... FIRST, DROP COLUMN and column
reordering rewrite the SYS_COLUMNS records of already existing columns.

Detect this on the SYS_TABLES record itself, which is located by table
name and therefore does not depend on N_COLS. Every instant ALTER TABLE
that changes the columns updates that record, because
innobase_instant_try() invokes innodb_update_cols().

Fourth, the rollback writes a metadata record that comprises fewer
fields than the table definition describes, because
btr_cur_trim_alter_metadata() shortens it to the number of fields that
it comprised before the operation. That number determines the size of
the null flag bitmap, and hence the position of the array of field
lengths. rec_init_offsets_comp_ordinary() derives it from the record,
while the two functions that write the record derived it from the table
definition and asserted that the two agree.

- btr_store_big_rec_metadata():
New function to store the off-page columns of a metadata record
ahead of time. Each BLOB page is allocated and linked in its own
mini-transaction, and the resulting BLOB pointers are written
directly into the (heap-resident) index entry. On failure, it frees
any pages it already allocated and resets the pointers to zero.

- btr_free_big_rec_metadata():
New helper to free the BLOB pages written by
btr_store_big_rec_metadata() and reset the entry's BLOB pointers
to zero, used both on failure inside that function and by its
callers when the metadata record ends up not being written.

- row_ins_clust_index_entry_low():
For a metadata entry that needs external storage, convert it to a
big record and call btr_store_big_rec_metadata() (with
log_free_check() allowed, since no latches are held yet) before
inserting the record. On failure, free the metadata BLOBs and
convert the entry back.

- btr_cur_pessimistic_update():
When updating a metadata record that requires external storage,
call btr_store_big_rec_metadata() (without log_free_check(),
since index and page latches are held) before modifying the record,
and free the temporary big_rec vector via btr_free_big_rec_metadata()
or dtuple_big_rec_free() on the various failure/success paths.

- btr_cur_optimistic_insert():
Remove the special-cased jump to convert_big_rec for metadata
entries, since their BLOBs are now always stored ahead of time by
the caller; assert that a metadata entry never needs external
storage at this point.

- innobase_instant_try():
Since btr_cur_pessimistic_update() now stores metadata BLOBs
before updating the record, big_rec is always NULL here; assert
this instead of calling btr_store_big_rec_extern_fields().

- trx_undo_report_row_operation():
New parameter caller_mtr. If it is specified, the undo log record
is written in that mini-transaction, which is never committed or
restarted here. An undo log page is added within the same
mini-transaction if the record does not fit on the current one. A
temporary table never uses the caller's mini-transaction, because
that would require changing its logging mode. All other callers
pass NULL and are unaffected.
Encapsulate the parameters that describe the row change
(clust_entry, update, cmpl_info, rec, offsets) in the new type
trx_undo_row_op, which of the fields are set depends on the
operation, which the type documents.

- btr_cur_ins_lock_and_undo(), btr_cur_upd_lock_and_undo():
For an instant ALTER TABLE metadata record, pass the
mini-transaction that is going to insert or modify the record.

- trx_undo_max_rec_size():
New function to determine the maximum size of an undo log record,
that is, the space available on an empty undo log page.

- ha_innobase::check_if_supported_inplace_alter():
Refuse ALGORITHM=INSTANT if the metadata record already exists and
the undo log record for updating it would exceed
trx_undo_max_rec_size(). trx_undo_page_report_modify() stores the
DEFAULT value of each column that is being added in that record in
full, inline. No such limit applies when the metadata record is
being inserted, because trx_undo_page_report_insert() writes
TRX_UNDO_INSERT_METADATA and no field data.

- dict_load_table_one():
If the SYS_TABLES record was written by a transaction that is still
active, load the table definition as READ UNCOMMITTED. A
delete-marked record is excluded, because SYS_TABLES.NAME is the
clustered index key: RENAME TABLE delete-marks the record of the old
name, and the definition that corresponds to that name is the one
that precedes the rename.

- dict_sys_tables_rec_read():
Report whether the current version of the record was written by a
transaction that has not been committed. The function already
determines this in order to decide whether to read an older
version of the record, and used to discard the answer. Store the
fields that are read in the new type dict_sys_tables_rec, instead
of in separate output parameters. A caller that does not want a
delete-marked record to be reported as not found used to indicate
that by specifying trx_id as nullptr; that is now the parameter
skip_deleted.

- dict_load_table_low():
New parameter uncommitted_rec, which is passed on to
dict_sys_tables_rec_read().

- rec_get_converted_size_comp_prefix_low(),
rec_convert_dtuple_to_rec_comp():
For a record that includes a metadata BLOB, determine the number of
nullable fields from the tuple, by way of
dict_index_t::get_n_nullable(), and not from
dict_index_t::n_nullable. This is what
rec_init_offsets_comp_ordinary() does, and it is equivalent for a
tuple that comprises all fields of the index. Relax the assertions
that required the tuple to comprise all of them.

- Added test in innodb.instant_alter and innodb.instant_alter_crash
to test normal working of INSTANT ALTER, crash safety and full table.

aac56e96065d...

aac56e96065d0350a2d3727854933b40f9743ed9

PranavKTiwari

pranav.tiwari@mariadb.com

MDEV-36896 Assertion 'marked_for_read()' failed in virtual String *Field_varstring::val_str(String *, String *)

Problem: Executing queries that require virtual/generated column
evaluation during filesort trigger debug assertions due to missing
columns in read_set. Release builds return wrong results: rows that do
not match the WHERE, or missing rows that do.

Cause: find_all_keys() temporarily assigns TABLE::tmp_set as both
read_set and write_set (keyread does the same). InnoDB calls
TABLE::update_virtual_field() in the middle of the
scan (row_sel_sec_rec_is_for_clust_rec() ->
innobase_get_computed_value()) when it checks a secondary index record
against an older row version, a delete-marked record, or at READ
UNCOMMITTED. TABLE::update_virtual_field() calls
bitmap_clear_all(&tmp_set) before evaluating virtual column
dependencies. Since all three pointers share the same underlying
bitmap buffer, clearing tmp_set also clears the active
read_set/write_set, causing required columns to appear missing during
execution and triggering the assertion.

Fix: The fix uses a local bitmap instead of tmp_set for the virtual
column dependency walk in TABLE::update_virtual_field(), so the active
read_set/write_set is not touched.

Test: vcol.vcol_keys_innodb covers READ UNCOMMITTED (MDEV-36896) and a
concurrent uncommitted update under REPEATABLE READ (MDEV-41365).

Duplicated by MDEV-41365.

a349bb8501ba...

a349bb8501ba4103dbc378c0bea7ea269d3a4a16

Vladislav Vaintroub

vvaintroub@gmail.com

970492062d91...

970492062d91cd606dd3f6f8a52bd51cf746ab4f

drrtuy

drrtuy@gmail.com

chore: remove jemalloc extension from DuckDB CMake b/c since 1.5.4 is is a part of DuckDB core.

93e051860a9c...

93e051860a9c7e87ee8cee6ed38b640d491f7170

Daniel Black

daniel@mariadb.org

MDEV-40801 ppc64le ro_after_init isn't pagesize aligned

Align ro_after_init using MAXPAGESIZE instead of COMMONPAGESIZE.

COMMONPAGESIZE may be smaller than the actual page size supported by
the target ABI. This can leave ro_after_init sharing an OS page with
adjacent sections, causing mprotect() to change permissions on data
outside ro_after_init.

Use MAXPAGESIZE so the section boundaries are aligned to the maximum
page size required by the target linker/ABI.

This is particularly important on architectures such as ppc64le and
aarch64, where the runtime page size can differ from COMMONPAGESIZE.

Before:
.data 0x...1b80000
ro_after_init 0x...1c70000
.bss 0x...1c72000

After:
ro_after_init starts and ends on MAXPAGESIZE boundaries, ensuring
mprotect() only affects pages belonging to ro_after_init.

Co-authored-by: ChatGPT GPT-5.6 Luna <[email protected]>

919b643dd1da...

919b643dd1dac8a6052b20245bcb83e907dd95ac

Vladislav Vaintroub

vvaintroub@gmail.com

MDEV-11111: fix embedded test failures seen on Linux

- The launcher connects once to see that the private server listens. The
server logged that as an aborted unauthenticated connection, in the
language of the server, so mtr did not suppress it (main.locale). Do
not log it in embedded mode.
- sys_vars.version found embedded runs by the name of mysqltest; use the
--server-arg it is now given.
- sys_vars.port_basic, skip_networking_basic and socket_basic show the
TCP and socket settings, which the private server sets by itself; skip
them in embedded runs.

Tested on Linux in normal and --embedded-server mode.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

8f00e6caca63...

8f00e6caca633c783140db86d3a48a96de67cf38

Marko Mäkelä

marko.makela@mariadb.com

MDEV-40756 Incorrect multi-batch recovery of file size

file_name_t::page0_lsn: Keep track of the last applied
recv_sys_t::parse_page0() so that a multi-batch recovery
will not reset the file to a smaller size.

Reviewed by: Thirunarayanan Balathandayuthapani

84695e9c0b76...

84695e9c0b762db7ce7e23fc4ac51717b3a77efc

Daniel Black

daniel@mariadb.org

MDEV-40243 Fix MEMORY_LEAK_C leaks in mariadb-dump (rockdb tests)

With memory leaks fixed in the rocksdb.mysqldump/mysqldump2 no
longer need to run with leak detection disabled.

There tests are still disabled as there's no --rockdb arg to
mariadb-dump, but removing so there's no precidence to ignoring
leaks.

ref: 2217477fb8fc82f4921d9d13afcd24b1d86b34d6

83c5d8746480...

83c5d87464801eb23e23ff4bcbc6b7c6f9b7edd4

Daniel Black

daniel@mariadb.org

MDEV-40750 gcc-16.1.0 on ppc64 causes innodb to fail to compile

Assembler comes up with the error:
unrecognized opcode: `dcbstps'

dcbstps is a Power 10 instruction. The default target arch on most
platforms is Power 8 or 9.

Added the target power10 to the function pmem_phwsync. The execution
of this function is gated on the ISA 3.1 in pmem_persist_init so
there's no chance of a SIGILL.

clang supports this target as arch=pwr10 and gcc as cpu=power10.
Revert back to using opcodes for old versions.

81bb68ba63b5...

81bb68ba63b59ec5999afea7b1182350761d4de9

drrtuy

drrtuy@gmail.com

chore: add DuckDB version info function.

7a40c0cf8e51...

7a40c0cf8e510decf71f51538c8a7a4ec12ecc5c

Rex Johnston

rex.johnston@mariadb.com

79520ba4e5b1...

79520ba4e5b17ac69f69a980615ad81f26f6b975

Daniel Black

daniel@mariadb.org

RocksDB: compile fix std::replace requires algorithm header

Otherwise it compile fails.

Found in clang-24.

77c8f7916181...

77c8f791618136002e5724ca81f365134b583a29

Daniel Black

daniel@mariadb.org

MDEV-40749 period.create test leaks/faults in asan

Selecting from the information_schema.plugins causes the loading
of all plugins. Because rockdb leaks, and duckdb triggers an
address sanitizer warning on shutdown avoid this table.

Use the information_schema.ENGINES to validate that InnoDB is
disabled per the original request in the review of MDEV-32205.

64f8fee97b2c...

64f8fee97b2c38f906a6f09ac78495159dc17d53

Vladislav Vaintroub

vvaintroub@gmail.com

MDEV-40955 mysql_client_test needs a resolvable DNS on Linux.

The test test_proxy_header_connect_errors_reset() relies on 192.0.2.50
(test IP, per RFC 5737) failing reverse DNS lookup permanently, which is
what a real, working resolver reports for it. Linux's resolver isn't so
RFC-compliant, when it has no route to any nameserver at all: it reports
EAI_AGAIN (temporary) instead, which is deliberately excluded from
connect-error accounting to avoid blocking hosts during a DNS outage.
That silently defeats the max_connect_errors check this test exercises.

Fix by forcing the deterministic "permanent failure" outcome via the
existing getnameinfo_error_noname debug instrumentation, same as its
sibling tests. Debug-only, like those siblings, since the workaround
needs DBUG_EXECUTE_IF.

Assisted-By: Claude Sonnet 5 <[email protected]>

5e3faaaa23cc...

5e3faaaa23cc4bba251c82c28f57759385c6909d

Vladislav Vaintroub

vvaintroub@gmail.com

MDEV-11111: fix more buildbot failures

- main.mysqld--help: the three --embedded-* options are listed.
- debian: libmariadb3.symbols gets mariadb_set_embedded_hooks.
- mysqltest: allow 256 --server-arg (the private server of an embedded
run gets more than 64 with the options of the test and of mtr).
- embedded runs: skip the tests that need a TCP listener, which the
private server does not have (pool of threads, ssl_verify_ip,
ssl_7937); main.variables sees skip_networking ON there.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

5b768b49f2b7...

5b768b49f2b7d98fc1755e3e598a7db9ea46d878

Vladislav Vaintroub

vvaintroub@gmail.com

53b1cc014932...

53b1cc0149328c7d3857d9d0d6efbbbc779ac2c2

Alexander Barkov

bar@mariadb.com

MDEV-28498 Incorrect information in file: './test/t0.frm' on CREATE TABLE

Applying HEX encoding write writting an ENUM/SET TYPELIB to FRM
if the TYPELIB has 0x00 bytes in the value.

This HEX encoding was earlier used only to write UCS2/UTF16/UTF32 TYPELIBs.

A new flag FIELDFLAG_FRM_HEX_ENCODED_TYPELIB was added to indicate
that the TYPELIB is hex encoded. It's used only inside FRM.
Note, it's mangled with FIELDFLAG_TREAT_BIT_AS_CHAR.
This should not be harmful:
- BIT and ENUM/SET columns are handled by two separate code branches
when opening an FRM
- The flag is unset immediately after decoding TYPELIB, so the rest
of the code does not se an unexpected flag combination.

45c0b8649cd3...

45c0b8649cd3e8ff8fefa5258b6b3f2c3172b61f

GoldenEmperor1177

xurbanconcept1@gmail.com

MDEV-34215 Fix DATE_FORMAT result length for negative TIME

DATE_FORMAT calculated its maximum result length solely from the format
string. Formatting a negative TIME also prepends a minus sign, so the
cursor protocol trusted an undersized result and truncated -01 to -0.

Account for the possible sign in format_length() for TIME_FORMAT() and
DATE_FORMAT() with a native TIME argument. Enable the existing cursor
protocol regression cases for binary, latin1, and utf32 result character
sets.

3b8db4540386...

3b8db4540386791bb0fd2fbf53f397f9ad8c19a0

Oleksandr Byelkin

sanja@mariadb.com

Merge branch '11.4' into 11.8

3523ffdf971f...

3523ffdf971f60d8d91f571618c768057fae4632

sjaakola

seppo.jaakola@mariadb.com

MDEV-36677 rsync sst fails with different innodb_log_group_home_dir and datadir

Backported the fix done by Pekka Lampio for mariaDB 11.4 in PR
https://github.com/mariadb-corporation/codership-mariadb-server/pull/543

The PR has a fix for wsrep_sst_rsync script and new mtr test:
galera_3nodes.galera_mdev_36677" to check that the rsync SST method of Galera
works correctly also when the joiner node store InnoDB log files in a dedicated
directory separate from the data dictionary

Note: merging this PR to 11.4 may not be fully functional as there are other
changes in the rsync SST script. Take a look at the original 11.4 PR when merging.

30e7c940ff6b...

30e7c940ff6bca2c12455b68735bc5dffcb83b9c

Aleksey Midenkov

midenok@gmail.com

handlersocket.basic unstable result fix

The test fails on random secret with backslash.

The random handlersocket_plain_secret is generated from the '0'..'z'
range, which includes the backslash. The test masked the secret with
--replace_result $HS_SECRET, and mysqltest parses --replace_result
arguments with backslash escapes, so the search string lost the
backslash and did not match the output. The unmasked secret then
appeared in the result (about 19% of runs).

The fix masks the secret in SQL: IF(variable_name LIKE
'handlersocket_plain_secret%', 'HS_SECRET', variable_value), which does
not depend on the secret value.

2fa3b0f0c4b6...

2fa3b0f0c4b66f302b70e213fdf83f866adff7ec

Daniel Black

daniel@mariadb.org

MDEV-37224 Remove UBSAN limitation from MTR tests

Having a not_ubsan.inc as a test case exclusion mechanism is
allowing developers to ignore UBSAN issues. As undefined behaviour
detected at runtime or compile time isn't acceptable in the
code base, remove the exclusion.

The lotofstack test, the only user of not_ubsan.inc, has this
exclusion because the stack size under UBSAN lacks predictability.

Adjust its exclusion because of this criteria, and not its UBSAN
status.

Reviewer: Jimmy Hu <[email protected]>

2a3891f1b7e1...

2a3891f1b7e1993e1de3bc43242d87f5ff0a2be4

Alexey Yurchenko

alexey.yurchenko@mariadb.com

Merge branch '10.11' into MDEV-38147-missing-result-file

282a10a4a795...

282a10a4a7958fd11dcf98a6575664a3aa57ea21

Daniel Black

daniel@mariadb.org

MDEV-38405 Assertion `tbl->trn == 0' failed in _ma_set_trn_for_table

Aria bulk insert operations disables share->now_transaction meaning
a concurrent open of the stable table will have
trn == &dummy_transaction_object for its MARIA_HA object during opening.

As the _ma_set_trn_for_table is setting the trn, its harmless if the
current trn is the dummy_transaction_object.

Relax the assert to allow for this state.

1a052f27e374...

1a052f27e374fc9b4cb5b1fd098cf10f0e1381cc

Sergei Golubchik

serg@mariadb.org

rocksdb: don't abort early in submodule update

Fix for 1fb075512a7aeab8646a163cbb6f265c49f4c075 to allow
the ADD_SUBMODULE to perform updates.

170b1d70737b...

170b1d70737be6f134448f51713cdc1ae215b420

Oleksandr Byelkin

sanja@mariadb.com

Merge branch '10.11' into 11.4

12ceb4d6aac1...

12ceb4d6aac1c287f4e2bf8d0412795f4e539020

Daniel Black

daniel@mariadb.org

MDEV-34482 main.events_processlist test fix

As the test result is dependent of SHOW PROCESSLIST output,
adjust the wait condition to ensure the state is in sleeping
rather than "init" or another state.

12016fdeedf7...

12016fdeedf771099059e367bf41a4bf4066b471

Alexey Yurchenko

alexey.yurchenko@mariadb.com

MDEV-38147 add missing result file for MDEV-38147_gtid_off test

0fe578244bc2...

0fe578244bc2904ae482d7836a7e3d4415e3482f

Mohammad Tafzeel Shams

tafzeel.shams@mariadb.com

MDEV-39795: Assertion `n_reserved > 0' failed

Problem:
========

1. Assertion `n_reserved > 0` failed in fseg_create():

fsp_reserve_free_extents() has a special condition for small
tablespaces where it reserves individual pages instead of full
extents. In such cases, n_reserved can be 0 even when the
reservation succeeds, causing the assertion ut_ad(n_reserved > 0)
to fail incorrectly.

The code was checking n_reserved to determine whether a reservation
had already been attempted, but this logic breaks for small
tablespaces where pages, rather than extents, are reserved.

2. Encryption metadata not cleared for compressed-only pages:

buf_page_encrypt() only cleared encryption-related metadata
fields (key-version and crypt-checksum) when the page was
neither encrypted nor compressed. However, these fields should
also be cleared when page_compressed is true but encrypted is
false, to avoid leaving stale encryption metadata in
compressed-only pages.

Solution:
=========

buf_page_encrypt(): Refactored the early-return logic. Encryption
metadata fields are now cleared whenever encrypted is false,
regardless of page_compressed. The function returns early only
when both !encrypted and !page_compressed.

fseg_create(): Reintroduced a boolean variable `reserved` to track
whether fsp_reserve_free_extents() has been attempted (removed as
part of MDEV-38419 | c7313da), replacing assertion `n_reserved > 0`.
Added an early return when DB_DECRYPTION_FAILED is encountered
during inode allocation.

my_error_innodb(): Added handling for DB_DECRYPTION_FAILED to
report decryption errors to the user through ER_GET_ERRMSG.