Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
fca6a7b784cb...
fca6a7b784cbedcfbc8c16fd259b85d9b6b40929
Oleksandr Byelkin
change after changing server maturity
f9fe7255659d...
f9fe7255659d3c9c58ecf6550068e102c6b2ab51
Dave Gosselin
MDEV-35747: Wrong result from prepared TVC with parameter markers

The setup of column type information in table_value_constr::prepare()
was wrapped in an "if (!holders)" guard so that it runs only once per
prepared statement.  However, the guard was too wide because it bound
the allocation of item holders (which should happen only once) to the
collection of type information (which should happen on each
execution).

This leaves the TVC stuck with whatever placeholder type the parameter
had at PREPARE time which may not match the type of the next
substitution.  A type holder has no actual type at PREPARE time.  Its
type only becomes known when a value is bound at EXECUTE time.  So
both the TVC types and the corresponding Item_type_holder instance in
the SELECT item list must be computed again on every EXECUTE.

This patch separates the work done once per prepared statement from
the work done on every execution as implied above.
f664ccbd2f96...
f664ccbd2f96da55c74818ca50422b60728073c8
Monty
Review fixes for "Batch tail allocation for blob continuation chains"

- Optimized setting is_only_run (avoiding one/two if's for each loop)
- Removed test for run_rec_count == 1 in a context where it was guaranteed
  to be 1.
- Removed not needed variable prev_pos (as it was always identical to
  run_start)
ed8f61d5ecfa...
ed8f61d5ecfaf8498f30a1e5ac0c689bfa6e8d20
Jan Lindström
MDEV-39488 : Skip Galera test requiring perfschema if -DPLUGIN_PERFSCHEMA=NO

Test change only, this test does not need perfschema.
e706cddcd53d...
e706cddcd53dcb7af89fa80a1f12ed9038a4c523
Oleksandr Byelkin
fix show create after merge
e22c2a0d0e01...
e22c2a0d0e0101fd447216fc0a1e73742f09bc1c
ParadoxV5
MDEV-37321: Move select IO thread steps and select connector functions

To prepare for MDEV-37321, this commit moves them to a
`Remote_event_stream` class outside of `sql/`.
The `.cc` file will switch to Connector/C unbeknownst to `rpl_mi.cc`.

Only the following steps are reörganized to reusable instance methods:
* Connection setup and startup
* VIO management
  * Abort when the thread is killed
  * Closing
    (already covered by Connector/C, but not by the current `libmysql`)

The following steps are currently not öptimal for moving
(have verbose changesets), so they are only wrapped, not reörganized:
* steps that run queries *with copy-pasted code*
* sending commands `COM_REGISTER_SLAVE` & `COM_BINLOG_DUMP`,
  including serializing their arguments
  * Connector/C does not have a formal API for serializing
    command arguments, especially variable-length strings.
  * Connector/C has a Binlog API that duplicates this step, but that
    API is not modular for the Server’s full replication capabilities.
* error checking

These require refactors and ideally an evaluation for `mariadb-binlog`.

To enable this migration, this commit additionally:
* Reserves the management of the IO thread’s VIO to the client library
* Draft-specific: omits MDEV-28114’s kludge failure
  recovery for Semi-Sync graceful self-KILL since
  * MDEV-32551 fixed the root bug on the ACK receiver, and
  * MDEV-39583 plans to remove this entire sub-component.

Draft-specific: Until Connector/C exports the pre-decompress (network)
byte count, `@@read_binlog_speed_limit` will measure the post-decompress
count even in `@@slave_compressed_protocol` for now.
df2b2ee7457d...
df2b2ee7457dc483f647e5c6b5127a0c9ccaa2f3
Sergei Golubchik
MDEV-39582 mariadb-binlog missing sanity checks for ibb files

check that binlog_page_size <= BINLOG_PAGE_SIZE_MAX
dec3f0a619a7...
dec3f0a619a76149d1d8788631c312e36296d590
Oleksandr Byelkin
MDEV-39389 Memory leaks in _db_set_init

Handle forgotten case of resetting parameters
(free command_line before assigning a new one).
db1f0dd86fee...
db1f0dd86fee58c690e7b03a5a136942dfdcd4e6
Alexey Botchkov
MDEV-39536 ASAN heap-buffer-overflow in process_str_arg upon ER_TRUNCATED_WRONG_VALUE "Incorrect XML value".

Test casse added.
c7f2c23f9bad...
c7f2c23f9bad0008eb2fd65d32aec8ac6884c717
Raghunandan Bhat
MDEV-39095: Fixes to MariaDB Syntax Checker

- Skip initializing stopwords for full-text indicies.
- Skip changing data directory when checking syntax.
- Help message when syntax checker is used in interactive mode.
- Initialize THD with a dummy database name to prevent `No database
  selected` error.
- Allow execution of SET sql_mode, so that subsequent queries are parsed
  based on the set sql mode.
- More tests: DDLs, DMLs, Stored Procedures, Views, sql_mode
c7643a97878d...
c7643a97878d170f43856d4839500f59e4d6cc2f
Monty
Review of reclaim tail records on failed blob allocation

- Simplify loop in hp_shrink_tail to avoid multiplcations
- Moved assert from callers of hp_shrink_tail() to hp_shrink_tail()
c60da991467d...
c60da991467d15cadf8adbe3e7b43e96b874d76f
Monty
Review fixes for "Code review feedback: `hp_update.c` cleanup, test renames, style fixes"

- Optimized struct layouts in heap.h even more by moving variables
  according to size
- Replaced max_heap_table_size with tmp_memory_table_size in tests
- In ha_heap::records_in_range, removed not needed variable blob_count
- In hp_blob.cc:hp_write_run_data() replaced loop with one memcpy
- In heap_write() replaced loop with jump to avoid code duplication

Other things:
- Removed extra empty lines
- Reformatted rows to fit 80 characters
- Removed not needed braces from blocks with no varaibles.
c5dc80a7299e...
c5dc80a7299e19db8e926ac0a75458d721257ab4
Monty
Review fixes for "Batch tail allocation for blob continuation chains"

- Optimized setting is_only_run (avoiding one/two if's for each loop)
- Removed test for run_rec_count == 1 in a context where it was guaranteed
  to be 1.
- Removed not needed variable prev_pos (as it was always identical to
  run_start). This also fixes one of the bugs fixed by the next commit.
c44ddd95f466...
c44ddd95f466f479967bfc1c251a309ba12d621d
Dave Gosselin
MDEV-35747: Wrong result from prepared TVC with parameter markers

The setup of column type information in table_value_constr::prepare()
was wrapped in an "if (!holders)" guard so that it runs only once per
prepared statement.  However, the guard was too wide because it bound
the allocation of item holders (which should happen only once) to the
collection of type information (which should happen on each
execution).

This leaves the TVC stuck with whatever placeholder type the parameter
had at PREPARE time which may not match the type of the next
substitution.  A type holder has no actual type at PREPARE time.  Its
type only becomes known when a value is bound at EXECUTE time.  So
both the TVC types and the corresponding Item_type_holder instance in
the SELECT item list must be computed again on every EXECUTE.

This patch separates the work done once per prepared statement from
the work done on every execution as implied above.
bf715bc46e2c...
bf715bc46e2c6a6974eaa2c7e1eae637aad65b42
Alexey Botchkov
MDEV-39536 ASAN heap-buffer-overflow in process_str_arg upon ER_TRUNCATED_WRONG_VALUE "Incorrect XML value".

Test casse added.
bd6715c55822...
bd6715c55822b97bf706f1318f4417556ebe37fc
Rex Johnston
MDEV-39492 Parallel Query: Study how to create worker threads

Introduces parallel_worker_threads variable to control the number
of worker threads created by a parallel execution query.

2 new files, sql_parallel_workers.h sql_parallel_workers.cc which
contain structures for the creation, management and deletion of
parallel worker threads (pwt_ in the name).  Main management
class created in the stack in JOIN::exec, implemented for the
top level select.

Current parallel_worker_thread_func sleeps for a random time, generates
a warning, signals the main thread, sleeps a random time, signals the
main thread again, sets it's finished flag and cleans it's THD.

The main thread loops through worker threads, looking for finished
thread and cleans them up if they have finished.
It then waits for a signal, then processes it's message queue.

The thread management data is allocated on the stack in JOIN::exec.
Everything else is allocated using my_malloc() and my_free().
b7fe0ec311e9...
b7fe0ec311e9af79467822742689de3672390315
Dave Gosselin
MDEV-38508: Constant table detection

If a table that's in a FULL OUTER JOIN is found to be a const
table, then don't allow the constant table optimization to
take place.

Later, when we support FULL OUTER JOIN on the inner side of
other join types then we may be able to relax this restriction.
b01065852a72...
b01065852a729a711bc73fdbe38e58b3d3c29802
Alexey Botchkov
MDEV-39589 Wrong results with xmltype as a virtual column.

Store value in the XML column even if an error happened.
aed5d6199d51...
aed5d6199d51451ea455a2f4b7d22a751e921401
Monty
Review fixes for "Code review feedback: `hp_update.c` cleanup, test renames, style fixes"

- Optimized struct layouts in heap.h even more by moving variables
  according to size
- Replaced max_heap_table_size with tmp_memory_table_size in tests
- In ha_heap::records_in_range, removed not needed variable blob_count
- In hp_blob.cc:hp_write_run_data() replaced loop with one memcpy
- In heap_write() replaced loop with jump to avoid code duplication

Other things:
- Removed extra empty lines
- Reformatted rows to fit 80 characters
- Removed not needed braces from blocks with no varaibles.
95ab071bead6...
95ab071bead67a564f7a8fbcb0a6fc3b377efbe2
Dave Gosselin
Remove the unused AGGR_OP::flush_record method
92ef4ea84e0e...
92ef4ea84e0e63c73a7d674fd2dc3b96cd52fa93
Raghunandan Bhat
MDEV-39095: Fixes to MariaDB Syntax Checker

- Skip initializing stopwords for full-text indicies.
- Skip changing data directory when checking syntax.
- Help message when syntax checker is used in interactive mode.
- Initialize THD with a dummy database name to prevent `No database
  selected` error.
- Allow execution of SET sql_mode, so that subsequent queries are parsed
  based on the set sql mode.
- More tests.
902e468b5574...
902e468b55742075368d2f6a6f2e03027a43f592
Alexey Botchkov
MDEV-39536 ASAN heap-buffer-overflow in process_str_arg upon ER_TRUNCATED_WRONG_VALUE "Incorrect XML value".

Test casse added.
6e9ae08b7ad7...
6e9ae08b7ad79885425652bc648f8fc56f7b1177
Monty
squash! 4888cdb69fd115986625da2a44b78a6a3898983c

Fixed that heap_prepare_hp_create_info() honors tmp_memory_table_size
Fixed memory overrun error in hp_test_hash-t
Added DBUG_ASSERT to ensure that we are not used converted heap
keys with index_read()
66632eb12686...
66632eb12686444f1ead9471b934159deee5f2a0
Alexey Botchkov
MDEV-39570 LeakSanitizer: detected memory leaks after insert with xmltype

XML parser should always be freed.
586ea54ff50f...
586ea54ff50fb58ab41c76026ae14cab3be7a22e
Raghunandan Bhat
MDEV-39095: Fixes to MariaDB Syntax Checker

- Skip initializing stopwords for full-text indicies.
- Skip changing data directory when checking syntax.
- Help message when syntax checker is used in interactive mode.
- Initialize THD with a dummy database name to prevent `No database
  selected` error.
- Allow execution of SET sql_mode, so that subsequent queries are parsed
  based on the set sql mode.
- More tests.
509e40e706d0...
509e40e706d0cea33e1b1486bc9f0929b5991553
Daniel Black
MDEV-30518: JSON functions cannot be killed on big-endian

The json_engine killed_ptr was of type uchar however the enum
in the server is dependant on the architecture. On big-endian
architectures like IBM Z, retreiving a uchar* retreived the
unmodifed part of the THD->kill enum location and was always 0.

As C++11 allows enums to inherit a type, used uint32_t as the base
class of killed_state type in the server and used uint32_t in the
json library.

reload_acl_and_cache required an expression change to avoid
the compile error:
sql/sql_reload.cc:472:24: error: enumerated and non-enumerated
type in conditional expression [-Werror=enum-conversion]
  472 |  return result || (thd ? thd->killed : 0);

Added the kill_ptr assignment the following functions can be
killed:
* Item_func_json_depth::val_int
* Item_func_json_type::val_str
* Item_func_json_length::val_int

Item_func_json_array_append::val_str, check_killed() only applied
to json_error: label and not return_null.

Item_func_json_overlaps::val_bool ensure check_killed() is called.

Item_func_json_format::val_str(), corresponding to the SQL,
json_compact, json_detailed, json_loose - add debug instrumentation
for the func_json_notembedded test.

MDEV-26726 (fcd345de485f) added a json_pause_execution sync point
however the test case used debug_max_statement_time, which doesn't
exist. Fix the sync point name in the test.
501c84b01db7...
501c84b01db7e2ab2fb97988fd7e02ca71ce9dd1
Sergei Golubchik
MDEV-39582 mariadb-binlog missing sanity checks for ibb files

check that binlog_page_size <= BINLOG_PAGE_SIZE_MAX
4e48c7323f45...
4e48c7323f4513b90a6277cbdc2ede41aaf1fa0c
Alexey Botchkov
MDEV-39536 ASAN heap-buffer-overflow in process_str_arg upon ER_TRUNCATED_WRONG_VALUE "Incorrect XML value".

Test casse added.
4c371e30f003...
4c371e30f003b601e7485533476208ae27d51937
Alexey Botchkov
MDEV-38809 RBR fails upon DML with XML type.

Add Field_xmltype::rpl_conv_type_from() function to control
replication data types.
45718801fb07...
45718801fb0755ea2092d8382bf29f7490667dcb
Monty
Review commit for Overflow-to-Aria on `ha_update_tmp_row()`...

- Updated test to print number created temporary files for all
  test parts.
- Fixed long comment in hp_blob.c
426e8e73da72...
426e8e73da722c7675199afe1884c3d2a06e77c3
Alexey Botchkov
MDEV-39536 ASAN heap-buffer-overflow in process_str_arg upon ER_TRUNCATED_WRONG_VALUE "Incorrect XML value".

Test casse added.
32f4837fff54...
32f4837fff540d76004260f117cafbdf2d1c1406
Alexey Botchkov
MDEV-39573 Server crashes in Item_char_typecast::fix_length_and_dec_internal after select xmltype.

Charset specified.
3070012b02e2...
3070012b02e27cb3ab58d453c4a8ec8d825c9a3c
Alexey Botchkov
MDEV-39570 LeakSanitizer: detected memory leaks after insert with xmltype

XML parser should always be freed.
24cf892eb5c1...
24cf892eb5c1a160383dc018851101b7052f96d5
Dave Gosselin
MDEV-35747: Wrong result from prepared TVC with parameter markers

The setup of column type information in table_value_constr::prepare()
was wrapped in an "if (!holders)" guard so that it runs only once per
prepared statement.  However, the guard was too wide because it bound
the allocation of item holders (which should happen only once) to the
collection of type information (which should happen on each
execution).

This leaves the TVC stuck with whatever placeholder type the parameter
had at PREPARE time which may not match the type of the next
substitution.  An Item_param has no actual type at PREPARE time.  Its
type only becomes known when a value is bound at EXECUTE time.  So
both the TVC types and the corresponding Item_type_holder instance in
the SELECT item list must be computed again on every EXECUTE.

This patch separates the work done once per prepared statement from
the work done on every execution.

A separate change in Item_args::alloc_arguments resets arg_count to
zero on entry, so that running get_type_attributes_for_tvc again on
persistent Type_holder slots does not accumulate arguments across
executions.
181f13ec49fd...
181f13ec49fdf14a873e9ebf7440133b3e0d70d9
Alexey Botchkov
MDEV-39536 ASAN heap-buffer-overflow in process_str_arg upon ER_TRUNCATED_WRONG_VALUE "Incorrect XML value".

XML should be prepared before inserting it into the error message.
0d9a5905baf2...
0d9a5905baf2f771d6553dbb62c6d79edd6d8b72
Raghunandan Bhat
MDEV-39095: Fixes to MariaDB Syntax Checker

- Skip initializing stopwords for full-text indicies.
- Skip changing data directory when checking syntax.
- Help message when syntax checker is used in interactive mode.
- Initialize THD with a dummy database name to prevent `No database
  selected` error.
- Allow execution of SET sql_mode, so that subsequent queries are parsed
  based on the set sql mode.
- More tests: DDLs, DMLs, Stored Procedures, Views, sql_mode
09f76560e80a...
09f76560e80a167c8a975034825fe5c5c6f9027c
Dave Gosselin
MDEV-39569: Skip FULL JOIN rewrite to inner side of an outer join

Prevent simplify_joins from rewriting a chained FULL JOIN into a query
where a FULL JOIN could end up on the inner side of another outer
join.  Of course, this means that we will have a null complement pass
that the rewritten query would have avoided.  Once we support FULL
JOINs on the inner side of outer joins, in phase 3, then we can relax
this constraint.
BuildBot (0.8.9) working for the MariaDB project.
Page built: Thu 14 May 2026 02:31:42 (UTC)