Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Categories: connectors experimental galera main
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

connectors experimental galera main
e3c9ff6a0e13...
e3c9ff6a0e1378fca533144595fa01cd72000a85
Sergei Golubchik
cleanup: remove explicit rounding before decimal2longlong

embed rounding into decimal2longlong instead.
this avoid carry propagation loop on rounding.
and allows decimal2longlong detect truncation correctly
e1c2bb860a5b...
e1c2bb860a5b36e492e97f0f0dbb5b17d7868120
Sergei Golubchik
bump the maturity of caching_sha2_password and parsec plugins
ce355a5979c4...
ce355a5979c4c2d61fe758ad371076e939ea8980
Alessandro Vetere
fixup! MDEV-37070  Implement table options to enable/disable features
c791bb256e41...
c791bb256e41c7b0b4e9ac40abca81bed9bdb84b
Sergei Golubchik
MDEV-38806 Non-debug assertion failure in btr_pcur_t::restore_position upon HANDLER operations

amend the fix from MDEV-37832 to restore old locking behavior for HANDLER,
even if it's not an "updating" command.

Also let's do the same for CHECKSUM/ANALYZE. There is CHECKSUM and
ANALYZE specific code inside that if(), it should be either restored
to work or removed there's no reason to leave dead code there.
I prefer to be conservative here and restore it to work.
c061f4f1c020...
c061f4f1c020e9ca0a647b4ed697fe8c36ca3a51
Monty
MDEV-37070  Implement table options to enable/disable features

Added ADAPTIVE_HASH_INDEX=DEFAULT|YES|NO table and index option to InnoDB.
The table and index options only have an effect if InnoDB adaptive hash
index feature is enabled.

- Having the ADAPTIVE_HASH_INDEX TABLE option set to NO will disable
  adaptive hash index for all indexes in the table that does not have
  the index option adaptive_hash_index=yes.
- Having the ADAPTIVE_HASH_INDEX TABLE option set to YES will enable the
  adaptive hash index for all indexes in the table that does not have
  the index option adaptive_hash_index=no.
- Using adaptive_hash_index=default deletes the old setting.
- One can also use OFF/ON as the options. This is to make it work similar
  as other existing options.
- innodb.adaptive_hash_index has been changed from a bool to an enum with
  values OFF, ON and IF_SPECIFIED.  If IF_SPECIFIED is used, adaptive
  hash index are only used for tables and indexes that specifies
  adaptive_hash_index=on.
- The following new options can be used to further optimize adaptive hash
  index for an index (default is unset/auto for all of them):
  - complete_fields:
    - 0 to the number of columns the key is defined on (max 64)
  - bytes_from_incomplete_field:
    - This is only usable for memcmp() comparable index fields, such as
      VARBINARY or INT. For example, a 3-byte prefix on an INT will
      return an identical hash value for 0‥255, another one for 256‥511,
      and so on.
    - Range is min 0 max 16383.
  - for_equal_hash_point_to_last_record
    -  Default is unset/auto, NO points to the first record, known as
        left_side in the code; YES points to the last record.
        Example: we have an INT column with the values 1,4,10 and bytes=3,
        will that hash value point to the record 1 or the record 10?
        Note: all values will necessarily have the same hash value
        computed on the big endian byte prefix 0x800000, for all of the
        values 0x80000001, 0x80000004, 0x8000000a. InnoDB inverts the
        sign bit in order to have memcmp() compatible comparison

Example:
CREATE TABLE t1 (a int primary key, b varchar(100), c int,
index (b) adaptive_hash_index=no, index (c))
engine=innodb, adaptive_hash_index=yes;

Notable changes in InnoDB
- btr_search.enabled was changed from a bool to a ulong to be
  able to handle options OFF, ON as IF_ENABLED. ulong is needed
  to compile with MariaDB enum variables.
- To be able to find all instances where btr_search.enabled was used
  I changed all code to use btr_search.get_enabled() when accessing
  the value and used btr_search.is_enabled(index) to test if AHI is
  enabled for the index.
- btr_search.enable() was changed to always take two parameters,
  resize and value of enabled. This was needed as enabled can now
  have values 0, 1, and 2.
- store all AHI related options in per-index `dict_index_t::ahi`
  bit-packed 32-bit atomic field `ahi_enabled_fixed_mask`
  - static assertions and debug assertions ensure that all options fit
    into the 32-bit field
  - packing details:
    - `enabled`, `adaptive_hash_index` (first 2 bits)
    - `fields`, `complete_fields` (7 bit)
    - `bytes`, `bytes_from_incomplete_field` (14 bits)
    - `left`, `~for_equal_hash_point_to_last_record` (1 bit)
    - `is_fields_set`, `fields` set flag (1 bit)
    - `is_bytes_set`, `bytes` set flag (1 bit)
    - `is_left_set`, `left` set flag (last 1 bit)
    - 5 bits spare after `is_left_set`
  - manipulation of the bit-packed field avoids usage of branches or
    conditional instructions to minimize the performance impact of
    the new options
- in `btr_search_update_hash_ref` apply the per-index AHI options
  using bit-masking to override internal heuristic values with user
  preferences
- add `innodb.index_ahi_option` test:
  - test a combination of per-table and per-index AHI options
  - use a stored procedure which checks if AHI is used during a burst of
    index lookups checking delta in `adaptive_hash_searches` InnoDB
    monitor variable
  - test that the maximum number of fields per (secondary) index is 64
    (32+32)
- add `innodb.index_ahi_option_debug` test:
  - test debug builds with `index_ahi_option_debug_check` debug variable
    enabled to verify that the proper per-index AHI options are applied
    during index lookups
  - test that illegal per-index AHI are non-destructive and just lead to
    no AHI usage

Visible user changes:
- select @@global.adaptive_hash_index will now return a string instead
  of 0 or 1.

Other notable changes:
- In `sql/create_options.cc`:
  - In function `parse_engine_part_options` do allocate table options
    in share root to avoid MSAN/ASAN errors due to use after free of
    `option_struct` in test `parts.partition_special_innodb`.
  - In function `set_one_value` avoid reading after the end of the
    current string.

Co-authored-by: Monty <[email protected]>
Co-authored-by: Marko Mäkelä <[email protected]>
Co-authored-by: Alessandro Vetere <[email protected]>
Co-authored-by: Thirunarayanan Balathandayuthapani <[email protected]>
a806ca28ff18...
a806ca28ff1899336805fcce3bc6820c2d049fb0
Sergei Golubchik
cleanup: rename an argument
9b325e1b7dc1...
9b325e1b7dc17118469af9bbe936821302b54828
Rucha Deodhar
MDEV-39179: Incorrect NULL handling in UPDATE ... RETURNING result

Analysis:
OLD_VALUE() swapped only field->ptr, leaving null_ptr pointing to the
current record. This caused incorrect NULL results.

Fix:
Store null_ptr_old for record[1] and swap it together with ptr to
preserve correct NULL semantics.
89c933d61c8d...
89c933d61c8d67e71191517f42cd4890bf87f06f
Sergei Golubchik
cleanup: remove explicit rounding before decimal2longlong

embed rounding into decimal2longlong instead.
this avoid carry propagation loop on rounding.
and allows decimal2longlong detect truncation correctly
85e4f5cfb3dc...
85e4f5cfb3dc0ee119cb34aa2f6c7c3ec4d24801
Rucha Deodhar
MDEV-39119: Improve error handling when using OLD_VALUE as alias name

Analysis:
Since OLD_VALUE_SYM was part of reserved keywords, it did not allow
old_value in the alias.
Fix:
Change OLD_VALUE_SYM from reserved keyword to keyword_sp_var_and_label.
7c1c9e8ae27a...
7c1c9e8ae27a50d839a2993b6b652628badd627c
Rucha Deodhar
MDEV-39212: JSON_MERGE_PATCH depth crash

Analysis:
The crash happens because we run out of stack space

Fix:
Add a stack overflow check.
77dc05994e2c...
77dc05994e2c2807fbb342fdf9021c83f989cfdb
Rucha Deodhar
MDEV-39213: json range syntax crash

Analysis:
When json is being parsed, the step decreases without a out-of-bound check
resulting in failure.
Fix:
Before decreasing the step, check if it will result into out of bound.
7192d140dd54...
7192d140dd54771c1c9f3e700018f2addbf0f75d
Sergei Golubchik
MDEV-39141 MariaDB crashes in THD::THD() due to misalignment

fix alloc_root() and my_malloc() to return 16-aligned pointers

(type_assoc_array.sp-assoc-array-64bit prints changes in memory_used,
and my_malloc() uses more memory now)
6da5c8e0eab7...
6da5c8e0eab73431f0cdd1013ccb35b53f0b1974
ParadoxV5
Move `Info_file`s’ `VALUE_LIST`s to for-each

This commit refactors the static lists of bulky member pointer
substitutes to instance-level lists of on-demand references.

The choice of these static lists was an aggressive optimization.
Once operations reduce dependence on saving and loading, e.g., for crash
safety in non-GTID mode, that improvement will no longer be significant.
6a7a44aba0ee...
6a7a44aba0eeea7c99641ed03c661c737ddf4516
Rucha Deodhar
MDEV-5092: Implement UPDATE with result set (UPDATE ... RETURNING)

The patch introduces the OLD_VALUE() expression to reference the value
of a column before it was updated. The parser is extended to support
RETURNING and OLD_VALUE(), and RETURNING expressions are stored in a
separate returning_list in SELECT_LEX with independent wildcard tracking.
RETURNING is rejected for multi-table UPDATE.

During setup of RETURNING fields, THD::is_setting_returning is used
when resolving fields, particularly for updates through views.
When resolving view fields, Item_direct_view_ref may point to the
view's item_list, losing the information about whether the value
should be old or new. The original item in returning_list still
contains the correct is_old_value_reference flag, which is copied
back to the resolved item.

OLD_VALUE() is implemented by extending Item_field with a new
Item_old_field class. Item_field::set_field() initializes
Field::ptr_old to the corresponding location in record[1],
which stores the old row during UPDATE execution.

When sending result rows, Item_old_field::send() temporarily switches
the field pointer from record[0] (current row) to ptr_old so
OLD_VALUE() returns the value before the update.

The UPDATE execution path is modified to send a result set when
RETURNING is present instead of an OK packet.
67068c8f9050...
67068c8f9050dc1b5d63efa5dca8af3aee4048e9
Sergei Golubchik
MDEV-38702 Behaviour of IF() with boolean JSON_EXTRACT as expression is wrong

implement Item_func_json_extract::val_bool()
5f262639fe96...
5f262639fe9663395cea752a7b4961aaf7103842
Sergei Golubchik
MDEV-38199 Optimizer Error with = SOME on UNIQUE Column Using Decimal/Integer Types

return 1 (non-fatal error) when a decimal or float number
was modified when stored in Field_long (= fractional part was lost).

This tells the optimizer that a number with a non-zero fractional
part cannot be found in an index over an integer field.
507056ddc80d...
507056ddc80d403c01154cb020adaeee85a1e9ef
ParadoxV5
MDEV-38972 Refactor MDEV-37530 and MDEV-28302 to Use Internal Data Structures

We currently (should) use in-house data structures;
those in the C++ Standard Library are not yet formally approved.
Until that day comes (if ever),
this commit swaps the set of data structures.
As this commit contains no other significant refactoring,
this change from one library to the other is also
a sample for static and performance comparisons.
4d0395a6ffe0...
4d0395a6ffe0c3b5b51bf6db2a161623b56a8e78
Sergei Golubchik
correct sql_command_flags: add CF_CHANGES_DATA as needed

SQLCOM_REVOKE_ALL needs it because SQLCOM_REVOKE does.
SQLCOM_DROP_ROLE needs it because SQLCOM_DROP_USER does.
SQLCOM_CREATE_SERVER / SQLCOM_ALTER_SERVER / SQLCOM_DROP_SERVER
need it because SQLCOM_CREATE_USER / etc do.
4aafb1a771a1...
4aafb1a771a118b74b2ec13e3d67ede230269f57
Sergei Golubchik
cleanup: change sql_command_flags from uint to cf_flags_t

introduce a dedicated enum type for sql_command_flags
to simplify debugging:

(gdb) p sql_command_flags[SQLCOM_SELECT]
$2 = (CF_REEXECUTION_FRAGILE | CF_CAN_GENERATE_ROW_EVENTS | CF_PREOPEN_TMP_TABLES | CF_CAN_BE_EXPLAINED | CF_OPTIMIZER_TRACE)
473a6cea79de...
473a6cea79deca527d844ae42d79fb8afdd3bcec
Sergei Golubchik
cleanup: rename an argument
45d60d7f3d03...
45d60d7f3d03671f6463676904b1afa6cf3053eb
Sergei Golubchik
correct sql_command_flags: add CF_CHANGES_DATA as needed

SQLCOM_REVOKE_ALL needs it because SQLCOM_REVOKE does.
SQLCOM_DROP_ROLE needs it because SQLCOM_DROP_USER does.
SQLCOM_CREATE_SERVER / SQLCOM_ALTER_SERVER / SQLCOM_DROP_SERVER
need it because SQLCOM_CREATE_USER / etc do.
3721603f85dd...
3721603f85dd2241080d846dd78bce023ecf276d
Sergei Golubchik
MDEV-38199 Optimizer Error with = SOME on UNIQUE Column Using Decimal/Integer Types

return 1 (non-fatal error) when a decimal or float number
was modified when stored in Field_long (= fractional part was lost).

This tells the optimizer that a number with a non-zero fractional
part cannot be found in an index over an integer field.
35f65007b749...
35f65007b749c2a9853d293091063f4ae9c08c17
Sergei Golubchik
cleanup: change sql_command_flags from uint to cf_flags_t

introduce a dedicated enum type for sql_command_flags
to simplify debugging:

(gdb) p sql_command_flags[SQLCOM_SELECT]
$2 = (CF_REEXECUTION_FRAGILE | CF_CAN_GENERATE_ROW_EVENTS | CF_PREOPEN_TMP_TABLES | CF_CAN_BE_EXPLAINED | CF_OPTIMIZER_TRACE)
343d4ece9c00...
343d4ece9c0017e79712158d3b6e5fdb8b04a005
Rucha Deodhar
MDEV-39127: UBSAN : downcast of address X which does not point to an object
of type 'multi_update' in sql/sql_update.cc
| Sql_cmd_update::update_single_table

Analysis:
the 'result' object was being incorrectly used which maybe of the type
multi_update.This caused UBSAN error due to an invalid downcast in
Sql_cmd_update::update_single_table().

Fix:
Introduce a dedicated returning_result object for handling RETURNING output
instead of reusing result. This ensures the correct result handler is used
and avoids unsafe casts.
2a31a0f893d8...
2a31a0f893d8640c2baf8b3418d75230087e3b21
Sergei Golubchik
MDEV-38802 MariaDB server start emits error but continues anyway: Can't open and lock privilege tables: Table 'mysql.servers' doesn't exist

it's not an error, as the server continues anyway
26606cefdc1f...
26606cefdc1f8a1eaeaba77b831d3e423bbb4f3b
Sergei Golubchik
MDEV-39141 MariaDB crashes in THD::THD() due to misalignment

fix alloc_root() and my_malloc() to return 16-aligned pointers

(type_assoc_array.sp-assoc-array-64bit prints changes in memory_used,
and my_malloc() uses more memory now)
25a27761efbe...
25a27761efbeae597694a6d8646d30f9cd61e869
Sergei Golubchik
MDEV-38806 Non-debug assertion failure in btr_pcur_t::restore_position upon HANDLER operations

amend the fix from MDEV-37832 to restore old locking behavior for HANDLER,
even if it's not an "updating" command.

Also let's do the same for CHECKSUM/ANALYZE. There is CHECKSUM and
ANALYZE specific code inside that if(), it should be either restored
to work or removed there's no reason to leave dead code there.
I prefer to be conservative here and restore it to work.
1839cc67a746...
1839cc67a74659f518c9e82d46b5ae6c1e8c5617
Sergei Golubchik
MDEV-39135 JSON_OBJECTAGG(NULL) in decimal context

json_objectagg didn't return NULL if null_value==true
BuildBot (0.8.9) working for the MariaDB project.
Page built: Fri 01 May 2026 01:42:31 (UTC)